He began his career with Swansea City in 1972, and spent the next seven years with the "Swans", winning promotion out of the Fourth Division in 1977–78 and out of the Third Division in 1978–79. He was then sold on to Leeds United, but struggled in the First Division and was sold back to Swansea in 1980. He helped Swansea to win promotion out of the Second Division in 1980–81, but a period of decline for the club followed and he moved on to Southampton in November 1983. He played on loan at Stoke City towards the end of the 1985–86 season, before he joined Cardiff City in the summer. He helped the "Bluebirds" to win promotion out of the Fourth Division in 1987–88 and to also win the Welsh Cup in 1988. He made another return to Swansea during the 1989–90 campaign, and later ended his career with Barry Town, winning the Welsh Cup in 1994.
