starcitizentools/citizen-skin is vulnerable to Stored XSS attack in the legacy search bar through page descriptions
SummaryPage descriptions are inserted into raw HTML without proper sanitization by the Citizen skin when using the old search bar.DetailsThe descriptions, which are unsanitized, are inserted as raw HTML:
https://github.com/StarCitizenTools/mediawiki-skins-Citizen/blob/d4dfc3697a82948b3b9c4d44e9a273c79bc86b87/resources/skins.citizen.search/templates/TypeaheadListItem.mustache#L18PoCAll of the reproduction methods require the command palette to be disabled via `$wgCitizenEnableCommandPalette = false;`.
Additionally, the action API must be used as the Search Gateway via  `$wgCitizenSearchGateway = 'mwActionApi';`.TextExtracts as the description sourceEnable the TextExtracts extensionAdd `$wgCitizenSearchDescriptionSource = 'textextracts';` to your LocalSettings.phpCreate a page called `CitizenXSSTextExtracts` and insert `<img src="" onerror="alert('citizen search xss')">` into itOpen the search modal and search for `CitizenXSSTextExtracts`![image](https://github.com/user-attachments/assets/fbc88458-c429-4f08-9376-584b7db93f58)Description2 as the description sourceEnable the Description2 extensionAdd `$wgEnableMetaDescriptionFunctions = true;` to your LocalSettings.php to enable the `{{#description2:}}` parser functionAdd `$wgCitizenSearchDescriptionSource = 'pagedescription';` to your LocalSettings.phpCreate a page called `CitizenXSSDescription2` and insert `{{#description2:<img src="" onerror="alert('citizen search xss 2')">}}` into itOpen the search modal and search for `CitizenXSSDescription2`![image](https://github.com/user-attachments/assets/24513eba-dbec-4bc6-ac06-6276d509fcab)Wikibase as the description sourceNote that this method is currently untested due to issues I experienced when setting up Wikibase.Enable Wikibase client + repo in your wikiAdd `$wgCitizenSearchDescriptionSource = 'wikidata';` to your LocalSettings.phpHave an item with a description like `<img src="" onerror="alert('citizen search xss 3')">`Open the search modal and search for the page linked to the itemShortDescription as the description sourceEnable the ShortDescription extensionAdd `$wgCitizenSearchDescriptionSource = 'wikidata';` to your LocalSettings.phpCreate a page called `CitizenXSSDescription4` and insert `{{SHORTDESC:<img src="" onerror="alert('citizen search xss 4')">}}` into itOpen the search modal and search for `CitizenXSSDescription4`ImpactOn all wikis that use the aforementioned settings (command palette disabled or using an old release where the old search bar is still used; using the action API as the search gateway), anybody who can edit pages is able to insert XSS payloads into the DOM for other users who are searching for specific pages.