<gh_stars>1-10
{
	"description": "cmd/gc: silence valgrind error\n\nvalgrind complained that under some circumstances, \n\n    *nr = *nc\n\nwas being called when nr and nc were the same *Node. The suggestion my R\u00e9my was to introduce a tmp node to avoid the potential for aliasing in subnode.",
	"cc": [
		"<EMAIL>",
		"<EMAIL>",
		"<EMAIL>",
		"<EMAIL>"
	],
	"reviewers": [],
	"messages": [
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "Hello <EMAIL>, <EMAIL>, <EMAIL> (cc: <EMAIL>),\n\nI'd like you to review this change to\nhttps://code.google.com/p/go",
			"disapproval": false,
			"date": "2013-03-13 10:58:52.402700",
			"approval": false
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "The original valgrind report.\n\n==2499== Memcheck, a memory error detector\n==2499== Copyright (C) 2002-2011, and GNU GPL'd, by <NAME> et al.\n==2499== Using Valgrind-3.7.0 and LibVEX; rerun with -h for copyright info\n==2499== Command: /home/dfc/go/pkg/tool/linux_386/8g -o /tmp/go-build072428647/fmt/_obj/_go_.8 -p fmt -complete -D _/home/dfc/go/src/pkg/fmt -I /tmp/go-build072428647 /home/dfc/go/src/pkg/fmt/doc.go /home/dfc/go/src/pkg/fmt/format.go /home/dfc/go/src/pkg/fmt/print.go /home/dfc/go/src/pkg/fmt/scan.go\n==2499== Parent PID: 2302\n==2499==\n==2499== Source and destination overlap in memcpy(0xbefc76d8, 0xbefc76d8, 224)\n==2499==    at 0x402D9A9: memcpy (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)\n==2499==    by 0x8049071: subnode (cplx.c:364)\n==2499==    by 0x8048F11: complexmove (cplx.c:70)\n==2499==    by 0x8055ED7: gmove (gsubr.c:1288)\n==2499==    by 0x804ADCE: cgen (cgen.c:125)\n==2499==    by 0x806AB3D: cgen_as (gen.c:745)\n==2499==    by 0x80503A9: cgen_callret (ggen.c:316)\n==2499==    by 0x804B5DB: cgen (cgen.c:366)\n==2499==    by 0x806AB3D: cgen_as (gen.c:745)\n==2499==    by 0x806A72F: gen (gen.c:468)\n==2499==    by 0x806A0C9: genlist (gen.c:257)\n==2499==    by 0x80501D8: cgen_call (ggen.c:259)",
			"disapproval": false,
			"date": "2013-03-13 10:59:42.990240",
			"approval": false
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>"
			],
			"text": "LGTM\r\n\r\nThank you. I have yet to see a valgrind report that was a false positive.\r\nThis might be the closest one I've seen - who knew that the compiler was\r\nputting a memcpy there! - but it's still worth cleaning up to make the rest\r\nof the valgrind output useful.\r\n\r\nRuss\r\n",
			"disapproval": false,
			"date": "2013-03-13 16:48:29.744390",
			"approval": true
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>"
			],
			"text": "Excellent, thank you. I'm working through all the permutations of {5,6,8}{a,c,g,l}. \r\n\r\n\r\n\r\nOn 14/03/2013, at 3:48 AM, <NAME> <<EMAIL>> wrote:\r\n\r\n> LGTM\r\n> \r\n> Thank you. I have yet to see a valgrind report that was a false positive. This might be the closest one I've seen - who knew that the compiler was putting a memcpy there! - but it's still worth cleaning up to make the rest of the valgrind output useful.\r\n> \r\n> Russ\r\n",
			"disapproval": false,
			"date": "2013-03-13 19:42:14.851160",
			"approval": false
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "*** Submitted as https://code.google.com/p/go/source/detail?r=28dbe614d61c ***\n\ncmd/gc: silence valgrind error\n\nvalgrind complained that under some circumstances, \n\n    *nr = *nc\n\nwas being called when nr and nc were the same *Node. The suggestion my R\u00e9my was to introduce a tmp node to avoid the potential for aliasing in subnode.\n\nR=remyoudompheng, minux.ma, rsc\nCC=golang-dev\nhttps://codereview.appspot.com/7780044",
			"disapproval": false,
			"date": "2013-03-13 20:11:26.608750",
			"approval": false
		}
	],
	"owner_email": "<EMAIL>.net",
	"private": false,
	"base_url": "",
	"owner": "dfc",
	"subject": "code review 7780044: cmd/gc: silence valgrind error",
	"created": "2013-03-13 04:45:48.767070",
	"patchsets": [
		1,
		2001,
		5001,
		8001,
		14001
	],
	"modified": "2013-03-13 20:11:28.310320",
	"closed": true,
	"issue": 7780044
}