<filename>data/reviews/682/6827076.json
{
	"description": "exp/types: avoid init race in check_test.go.\n\nThere was an init race between\n\tcheck_test.go:init\n        universe.go:def\n        use of Universe\nand\n\tuniverse.go:init\n        creation of Universe\n\nThe order in which init funcs are executed in a package is unspecified.\nThe test is not currently broken in the golang.org environment\nbecause the go tool compiles the test with non-test sources before test sources,\nbut other environments may, say, sort the source files before compiling,\nand thus trigger this race, causing a nil pointer panic.",
	"cc": [
		"<EMAIL>",
		"<EMAIL>"
	],
	"reviewers": [],
	"messages": [
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "Hello gri (cc: <EMAIL>),\n\nI'd like you to review this change to\nhttps://code.google.com/p/go",
			"disapproval": false,
			"date": "2012-11-12 01:26:04.085490",
			"approval": false
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "LGTM.\n\nThanks for catching this.\n- gri",
			"disapproval": false,
			"date": "2012-11-12 18:02:56.195960",
			"approval": true
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "*** Submitted as http://code.google.com/p/go/source/detail?r=919e2645d301 ***\n\nexp/types: avoid init race in check_test.go.\n\nThere was an init race between\n\tcheck_test.go:init\n        universe.go:def\n        use of Universe\nand\n\tuniverse.go:init\n        creation of Universe\n\nThe order in which init funcs are executed in a package is unspecified.\nThe test is not currently broken in the golang.org environment\nbecause the go tool compiles the test with non-test sources before test sources,\nbut other environments may, say, sort the source files before compiling,\nand thus trigger this race, causing a nil pointer panic.\n\nR=gri\nCC=golang-dev\nhttp://codereview.appspot.com/6827076",
			"disapproval": false,
			"date": "2012-11-12 22:08:42.375000",
			"approval": false
		}
	],
	"owner_email": "<EMAIL>",
	"private": false,
	"base_url": "",
	"owner": "dsymonds",
	"subject": "code review 6827076: exp/types: avoid init race in check_test.go.",
	"created": "2012-11-12 01:23:32.403020",
	"patchsets": [
		1,
		2001,
		3002,
		7001
	],
	"modified": "2012-11-12 22:08:44.553640",
	"closed": true,
	"issue": 6827076
}