{
	"description": "go.crypto/openpgp: don't select expired keys.\n\nWhen selecting keys for encryption, don't select keys that have\nexpired.\n\nFixes issue 5808.",
	"cc": [
		"<EMAIL>",
		"<EMAIL>"
	],
	"reviewers": [],
	"messages": [
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>"
			],
			"text": "On Tue, Jul 2, 2013 at 1:10 PM,  <<EMAIL>> wrote:\r\n> Yes, good point. Updated.\r\n\r\nping.\r\n\r\n\r\nCheers\r\n\r\nAGL\r\n",
			"disapproval": false,
			"date": "2013-07-12 15:58:51.259940",
			"approval": false
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "R=bradfitz",
			"disapproval": false,
			"date": "2013-07-12 16:14:07.307000",
			"approval": false
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "LGTM\n\nhttps://codereview.appspot.com/10847043/diff/5006/openpgp/packet/signature.go\nFile openpgp/packet/signature.go (right):\n\nhttps://codereview.appspot.com/10847043/diff/5006/openpgp/packet/signature.go#newcode386\nopenpgp/packet/signature.go:386: // KeyExpired returns true iff sig is a self-signature of a key that has\nGo style: s/true iff/whether/",
			"disapproval": false,
			"date": "2013-07-17 00:32:49.929020",
			"approval": true
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "*** Submitted as https://code.google.com/p/go/source/detail?r=c0932d3462e8&repo=crypto ***\n\ngo.crypto/openpgp: don't select expired keys.\n\nWhen selecting keys for encryption, don't select keys that have\nexpired.\n\nFixes issue 5808.\n\nR=bradfitz\nCC=golang-dev\nhttps://codereview.appspot.com/10847043",
			"disapproval": false,
			"date": "2013-07-22 22:23:36.598780",
			"approval": false
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "https://codereview.appspot.com/10847043/diff/5006/openpgp/packet/signature.go\nFile openpgp/packet/signature.go (right):\n\nhttps://codereview.appspot.com/10847043/diff/5006/openpgp/packet/signature.go#newcode386\nopenpgp/packet/signature.go:386: // KeyExpired returns true iff sig is a self-signature of a key that has\nOn 2013/07/17 00:32:50, bradfitz wrote:\n> Go style: s/true iff/whether/\n\nDone.",
			"disapproval": false,
			"date": "2013-07-22 22:23:45.721310",
			"approval": false
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "fixes issue 5808?",
			"disapproval": false,
			"date": "2013-07-01 23:51:01.166390",
			"approval": false
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "On 2013/07/01 23:51:01, r wrote:\n> fixes issue 5808?\n\nYes, good point. Updated.",
			"disapproval": false,
			"date": "2013-07-02 17:10:01.277910",
			"approval": false
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "Hello <EMAIL> (cc: <EMAIL>),\n\nI'd like you to review this change to\nhttps://code.google.com/p/go.crypto/",
			"disapproval": false,
			"date": "2013-07-01 21:55:06.042130",
			"approval": false
		}
	],
	"owner_email": "<EMAIL>",
	"private": false,
	"base_url": "",
	"owner": "agl1",
	"subject": "code review 10847043: go.crypto/openpgp: don't select expired keys.",
	"created": "2013-07-01 21:26:15.635980",
	"patchsets": [
		8001,
		5006,
		18001
	],
	"modified": "2013-07-22 22:23:46.143180",
	"closed": true,
	"issue": 10847043
}