<reponame>bradfitz/qopher
{
	"description": "godashboard: Show packages at launchpad.net\n\nThe changes were not tested for real in an App Engine environment,\nso extra care should be taken.  That said, some static testing\nwas done with pyflakes, and a few existent problems were fixed on\nthe way.",
	"cc": [
		"<EMAIL>",
		"<EMAIL>"
	],
	"reviewers": [],
	"messages": [
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "Hello adg (cc: <EMAIL>),\n\nI'd like you to review this change to\nhttps://go.googlecode.com/hg/",
			"disapproval": false,
			"date": "2011-04-12 02:26:13.620569",
			"approval": false
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "LGTM\n\nGotta love Python. All these errors would have been caught at compile time in Go.\n\nI'll test this before submitting it.\n\nhttp://codereview.appspot.com/4378053/diff/8001/misc/dashboard/godashboard/package.py\nFile misc/dashboard/godashboard/package.py (left):\n\nhttp://codereview.appspot.com/4378053/diff/8001/misc/dashboard/godashboard/package.py#oldcode17\nmisc/dashboard/godashboard/package.py:17: import binascii\nnice catch. thanks.\n\nhttp://codereview.appspot.com/4378053/diff/8001/misc/dashboard/godashboard/package.py\nFile misc/dashboard/godashboard/package.py (right):\n\nhttp://codereview.appspot.com/4378053/diff/8001/misc/dashboard/godashboard/package.py#newcode141\nmisc/dashboard/godashboard/package.py:141: memcache.set('view-package-json', json, time=CacheTimeout)\nI could have sworn I'd already fixed this.",
			"disapproval": false,
			"date": "2011-04-12 03:11:03.049631",
			"approval": true
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "*** Submitted as http://code.google.com/p/go/source/detail?r=8269271e8f70 ***\n\ngodashboard: Show packages at launchpad.net\n\nThe changes were not tested for real in an App Engine environment,\nso extra care should be taken.  That said, some static testing\nwas done with pyflakes, and a few existent problems were fixed on\nthe way.\n\nR=adg\nCC=golang-dev\nhttp://codereview.appspot.com/4378053\n\nCommitter: <NAME> <<EMAIL>>",
			"disapproval": false,
			"date": "2011-04-13 00:34:43.263445",
			"approval": false
		}
	],
	"owner_email": "<EMAIL>",
	"private": false,
	"base_url": "",
	"owner": "niemeyer",
	"subject": "code review 4378053: godashboard: Show packages at launchpad.net",
	"created": "2011-04-12 02:17:18.700373",
	"patchsets": [
		1,
		2001,
		5001,
		8001
	],
	"modified": "2011-09-23 18:15:41.353062",
	"closed": true,
	"issue": 4378053
}