<filename>data/reviews/646/6463058.json
{
	"description": "cmd/ld: skip R_*_NONE relocations, fix Linux/386 build again\r\nThe last fix was wrong w.r.t C's operator precedence,\r\nand it also failed to really skip the NONE relocation.\r\n\r\nThe offending R_386_NONE relocation is a absolute\r\nrelocation in section .eh_frame.",
	"cc": [
		"<EMAIL>"
	],
	"reviewers": [
		"<EMAIL>",
		"<EMAIL>"
	],
	"messages": [
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>"
			],
			"text": "On Tue, Aug 21, 2012 at 12:30 AM, <<EMAIL>> wrote:\r\n\r\n> Description:\r\n> cmd/ld: skip R_*_NONE relocations, fix Linux/386 build again\r\n> The last fix was wrong w.r.t C's operator precedence\r\n>\r\nApparently, after exposed to Go, I don't want to use C again.\r\n\r\nAlthough Go failed to attract C++ programmers, I think it\r\nsucceeded in making a C fan hate C. ;-)\r\n",
			"disapproval": false,
			"date": "2012-08-20 16:57:39.617810",
			"approval": false
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>"
			],
			"text": "On Tuesday, August 21, 2012, wrote:\r\n>\r\n> Sorry for not catching that.\r\n>\r\nIt's not your fault and I  should apologize. I just shouldn't mail that\r\nCL out before I could verify it.\r\n\r\nMaybe we can document the builders' setting somewhere, so that\r\nwe can always reproduce the exact build failures.\r\n",
			"disapproval": false,
			"date": "2012-08-20 18:00:53.433780",
			"approval": false
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "Hello <EMAIL> (cc: <EMAIL>),\n\nI'd like you to review this change to\nhttps://code.google.com/p/go/",
			"disapproval": false,
			"date": "2012-08-20 16:30:33.228530",
			"approval": false
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "*** Submitted as http://code.google.com/p/go/source/detail?r=81cf3cd39e2f ***\n\ncmd/ld: skip R_*_NONE relocations, fix Linux/386 build again\nThe last fix was wrong w.r.t C's operator precedence,\nand it also failed to really skip the NONE relocation.\n\nThe offending R_386_NONE relocation is a absolute\nrelocation in section .eh_frame.\n\nTBR=golang-dev\nCC=golang-dev\nhttp://codereview.appspot.com/6463058",
			"disapproval": false,
			"date": "2012-08-20 16:34:56.244170",
			"approval": false
		},
		{
			"sender": "<EMAIL>",
			"recipients": [
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>",
				"<EMAIL>"
			],
			"text": "LGTM\n\nSorry for not catching that.",
			"disapproval": false,
			"date": "2012-08-20 17:29:18.661130",
			"approval": true
		}
	],
	"owner_email": "<EMAIL>",
	"private": false,
	"base_url": "",
	"owner": "minux",
	"subject": "code review 6463058: cmd/ld: skip R_*_NONE relocations, fix Linux/386 build again",
	"created": "2012-08-17 16:43:11.423800",
	"patchsets": [
		1,
		2001
	],
	"modified": "2012-08-21 06:59:11.205660",
	"closed": true,
	"issue": 6463058
}