From cu at cua0.org  Mon Feb 13 00:51:45 2017
From: cu at cua0.org (Justin =?utf-8?Q?Bed=C5=91?=)
Date: Mon, 13 Feb 2017 10:51:45 +1100
Subject: [Rd] Bug with zlib version checking for zlib >= 1.2.10,
	R version 3.3.2
Message-ID: <87lgtbx90u.fsf@cua0.org>


Hi,

Posting here as bugzilla is closed to registration.
The zlib version checking code does not handle double digits for the
patch version in the semantic versioning scheme. Consequently, a
./configure fails when using a zlib version ? 1.5.10. I suggest
something like the following patch:

--- a/m4/R.m4
+++ b/m4/R.m4
@@ -3116,7 +3116,7 @@ int main() {
 #ifdef ZLIB_VERSION
 /* Work around Debian bug: it uses 1.2.3.4 even though there was no such
    version on the master site zlib.net */
-  exit(strncmp(ZLIB_VERSION, "1.2.5", 5) < 0);
+  exit(strncmp(ZLIB_VERSION, "1.2.5", 5) < 0 && (strlen(ZLIB_VERSION) < 6 || strncmp(ZLIB_VERSION, "1.2.10", 6) < 0));
 #else
   exit(1);
 #endif

This could of course be improved to properly parse the string.

Cheers,

Justin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 487 bytes
Desc: not available
URL: <https://stat.ethz.ch/pipermail/r-devel/attachments/20170213/12ffdf5a/attachment.bin>


[Rd] Bug with zlib version checking for zlib >= 1.2.10, R version 3.3.2
Justin =?utf-8?Q?Bed=C5=91?=