From p.dalgaard at biostat.ku.dk  Sat Oct  4 13:14:12 2003
From: p.dalgaard at biostat.ku.dk (Peter Dalgaard BSA)
Date: Sat Oct  4 14:14:14 2003
Subject: [Rd] latest beta + MinGW 3.1.0-1 = minor fix needed
In-Reply-To: <3F7DB32F.4030701@statistik.uni-dortmund.de>
References: <3F7DACFF.9030306@math.uni-augsburg.de>
	<3F7DB32F.4030701@statistik.uni-dortmund.de>
Message-ID: <x2pthdtczk.fsf@biostat.ku.dk>

Uwe Ligges <ligges@statistik.uni-dortmund.de> writes:

> Simon Urbanek wrote:
> 
> > There are two possible fixes for this:
> > 1) make sock.h use long instead of int.
> > 2) use something like:
> > #if defined Win32 && !defined _SSIZE_T_

> Simon,
> 
> it does not happen with MinGW's gcc-3.3.1 candidate release we (Duncan
> and myself) use for compiling R base + packages.
> The gcc-3.3.1 candidate is older (2003-08-07) than the official
> release (2003-09-14, gcc-3.2.?) you are using, though.
> 
> Some thoughts:
> The first suggested fix seems to be forbidden during code freeze
> (might break other platforms, doesn't it?), the second one puts one
> more OS dependence into the sources.
> Another solution is to hope for an official MinGW release of gcc-3.3.1
> with the change you are reporting reverted before the release of
> R-1.8.1 (of course one should document not to use MinGW 3.1.0-1 as is).

Fixes that are NOPs on non-broken setups should be allowable...
Version 2) looks most correct to me: We want to use the system
definition wherever it is available, and it would obviously only
change anything on Win32.

-- 
   O__  ---- Peter Dalgaard             Blegdamsvej 3  
  c/ /'_ --- Dept. of Biostatistics     2200 Cph. N   
 (*) \(*) -- University of Copenhagen   Denmark      Ph: (+45) 35327918
~~~~~~~~~~ - (p.dalgaard@biostat.ku.dk)             FAX: (+45) 35327907


[Rd] latest beta + MinGW 3.1.0-1 = minor fix needed
Peter Dalgaard BSA