From murdoch.duncan at gmail.com  Mon Sep  2 00:42:25 2013
From: murdoch.duncan at gmail.com (Duncan Murdoch)
Date: Sun, 01 Sep 2013 18:42:25 -0400
Subject: [Rd] [PATCH] remove a duplicate tk function definition (and
	alphabetize)
In-Reply-To: <6CEB142B-5088-44A0-82C6-EE1CB4380034@gmail.com>
References: <CAE3=dmf7XOBCJ-zNzVEH6HV4-Rz+J5om=WghfjkN4cdnSv0XVQ@mail.gmail.com>
	<522382B5.40106@gmail.com>
	<6CEB142B-5088-44A0-82C6-EE1CB4380034@gmail.com>
Message-ID: <5223C2D1.2020402@gmail.com>

On 13-09-01 3:53 PM, peter dalgaard wrote:
>
> On Sep 1, 2013, at 20:08 , Duncan Murdoch wrote:
>
>> On 13-09-01 2:45 AM, Scott Kostyshak wrote:
>>> 'tkcoords' is defined twice (in the same way) in src/library/tcltk/R/Tk.R.
>>>
>>> Attached is a patch against r63780 that removes the duplicate
>>> definition and alphabetizes the functions.
>>>
>>> I've read that minor patches such as this should be sent to r-devel [1].
>>>
>>> Scott
>>>
>>> [1] http://permalink.gmane.org/gmane.comp.lang.r.devel/33987
>>
>> Thanks.  I would not do the alphabetization; that makes it much harder to track changes.  But if tkcoords is unnecessarily duplicated, that seems like a reasonable change.
>>
>
> That's what I thought at first sight, but actually, the current breach of alphabetization is quite slight, so might be worth fixing after all, since it helps against putting the same function in twice... (the patch has tkpostcascade before tkpost, which is wrong, though).

In that case, go ahead.  I didn't look at the patch due to the 
description.  (I have committed the removal of the dupe.)

Duncan Murdoch



[Rd] [PATCH] remove a duplicate tk function definition (and alphabetize)
Duncan Murdoch