From ripley at stats.ox.ac.uk  Sat Jun 30 15:16:38 2007
From: ripley at stats.ox.ac.uk (Prof Brian Ripley)
Date: Sat, 30 Jun 2007 14:16:38 +0100 (BST)
Subject: [Rd] make check for 2.5.1 RC fails on mbcsToSbcs in graphics
In-Reply-To: <20070630113233.GA2273@cs.cas.cz>
References: <20070627132826.GB12244@cs.cas.cz>
	<Pine.LNX.4.64.0706271442360.6441@gannet.stats.ox.ac.uk>
	<46827388.6020706@biostat.ku.dk>
	<Pine.LNX.4.64.0706271544050.15363@auk.stats>
	<20070630113233.GA2273@cs.cas.cz>
Message-ID: <Pine.LNX.4.64.0706301416230.17524@gannet.stats.ox.ac.uk>

But, this is already dealt with in 2.5.1 patched ...

On Sat, 30 Jun 2007, Petr Savicky wrote:

> On Wed, Jun 27, 2007 at 04:20:39PM +0100, Prof Brian Ripley wrote:
>> But you can't really avoid it if you want to test non-ASCII
>> features: for example, you cannot test Latin-1 graphics in a C locale.
>>
>> It was intended that the postscript device opened for testing graphics was
>> opened with encoding="ISOLatin1".  That should certainly have helped, at
>> least in a UTF-8 locale, but unfortunately there were a couple of typos in
>> tests/Examples/Makefile.  Fixing that file makes 'make check' work in
>> cs_CZ.utf8 at least on my machine.
>>
>> It still remains that (for examples) you cannot successfully run make
>> check in a MBCS locale without iconv, nor will zh_CN.gbk nor zh_TW.big5
>> work.  I've added a note to R-admin to say that you may need to try a
>> suitable locale.
>
> I applied the following patch obtained by comparing R-devel_2007-06-26 and R-devel_2007-06-27
>
> --- D070626/R-devel/tests/Examples/Makefile.in	2007-05-10 17:50:54.000000000 +0200
> +++ D070627/R-devel/tests/Examples/Makefile.in	2007-06-27 17:50:09.000000000 +0200
> @@ -82,8 +82,8 @@
> 	@if test -f $@; then mv $@ $@.prev; fi
> 	@echo $(ECHO_N) "running code in '$<' ...$(ECHO_C)"
> 	@echo 'tools:::.convert_examples("graphics-Ex.R", "graphics-Ex.R-locale", "latin1")' | $(R) --slave > /dev/null 2>&1 || exit 1
> -	@sed -e 's/grDevices::postscript("graphics-Ex.ps")/grDevices::postscript("graphics-Ex.ps",encoding="ISOlatin1")/' graphics-Ex.R-locale \
> -	  | $(R) < graphics-Ex.R-locale  > $@ 2>&1 || (mv $@ $@.fail && exit 1)
> +	@sed -e 's/grDevices::postscript("graphics-Ex.ps")/grDevices::postscript("graphics-Ex.ps",encoding="ISOLatin1")/' graphics-Ex.R-locale \
> +	  | $(R) > $@ 2>&1 || (mv $@ $@.fail && exit 1)
> 	@rm graphics-Ex.R-locale
> 	@echo "$(ECHO_T) OK"
> 	@if test -f $@.prev; then \
>
> to my copy of R-2.5.1. Then, make check works with no error in cs_CZ.UTF-8 locale
> also on my machine. Thank you for the correction.
>
> Petr.
>
> ______________________________________________
> R-devel at r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel
>

-- 
Brian D. Ripley,                  ripley at stats.ox.ac.uk
Professor of Applied Statistics,  http://www.stats.ox.ac.uk/~ripley/
University of Oxford,             Tel:  +44 1865 272861 (self)
1 South Parks Road,                     +44 1865 272866 (PA)
Oxford OX1 3TG, UK                Fax:  +44 1865 272595



[Rd] make check for 2.5.1 RC fails on mbcsToSbcs in graphics
Prof Brian Ripley