From maechler at stat.math.ethz.ch  Sat May 30 16:11:18 2009
From: maechler at stat.math.ethz.ch (Martin Maechler)
Date: Sat, 30 May 2009 16:11:18 +0200
Subject: [Rd] as.numeric(levels(factor(x))) may be a decreasing sequence
In-Reply-To: <4A206193.8070807@idi.ntnu.no>
References: <20090523074454.GA17112@cs.cas.cz>
	<18973.42970.826686.173830@cmath-5.math.ethz.ch>
	<4A1DC057.80401@idi.ntnu.no>
	<18975.59582.885300.549159@lynne.math.ethz.ch>
	<4A203D67.8000007@idi.ntnu.no>
	<3f1d2410905291448y271fa484te82b8dbaa547017f@mail.gmail.com>
	<4A206193.8070807@idi.ntnu.no>
Message-ID: <3f1d2410905300711k71a05880x8c5d42b2f2842f5b@mail.gmail.com>

2009/5/30 Wacek Kusnierczyk <Waclaw.Marcin.Kusnierczyk at idi.ntnu.no>:
> Martin Maechler wrote:
>> Hi Waclav (and other interested parties),
>>
>> I have committed my working version of src/main/coerce.c
>> so you can prepare your patch against that.
>>
>
> Hi Martin,
>
> One quick reaction (which does not resolve my original complaint): ?you
> can have p non-const, and cast s to char* on the first occasion its
> value is assigned to p, thus being able to copy from p to replace
> without repetitive casts. ?make check-ed patch atatched.

yes, thank you,
that's definitely more esthetically appealing (and as you said, does
not solve your original complaint).

(I'll wait a bit before further commits on this; notably I'll also
want to commit a corresponding entry to
 PrtUtil.h)

Martin



[Rd] as.numeric(levels(factor(x))) may be a decreasing sequence
Martin Maechler