From frederik at ofb.net  Mon Jun 20 20:43:46 2016
From: frederik at ofb.net (frederik at ofb.net)
Date: Mon, 20 Jun 2016 11:43:46 -0700
Subject: [Rd] getGraphicsEvent on X11 and event queuing
In-Reply-To: <20160614153413.GA24958@ofb.net>
References: <20160607013845.GA21587@ofb.net> <20160607222005.GB6983@ofb.net>
	<22361.33450.594773.902489@stat.math.ethz.ch>
	<20160614153413.GA24958@ofb.net>
Message-ID: <20160620184346.GF32398@ofb.net>

Hi R-Devel and Duncan,

Any ideas about my patch? I'm including Duncan Murdoch since he was
actually the one who made the "fix" to Hugo's bug in September 2010.
Duncan chose to "fix" Cairo support by formally disabling it, rather
than by enabling it as Hugo had proposed. I don't see a reply to
Hugo's January 2011 question, asking why this was done. Hugo's patch
was pretty simple:

        if(!using cairo) {
            xlib stuff
    -        set up for getGraphicsEvent
        }
    +    set up for getGraphicsEvent

Sorry to be annoying, but I'm not sure how long I should wait for an
acknowledgment. Perhaps Duncan is waiting for someone else to take the
lead in this? I think it would be great if R maintainers could
delegate commit powers to more people so that time isn't wasted by
eager contributors duplicating each other's no-brainer patches which
were ignored many years ago. I guess there is a lot more interest in
Windows than Linux, but maybe that means that someone should be
assigned to handle Linux-specific changes who cares about them. (I see
a lot of Word-document, Windows-character-set, and RStudio stuff on
this list, so I sympathize with any disinterest there may be in Linux
Xlib problems)

Let me know if you'd like to divorce the "onIdle" part of my patch
from the Cairo-enabling part and discuss those separately, perhaps
that would make sense if time is short.

Thanks for handling my recent Readline patches.

Frederick

On Tue, Jun 14, 2016 at 08:34:13AM -0700, frederik at ofb.net wrote:
> Hi Martin,
> 
> > Also, as you are studying the C code and the issues anyway, it
> > may be worthwhile to consider (as small as possible!) patches to
> > the source you could also post to the bugzilla site if you
> > prefer; attaching as text/plain to R-devel does work fine, too.
> 
> Well, after your kind solicitation I went through all the touble of
> locally fixing getGraphicsEvent Cairo support and implementing an
> onIdle handler.
> 
> However, I noticed that the first part actually already has a patch on
> the R bug tracker, which is exactly the same as the fix I implemented!
> (minus documentation)
> 
> https://bugs.r-project.org/bugzilla/show_bug.cgi?id=14364
> 
> Problem: somebody ignored the patch and closed the bug. Who closed it?
> YOU!
> 
> So, I guess since that patch (fixing Cairo support) was sent in 2010,
> and my patch (fixing both problems) is about 8 times longer, I can
> expect you to ignore my patch until at least 2063 (a tight lower bound
> if you apply Hugo's patch this year). :)
> 
> I posted my patch here:
> 
> https://bugs.r-project.org/bugzilla/show_bug.cgi?id=16951
> 
> Frederick
> 
> ______________________________________________
> R-devel at r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel
>



[Rd] getGraphicsEvent on X11 and event queuing
frederik at ofb.net