From murdoch at stats.uwo.ca  Tue Nov 17 12:40:00 2009
From: murdoch at stats.uwo.ca (Duncan Murdoch)
Date: Tue, 17 Nov 2009 06:40:00 -0500
Subject: [Rd] make.packages.html
In-Reply-To: <971536df0911170233w71d062cr2bcc9e6246aa0b13@mail.gmail.com>
References: <971536df0911170233w71d062cr2bcc9e6246aa0b13@mail.gmail.com>
Message-ID: <4B028B90.4090607@stats.uwo.ca>

On 17/11/2009 5:33 AM, Gabor Grothendieck wrote:
> In "R version 2.10.0 Patched (2009-11-15 r50445)" on Windows Vista
> upon issuing help.start() and clicking on Packages I get this.
> 
> Packages in C:\Users\Gabor\Documents\R\win-library\2.10
> 
> C:\Users\Gabor\Documents/R/win-library/2.10/AER/DESCRIPTION -- Title
> is missing --
> C:\Users\Gabor\Documents/R/win-library/2.10/akima/DESCRIPTION -- Title
> is missing --
> C:\Users\Gabor\Documents/R/win-library/2.10/car/DESCRIPTION -- Title
> is missing --
> C:\Users\Gabor\Documents/R/win-library/2.10/caroline/DESCRIPTION --
> Title is missing --
> ...
> 
> Looking at make.packages.html in utils, this code:
> 
>     for (lib in lib.loc) {
>         pg <- Sys.glob(file.path(lib, "*", "DESCRIPTION"))
>         pkgs[[lib]] <- sort(sub(paste(lib, "([^/]*)", "DESCRIPTION$",
>             sep = "/"), "\\1", pg))
>     }
> 
> has the problem that lib can contain regular expression characters but
> is used in the pattern of sub.  This could be changed to the following
> which does not use lib in any pattern. Only the pkgs[[lib]]<-
> statement is changed relative to the original:
> 
>     for (lib in lib.loc) {
>         pg <- Sys.glob(file.path(lib, "*", "DESCRIPTION"))
>         pkgs[[lib]] <- sort(sub(".*[\\/]", "", sub(".DESCRIPTION$", "", pg)))
>     }

I've committed your patch to R-devel and R-patched now.  Thanks!

Duncan Murdoch



[Rd] make.packages.html
Duncan Murdoch