From edd at debian.org  Mon Jan 19 23:35:31 2015
From: edd at debian.org (Dirk Eddelbuettel)
Date: Mon, 19 Jan 2015 16:35:31 -0600
Subject: [Rd] [PATCH] Makefile: add support for git svn clones
In-Reply-To: <54BD811A.5060309@gmail.com>
References: <1421696001-21383-1-git-send-email-balbi@kernel.org>
	<54BD63B3.8090803@gmail.com> <20150119202025.GA28274@saruman>
	<54BD69A4.60600@gmail.com> <20150119203419.GA24996@saruman>
	<54BD6CBD.8070304@gmail.com> <20150119210041.GB25690@saruman>
	<CAFAN8vxnX5Bb-8rDP2mJZE0s4V7mjFBPBfPx2XO31gUtUccsUQ@mail.gmail.com>
	<54BD811A.5060309@gmail.com>
Message-ID: <21693.34483.729086.121918@max.nulle.part>


On 19 January 2015 at 17:11, Duncan Murdoch wrote:
| The people who would have to maintain the patch can't test it.  

I don't understand this.

The patch, as we may want to recall, was all of

   +GIT := $(shell if [ -d "$(top_builddir)/.git" ]; then \
   +	echo "git"; fi)
   +

and

   -	  (cd $(srcdir); LC_ALL=C TZ=GMT svn info || $(ECHO) "Revision: -99") 2> /dev/null \
   +	  (cd $(srcdir); LC_ALL=C TZ=GMT $(GIT) svn info || $(ECHO) "Revision: -99") 2> /dev/null \

I believe you can test that builds works before applying the patch, and
afterwards---even when you do not have git, or in this case a git checkout.
The idiom of expanding a variable to "nothing" if not set is used all over
the R sources and can be assumed common.  And if (hypothetically speaking)
the build failed when a .git directory was present?  None of R Core's concern
either as git was never supported.

I really do not understand the excitement over this.  The patch is short,
clean, simple, and removes an entirely unnecessary element of friction.

Dirk

-- 
http://dirk.eddelbuettel.com | @eddelbuettel | edd at debian.org



[Rd] [PATCH] Makefile: add support for git svn clones
Dirk Eddelbuettel