From @@ren@t@@c|y@n @end|ng |rom |@t@@c@@t  Thu Apr 18 22:21:37 2019
From: @@ren@t@@c|y@n @end|ng |rom |@t@@c@@t (Saren Tasciyan)
Date: Thu, 18 Apr 2019 22:21:37 +0200
Subject: [Rd] Bug in the "reformulate" function in stats package
In-Reply-To: <d5cf30f0-adcd-a8c3-9bfa-746b88a5582a@gmail.com>
References: <ac491662-1aad-3775-1936-9e2694da50e6@ist.ac.at>
 <9409b485-7a3b-0f2c-201e-7ef2bde1de86@ist.ac.at>
 <23709.55119.213555.244342@stat.math.ethz.ch>
 <765cd87b-98d6-b23f-9a58-ad817fa5c6e5@ist.ac.at>
 <bad24743-b6e1-f4cd-97a5-8047c27c6707@gmail.com>
 <0c567c84-5c27-128c-584c-022d8d1f6892@gmail.com>
 <23717.41596.382159.209811@stat.math.ethz.ch>
 <ebdebd3e-a522-6fba-4f10-3fea3ea38aae@gmail.com>
 <23719.1502.248949.496054@stat.math.ethz.ch>
 <db32594c-ffed-f41f-b6a8-c13b753d983e@ist.ac.at>
 <d5cf30f0-adcd-a8c3-9bfa-746b88a5582a@gmail.com>
Message-ID: <ae265c8e-951a-8973-84c0-081a3ca46d97@ist.ac.at>

So here is it as txt file. It is funny that a R file is restricted in 
R-devel mailing list.

Anyhow, in this case R-core have a few choices here:

  * ignore my solution
  * show that it is actually bad or worse
  * consider adding it

Considering, that it is a minor change from previous version and doesn't 
bother the existing usage, I saw the necessity to submit it here. But 
newer solution in the 3.6.0 may solve other problems too. I can't argue 
against that. This solves my part of the problem, without affecting 
existing usage of the function.

If R-core is hard to convince, because this is just who they are, then I 
should consider moving to other platforms. But so far, it seems to me 
that they are doing a great job. I don't mind also someone rejecting 
this tiny fix I have found, which works for me now. I can only thank for 
their time spent considering it.

Actually, I had in mind a more complex but cleaner solution with 
recursive functions to implement any kind of reformulation (not only 
with "+"). But I simple lack the big picture on R expressions, I need to 
read more. Maybe I will come back with that in the future.

Cheers to all,

Saren

On 18.04.19 17:51, Ben Bolker wrote:
>    I appreciate your enthusiasm and persistence for this issue, but I
> suspect you may have trouble convincing R-core to adopt your changes --
> they are "better", "easier", "more intuitive" for you ... but how sure
> are you they are completely backward compatible, have no performance
> issues, will not break in unusual cases ... ?
-- 
Saren Tasciyan
/PhD Student / Sixt Group/
Institute of Science and Technology Austria
Am Campus 1
3400 Klosterneuburg, Austria



-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: reformulate_solution.txt
URL: <https://stat.ethz.ch/pipermail/r-devel/attachments/20190418/766f0577/attachment.txt>


[Rd] Bug in the "reformulate" function in stats package
Saren Tasciyan