From martin.morgan at roswellpark.org  Fri Jul 21 10:13:47 2017
From: martin.morgan at roswellpark.org (Martin Morgan)
Date: Fri, 21 Jul 2017 04:13:47 -0400
Subject: [Rd] [PATCH] Fix status in main
In-Reply-To: <1528218.0Ib1CH6ICv@x2>
References: <1528218.0Ib1CH6ICv@x2>
Message-ID: <765b29ba-4512-5eb1-f26a-36abd0dd0be1@roswellpark.org>

On 07/20/2017 05:31 PM, Steve Grubb wrote:
> Hello,
> 
> This is a patch to fix what appears to be a simple typo. The warning says
> "invalid status assuming 0", but then instead sets runLast to 0.
> 
> Signed-of-by: Steve Grubb <sgrubb at redhat.com>

fixed in 72938 / 39.

This seemed not to have consequence, since exit() reports NA & 0377 
(i.e., 0) and the incorrect assignment to runLast is immediately 
over-written by the correct value.

Martin Morgan

> 
> Index: src/main/main.c
> ===================================================================
> --- src/main/main.c	(revision 72935)
> +++ src/main/main.c	(working copy)
> @@ -1341,7 +1341,7 @@
>       status = asInteger(CADR(args));
>       if (status == NA_INTEGER) {
>   	warning(_("invalid 'status', 0 assumed"));
> -	runLast = 0;
> +	status = 0;
>       }
>       runLast = asLogical(CADDR(args));
>       if (runLast == NA_LOGICAL) {
> 
> ______________________________________________
> R-devel at r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel
> 


This email message may contain legally privileged and/or...{{dropped:2}}



[Rd] [PATCH] Fix status in main
Martin Morgan