From suharto_anggono at yahoo.com  Sun Jun 11 14:30:10 2017
From: suharto_anggono at yahoo.com (Suharto Anggono Suharto Anggono)
Date: Sun, 11 Jun 2017 12:30:10 +0000 (UTC)
Subject: [Rd] translateChar in NewName in bind.c
References: <1484198017.6589962.1497184210220.ref@mail.yahoo.com>
Message-ID: <1484198017.6589962.1497184210220@mail.yahoo.com>

I see another thing in function 'NewName' in bind.c. In
else if (*CHAR(tag)) ,
'ans' is basically copied from 'tag'. Could the whole thing there be just the following?
ans = tag;
It seems to me that it can also replace
ans = R_BlankString;
in 'else'; so,
else if (*CHAR(tag))
and
else
can be merged to be just
else .

--------------------------------------------


 Subject: translateChar in NewName in bind.c
 To: r-devel at r-project.org
 Date: Saturday, 10 June, 2017, 9:14 PM
 
 In function 'NewName' in bind.c (https://svn.r-project.org/R/trunk/src/main/bind.c), in
 else if (*CHAR(base)) ,
 'translateChar' is used. Should it be
 'translateCharUTF8' instead? The end result is marked as
 UTF-8:
 mkCharCE(cbuf, CE_UTF8)
 Other cases already use
 'translateCharUTF8'.



[Rd] translateChar in NewName in bind.c
Suharto Anggono Suharto Anggono