From balbi at kernel.org  Mon Jan 19 21:20:25 2015
From: balbi at kernel.org (Felipe Balbi)
Date: Mon, 19 Jan 2015 14:20:25 -0600
Subject: [Rd] [PATCH] Makefile: add support for git svn clones
In-Reply-To: <54BD63B3.8090803@gmail.com>
References: <1421696001-21383-1-git-send-email-balbi@kernel.org>
	<54BD63B3.8090803@gmail.com>
Message-ID: <20150119202025.GA28274@saruman>

Hi,

On Mon, Jan 19, 2015 at 03:06:11PM -0500, Duncan Murdoch wrote:
> On 19/01/2015 2:33 PM, Felipe Balbi wrote:
> > git has an interface for cloning SVN repositories into git which
> > some users might decide to use. For those users' surprise, the
> > repository will always fail to build on svnonly target and it will
> > exit early.
> > 
> > The problem is simple enough to fix by just checking if a .git
> > directory exists in top_builddir and, if so, call git svn info insstead
> > of svn info.
> > 
> 
> I think we are unlikely to accept this change.  Nobody in R Core uses
> git this way, so it would never be tested, and would likely soon fail.

it will be tested by anybody using git svn clone, right ?

> Indeed, it already fails if someone were to try it on Windows, since you
> didn't patch the makefiles for that platform.

yeah, sorry about that, I wasn't aware there were windows-specific
Makefiles with duplicated logic in the repository.

> The R sources are kept in an SVN repository, and as long as that's true,
> we're only likely to support direct SVN access.

Fair enough. But don't you think it's a bit odd to couple the repository
compilation with the availability of a specific SCM tool ?

I mean, R just won't build unless you have svn info available, I think
that's pretty odd. Printing a warning would be another possibility, but
exitting build is almost an overreaction.

But fair enough, no need to spend days discussing $subject if the
community doesn't want to support git svn clone ;-)

cheers

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://stat.ethz.ch/pipermail/r-devel/attachments/20150119/b91c5deb/attachment.bin>


[Rd] [PATCH] Makefile: add support for git svn clones
Felipe Balbi