From xie at yihui.name  Thu Apr 18 20:41:46 2013
From: xie at yihui.name (Yihui Xie)
Date: Thu, 18 Apr 2013 13:41:46 -0500
Subject: [Rd] Patch proposal for R style consistency (concerning
	deparse.c)
In-Reply-To: <CAErODj_N+FCjP1zt2H4VHv28o8RDU8sQ-W4qGONkx1gLvC33pg@mail.gmail.com>
References: <CAErODj85saboM+8SaYKKVVDL6cPeX=LVR=PKwY+FZb2ky_cpBg@mail.gmail.com>
	<5478C197-76AB-481D-A1AA-64DB63D8D122@gmail.com>
	<CAErODj_N+FCjP1zt2H4VHv28o8RDU8sQ-W4qGONkx1gLvC33pg@mail.gmail.com>
Message-ID: <CANROs4emmr=rGLKWpCQ6z_016mAk7O42=ttA1BLnc9zQ_DTzqQ@mail.gmail.com>

I second the change of "} else {".

Regards,
Yihui
--
Yihui Xie <xieyihui at gmail.com>
Phone: 515-294-2465 Web: http://yihui.name
Department of Statistics, Iowa State University
2215 Snedecor Hall, Ames, IA


On Thu, Apr 18, 2013 at 11:16 AM, Paul Johnson <pauljohn32 at gmail.com> wrote:
> OK, I concede that.
>
> Now, how about "} else {"
>
> I will provide patch that does only that change.
> ?
>
> On Thu, Apr 18, 2013 at 3:05 AM, peter dalgaard <pdalgd at gmail.com> wrote:
>>
>> On Apr 18, 2013, at 05:39 , Paul Johnson wrote:
>>
>>> 2 & 3. I want to omit space after if and for.   Since if and for are
>>> functions in R, not keywords, I suggest that there should not be a
>>> space before the opening parentheses.
>>
>> Wrong. They are part of language constructs (and they _are_ keywords, not names, that's why ?for won't work). The function calls are `if`(fee, {foo}, {fie}) and something rebarbative for `for`(....).
>>
>> Besides, both constructs are harder to read without the spaces.
>>
>> --
>> Peter Dalgaard, Professor
>> Center for Statistics, Copenhagen Business School
>> Solbjerg Plads 3, 2000 Frederiksberg, Denmark
>> Phone: (+45)38153501
>> Email: pd.mes at cbs.dk  Priv: PDalgd at gmail.com
>>
>
>
>
> --
> Paul E. Johnson
> Professor, Political Science      Assoc. Director
> 1541 Lilac Lane, Room 504      Center for Research Methods
> University of Kansas                 University of Kansas
> http://pj.freefaculty.org               http://quant.ku.edu



[Rd] Patch proposal for R style consistency (concerning deparse.c)
Yihui Xie