From h.wickham at gmail.com  Tue Nov 21 14:23:11 2017
From: h.wickham at gmail.com (Hadley Wickham)
Date: Tue, 21 Nov 2017 07:23:11 -0600
Subject: [Rd] Small performance bug in [.Date
In-Reply-To: <23060.580.899992.677761@stat.math.ethz.ch>
References: <CABdHhvH6iWobpPDdpOWc0oqDASNJbTwgRQp9RaS-Jk_JNDE4dg@mail.gmail.com>
 <23060.580.899992.677761@stat.math.ethz.ch>
Message-ID: <CABdHhvGLu7x9jAYQh_vr3i9ar8Th-5Z3mZ1o5ejwHL9GPRyHiw@mail.gmail.com>

> Yes, at least so it looks in  src/main/objects.c
>
> Also, we had a very similar change a while ago :
> ------------------------------------------------------------------------
> r65926 | luke | 2014-06-12 15:54:38 +0200 (Thu, 12. Jun 2014) | 2 Zeilen
> Ge?nderte Pfade:
>    M src/library/base/R/datetime.R
>
> Commented out class(x) <- NULL in [.POSIXct and [[.POSICct.
> ------------------------------------------------------------------------
>
> and we never seemed to have followed up in a systematic manner
> finding other places where this happens and could be
> eliminated.  I see about half a dozen examples in
> base/R/dates.R  alone and am trying to find more in other places.
>
> [maybe this used to be necessary for very early different
>  versions of NextMethod() which were not yet optimized using  .Class etc]

Thanks for making the fix!

Hadley

-- 
http://hadley.nz



[Rd] Small performance bug in [.Date
Hadley Wickham