From ggrothendieck at gmail.com  Tue Jul  3 19:42:54 2007
From: ggrothendieck at gmail.com (Gabor Grothendieck)
Date: Tue, 3 Jul 2007 13:42:54 -0400
Subject: [Rd] minor flaw in integrate()
In-Reply-To: <46842286.8080402@uni-bayreuth.de>
References: <46842286.8080402@uni-bayreuth.de>
Message-ID: <971536df0707031042n8b3e0a4re00e6d286dbeba7@mail.gmail.com>

If integrate is changed it would be nice at the same time to make it
into an S3 generic.  deriv already is an S3 generic but strangely integrate
is not.  Ryacas provides a deriv method but for integrate Ryacas inconsistently
provides Integrate since integrate is not generic.

On 6/28/07, Peter Ruckdeschel <Peter.Ruckdeschel at uni-bayreuth.de> wrote:
> Hi,
>
> I noticed a minor flaw in integrate() from package stats:
>
> Taking up arguments lower and upper from integrate(),
>
>   if (lower ==  Inf) && (upper ==  Inf)
>
>       or
>
>   if (lower == -Inf) && (upper == -Inf)
>
> integrate() calculates the value for (lower==-Inf) && (upper==Inf).
>
> Rather, it should return 0.
>
> Quick fix:
>
> ### old code ###
> ### [snip]
>    else {
>            if (is.na(lower) || is.na(upper))
>                stop("a limit is missing")
>            if (is.finite(lower)) {
>                inf <- 1
>                bound <- lower
>            }
>            else if (is.finite(upper)) {
>                inf <- -1
>                bound <- upper
>            }
>            else {
>                inf <- 2
>                bound <- 0
>            }
>            wk <- .External("call_dqagi", ff, rho = environment(),
>                as.double(bound), as.integer(inf), as.double(abs.tol),
>                as.double(rel.tol), limit = limit, PACKAGE = "base")
>    }
> ### [snip]
>
> ### new code  to replace the old one ###
>
> ### [snip]
>    else {
>            if (is.na(lower) || is.na(upper))
>                stop("a limit is missing")
>
>            if (lower == upper){
>
>                wk <- list("value" = 0, "abs.error" = 0,
>                        "subdivisions" = subdivisions,
>                        "ierr" = 0 )
>
>            } else {
>                    if (is.finite(lower)) {
>                        inf <- 1
>                        bound <- lower
>                    }
>                    else if (is.finite(upper)) {
>                            inf <- -1
>                        bound <- upper
>                    }
>                    else {
>                        inf <- 2
>                        bound <- 0
>                    }
>                    wk <- .External("call_dqagi", ff, rho = environment(),
>                            as.double(bound), as.integer(inf),
>                            as.double(abs.tol), as.double(rel.tol),
>                            limit = limit, PACKAGE = "base")
>
>            }
>    }
> ### [snip]
>
> Best, Peter
>
> ______________________________________________
> R-devel at r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel
>



[Rd] minor flaw in integrate()
Gabor Grothendieck