From roebuck at odin.mdacc.tmc.edu  Wed Jun 15 23:16:52 2005
From: roebuck at odin.mdacc.tmc.edu (Paul Roebuck)
Date: Wed, 15 Jun 2005 16:16:52 -0500 (CDT)
Subject: [Rd] R Include File Guards
In-Reply-To: <x2psvorz1q.fsf@turmalin.kubism.ku.dk>
References: <Pine.OSF.4.58.0505181524160.204610@odin.mdacc.tmc.edu>
	<x2psvorz1q.fsf@turmalin.kubism.ku.dk>
Message-ID: <Pine.OSF.4.58.0506151612190.332019@odin.mdacc.tmc.edu>

On Wed, 18 May 2005, Peter Dalgaard wrote:

> Paul Roebuck <roebuck at odin.mdacc.tmc.edu> writes:
>
> > R 2.1.0/src/include from 2005/04/18 download
> >
> > Naming inconsistent for guards as well but that's pedantic.
> > Simple convention:
> >   file <foo.h>
> >     #ifndef R_FOO_H
> >   file <R_ext/bar.h>
> >     #ifndef R_EXT_BAR_H
> >
> > Missing guards:
> > <IOStuff.h>
> > <Internal.h>
> > <Parse.h>
> > <R_ext/GraphicsBase.h>
> > <R_ext/GraphicsDevice.h>
> > <R_ext/GraphicsEngine.h>
> > <R_ext/R-ftp-http.h>
> > <R_ext/libextern.h>
> >
> >
> > Illegal Guards (leading underscore):
> > <Rinternals.h>
> > <R_ext/Error.h>
> > <config.h.in>
>
> Thanks. The ones outside R_ext, except Rinternals.h, are not part of the
> API, so it is not a bug that there are no guards - could still be a
> good idea to have them of course. libextern.h explicitly says that you
> shouldn't disallow including it more than once. So the ones with real
> problems would be
>
> <R_ext/GraphicsBase.h>
> <R_ext/GraphicsDevice.h>
> <R_ext/GraphicsEngine.h>
> <R_ext/R-ftp-http.h>
>
> <Rinternals.h>
> <R_ext/Error.h>
>
> What's illegal about leading underscores, BTW?
>

I downloaded the R-patched for 2005/06/14 and noticed that
the guards were never fixed. Should a bug report have been
opened instead of simply noting them here?

----------------------------------------------------------
SIGSIG -- signature too long (core dumped)



[Rd] R Include File Guards
Paul Roebuck