From tomas.kalibera at gmail.com  Tue Jun 13 09:35:50 2017
From: tomas.kalibera at gmail.com (Tomas Kalibera)
Date: Tue, 13 Jun 2017 09:35:50 +0200
Subject: [Rd] translateChar in NewName in bind.c
In-Reply-To: <1484198017.6589962.1497184210220@mail.yahoo.com>
References: <1484198017.6589962.1497184210220.ref@mail.yahoo.com>
 <1484198017.6589962.1497184210220@mail.yahoo.com>
Message-ID: <73f9e2e7-3b4b-f057-0c3c-329d1f6c4509@gmail.com>

Thanks, fixed in R-devel.
Best
Tomas

On 06/11/2017 02:30 PM, Suharto Anggono Suharto Anggono via R-devel wrote:
> I see another thing in function 'NewName' in bind.c. In
> else if (*CHAR(tag)) ,
> 'ans' is basically copied from 'tag'. Could the whole thing there be just the following?
> ans = tag;
> It seems to me that it can also replace
> ans = R_BlankString;
> in 'else'; so,
> else if (*CHAR(tag))
> and
> else
> can be merged to be just
> else .
>
> --------------------------------------------
>
>
>   Subject: translateChar in NewName in bind.c
>   To: r-devel at r-project.org
>   Date: Saturday, 10 June, 2017, 9:14 PM
>   
>   In function 'NewName' in bind.c (https://svn.r-project.org/R/trunk/src/main/bind.c), in
>   else if (*CHAR(base)) ,
>   'translateChar' is used. Should it be
>   'translateCharUTF8' instead? The end result is marked as
>   UTF-8:
>   mkCharCE(cbuf, CE_UTF8)
>   Other cases already use
>   'translateCharUTF8'.
>
> ______________________________________________
> R-devel at r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel



[Rd] translateChar in NewName in bind.c
Tomas Kalibera