From suharto_anggono at yahoo.com  Mon Sep  3 12:05:56 2012
From: suharto_anggono at yahoo.com (Suharto Anggono Suharto Anggono)
Date: Mon, 3 Sep 2012 03:05:56 -0700 (PDT)
Subject: [Rd] Typo (?) in 'aggregate.formula'
In-Reply-To: <0FF0E2BB-CCCA-40D0-9A32-AB6F3BC10860@gmail.com>
Message-ID: <1346666756.62489.YahooMailClassic@web125106.mail.ne1.yahoo.com>

No, I didn't actually get bitten by this. I used 'aggregate.formula' only recently. I saw this when trying to know how 'aggregate.formula' worked, especially in accepting dot (.) in left-hand side of formula.
Thanks for the fix.

--- On Mon, 3/9/12, peter dalgaard <pdalgd at gmail.com> wrote:

> From: peter dalgaard <pdalgd at gmail.com>
> Subject: Re: [Rd] Typo (?) in 'aggregate.formula'
> To: "Suharto Anggono Suharto Anggono" <suharto_anggono at yahoo.com>
> Cc: R-devel at r-project.org
> Date: Monday, 3 September, 2012, 4:43 PM
> This (and more) was fixed in r-devel
> back in May. Did you actually get bitten by this? (The code
> has been there for years, so it hasn't been slated for
> R-patched.)
> 
> -pd 
> 
> On Sep 3, 2012, at 11:06 , Suharto Anggono Suharto Anggono
> wrote:
> 
> > In the code for 'aggregate.formula', there is
> > if (as.character(formula[[2L]] == "."))
> > I believe that it is meant to be
> > if (as.character(formula[[2L]]) == ".")
> > 
> > However,
> > if (as.character(formula[[2L]] == "."))
> > gives the expected result.
> > Tracing:
> > - formula[[2L]] == "."
> > is equivalent to
> > as.character(formula[[2L]]) == "."
> > From the help page for '==' (Comparison), "Language
> objects such as symbols and calls are deparsed to character
> strings before comparison."
> > - By applying 'as.character', the TRUE/FALSE result of
> > formula[[2L]] == "."
> > is converted to character, becomes "TRUE"/"FALSE".
> > - Then, for 'if', it is implicitly converted back to
> logical.
> > 
> > 
> >> sessionInfo()
> > R version 2.14.2 (2012-02-29)
> > Platform: i386-pc-mingw32/i386 (32-bit)
> > 
> > locale:
> > [1] LC_COLLATE=English_United States.1252 
> > [2] LC_CTYPE=English_United
> States.1252???
> > [3] LC_MONETARY=English_United States.1252
> > [4] LC_NUMERIC=C? ? ? ? ?
> ? ? ? ? ? ? ? ? 
> > [5] LC_TIME=English_United States.1252? ? 
> > 
> > attached base packages:
> > [1] stats? ???graphics?
> grDevices utils? ???datasets?
> methods???base? ???
> > 
> > 
> > I see that, in R 2.15.1, the code for
> 'aggregate.formula' is still the same.
> > 
> > ______________________________________________
> > R-devel at r-project.org
> mailing list
> > https://stat.ethz.ch/mailman/listinfo/r-devel
> 
> -- 
> Peter Dalgaard, Professor
> Center for Statistics, Copenhagen Business School
> Solbjerg Plads 3, 2000 Frederiksberg, Denmark
> Phone: (+45)38153501
> Email: pd.mes at cbs.dk?
> Priv: PDalgd at gmail.com
> 
>



[Rd] Typo (?) in 'aggregate.formula'
Suharto Anggono Suharto Anggono