From maechler at stat.math.ethz.ch  Sat Apr 14 16:19:29 2018
From: maechler at stat.math.ethz.ch (Martin Maechler)
Date: Sat, 14 Apr 2018 16:19:29 +0200
Subject: [Rd] Fwd: suggested patch for messages
In-Reply-To: <CABghstQfMawckLUrA6Yh5adzUdwD5XH6Eo_=VN=ByEGvFCy5dA@mail.gmail.com>
References: <CABghstTbEB1Y2TbvxvEN8iEy7psi3wAb75m0WOEr4eOZvUj6WA@mail.gmail.com>
 <CABghstQfMawckLUrA6Yh5adzUdwD5XH6Eo_=VN=ByEGvFCy5dA@mail.gmail.com>
Message-ID: <23250.3569.519324.104572@stat.math.ethz.ch>

>>>>> Ben Bolker <bbolker at gmail.com>
>>>>>     on Fri, 13 Apr 2018 14:42:10 -0400 writes:

    > Any follow-up/comments on this? If I don't hear back I'll submit to
    > r-bugs so it doesn't get lost ...

    > (Don't see any changes in QC.R in the last few days ...
    > https://github.com/wch/r-source/commits/trunk/src/library/tools/R/QC.R
    > )

Thank you, Ben, for the proposal and the reminder.

I agree that the message after the change is much easier to
understand, notably for people like me who are not proficient in
style of the Queen's English.

I've committed a change (74593) to R-devel where I've slightly
simplified the wording from
 "this would be:"  to
 "that is:"

and really I cannot give a rational reason why I also
changed "this" to "that"  so I'm open for another tweak from
people with better English style proficiency..

Martin


---------- Forwarded message ----------
  From: Ben Bolker <bbolker at gmail.com>
  Date: Sun, Apr 8, 2018 at 1:45 PM
  Subject: suggested patch for messages
  To: r-devel at r-project.org


  Does anyone have comments on the new wording here?

  Suggested:

  The Title field should be in title case. Current version is:
     (xxx)
  In title case this would be:
     (Xxx)

  Hoping R core will see this here and magically adopt it, otherwise
  I'll try posting it to the r bugs site ...

===================================================================
--- src/library/tools/R/QC.R    (revision 74551)
+++ src/library/tools/R/QC.R    (working copy)
@@ -7727,8 +7727,10 @@
                 "The Title field starts with the package name."
             },
             if(length(y <- x$title_case)) {
-                paste(c("The Title field should be in title case,
current version then in title case:",
-                        sQuote(y)),
+                paste(c("The Title field should be in title case.
Current version is:",
+                        sQuote(y[1]),
+                        "In title case this would be:",
+                        sQuote(y[2])),
                       collapse = "\n")
             })),
       fmt(c(if(length(x$descr_bad_initial)) {



[Rd] Fwd: suggested patch for messages
Martin Maechler