From dtemplel@ng @ending from ucd@vi@@edu  Wed Jun  6 22:59:14 2018
From: dtemplel@ng @ending from ucd@vi@@edu (Duncan Temple Lang)
Date: Wed, 6 Jun 2018 13:59:14 -0700
Subject: [Rd] minor problem in XML package
In-Reply-To: <CAF8bMcZ__6AAfKuxi-CUMORo+35WN7vmgO_umDf-10bmmxjv0g@mail.gmail.com>
References: <CAF8bMcZ__6AAfKuxi-CUMORo+35WN7vmgO_umDf-10bmmxjv0g@mail.gmail.com>
Message-ID: <CABQ6xNabpUVOMTNr2BUzbJnxLwmT=OWxi29tUhmur3dkfzCStg@mail.gmail.com>

Thanks Bill.
It has been changed in the github repository for the package for a while
now.
Thanks for pointing out.

D.

On Wed, Jun 6, 2018 at 11:40 AM William Dunlap via R-devel <
r-devel at r-project.org> wrote:

> [The package XML is labelled ORPHANED and a comment says the CRAN team
> maintains it.  I am not sure what address to send this to.]
>
> In package XML version 3.98.1.11, RUtils.c registers the C function
> RS_XML_xmlNodeChildrenReferences twice.  The registration information is
> identical but this could cause maintenance problems if the routine were
> changed.
>
> % grep -n RS_XML_xmlNodeChildrenReferences RUtils.c
> 205:        ENTRY(RS_XML_xmlNodeChildrenReferences, 3),
> 231:    ENTRY(RS_XML_xmlNodeChildrenReferences, 3),
>
> One of them should be deleted.
>
> % diff -u XML/src/RUtils.c~ XML/src/RUtils.c
> --- XML/src/RUtils.c~   2018-06-06 11:32:16.549338000 -0700
> +++ XML/src/RUtils.c    2018-06-06 11:33:07.899782000 -0700
> @@ -228,7 +228,6 @@
>         ENTRY(RS_XML_xmlNodeName, 1),
>         ENTRY(RS_XML_xmlNodeNamespace, 1),
>         ENTRY(RS_XML_xmlNodeAttributes, 3),
> -       ENTRY(RS_XML_xmlNodeChildrenReferences, 3),
>         ENTRY(R_xmlNodeValue, 3),
>         ENTRY(R_setXMLInternalTextNode_value, 2),
>         ENTRY(RS_XML_xmlNodeParent, 2),
>
> Bill Dunlap
> TIBCO Software
> wdunlap tibco.com
>
>         [[alternative HTML version deleted]]
>
> ______________________________________________
> R-devel at r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel
>
-- 
Duncan Temple Lang
Director, Data Science Initiative
Professor of Statistics

	[[alternative HTML version deleted]]



[Rd] minor problem in XML package
Duncan Temple Lang