From p.dalgaard at biostat.ku.dk  Sat Apr  9 20:24:00 2005
From: p.dalgaard at biostat.ku.dk (Peter Dalgaard)
Date: Sat Apr  9 20:27:09 2005
Subject: [Rd] make check-all fails (PR#7784)
In-Reply-To: <425819C2.5070108@cesmail.net>
References: <20050409172136.1C551CA2F@slim.kubism.ku.dk>
	<x2y8br26ao.fsf@turmalin.kubism.ku.dk> <425819C2.5070108@cesmail.net>
Message-ID: <x2u0mf24hr.fsf@turmalin.kubism.ku.dk>

"M. Edward (Ed) Borasky" <znmeb@cesmail.net> writes:

[snip]
> >Hmm, could you replace the a1 == a2 with all.equal(a1, a2) instead?
> >(inside reg-tests-1.R of course)
> >
> >Asking for identity up to machine precision does look a bit optimistic...
> >
> >
> That worked ... it got through reg-tests-1.R fine. However, it failed
> a little further down in the NA handling tests:
> 
> running tests of NA handling functions
> make[3]: Entering directory `/home/znmeb/R-beta/tests'
> running code in 'nafns.R' ...make[3]: *** [nafns.Rout] Error 1
> make[3]: Leaving directory `/home/znmeb/R-beta/tests'
> make[2]: *** [test-Nafns] Error 2
> make[2]: Leaving directory `/home/znmeb/R-beta/tests'
> make[1]: *** [test-all-devel] Error 1
> make[1]: Leaving directory `/home/znmeb/R-beta/tests'
> make: *** [check-all] Error 2
> 
>  > sm(fitted(gfit2))
> length 153 with 42 NAs
>  > sm(resid(gfit2))
> length 153 with 42 NAs
>  > sm(predict(gfit2))
> length 153 with 42 NAs
>  > (pp2 <- predict(gfit2, nd))
> 6 25 26 27
> NA -16.177404 1.688479 NA
>  > stopifnot(all.equal(pp, pp2))
>  >
>  > ## more precise tests.
>  > f1 <- fitted(gfit)
>  > f2 <- fitted(gfit2)
>  > common <- match(names(f1), names(f2))
>  > stopifnot(max(abs(f1 - f2[common])) < 100*.Machine$double.eps)
> Error: max(abs(f1 - f2[common])) < 100 * .Machine$double.eps is not TRUE
> Execution halted
> "tests/nafns.Rout.fail"

This looks more serious. 100 times machine precision is quite a large
margin in these matters. Could you perhaps stick in a printout of the
two terms and their difference?

I have an ATLAS build on AMD64 and it passes all the checks, but it is
using ATLAS 3.7.8, so you might want to try an upgrade.

-- 
   O__  ---- Peter Dalgaard             Blegdamsvej 3  
  c/ /'_ --- Dept. of Biostatistics     2200 Cph. N   
 (*) \(*) -- University of Copenhagen   Denmark      Ph: (+45) 35327918
~~~~~~~~~~ - (p.dalgaard@biostat.ku.dk)             FAX: (+45) 35327907


[Rd] make check-all fails (PR#7784)
Peter Dalgaard