From rgentlem@jimmy.harvard.edu  Sun Oct 31 17:12:38 1999
From: rgentlem@jimmy.harvard.edu (Robert Gentleman)
Date: Sun, 31 Oct 1999 12:12:38 -0500
Subject: diag
In-Reply-To: <Pine.GSO.4.05.9910311620090.12623-100000@auk.stats>; from Prof Brian D Ripley on Sun, Oct 31, 1999 at 04:36:33PM +0000
References: <Pine.GSO.4.05.9910311620090.12623-100000@auk.stats>
Message-ID: <19991031121238.A10461@jimmy.harvard.edu>

On Sun, Oct 31, 1999 at 04:36:33PM +0000, Prof Brian D Ripley wrote:
> A change to diag() between 0.65.0 and 0.65.1 which seems undocumented in
> the logs (apparently revision 1.3.2.1, `diag names') introduced
> 
>     if (is.array(x)) 
>         stop("first argument is array, but not matrix.")
> 
> which has broken the code in rpart. This looks wrong to me, as diag used to
> cope happily with a single-dimensional array. Such things occur quite
> often as the output from table().
> 
> Is there any reason not to make this
> 
>     if (length(dim(x)) > 2)
> 
> which seems the intention?  Martin (if I have decoded the cvs diffs
> correctly)?
> 
  I think it was me. I think that this is fine (the old version
complained about matrices at this point and they should be allowed).
  It was a bug report off of R-help but I can't recall who...
robert
-- 
+-------------------------------------------------------------------------+
| Robert Gentleman              voice: (617) 632-5045                     |
| Senior Lecturer               fax:   (617) 632-2444                     |
| University of Auckland	email1: rgentlem@jimmy.harvard.edu        |
| on leave at:                                                            |
| Dana-Farber Cancer Institute  email2: rgentlem@stat.auckland.ac.nz      |
+-------------------------------------------------------------------------+
-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-
r-devel mailing list -- Read http://www.ci.tuwien.ac.at/~hornik/R/R-FAQ.html
Send "info", "help", or "[un]subscribe"
(in the "body", not the subject !)  To: r-devel-request@stat.math.ethz.ch
_._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._


diag
Robert Gentleman