From maechler at stat.math.ethz.ch  Mon Dec 10 17:46:50 2012
From: maechler at stat.math.ethz.ch (Martin Maechler)
Date: Mon, 10 Dec 2012 17:46:50 +0100
Subject: [Rd] small issue with over-zealous clean.
In-Reply-To: <1355131394.64582.YahooMailClassic@web172305.mail.ir2.yahoo.com>
References: <20677.41077.877503.721651@stat.math.ethz.ch>
	<1355131394.64582.YahooMailClassic@web172305.mail.ir2.yahoo.com>
Message-ID: <20678.4602.644283.169005@stat.math.ethz.ch>

>>>>> Hin-Tak Leung <htl10 at users.sourceforge.net>
>>>>>     on Mon, 10 Dec 2012 09:23:14 +0000 writes:

    > --- On Mon, 10/12/12, Martin Maechler <maechler at stat.math.ethz.ch> wrote:
 [.....]

    >> > That said ..a small bug was introduced back in
    >> May? .....
    >> 
    >> Yes, you are right.
    >> BTW: The reason that nobody (from R core, probably not many
    >> people otherwise) has found/mentioned this bug before is not
    >> the
    >> use of svn, but the fact that it is much more convenient
    >> (and
    >> hence somewhat recommended) to build R outside of its
    >> source
    >> directory, and in that case the two *.Rd files that belong
    >> to
    >> ./tests/ are not removed (from the *build* directory's
    >> ./tests/)

    > "more convenient" is a subjective matter.

    > As I mentioned in my original post, I have a few local modifications which are continually re-applied ("rebase"d, but I shall not be drawn into arguing about matters of personal preference again) - therefore it is more convenient to build on top.

    > Since we are on the topic of locally-continually applied modifications, I reported another issue about 40 days ago, that reccent R trunk now treat revision as numeric, so 'unknown' in the topic level Makefile.in should be changed accordingly to 0 or some number. Here is the diff - one of the "locally-continually applied modifications" I am talking about:

    > --- a/Makefile.in
    > +++ b/Makefile.in
    > @@ -94,7 +94,7 @@ svnonly:
    > @if test ! -f "$(srcdir)/doc/FAQ" || test -f non-tarball ; then \
    > (cd doc/manual && $(MAKE) front-matter html-non-svn) ; \
    > touch non-tarball ; \
    > -         (cd $(srcdir); LC_ALL=C TZ=GMT svn info || $(ECHO) "Revision: unknown") 2> /dev/null \
    > +         (cd $(srcdir); LC_ALL=C TZ=GMT svn info || $(ECHO) "Revision: 0") 2> /dev/null \
    > | sed -n -e '/^Revision/p' -e '/^Last Changed Date/'p \
    > | cut -d' ' -f1,2,3,4 > SVN-REVISION-tmp ; \
    > $(SHELL) $(top_srcdir)/tools/move-if-change SVN-REVISION-tmp SVN-REVISION ; \

That change needs another important change in src/main/version.c
where the string "unknown" has been explicitly looked for.

I have now committed a patch to both ---
using '-99' : something clearly "artificial", rather than '0'
which looks too innocuous.

Martin



[Rd] small issue with over-zealous clean.
Martin Maechler