From maechler at stat.math.ethz.ch  Thu May 19 11:02:48 2016
From: maechler at stat.math.ethz.ch (Martin Maechler)
Date: Thu, 19 May 2016 11:02:48 +0200
Subject: [Rd] Latest R-devel build failing on OS X
In-Reply-To: <22333.30916.298334.864817@stat.math.ethz.ch>
References: <70CBF2CD-1B4C-48CA-AFFD-E3F1DDBDC073@nyu.edu>
	<1771C0EE-8B59-4921-B648-60DB197824C2@gmail.com>
	<22332.40522.266571.404208@stat.math.ethz.ch>
	<25CBCECC-52C0-4228-978B-44BE848C7CF3@gmail.com>
	<604481D6-9DE0-49D1-89A6-41B8A8D537B7@gmail.com>
	<0C7F9946-4666-493C-BE88-5805B56902A5@gmail.com>
	<20160518220330.GA1621@ofb.net>
	<22333.30916.298334.864817@stat.math.ethz.ch>
Message-ID: <22333.33080.885593.770604@stat.math.ethz.ch>

>>>>> Martin Maechler <maechler at stat.math.ethz.ch>
>>>>>     on Thu, 19 May 2016 10:26:44 +0200 writes:

>>>>>   <frederik at ofb.net>
>>>>>     on Wed, 18 May 2016 15:03:31 -0700 writes:

    >> Readline <= 6.2 shouldn't require the SIGWINCH patch, so
    >> if older versions have trouble finding rl_resize_terminal
    >> then you could wrap a macro around that part.

    > I find python related patches that use

    > #ifdef HAVE_RL_RESIZE_TERMINAL

    > so they must have configured for that.  We could and
    > probably should do the same, but as a Linux_only guy
    > currently (even basically only one flavor of Linux), I'd
    > appreciate others to produce code for that.

Actually that was easy (in hindsight.. I took too long!)
enough, so I've now committed

------------------------------------------------------------------------
r70632 | maechler | 2016-05-19 10:59:51 +0200 (Thu, 19 May 2016) | 1 line
Changed paths:
   M configure
   M configure.ac
   M src/include/config.h.in
   M src/unix/sys-std.c

check for rl_resize_terminal() now
------------------------------------------------------------------------

... and Keith should even not see the warning anymore
(nor Peter the error, when compiling using readline 5.x instead of 6.[23]).



    >> The isearch C-c bug has existed forever, according to
    >> Chet Ramey.

    > I see.  As your patch seems to only work for readline (>=)
    > 6.3, we have solved part of the problems.  If those who
    > use olders readlines are willing to test and provide (well
    > looking, as yours) patches for earlier versions, they
    > should be welcome too.



    >> Yes, I had to retrain myself to use C-g to exit isearch
    >> but it's confusing.  It would be nice to fix this C-c bug
    >> on older versions too, but my solution used some global
    >> variables and I'm not sure which Readline version they
    >> date from.

    >> Out of curiosity, did you delete the
    >> HAVE_READLINE_READLINE_H block?

    > Not yet...I've even kept your suggestion about it in the
    > source comments.  Note you can always point your web
    > browser at https://svn.r-project.org/trunk/R/ which
    > contains upto the minute current R development sources (it
    > *is* our apache based subversion server), i.e., the file
    > in this case is
    > https://svn.r-project.org/trunk/R/src/unix/sys-std.c

    > {or you can use the github *mirror* of the svn server
    > which provides version/revision/log etc ((this be
    > available for svn as well, but we (I) had chosen not to
    > provide (via apache modules) just to keep our server as
    > bare bones as possible and hence less vulnerable to
    > viciousities)) }



[Rd] Latest R-devel build failing on OS X
Martin Maechler