From nalimilan at club.fr  Fri Oct 21 15:00:25 2011
From: nalimilan at club.fr (Milan Bouchet-Valat)
Date: Fri, 21 Oct 2011 15:00:25 +0200
Subject: [Rd] Contributors on R-Forge
In-Reply-To: <3CBFCFB1FEFFA841BA83ADF2F2A9C6FA01BF66A3@mango-data1.Mango.local>
References: <3CBFCFB1FEFFA841BA83ADF2F2A9C6FA01BF66A3@mango-data1.Mango.local>
Message-ID: <1319202026.9174.6.camel@milan>

Le vendredi 21 octobre 2011 ? 13:39 +0100, Charles Roosen a ?crit :
> Hi,
> 
>  
> I've recently taken over maintenance for the "xtable" package, and have
> set it up on R-Forge.  At the moment I'm pondering what the best way is
> to handle submitted patches.  Basically, is it better to:
>  
> 
> 1)      Be non-restrictive regarding committer status, let individuals
> change the code with minimal pre-commit review, and figure changes can
> be reviewed before release.
> 
> 2)      Accept patches and basically log them as issues to look at in
> detail before putting them in.
I'd say you'd better review patches before they go in, as it would be
quite ugly to fix things afterwards, right before the release. If a
patch is buggy, better catch problems early instead of waiting for
changes to add up: then, it will be harder to find out the origin of the
bug. It also allows you to spot small issues like styling and
indentation, that you wouldn't bother to fix once they've been
committed.

You can give people committer status, but ask them to post their patches
as issues before committing. This reduces the burden imposed on the
reviewer/maintainer.


Regards



[Rd] Contributors on R-Forge
Milan Bouchet-Valat