From berwin at maths.uwa.edu.au  Mon Oct 11 20:15:27 2010
From: berwin at maths.uwa.edu.au (Berwin A Turlach)
Date: Tue, 12 Oct 2010 02:15:27 +0800
Subject: [Rd] Query about .check_packages_used_in_examples
In-Reply-To: <alpine.LFD.2.00.1010111108030.24058@gannet.stats.ox.ac.uk>
References: <20101011060646.0fbab35a@goodenia>
	<20101011062603.13b56251@goodenia>
	<alpine.LFD.2.00.1010111108030.24058@gannet.stats.ox.ac.uk>
Message-ID: <20101012021527.5c5f799a@goodenia>

G'day Brian,

On Mon, 11 Oct 2010 11:11:42 +0100 (BST)
Prof Brian Ripley <ripley at stats.ox.ac.uk> wrote:

> Sounds reasonable to count Imports, so we'll alter this.

Thanks for that.  I noticed the changes to R-devel and to the R-2-12-branch.
Looking at the diffs (an example is appended below), it seems to me
that, except for the ordering, the variables `depends_suggests' and
`imports'  are the same.  This would suggest that only one of them is
necessary and that the remaining code could be made leaner...  but
probably that is something to do after the code freeze is over...

> Thank you for the report,  However, the pre-test period for 2.12.0 is 
> already 80% over and we are in code freeze -- reports early on in the 
> period are much more useful and at this stage anything but very
> simple localized changes need to be deferred to 2.12.1.

Point taken.  When I am back home, I will think about what versions of
R I want to have installed on my main machine...  should probably
also write some scripts that regularly check my packages...

Cheers,

	Berwin

berwin at goodenia:/opt/src/R-2-12-branch/src/library/tools/R$ svn diff -r53024 QC.R
Index: QC.R
===================================================================
--- QC.R        (revision 53024)
+++ QC.R        (working copy)
@@ -3937,7 +3937,7 @@

     ## it is OK to refer to yourself and standard packages
     standard_package_names <- .get_standard_package_names()$base
-    depends_suggests <- c(depends, suggests, enhances,  pkg_name,
+    depends_suggests <- c(depends, imports, suggests, enhances, pkg_name,
                           standard_package_names)
     imports <- c(imports, depends, suggests, enhances, pkg_name,
                  standard_package_names)
@@ -4038,7 +4038,7 @@

     ## it is OK to refer to yourself and standard packages
     standard_package_names <- .get_standard_package_names()$base
-    depends_suggests <- c(depends, suggests, enhances,  pkg_name,
+    depends_suggests <- c(depends, imports, suggests, enhances, pkg_name,
                           standard_package_names)
     imports <- c(imports, depends, suggests, enhances, pkg_name,
                  standard_package_names)



[Rd] Query about .check_packages_used_in_examples
Berwin A Turlach