Merge pull request #1292 from danielaskdd/fix-promise-warning

Fix promise warning and add null checks in FileUploader to prevent split() on undefined

lightrag/api/__init__.py

@@ -1 +1 @@
-__api_version__ = "0138"
+__api_version__ = "0139"

lightrag_webui/src/App.tsx

@@ -33,6 +33,26 @@ function App() {
     }
   }, [])
 
+  // Track component mount status with useRef
+  const isMountedRef = useRef(true);
+
+  // Set up mount/unmount status tracking
+  useEffect(() => {
+    isMountedRef.current = true;
+
+    // Handle page reload/unload
+    const handleBeforeUnload = () => {
+      isMountedRef.current = false;
+    };
+
+    window.addEventListener('beforeunload', handleBeforeUnload);
+
+    return () => {
+      isMountedRef.current = false;
+      window.removeEventListener('beforeunload', handleBeforeUnload);
+    };
+  }, []);
+
   // Health check - can be disabled
   useEffect(() => {
     // Only execute if health check is enabled and ApiKeyAlert is closed
@@ -40,7 +60,14 @@ function App() {
 
     // Health check function
     const performHealthCheck = async () => {
-      await useBackendState.getState().check();
+      try {
+        // Only perform health check if component is still mounted
+        if (isMountedRef.current) {
+          await useBackendState.getState().check();
+        }
+      } catch (error) {
+        console.error('Health check error:', error);
+      }
     };
 
     // Set interval for periodic execution

lightrag_webui/src/components/ui/FileUploader.tsx

@@ -206,10 +206,15 @@ function FileUploader(props: FileUploaderProps) {
       if (onUpload && acceptedFiles.length > 0) {
         // Filter out any files that might have been rejected by our custom validator
         const validFiles = acceptedFiles.filter(file => {
+          // Skip files without a name
+          if (!file.name) {
+            return false;
+          }
+
           // Check if file type is accepted
           const fileExt = `.${file.name.split('.').pop()?.toLowerCase() || ''}`;
           const isAccepted = Object.entries(accept || {}).some(([mimeType, extensions]) => {
-            return file.type === mimeType || extensions.includes(fileExt);
+            return file.type === mimeType || (Array.isArray(extensions) && extensions.includes(fileExt));
           });
 
           // Check file size
@@ -260,10 +265,22 @@ function FileUploader(props: FileUploaderProps) {
         multiple={maxFileCount > 1 || multiple}
         disabled={isDisabled}
         validator={(file) => {
-          // Check if file type is accepted
+          // Ensure file name exists
+          if (!file.name) {
+            return {
+              code: 'invalid-file-name',
+              message: t('documentPanel.uploadDocuments.fileUploader.invalidFileName',
+                { fallback: 'Invalid file name' })
+            };
+          }
+
+          // Safely extract file extension
           const fileExt = `.${file.name.split('.').pop()?.toLowerCase() || ''}`;
+
+          // Ensure accept object exists and has correct format
           const isAccepted = Object.entries(accept || {}).some(([mimeType, extensions]) => {
-            return file.type === mimeType || extensions.includes(fileExt);
+            // Ensure extensions is an array before calling includes
+            return file.type === mimeType || (Array.isArray(extensions) && extensions.includes(fileExt));
           });
 
           if (!isAccepted) {

lightrag_webui/src/features/DocumentManager.tsx

@@ -137,6 +137,26 @@ type SortField = 'created_at' | 'updated_at' | 'id';
 type SortDirection = 'asc' | 'desc';
 
 export default function DocumentManager() {
+  // Track component mount status
+  const isMountedRef = useRef(true);
+
+  // Set up mount/unmount status tracking
+  useEffect(() => {
+    isMountedRef.current = true;
+
+    // Handle page reload/unload
+    const handleBeforeUnload = () => {
+      isMountedRef.current = false;
+    };
+
+    window.addEventListener('beforeunload', handleBeforeUnload);
+
+    return () => {
+      isMountedRef.current = false;
+      window.removeEventListener('beforeunload', handleBeforeUnload);
+    };
+  }, []);
+
   const [showPipelineStatus, setShowPipelineStatus] = useState(false)
   const { t } = useTranslation()
   const health = useBackendState.use.health()
@@ -324,7 +344,13 @@ export default function DocumentManager() {
 
   const fetchDocuments = useCallback(async () => {
     try {
-      const docs = await getDocuments()
+      // Check if component is still mounted before starting the request
+      if (!isMountedRef.current) return;
+
+      const docs = await getDocuments();
+
+      // Check again if component is still mounted after the request completes
+      if (!isMountedRef.current) return;
 
       // Get new status counts (treat null as all zeros)
       const newStatusCounts = {
@@ -339,30 +365,36 @@ export default function DocumentManager() {
         status => newStatusCounts[status] !== prevStatusCounts.current[status]
       )
 
-      // Trigger health check if changes detected
-      if (hasStatusCountChange) {
+      // Trigger health check if changes detected and component is still mounted
+      if (hasStatusCountChange && isMountedRef.current) {
         useBackendState.getState().check()
       }
 
-      // Update previous status counts
-      prevStatusCounts.current = newStatusCounts
-
-      // Update docs state
-      if (docs && docs.statuses) {
-        const numDocuments = Object.values(docs.statuses).reduce(
-          (acc, status) => acc + status.length,
-          0
-        )
-        if (numDocuments > 0) {
-          setDocs(docs)
+      // Only update state if component is still mounted
+      if (isMountedRef.current) {
+        // Update previous status counts
+        prevStatusCounts.current = newStatusCounts
+
+        // Update docs state
+        if (docs && docs.statuses) {
+          const numDocuments = Object.values(docs.statuses).reduce(
+            (acc, status) => acc + status.length,
+            0
+          )
+          if (numDocuments > 0) {
+            setDocs(docs)
+          } else {
+            setDocs(null)
+          }
         } else {
           setDocs(null)
         }
-      } else {
-        setDocs(null)
       }
     } catch (err) {
-      toast.error(t('documentPanel.documentManager.errors.loadFailed', { error: errorMessage(err) }))
+      // Only show error if component is still mounted
+      if (isMountedRef.current) {
+        toast.error(t('documentPanel.documentManager.errors.loadFailed', { error: errorMessage(err) }))
+      }
     }
   }, [setDocs, t])
 
@@ -375,10 +407,20 @@ export default function DocumentManager() {
 
   const scanDocuments = useCallback(async () => {
     try {
-      const { status } = await scanNewDocuments()
-      toast.message(status)
+      // Check if component is still mounted before starting the request
+      if (!isMountedRef.current) return;
+
+      const { status } = await scanNewDocuments();
+
+      // Check again if component is still mounted after the request completes
+      if (!isMountedRef.current) return;
+
+      toast.message(status);
     } catch (err) {
-      toast.error(t('documentPanel.documentManager.errors.scanFailed', { error: errorMessage(err) }))
+      // Only show error if component is still mounted
+      if (isMountedRef.current) {
+        toast.error(t('documentPanel.documentManager.errors.scanFailed', { error: errorMessage(err) }));
+      }
     }
   }, [t])
 
@@ -390,13 +432,21 @@ export default function DocumentManager() {
 
     const interval = setInterval(async () => {
       try {
-        await fetchDocuments()
+        // Only perform fetch if component is still mounted
+        if (isMountedRef.current) {
+          await fetchDocuments()
+        }
       } catch (err) {
-        toast.error(t('documentPanel.documentManager.errors.scanProgressFailed', { error: errorMessage(err) }))
+        // Only show error if component is still mounted
+        if (isMountedRef.current) {
+          toast.error(t('documentPanel.documentManager.errors.scanProgressFailed', { error: errorMessage(err) }))
+        }
       }
     }, 5000)
 
-    return () => clearInterval(interval)
+    return () => {
+      clearInterval(interval)
+    }
   }, [health, fetchDocuments, t, currentTab])
 
   // Add dependency on sort state to re-render when sort changes