Bug 26926 - Omnibus: Update all occurrences of <input type="number"> to apply ACC2 coding guideline
Summary: Omnibus: Update all occurrences of <input type="number"> to apply ACC2 coding...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Eden
QA Contact: Testopia
URL: https://wiki.koha-community.org/wiki/...
Keywords: Academy, accessibility, rel_21_05_candidate
Depends on: 27290 27404 27405 27406 27407 27408 27409 27410 27411 27412 28134 28135
Blocks: 23003
  Show dependency treegraph
 
Reported: 2020-11-04 15:55 UTC by Martin Renvoize
Modified: 2021-04-14 13:51 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2020-11-04 15:55:53 UTC
Retroactively apply ACC2 coding guideline

We need to update all `input type="number"` occurrences to use `<input type="text" inputmode="numeric" pattern="[0-9]*">` as per the new accessibility guideline.
Comment 1 Katrin Fischer 2021-01-11 22:12:35 UTC
This bug split into multiple might make a good Academy task?
Comment 2 Martin Renvoize 2021-01-12 10:27:03 UTC
(In reply to Katrin Fischer from comment #1)
> This bug split into multiple might make a good Academy task?

Done
Comment 4 David Nind 2021-02-20 23:14:59 UTC
Owen Leonard updated Bug 27408 and Bug 27410 for currency strings, and I've updated Bug 27405:

- inputmode changed to "decimal"
- regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt

"The regex validating the modified field doesn't allow for currency-formatted values like "1.00" because of the dot."
Comment 5 Henry Bolshaw 2021-04-12 09:48:12 UTC
I think all of these occurrences have been fixed now. Is that correct?
Comment 6 Owen Leonard 2021-04-12 11:39:49 UTC
(In reply to Henry Bolshaw from comment #5)
> I think all of these occurrences have been fixed now. Is that correct?

I think Bug 28134 and 28135 are the last.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926
bugs.koha-community.org
crawl=CC-MAIN-2021-17
35793
application/http; msgtype=response
sha1:QUBTBSCZPJFYQDXL3GAZX3QQG5MKEFOH
<urn:uuid:7552dc1f-d585-4a12-9237-2905be881ecd>
2021-04-14T20:58:39Z
72.14.190.217
text/html
sha1:C3VVCFH4JPVXX5NP3ADCN5AFYF6WI4PV
<urn:uuid:8e8b6366-c4da-4840-afe8-8a3a7a806d4b>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926
response
<urn:uuid:0af67ae3-94c8-4a2b-9459-352efdca975d>
isPartOf: CC-MAIN-2021-17
publisher: Common Crawl
description: Wide crawl of the web for April 2021
operator: Common Crawl Admin (info@commoncrawl.org)
hostname: ip-10-67-67-40.ec2.internal
software: Apache Nutch 1.18 (modified, https://github.com/commoncrawl/nutch/)
robots: checked via crawler-commons 1.2-SNAPSHOT (https://github.com/crawler-commons/crawler-commons)
format: WARC File Format 1.1
conformsTo: https://iipc.github.io/warc-specifications/specifications/warc-format/warc-1.1/