Add desc parameter to Dataset filter method
COLLABORATOR
Hi,

`Dataset.map` allows more generic transforms compared to `Dataset.filter`, which purpose is very specific (to filter examples based on a condition). That's why I don't think we need the `desc` parameter there for consistency. #3196 has added descriptions to the  `Dataset` methods that call `.map` internally, but not for the `filter` method, so we should do that.

Do you have a description in mind? Maybe `"Filtering the dataset"` or `"Filtering the indices"`? If yes, feel free to open a PR.
2021-11-24T13:01:06Z
https://github.com/huggingface/datasets/issues/3317#issuecomment-977856384
https://api.github.com/repos/huggingface/datasets/issues/3317
IC_kwDODunzps46SOeA
https://api.github.com/repos/huggingface/datasets/issues/comments/977856384/reactions
2021-11-24T13:01:06Z
https://api.github.com/repos/huggingface/datasets/issues/comments/977856384
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
MEMBER
I'm personally ok with adding the `desc` parameter actually. Let's say you have different filters, it can be nice to differentiate between the different filters when they're running no ?
2021-11-25T16:59:00Z
https://github.com/huggingface/datasets/issues/3317#issuecomment-979360579
https://api.github.com/repos/huggingface/datasets/issues/3317
IC_kwDODunzps46X9tD
https://api.github.com/repos/huggingface/datasets/issues/comments/979360579/reactions
2021-11-25T16:59:00Z
https://api.github.com/repos/huggingface/datasets/issues/comments/979360579
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
@mariosasko the use case is filtering of a dataset prior to tokenization and subsequent training. As the dataset is huge it's just a matter of giving a user (model trainer) some feedback on what's going on. Otherwise, feedback is given for all steps in training preparation and not for filtering and the filtering in my use case lasts about 4-5 minutes. And yes, if there are more filtering stages, as @lhoestq pointed out, it would be nice to give some feedback. I thought desc is there already and got confused when I got the script error. 
2021-11-25T17:16:00Z
https://github.com/huggingface/datasets/issues/3317#issuecomment-979369504
https://api.github.com/repos/huggingface/datasets/issues/3317
IC_kwDODunzps46X_4g
https://api.github.com/repos/huggingface/datasets/issues/comments/979369504/reactions
2021-11-25T17:24:56Z
https://api.github.com/repos/huggingface/datasets/issues/comments/979369504
https://avatars.githubusercontent.com/u/458335?v=4
https://api.github.com/users/vblagoje/events{/privacy}
https://api.github.com/users/vblagoje/followers
https://api.github.com/users/vblagoje/following{/other_user}
https://api.github.com/users/vblagoje/gists{/gist_id}
https://github.com/vblagoje
vblagoje
MDQ6VXNlcjQ1ODMzNQ==
https://api.github.com/users/vblagoje/orgs
https://api.github.com/users/vblagoje/received_events
https://api.github.com/users/vblagoje/repos
https://api.github.com/users/vblagoje/starred{/owner}{/repo}
https://api.github.com/users/vblagoje/subscriptions
User
https://api.github.com/users/vblagoje
public
COLLABORATOR
I don't have a strong opinion on that, so having `desc` as a parameter is also OK.
2021-11-25T17:31:39Z
https://github.com/huggingface/datasets/issues/3317#issuecomment-979377231
https://api.github.com/repos/huggingface/datasets/issues/3317
IC_kwDODunzps46YBxP
https://api.github.com/repos/huggingface/datasets/issues/comments/979377231/reactions
2021-11-25T17:31:39Z
https://api.github.com/repos/huggingface/datasets/issues/comments/979377231
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
**Is your feature request related to a problem? Please describe.**
As I was filtering very large datasets I noticed the filter method doesn't have the desc parameter which is available in the map method. Why don't we add a desc parameter to the filter method both for consistency and it's nice to give some feedback to users during long operations on Datasets?

**Describe the solution you'd like**
Add desc parameter to Dataset filter method

**Describe alternatives you've considered**
N/A

**Additional context**
N/A
