Some functions use a param named `type` shouldn't that be avoided since it's a Python reserved name?
COLLABORATOR
Hi! Let's not do this - renaming it would be a breaking change, and going through the deprecation cycle is only worth it if it improves user experience.
2023-02-08T15:53:59Z
https://github.com/huggingface/datasets/issues/5513#issuecomment-1422842711
https://api.github.com/repos/huggingface/datasets/issues/5513
IC_kwDODunzps5UzttX
https://api.github.com/repos/huggingface/datasets/issues/comments/1422842711/reactions
2023-02-08T15:53:59Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1422842711
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
MEMBER
Hi @mariosasko, ok it makes sense. Anyway, don't you think it's worth it at some point to start a deprecation cycle e.g. `fs` in `load_from_disk`? It doesn't affect user experience but it's for sure a bad practice IMO, but's up to you 😄 Feel free to close this issue otherwise!
2023-02-08T15:58:09Z
https://github.com/huggingface/datasets/issues/5513#issuecomment-1422849341
https://api.github.com/repos/huggingface/datasets/issues/5513
IC_kwDODunzps5UzvU9
https://api.github.com/repos/huggingface/datasets/issues/comments/1422849341/reactions
2023-02-08T16:01:07Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1422849341
https://avatars.githubusercontent.com/u/36760800?v=4
https://api.github.com/users/alvarobartt/events{/privacy}
https://api.github.com/users/alvarobartt/followers
https://api.github.com/users/alvarobartt/following{/other_user}
https://api.github.com/users/alvarobartt/gists{/gist_id}
https://github.com/alvarobartt
alvarobartt
MDQ6VXNlcjM2NzYwODAw
https://api.github.com/users/alvarobartt/orgs
https://api.github.com/users/alvarobartt/received_events
https://api.github.com/users/alvarobartt/repos
https://api.github.com/users/alvarobartt/starred{/owner}{/repo}
https://api.github.com/users/alvarobartt/subscriptions
User
https://api.github.com/users/alvarobartt
public
COLLABORATOR
I don't think deprecating a param name in this particular instance is worth the hassle, so I'm closing the issue 🙂.
2023-07-24T14:27:59Z
https://github.com/huggingface/datasets/issues/5513#issuecomment-1648025958
https://api.github.com/repos/huggingface/datasets/issues/5513
IC_kwDODunzps5iOuFm
https://api.github.com/repos/huggingface/datasets/issues/comments/1648025958/reactions
2023-07-24T14:27:59Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1648025958
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
MEMBER
Sure, makes sense @mariosasko thanks!
2023-07-24T16:02:17Z
https://github.com/huggingface/datasets/issues/5513#issuecomment-1648195005
https://api.github.com/repos/huggingface/datasets/issues/5513
IC_kwDODunzps5iPXW9
https://api.github.com/repos/huggingface/datasets/issues/comments/1648195005/reactions
2023-07-24T16:02:17Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1648195005
https://avatars.githubusercontent.com/u/36760800?v=4
https://api.github.com/users/alvarobartt/events{/privacy}
https://api.github.com/users/alvarobartt/followers
https://api.github.com/users/alvarobartt/following{/other_user}
https://api.github.com/users/alvarobartt/gists{/gist_id}
https://github.com/alvarobartt
alvarobartt
MDQ6VXNlcjM2NzYwODAw
https://api.github.com/users/alvarobartt/orgs
https://api.github.com/users/alvarobartt/received_events
https://api.github.com/users/alvarobartt/repos
https://api.github.com/users/alvarobartt/starred{/owner}{/repo}
https://api.github.com/users/alvarobartt/subscriptions
User
https://api.github.com/users/alvarobartt
public
Hi @mariosasko, @lhoestq, or whoever reads this! :)

After going through `ArrowDataset.set_format` I found out that the `type` param is actually named `type` which is a Python reserved name as you may already know, shouldn't that be renamed to `format_type` before the 3.0.0 is released?

Just wanted to get your input, and if applicable, tackle this issue myself! Thanks 🤗