Force soundfile to return float32 instead of the default float64 
MEMBER
cc @polinaeterna
2022-12-14T18:01:47Z
https://github.com/huggingface/datasets/pull/5347#issuecomment-1351869240
https://api.github.com/repos/huggingface/datasets/issues/5347
IC_kwDODunzps5Qk-M4
https://api.github.com/repos/huggingface/datasets/issues/comments/1351869240/reactions
2022-12-14T18:01:47Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1351869240
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
NONE
The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_5347). All of your documentation changes will be reflected on that endpoint.
2022-12-16T13:21:26Z
https://github.com/huggingface/datasets/pull/5347#issuecomment-1354758506
https://api.github.com/repos/huggingface/datasets/issues/5347
IC_kwDODunzps5Qv_lq
https://api.github.com/repos/huggingface/datasets/issues/comments/1354758506/reactions
2022-12-16T13:21:26Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1354758506
https://avatars.githubusercontent.com/u/99929124?v=4
https://api.github.com/users/HuggingFaceDocBuilderDev/events{/privacy}
https://api.github.com/users/HuggingFaceDocBuilderDev/followers
https://api.github.com/users/HuggingFaceDocBuilderDev/following{/other_user}
https://api.github.com/users/HuggingFaceDocBuilderDev/gists{/gist_id}
https://github.com/HuggingFaceDocBuilderDev
HuggingFaceDocBuilderDev
U_kgDOBfTMJA
https://api.github.com/users/HuggingFaceDocBuilderDev/orgs
https://api.github.com/users/HuggingFaceDocBuilderDev/received_events
https://api.github.com/users/HuggingFaceDocBuilderDev/repos
https://api.github.com/users/HuggingFaceDocBuilderDev/starred{/owner}{/repo}
https://api.github.com/users/HuggingFaceDocBuilderDev/subscriptions
User
https://api.github.com/users/HuggingFaceDocBuilderDev
public
MEMBER
Cool ! Feel free to add a comment in the code to explain that and we can merge :)
2022-12-19T10:07:20Z
https://github.com/huggingface/datasets/pull/5347#issuecomment-1357398374
https://api.github.com/repos/huggingface/datasets/issues/5347
IC_kwDODunzps5Q6EFm
https://api.github.com/repos/huggingface/datasets/issues/comments/1357398374/reactions
2022-12-19T10:07:20Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1357398374
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
COLLABORATOR
I'm not sure if this is a good change since we plan to get rid of `torchaudio` in the next couple of months...
2023-01-13T16:04:46Z
https://github.com/huggingface/datasets/pull/5347#issuecomment-1382060706
https://api.github.com/repos/huggingface/datasets/issues/5347
IC_kwDODunzps5SYJKi
https://api.github.com/repos/huggingface/datasets/issues/comments/1382060706/reactions
2023-01-13T16:04:46Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1382060706
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
MEMBER
What do you think @polinaeterna @patrickvonplaten ? Models are usually using float32 (e.g. Wev2vec2 in `transformers`) IIRC
2023-01-13T16:21:40Z
https://github.com/huggingface/datasets/pull/5347#issuecomment-1382080136
https://api.github.com/repos/huggingface/datasets/issues/5347
IC_kwDODunzps5SYN6I
https://api.github.com/repos/huggingface/datasets/issues/comments/1382080136/reactions
2023-01-13T16:21:40Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1382080136
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
IMO we can safely assume that float32 is always good enough when using audio models in inference or training. Nevertheless there might be use cases for audio datasets in the future where float64 is needed. 

=> I would by default always cast to float32, but then possible allow the user to cast to float64 
2023-01-16T10:11:13Z
https://github.com/huggingface/datasets/pull/5347#issuecomment-1383801849
https://api.github.com/repos/huggingface/datasets/issues/5347
IC_kwDODunzps5SeyP5
https://api.github.com/repos/huggingface/datasets/issues/comments/1383801849/reactions
2023-01-16T10:11:13Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1383801849
https://avatars.githubusercontent.com/u/23423619?v=4
https://api.github.com/users/patrickvonplaten/events{/privacy}
https://api.github.com/users/patrickvonplaten/followers
https://api.github.com/users/patrickvonplaten/following{/other_user}
https://api.github.com/users/patrickvonplaten/gists{/gist_id}
https://github.com/patrickvonplaten
patrickvonplaten
MDQ6VXNlcjIzNDIzNjE5
https://api.github.com/users/patrickvonplaten/orgs
https://api.github.com/users/patrickvonplaten/received_events
https://api.github.com/users/patrickvonplaten/repos
https://api.github.com/users/patrickvonplaten/starred{/owner}{/repo}
https://api.github.com/users/patrickvonplaten/subscriptions
User
https://api.github.com/users/patrickvonplaten
public
CONTRIBUTOR
> I'm not sure if this is a good change since we plan to get rid of torchaudio in the next couple of months...

@mariosasko I agree but who knows how long we will have to wait until we are really able to do so (https://github.com/bastibe/libsndfile-binaries/pull/17 is a draft. so as @patrickvonplaten is okay with float32, I'd merge.



2023-01-16T16:03:58Z
https://github.com/huggingface/datasets/pull/5347#issuecomment-1384254740
https://api.github.com/repos/huggingface/datasets/issues/5347
IC_kwDODunzps5Sgg0U
https://api.github.com/repos/huggingface/datasets/issues/comments/1384254740/reactions
2023-01-16T16:04:12Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1384254740
https://avatars.githubusercontent.com/u/16348744?v=4
https://api.github.com/users/polinaeterna/events{/privacy}
https://api.github.com/users/polinaeterna/followers
https://api.github.com/users/polinaeterna/following{/other_user}
https://api.github.com/users/polinaeterna/gists{/gist_id}
https://github.com/polinaeterna
polinaeterna
MDQ6VXNlcjE2MzQ4NzQ0
https://api.github.com/users/polinaeterna/orgs
https://api.github.com/users/polinaeterna/received_events
https://api.github.com/users/polinaeterna/repos
https://api.github.com/users/polinaeterna/starred{/owner}{/repo}
https://api.github.com/users/polinaeterna/subscriptions
User
https://api.github.com/users/polinaeterna
public
COLLABORATOR
@polinaeterna Can you comment on the linked PR to see why it's still a draft? Maybe we can help somehow to get this merged finally.

I think it's weird to align `soundfile` with `torchaudio` when the latter is only used for MP3 (and prob for not much longer). 
2023-01-17T16:12:49Z
https://github.com/huggingface/datasets/pull/5347#issuecomment-1385668250
https://api.github.com/repos/huggingface/datasets/issues/5347
IC_kwDODunzps5Sl56a
https://api.github.com/repos/huggingface/datasets/issues/comments/1385668250/reactions
2023-01-17T16:12:49Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1385668250
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
(Fixes issue #5345)