Add LER
CONTRIBUTOR
Thanks for the comments. I addressed them and pushed again.
When I run "make quality" I get the following error but I don't know how to resolve it or what the problem ist respectively:
would reformat /Users/joelniklaus/NextCloud/PhDJoelNiklaus/Code/datasets/datasets/ler/ler.py
Oh no! 💥 💔 💥
1 file would be reformatted, 257 files would be left unchanged.
make: *** [quality] Error 1

2020-11-27T12:44:01Z
https://github.com/huggingface/datasets/pull/890#issuecomment-734818042
https://api.github.com/repos/huggingface/datasets/issues/890
MDEyOklzc3VlQ29tbWVudDczNDgxODA0Mg==
https://api.github.com/repos/huggingface/datasets/issues/comments/734818042/reactions
2020-11-27T12:47:07Z
https://api.github.com/repos/huggingface/datasets/issues/comments/734818042
https://avatars.githubusercontent.com/u/3775944?v=4
https://api.github.com/users/JoelNiklaus/events{/privacy}
https://api.github.com/users/JoelNiklaus/followers
https://api.github.com/users/JoelNiklaus/following{/other_user}
https://api.github.com/users/JoelNiklaus/gists{/gist_id}
https://github.com/JoelNiklaus
JoelNiklaus
MDQ6VXNlcjM3NzU5NDQ=
https://api.github.com/users/JoelNiklaus/orgs
https://api.github.com/users/JoelNiklaus/received_events
https://api.github.com/users/JoelNiklaus/repos
https://api.github.com/users/JoelNiklaus/starred{/owner}{/repo}
https://api.github.com/users/JoelNiklaus/subscriptions
User
https://api.github.com/users/JoelNiklaus
public
MEMBER
Awesome thanks :)
To automatically format the python files you can run `make style`
2020-11-27T13:28:47Z
https://github.com/huggingface/datasets/pull/890#issuecomment-734835368
https://api.github.com/repos/huggingface/datasets/issues/890
MDEyOklzc3VlQ29tbWVudDczNDgzNTM2OA==
https://api.github.com/repos/huggingface/datasets/issues/comments/734835368/reactions
2020-11-27T13:28:47Z
https://api.github.com/repos/huggingface/datasets/issues/comments/734835368
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
I did that now. But still getting the following error:
black --check --line-length 119 --target-version py36 tests src benchmarks datasets metrics
All done! ✨ 🍰 ✨
258 files would be left unchanged.
isort --check-only tests src benchmarks datasets metrics
flake8 tests src benchmarks datasets metrics
datasets/ler/ler.py:46:96: W291 trailing whitespace
datasets/ler/ler.py:47:68: W291 trailing whitespace
datasets/ler/ler.py:48:102: W291 trailing whitespace
datasets/ler/ler.py:49:112: W291 trailing whitespace
datasets/ler/ler.py:50:92: W291 trailing whitespace
datasets/ler/ler.py:51:116: W291 trailing whitespace
datasets/ler/ler.py:52:84: W291 trailing whitespace
make: *** [quality] Error 1

However: When I look at the file I don't see any trailing whitespace
2020-11-27T14:19:47Z
https://github.com/huggingface/datasets/pull/890#issuecomment-734857139
https://api.github.com/repos/huggingface/datasets/issues/890
MDEyOklzc3VlQ29tbWVudDczNDg1NzEzOQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/734857139/reactions
2020-11-27T14:19:47Z
https://api.github.com/repos/huggingface/datasets/issues/comments/734857139
https://avatars.githubusercontent.com/u/3775944?v=4
https://api.github.com/users/JoelNiklaus/events{/privacy}
https://api.github.com/users/JoelNiklaus/followers
https://api.github.com/users/JoelNiklaus/following{/other_user}
https://api.github.com/users/JoelNiklaus/gists{/gist_id}
https://github.com/JoelNiklaus
JoelNiklaus
MDQ6VXNlcjM3NzU5NDQ=
https://api.github.com/users/JoelNiklaus/orgs
https://api.github.com/users/JoelNiklaus/received_events
https://api.github.com/users/JoelNiklaus/repos
https://api.github.com/users/JoelNiklaus/starred{/owner}{/repo}
https://api.github.com/users/JoelNiklaus/subscriptions
User
https://api.github.com/users/JoelNiklaus
public
MEMBER
maybe a bug with flake8 ? could you try to update it ? which version do you have ?
2020-11-27T14:51:28Z
https://github.com/huggingface/datasets/pull/890#issuecomment-734871252
https://api.github.com/repos/huggingface/datasets/issues/890
MDEyOklzc3VlQ29tbWVudDczNDg3MTI1Mg==
https://api.github.com/repos/huggingface/datasets/issues/comments/734871252/reactions
2020-11-27T14:51:28Z
https://api.github.com/repos/huggingface/datasets/issues/comments/734871252
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
This is my flake8 version: 3.7.9 (mccabe: 0.6.1, pycodestyle: 2.5.0, pyflakes: 2.1.1) CPython 3.8.5 on Darwin

2020-11-28T00:11:54Z
https://github.com/huggingface/datasets/pull/890#issuecomment-735015657
https://api.github.com/repos/huggingface/datasets/issues/890
MDEyOklzc3VlQ29tbWVudDczNTAxNTY1Nw==
https://api.github.com/repos/huggingface/datasets/issues/comments/735015657/reactions
2020-11-28T00:11:54Z
https://api.github.com/repos/huggingface/datasets/issues/comments/735015657
https://avatars.githubusercontent.com/u/3775944?v=4
https://api.github.com/users/JoelNiklaus/events{/privacy}
https://api.github.com/users/JoelNiklaus/followers
https://api.github.com/users/JoelNiklaus/following{/other_user}
https://api.github.com/users/JoelNiklaus/gists{/gist_id}
https://github.com/JoelNiklaus
JoelNiklaus
MDQ6VXNlcjM3NzU5NDQ=
https://api.github.com/users/JoelNiklaus/orgs
https://api.github.com/users/JoelNiklaus/received_events
https://api.github.com/users/JoelNiklaus/repos
https://api.github.com/users/JoelNiklaus/starred{/owner}{/repo}
https://api.github.com/users/JoelNiklaus/subscriptions
User
https://api.github.com/users/JoelNiklaus
public
CONTRIBUTOR
Now I updated to: 3.8.4 (mccabe: 0.6.1, pycodestyle: 2.6.0, pyflakes: 2.2.0) CPython 3.8.5 on Darwin

And now I even get additional errors:
black --check --line-length 119 --target-version py36 tests src benchmarks datasets metrics
All done! ✨ 🍰 ✨
258 files would be left unchanged.
isort --check-only tests src benchmarks datasets metrics
flake8 tests src benchmarks datasets metrics
datasets/polyglot_ner/polyglot_ner.py:123:64: F541 f-string is missing placeholders
datasets/ler/ler.py:46:96: W291 trailing whitespace
datasets/ler/ler.py:47:68: W291 trailing whitespace
datasets/ler/ler.py:48:102: W291 trailing whitespace
datasets/ler/ler.py:49:112: W291 trailing whitespace
datasets/ler/ler.py:50:92: W291 trailing whitespace
datasets/ler/ler.py:51:116: W291 trailing whitespace
datasets/ler/ler.py:52:84: W291 trailing whitespace
datasets/math_dataset/math_dataset.py:233:25: E741 ambiguous variable name 'l'
metrics/coval/coval.py:236:31: F541 f-string is missing placeholders
make: *** [quality] Error 1

I do this on macOS Catalina 10.15.7 in case this matters
2020-11-28T00:14:42Z
https://github.com/huggingface/datasets/pull/890#issuecomment-735015944
https://api.github.com/repos/huggingface/datasets/issues/890
MDEyOklzc3VlQ29tbWVudDczNTAxNTk0NA==
https://api.github.com/repos/huggingface/datasets/issues/comments/735015944/reactions
2020-11-28T00:15:50Z
https://api.github.com/repos/huggingface/datasets/issues/comments/735015944
https://avatars.githubusercontent.com/u/3775944?v=4
https://api.github.com/users/JoelNiklaus/events{/privacy}
https://api.github.com/users/JoelNiklaus/followers
https://api.github.com/users/JoelNiklaus/following{/other_user}
https://api.github.com/users/JoelNiklaus/gists{/gist_id}
https://github.com/JoelNiklaus
JoelNiklaus
MDQ6VXNlcjM3NzU5NDQ=
https://api.github.com/users/JoelNiklaus/orgs
https://api.github.com/users/JoelNiklaus/received_events
https://api.github.com/users/JoelNiklaus/repos
https://api.github.com/users/JoelNiklaus/starred{/owner}{/repo}
https://api.github.com/users/JoelNiklaus/subscriptions
User
https://api.github.com/users/JoelNiklaus
public
MEMBER
Code quality test now passes, thanks :) 

To fix the other tests failing I think you can just rebase from master.
Also make sure that the dummy data test passes with
```python
RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_ler
```
2020-11-30T13:27:07Z
https://github.com/huggingface/datasets/pull/890#issuecomment-735784713
https://api.github.com/repos/huggingface/datasets/issues/890
MDEyOklzc3VlQ29tbWVudDczNTc4NDcxMw==
https://api.github.com/repos/huggingface/datasets/issues/comments/735784713/reactions
2020-11-30T13:27:16Z
https://api.github.com/repos/huggingface/datasets/issues/comments/735784713
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
I will close this PR because abishek did the same better (https://github.com/huggingface/datasets/pull/944)
2020-12-01T13:26:16Z
https://github.com/huggingface/datasets/pull/890#issuecomment-736550076
https://api.github.com/repos/huggingface/datasets/issues/890
MDEyOklzc3VlQ29tbWVudDczNjU1MDA3Ng==
https://api.github.com/repos/huggingface/datasets/issues/comments/736550076/reactions
2020-12-01T13:26:16Z
https://api.github.com/repos/huggingface/datasets/issues/comments/736550076
https://avatars.githubusercontent.com/u/3775944?v=4
https://api.github.com/users/JoelNiklaus/events{/privacy}
https://api.github.com/users/JoelNiklaus/followers
https://api.github.com/users/JoelNiklaus/following{/other_user}
https://api.github.com/users/JoelNiklaus/gists{/gist_id}
https://github.com/JoelNiklaus
JoelNiklaus
MDQ6VXNlcjM3NzU5NDQ=
https://api.github.com/users/JoelNiklaus/orgs
https://api.github.com/users/JoelNiklaus/received_events
https://api.github.com/users/JoelNiklaus/repos
https://api.github.com/users/JoelNiklaus/starred{/owner}{/repo}
https://api.github.com/users/JoelNiklaus/subscriptions
User
https://api.github.com/users/JoelNiklaus
public
MEMBER
Sorry you had to close your PR ! It looks like this week's sprint doesn't always make it easy to see what's being added/what's already added. 
Thank you for contributing to the library. You did a great job on adding LER so feel free to add other ones that you would like to see in the library, it will be a pleasure to review
2020-12-01T13:33:35Z
https://github.com/huggingface/datasets/pull/890#issuecomment-736554023
https://api.github.com/repos/huggingface/datasets/issues/890
MDEyOklzc3VlQ29tbWVudDczNjU1NDAyMw==
https://api.github.com/repos/huggingface/datasets/issues/comments/736554023/reactions
2020-12-01T13:33:35Z
https://api.github.com/repos/huggingface/datasets/issues/comments/736554023
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public