PR for the CFPB Consumer Complaints dataset
CONTRIBUTOR
> Nice ! Thanks for adding this dataset :)
> 
> 
> 
> I left a few comments:

Thanks!

I'd be interested in contributing to the core codebase - I had to go down the custom loading approach because I couldn't pull this dataset in using the load_dataset() method. Using either the json or csv files available for this dataset as it was erroring. 

I'll rerun it and share the errors and try debug
2022-01-25T09:44:22Z
https://github.com/huggingface/datasets/pull/3617#issuecomment-1020994392
https://api.github.com/repos/huggingface/datasets/issues/3617
IC_kwDODunzps482yNY
https://api.github.com/repos/huggingface/datasets/issues/comments/1020994392/reactions
2022-01-25T09:44:22Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1020994392
https://avatars.githubusercontent.com/u/42403093?v=4
https://api.github.com/users/kayvane1/events{/privacy}
https://api.github.com/users/kayvane1/followers
https://api.github.com/users/kayvane1/following{/other_user}
https://api.github.com/users/kayvane1/gists{/gist_id}
https://github.com/kayvane1
kayvane1
MDQ6VXNlcjQyNDAzMDkz
https://api.github.com/users/kayvane1/orgs
https://api.github.com/users/kayvane1/received_events
https://api.github.com/users/kayvane1/repos
https://api.github.com/users/kayvane1/starred{/owner}{/repo}
https://api.github.com/users/kayvane1/subscriptions
User
https://api.github.com/users/kayvane1
public
CONTRIBUTOR
Hey @lhoestq ,

When I use this dataset as part of my project, I'm using this method

`text_dataset = text_dataset['train'].train_test_split(test_size=0.2)`

to create a train and test split as this dataset doesn't have one. 

Can I add this directly in the script itself somehow, or is it better to give users the flexibility to slice and split their datasets after loading?
2022-01-29T12:22:55Z
https://github.com/huggingface/datasets/pull/3617#issuecomment-1024901735
https://api.github.com/repos/huggingface/datasets/issues/3617
IC_kwDODunzps49FsJn
https://api.github.com/repos/huggingface/datasets/issues/comments/1024901735/reactions
2022-01-29T12:22:55Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1024901735
https://avatars.githubusercontent.com/u/42403093?v=4
https://api.github.com/users/kayvane1/events{/privacy}
https://api.github.com/users/kayvane1/followers
https://api.github.com/users/kayvane1/following{/other_user}
https://api.github.com/users/kayvane1/gists{/gist_id}
https://github.com/kayvane1
kayvane1
MDQ6VXNlcjQyNDAzMDkz
https://api.github.com/users/kayvane1/orgs
https://api.github.com/users/kayvane1/received_events
https://api.github.com/users/kayvane1/repos
https://api.github.com/users/kayvane1/starred{/owner}{/repo}
https://api.github.com/users/kayvane1/subscriptions
User
https://api.github.com/users/kayvane1
public
MEMBER
> I'd be interested in contributing to the core codebase - I had to go down the custom loading approach because I couldn't pull this dataset in using the load_dataset() method. Using either the json or csv files available for this dataset as it was erroring.
>
> I'll rerun it and share the errors and try debug

Cool ! Let me know if you have questions or if I can help :)

> Can I add this directly in the script itself somehow, or is it better to give users the flexibility to slice and split their datasets after loading?

Usually we let the users the flexibility to split the datasets themselves (unless the dataset is already split, or if there is already a standard way to split it in the papers that use it)
2022-01-31T09:48:09Z
https://github.com/huggingface/datasets/pull/3617#issuecomment-1025551897
https://api.github.com/repos/huggingface/datasets/issues/3617
IC_kwDODunzps49IK4Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1025551897/reactions
2022-01-31T09:48:09Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1025551897
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
Thanks Quentin!
All okay to merge now?
2022-01-31T12:06:55Z
https://github.com/huggingface/datasets/pull/3617#issuecomment-1025670665
https://api.github.com/repos/huggingface/datasets/issues/3617
IC_kwDODunzps49In4J
https://api.github.com/repos/huggingface/datasets/issues/comments/1025670665/reactions
2022-01-31T12:06:55Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1025670665
https://avatars.githubusercontent.com/u/42403093?v=4
https://api.github.com/users/kayvane1/events{/privacy}
https://api.github.com/users/kayvane1/followers
https://api.github.com/users/kayvane1/following{/other_user}
https://api.github.com/users/kayvane1/gists{/gist_id}
https://github.com/kayvane1
kayvane1
MDQ6VXNlcjQyNDAzMDkz
https://api.github.com/users/kayvane1/orgs
https://api.github.com/users/kayvane1/received_events
https://api.github.com/users/kayvane1/repos
https://api.github.com/users/kayvane1/starred{/owner}{/repo}
https://api.github.com/users/kayvane1/subscriptions
User
https://api.github.com/users/kayvane1
public
CONTRIBUTOR
Thanks for the feedback Quentin and Mario - implemented all changes  :)
![Screenshot 2022-01-31 at 23 11 20](https://user-images.githubusercontent.com/42403093/151889262-30737feb-ac9c-4c5a-9326-9812db1d05bc.png)

2022-01-31T23:22:23Z
https://github.com/huggingface/datasets/pull/3617#issuecomment-1026310238
https://api.github.com/repos/huggingface/datasets/issues/3617
IC_kwDODunzps49LEBe
https://api.github.com/repos/huggingface/datasets/issues/comments/1026310238/reactions
2022-01-31T23:22:23Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1026310238
https://avatars.githubusercontent.com/u/42403093?v=4
https://api.github.com/users/kayvane1/events{/privacy}
https://api.github.com/users/kayvane1/followers
https://api.github.com/users/kayvane1/following{/other_user}
https://api.github.com/users/kayvane1/gists{/gist_id}
https://github.com/kayvane1
kayvane1
MDQ6VXNlcjQyNDAzMDkz
https://api.github.com/users/kayvane1/orgs
https://api.github.com/users/kayvane1/received_events
https://api.github.com/users/kayvane1/repos
https://api.github.com/users/kayvane1/starred{/owner}{/repo}
https://api.github.com/users/kayvane1/subscriptions
User
https://api.github.com/users/kayvane1
public
CONTRIBUTOR
Hey @lhoestq  / @mariosasko 
Any other changes required to merge? 🤗
2022-02-06T10:02:58Z
https://github.com/huggingface/datasets/pull/3617#issuecomment-1030799407
https://api.github.com/repos/huggingface/datasets/issues/3617
IC_kwDODunzps49cMAv
https://api.github.com/repos/huggingface/datasets/issues/comments/1030799407/reactions
2022-02-06T10:02:58Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1030799407
https://avatars.githubusercontent.com/u/42403093?v=4
https://api.github.com/users/kayvane1/events{/privacy}
https://api.github.com/users/kayvane1/followers
https://api.github.com/users/kayvane1/following{/other_user}
https://api.github.com/users/kayvane1/gists{/gist_id}
https://github.com/kayvane1
kayvane1
MDQ6VXNlcjQyNDAzMDkz
https://api.github.com/users/kayvane1/orgs
https://api.github.com/users/kayvane1/received_events
https://api.github.com/users/kayvane1/repos
https://api.github.com/users/kayvane1/starred{/owner}{/repo}
https://api.github.com/users/kayvane1/subscriptions
User
https://api.github.com/users/kayvane1
public
MEMBER
Hi ! Thanks and sorry for the late response 

It looks very good ! The CI is still failing because it can't file the dummy_data.zip file, you can fix that by moving `datasets/consumer-finance-complaints/dummy/1.0.0/dummy_data.zip` to `datasets/consumer-finance-complaints/dummy/0.0.0/dummy_data.zip` and it should be all good !
2022-02-07T16:49:07Z
https://github.com/huggingface/datasets/pull/3617#issuecomment-1031685241
https://api.github.com/repos/huggingface/datasets/issues/3617
IC_kwDODunzps49fkR5
https://api.github.com/repos/huggingface/datasets/issues/comments/1031685241/reactions
2022-02-07T16:49:07Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1031685241
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
@lhoestq - hopefully that should do it!

2022-02-07T16:55:25Z
https://github.com/huggingface/datasets/pull/3617#issuecomment-1031691652
https://api.github.com/repos/huggingface/datasets/issues/3617
IC_kwDODunzps49fl2E
https://api.github.com/repos/huggingface/datasets/issues/comments/1031691652/reactions
2022-02-07T16:55:25Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1031691652
https://avatars.githubusercontent.com/u/42403093?v=4
https://api.github.com/users/kayvane1/events{/privacy}
https://api.github.com/users/kayvane1/followers
https://api.github.com/users/kayvane1/following{/other_user}
https://api.github.com/users/kayvane1/gists{/gist_id}
https://github.com/kayvane1
kayvane1
MDQ6VXNlcjQyNDAzMDkz
https://api.github.com/users/kayvane1/orgs
https://api.github.com/users/kayvane1/received_events
https://api.github.com/users/kayvane1/repos
https://api.github.com/users/kayvane1/starred{/owner}{/repo}
https://api.github.com/users/kayvane1/subscriptions
User
https://api.github.com/users/kayvane1
public
Think I followed all the steps but please let me know if anything needs changing or any improvements I can make to the code quality