Fix unused arguments
COLLABORATOR
@lhoestq Re-added the arg. The ConnectionError in CI seems unrelated to this PR (the same test fails on master as well).
2021-03-03T14:17:00Z
https://github.com/huggingface/datasets/pull/1962#issuecomment-789745425
https://api.github.com/repos/huggingface/datasets/issues/1962
MDEyOklzc3VlQ29tbWVudDc4OTc0NTQyNQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/789745425/reactions
2021-03-03T14:17:00Z
https://api.github.com/repos/huggingface/datasets/issues/comments/789745425
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
MEMBER
Thanks !
I'm re-running the CI, maybe this was an issue with circleCI
2021-03-03T15:39:27Z
https://github.com/huggingface/datasets/pull/1962#issuecomment-789806326
https://api.github.com/repos/huggingface/datasets/issues/1962
MDEyOklzc3VlQ29tbWVudDc4OTgwNjMyNg==
https://api.github.com/repos/huggingface/datasets/issues/comments/789806326/reactions
2021-03-03T15:39:27Z
https://api.github.com/repos/huggingface/datasets/issues/comments/789806326
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
Looks all good now, merged :)
2021-03-03T16:38:24Z
https://github.com/huggingface/datasets/pull/1962#issuecomment-789857489
https://api.github.com/repos/huggingface/datasets/issues/1962
MDEyOklzc3VlQ29tbWVudDc4OTg1NzQ4OQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/789857489/reactions
2021-03-03T16:38:24Z
https://api.github.com/repos/huggingface/datasets/issues/comments/789857489
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
Noticed some args in the codebase are not used, so managed to find all such occurrences with Pylance and fix them.