Origin/fix missing features error
NONE
_The documentation is not available anymore as the PR was closed or merged._
2022-12-01T06:23:33Z
https://github.com/huggingface/datasets/pull/5318#issuecomment-1333272180
https://api.github.com/repos/huggingface/datasets/issues/5318
IC_kwDODunzps5PeB50
https://api.github.com/repos/huggingface/datasets/issues/comments/1333272180/reactions
2022-12-04T05:52:07Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1333272180
https://avatars.githubusercontent.com/u/99929124?v=4
https://api.github.com/users/HuggingFaceDocBuilderDev/events{/privacy}
https://api.github.com/users/HuggingFaceDocBuilderDev/followers
https://api.github.com/users/HuggingFaceDocBuilderDev/following{/other_user}
https://api.github.com/users/HuggingFaceDocBuilderDev/gists{/gist_id}
https://github.com/HuggingFaceDocBuilderDev
HuggingFaceDocBuilderDev
U_kgDOBfTMJA
https://api.github.com/users/HuggingFaceDocBuilderDev/orgs
https://api.github.com/users/HuggingFaceDocBuilderDev/received_events
https://api.github.com/users/HuggingFaceDocBuilderDev/repos
https://api.github.com/users/HuggingFaceDocBuilderDev/starred{/owner}{/repo}
https://api.github.com/users/HuggingFaceDocBuilderDev/subscriptions
User
https://api.github.com/users/HuggingFaceDocBuilderDev
public
CONTRIBUTOR
please review :) @lhoestq @ola13 thankoo
2022-12-02T13:03:36Z
https://github.com/huggingface/datasets/pull/5318#issuecomment-1335199008
https://api.github.com/repos/huggingface/datasets/issues/5318
IC_kwDODunzps5PlYUg
https://api.github.com/repos/huggingface/datasets/issues/comments/1335199008/reactions
2022-12-02T13:03:36Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1335199008
https://avatars.githubusercontent.com/u/12104720?v=4
https://api.github.com/users/eunseojo/events{/privacy}
https://api.github.com/users/eunseojo/followers
https://api.github.com/users/eunseojo/following{/other_user}
https://api.github.com/users/eunseojo/gists{/gist_id}
https://github.com/eunseojo
eunseojo
MDQ6VXNlcjEyMTA0NzIw
https://api.github.com/users/eunseojo/orgs
https://api.github.com/users/eunseojo/received_events
https://api.github.com/users/eunseojo/repos
https://api.github.com/users/eunseojo/starred{/owner}{/repo}
https://api.github.com/users/eunseojo/subscriptions
User
https://api.github.com/users/eunseojo
public
MEMBER
Thanks :) I just updated the test to make sure it works even when there's a column missing, and did a minor change to json.py to add the missing columns for the other kinds of JSON files as well (I moved the code to`self._cast_table`)
2022-12-02T13:57:24Z
https://github.com/huggingface/datasets/pull/5318#issuecomment-1335266647
https://api.github.com/repos/huggingface/datasets/issues/5318
IC_kwDODunzps5Plo1X
https://api.github.com/repos/huggingface/datasets/issues/comments/1335266647/reactions
2022-12-02T13:58:16Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1335266647
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
NONE
Thanks Unso! If @lhoestq is happy then I'm also happy :D
2022-12-02T14:03:59Z
https://github.com/huggingface/datasets/pull/5318#issuecomment-1335275263
https://api.github.com/repos/huggingface/datasets/issues/5318
IC_kwDODunzps5Plq7_
https://api.github.com/repos/huggingface/datasets/issues/comments/1335275263/reactions
2022-12-02T14:03:59Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1335275263
https://avatars.githubusercontent.com/u/1528523?v=4
https://api.github.com/users/ola13/events{/privacy}
https://api.github.com/users/ola13/followers
https://api.github.com/users/ola13/following{/other_user}
https://api.github.com/users/ola13/gists{/gist_id}
https://github.com/ola13
ola13
MDQ6VXNlcjE1Mjg1MjM=
https://api.github.com/users/ola13/orgs
https://api.github.com/users/ola13/received_events
https://api.github.com/users/ola13/repos
https://api.github.com/users/ola13/starred{/owner}{/repo}
https://api.github.com/users/ola13/subscriptions
User
https://api.github.com/users/ola13
public
COLLABORATOR
When I noticed the ping, this PR had already been merged...

Luckily, PyArrow's `read_json` behaves the same when `explicit_schema` is given via `ParseOptions`, so I'm okay with this change (our JSON loader doesn't use `read_json` for decoding JSON in some scenarios, so this manual approach is the right one).

2022-12-12T19:06:41Z
https://github.com/huggingface/datasets/pull/5318#issuecomment-1347115087
https://api.github.com/repos/huggingface/datasets/issues/5318
IC_kwDODunzps5QS1hP
https://api.github.com/repos/huggingface/datasets/issues/comments/1347115087/reactions
2022-12-12T19:06:41Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1347115087
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
This fixes the problem of when the dataset_load function reads a function with "features" provided but some read batches don't have columns that later show up. For instance, the provided "features" requires columns A,B,C but only columns B,C show. This fixes this by adding the column A with nulls. 