Keys yielded while generating dataset are not being checked
MEMBER
Hi ! Indeed there's no verification on the uniqueness nor the types of the keys.
Do you already have some ideas of what you would like to implement and how ?
2021-04-16T14:27:41Z
https://github.com/huggingface/datasets/issues/2230#issuecomment-821216697
https://api.github.com/repos/huggingface/datasets/issues/2230
MDEyOklzc3VlQ29tbWVudDgyMTIxNjY5Nw==
https://api.github.com/repos/huggingface/datasets/issues/comments/821216697/reactions
2021-04-16T14:27:41Z
https://api.github.com/repos/huggingface/datasets/issues/comments/821216697
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
Hey @lhoestq, thank you so much for the opportunity.
Although I haven't had much experience with the HF Datasets code, after a careful look at how the `ArrowWriter` functions, I think we can implement this as follows:

1.  First, we would have to update the `ArrowWriter.write()` function here:
https://github.com/huggingface/datasets/blob/fcd3c3c8e3b1d9a2f3686a496082e21f06591380/src/datasets/arrow_writer.py#L296
so that it accepts an additional argument `key` which would be appended along with the example here after hashing.

2.  Then, we would need to create a `Hasher` class which will take the key as its input and return a hash for it (We might need to use some hash salt which can be passed to the ArrowWriter.writer() with value equal to the `split_name` for differentiating between same keys of different splits)

    We can use the `hashlib.md5` function for hashing which will conert each key to its byte code before hashing (depending on the data type of the key) **Thus, the `key` type will be verified here**.

3.  Now, we would have to edit this
https://github.com/huggingface/datasets/blob/fcd3c3c8e3b1d9a2f3686a496082e21f06591380/src/datasets/arrow_writer.py#L257
 so that it iterates over each `(hash, example)` pair (sorted according to hash). We can then simply **check whether each hash is different from the previous hash** (since they will be sorted)

However, since I'm not very familiar with how the data is being written on disk in the form of a table, I might need some guidance for Step 3. 
Please let me know your thought on this. Thanks!
2021-04-16T20:56:23Z
https://github.com/huggingface/datasets/issues/2230#issuecomment-821560245
https://api.github.com/repos/huggingface/datasets/issues/2230
MDEyOklzc3VlQ29tbWVudDgyMTU2MDI0NQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/821560245/reactions
2021-04-16T20:56:52Z
https://api.github.com/repos/huggingface/datasets/issues/comments/821560245
https://avatars.githubusercontent.com/u/42388668?v=4
https://api.github.com/users/NikhilBartwal/events{/privacy}
https://api.github.com/users/NikhilBartwal/followers
https://api.github.com/users/NikhilBartwal/following{/other_user}
https://api.github.com/users/NikhilBartwal/gists{/gist_id}
https://github.com/NikhilBartwal
NikhilBartwal
MDQ6VXNlcjQyMzg4NjY4
https://api.github.com/users/NikhilBartwal/orgs
https://api.github.com/users/NikhilBartwal/received_events
https://api.github.com/users/NikhilBartwal/repos
https://api.github.com/users/NikhilBartwal/starred{/owner}{/repo}
https://api.github.com/users/NikhilBartwal/subscriptions
User
https://api.github.com/users/NikhilBartwal
public
MEMBER
Interesting !
We keep the dataset sorted in the order examples are generated by the builder (we expect the dataset builders to generate examples in deterministic order). Therefore I don't think we should shuffle the examples with the hashing. Let me know what you think.
Other that that, I really like the idea of checking for keys duplicates in `write_examples_on_file` :)

This looks like a great plan ! Feel free to open a PR and ping me if you have questions or if I can help

2021-04-19T08:55:05Z
https://github.com/huggingface/datasets/issues/2230#issuecomment-822297342
https://api.github.com/repos/huggingface/datasets/issues/2230
MDEyOklzc3VlQ29tbWVudDgyMjI5NzM0Mg==
https://api.github.com/repos/huggingface/datasets/issues/comments/822297342/reactions
2021-04-19T08:55:05Z
https://api.github.com/repos/huggingface/datasets/issues/comments/822297342
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
@lhoestq I'm glad you liked the idea!
I think that since the keys will be unique and deterministic in the nature themselves, so even if we shuffle the examples according to the hash, a deterministic order would still be maintained (as the keys will always have the same hash, whenever the dataset is generated). 
And since, we are not dealing with time series data (which would require the data to be in original order), I don't think the order of examples would matter much, as long as the order is deterministic and constant for all users.

I think that this is also what was originally envisioned as mentioned in the documentation here:
https://github.com/huggingface/datasets/blob/6775661b19d2ec339784f3d84553a3996a1d86c3/src/datasets/builder.py#L973

Also, if we avoid this, we would need to keep track of all the hashed keys in some place and compare each individual key with all others. This can cause some major overhead as each dataset consists of tens of thousands of examples.
Let me know your thoughts in it! I would be opening a PR soon :)
2021-04-19T15:50:18Z
https://github.com/huggingface/datasets/issues/2230#issuecomment-822576254
https://api.github.com/repos/huggingface/datasets/issues/2230
MDEyOklzc3VlQ29tbWVudDgyMjU3NjI1NA==
https://api.github.com/repos/huggingface/datasets/issues/comments/822576254/reactions
2021-04-19T15:50:18Z
https://api.github.com/repos/huggingface/datasets/issues/comments/822576254
https://avatars.githubusercontent.com/u/42388668?v=4
https://api.github.com/users/NikhilBartwal/events{/privacy}
https://api.github.com/users/NikhilBartwal/followers
https://api.github.com/users/NikhilBartwal/following{/other_user}
https://api.github.com/users/NikhilBartwal/gists{/gist_id}
https://github.com/NikhilBartwal
NikhilBartwal
MDQ6VXNlcjQyMzg4NjY4
https://api.github.com/users/NikhilBartwal/orgs
https://api.github.com/users/NikhilBartwal/received_events
https://api.github.com/users/NikhilBartwal/repos
https://api.github.com/users/NikhilBartwal/starred{/owner}{/repo}
https://api.github.com/users/NikhilBartwal/subscriptions
User
https://api.github.com/users/NikhilBartwal
public
MEMBER
When users load their own data, they expect the order to stay the same. I think that shuffling the data can make things inconvenient.

> I think that this is also what was originally envisioned as mentioned in the documentation here:

This part was originally developed by tensorflow datasets, and tensorflow datasets indeed does the shuffling. However in this library this is probably not what we want in the general case. But if @albertvillanova and @thomwolf you have opinions on this please let us know.

> Also, if we avoid this, we would need to keep track of all the hashed keys in some place and compare each individual key with all others. This can cause some major overhead as each dataset consists of tens of thousands of examples.

Maybe we cam simply keep track of the hashes of of each batch being written ? The size of the batch when the data are save in arrow is 10 000 examples. This would only ensure that we don't have duplicates in each batch, but there might still be duplicates across batches. For 10 000 examples the hashes can just be stored as a python `set`.

Otherwise if we want full deduplication, we need an extra tool that allows to temporarily save and query hashes that may need to use disk space rather than memory.
2021-04-19T16:39:09Z
https://github.com/huggingface/datasets/issues/2230#issuecomment-822612663
https://api.github.com/repos/huggingface/datasets/issues/2230
MDEyOklzc3VlQ29tbWVudDgyMjYxMjY2Mw==
https://api.github.com/repos/huggingface/datasets/issues/comments/822612663/reactions
2021-04-19T16:39:09Z
https://api.github.com/repos/huggingface/datasets/issues/comments/822612663
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
Yes I think we want to keep the original order by default and only shuffle when the user ask for it (for instance by calling `dataset.shuffle()`). That’s how I had it in mind originally.
2021-04-19T18:48:09Z
https://github.com/huggingface/datasets/issues/2230#issuecomment-822695575
https://api.github.com/repos/huggingface/datasets/issues/2230
MDEyOklzc3VlQ29tbWVudDgyMjY5NTU3NQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/822695575/reactions
2021-04-19T18:48:09Z
https://api.github.com/repos/huggingface/datasets/issues/comments/822695575
https://avatars.githubusercontent.com/u/7353373?v=4
https://api.github.com/users/thomwolf/events{/privacy}
https://api.github.com/users/thomwolf/followers
https://api.github.com/users/thomwolf/following{/other_user}
https://api.github.com/users/thomwolf/gists{/gist_id}
https://github.com/thomwolf
thomwolf
MDQ6VXNlcjczNTMzNzM=
https://api.github.com/users/thomwolf/orgs
https://api.github.com/users/thomwolf/received_events
https://api.github.com/users/thomwolf/repos
https://api.github.com/users/thomwolf/starred{/owner}{/repo}
https://api.github.com/users/thomwolf/subscriptions
User
https://api.github.com/users/thomwolf
public
CONTRIBUTOR
Hey @lhoestq, I just had a more in-depth look at the original TFDS code about why the keys and hash were used in the first place.

In my opinion, the only use that the `hash(key)` serves is that it allows us to shuffle the examples in a deterministic order (as each example will always yield the same key and thus, the same hash on every system) so that the same dataset is generated for each user, irrespective of the order the examples are yielded by the dataset builder on different user systems.

Otherwise, if we are not shuffling, then while yielding and writing the data, after getting the key and hashing it for an example, I can't quite see the use of the hash or the key. The hash will simply be generated for each example but not actually used anywhere?

@lhoestq @thomwolf It would be great if you could explain a bit more about the usage of keys. Thanks!

2021-04-19T18:56:39Z
https://github.com/huggingface/datasets/issues/2230#issuecomment-822700520
https://api.github.com/repos/huggingface/datasets/issues/2230
MDEyOklzc3VlQ29tbWVudDgyMjcwMDUyMA==
https://api.github.com/repos/huggingface/datasets/issues/comments/822700520/reactions
2021-04-19T19:00:10Z
https://api.github.com/repos/huggingface/datasets/issues/comments/822700520
https://avatars.githubusercontent.com/u/42388668?v=4
https://api.github.com/users/NikhilBartwal/events{/privacy}
https://api.github.com/users/NikhilBartwal/followers
https://api.github.com/users/NikhilBartwal/following{/other_user}
https://api.github.com/users/NikhilBartwal/gists{/gist_id}
https://github.com/NikhilBartwal
NikhilBartwal
MDQ6VXNlcjQyMzg4NjY4
https://api.github.com/users/NikhilBartwal/orgs
https://api.github.com/users/NikhilBartwal/received_events
https://api.github.com/users/NikhilBartwal/repos
https://api.github.com/users/NikhilBartwal/starred{/owner}{/repo}
https://api.github.com/users/NikhilBartwal/subscriptions
User
https://api.github.com/users/NikhilBartwal
public
MEMBER
In `datasets` the keys are currently ignored.
For shuffling we don't use the keys. Instead we shuffle an array of indices. Since both the original order of the dataset and the indices shuffling are deterministic, then `dataset.shuffle` is deterministic as well.
We can use it to:
1. detect duplicates
2. verify that the generation order is indeed deterministic
3. maybe more ?
2021-04-20T08:27:14Z
https://github.com/huggingface/datasets/issues/2230#issuecomment-823086095
https://api.github.com/repos/huggingface/datasets/issues/2230
MDEyOklzc3VlQ29tbWVudDgyMzA4NjA5NQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/823086095/reactions
2021-04-20T08:27:14Z
https://api.github.com/repos/huggingface/datasets/issues/comments/823086095
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
Thanks a lot @lhoestq. I think I understand what we need to do now. The keys can indeed be used for detecting duplicates in generated examples as well as ensuring the order.

> Maybe we cam simply keep track of the hashes of of each batch being written ? The size of the batch when the data are save in arrow is 10 000 examples. This would only ensure that we don't have duplicates in each batch,

I think that checking for duplicates in every batch independently would be sufficient as the probability of collisions using something like `MD5` is very low. I would be opening a draft PR soon. It would be great to have your guidance. Thanks!
2021-04-20T08:46:50Z
https://github.com/huggingface/datasets/issues/2230#issuecomment-823099681
https://api.github.com/repos/huggingface/datasets/issues/2230
MDEyOklzc3VlQ29tbWVudDgyMzA5OTY4MQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/823099681/reactions
2021-04-20T08:46:50Z
https://api.github.com/repos/huggingface/datasets/issues/comments/823099681
https://avatars.githubusercontent.com/u/42388668?v=4
https://api.github.com/users/NikhilBartwal/events{/privacy}
https://api.github.com/users/NikhilBartwal/followers
https://api.github.com/users/NikhilBartwal/following{/other_user}
https://api.github.com/users/NikhilBartwal/gists{/gist_id}
https://github.com/NikhilBartwal
NikhilBartwal
MDQ6VXNlcjQyMzg4NjY4
https://api.github.com/users/NikhilBartwal/orgs
https://api.github.com/users/NikhilBartwal/received_events
https://api.github.com/users/NikhilBartwal/repos
https://api.github.com/users/NikhilBartwal/starred{/owner}{/repo}
https://api.github.com/users/NikhilBartwal/subscriptions
User
https://api.github.com/users/NikhilBartwal
public
The keys used in the dataset generation script to ensure the same order is generated on every user's end should be checked for their types (i.e either `str` or `int`) as well as whether they are unique or not.
Currently, the keys are not being checked for any of these, as evident from `xnli' dataset generation:
https://github.com/huggingface/datasets/blob/56346791aed417306d054d89bd693d6b7eab17f7/datasets/xnli/xnli.py#L196
Even after having a tuple as key, the dataset is generated without any warning.

Also, as tested in the case of `anli` dataset (I tweeked the dataset script to use `1` as a key for every example):
```
>>> import datasets
>>> nik = datasets.load_dataset('anli')
Downloading and preparing dataset anli/plain_text (download: 17.76 MiB, generated: 73.55 MiB, post-processed: Unknown size, total: 91.31 MiB) to C:\Users\nikhil\.cache\huggingface\datasets\anli\plain_text\0.1.0\43fa2c99c10bf8478f1fa0860f7b122c6b277c4c41306255b7641257cf4e3299...
0 examples [00:00, ? examples/s]1        {'uid': '0fd0abfb-659e-4453-b196-c3a64d2d8267', 'premise': 'The Parma trolleybus system (Italian: "Rete filoviaria di Parma" ) forms part of the public transport network of the city and "comune" of Parma, in the region of Emilia-Romagna, northern Italy. In operation since 1953, the system presently comprises four urban routes.', 'hypothesis': 'The trolleybus system has over 2 urban routes', 'label': 'entailment', 'reason': ''}
2021-04-16 12:38:14.483968: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudart64_110.dll
1 examples [00:01,  1.87s/ examples]1    {'uid': '7ed72ff4-40b7-4f8a-b1b9-6c612aa62c84', 'premise': 'Alexandra Lendon Bastedo (9 March 1946 – 12 January 2014) was a British actress, best known for her role as secret agent Sharron Macready in the 1968 British espionage/science fiction adventure series "The Champions". She has been cited as a sex symbol of the 1960s and 1970s. Bastedo was a vegetarian and animal welfare advocate.', 'hypothesis': "Sharron Macready was a popular character through the 1980's.", 'label': 'neutral', 'reason': ''}
1        {'uid': '5d2930a3-62ac-485d-94d7-4e36cbbcd7b5', 'premise': 'Alexandra Lendon Bastedo (9 March 1946 – 12 January 2014) was a British actress, best known for her role as secret agent Sharron Macready in the 1968 British espionage/science fiction adventure series "The Champions". She has been cited as a sex symbol of the 1960s and 1970s. Bastedo was a vegetarian and animal welfare advocate.', 'hypothesis': "Bastedo didn't keep any pets because of her views on animal rights.", 'label': 'neutral', 'reason': ''}
1        {'uid': '324db753-ddc9-4a85-a825-f09e2e5aebdd', 'premise': 'Alexandra Lendon Bastedo (9 March 1946 – 12 January 2014) was a British actress, best known for her role as secret agent Sharron Macready in the 1968 British espionage/science fiction adventure series "The Champions". She has been cited as a sex symbol of the 1960s and 1970s. Bastedo was a vegetarian and animal welfare advocate.', 'hypothesis': 'Alexandra Bastedo was named by her mother.', 'label': 'neutral', 'reason': ''}
1        {'uid': '4874f429-da0e-406a-90c7-22240ff3ddf8', 'premise': 'Alexandra Lendon Bastedo (9 March 1946 – 12 January 2014) was a British actress, best known for her role as secret agent Sharron Macready in the 1968 British espionage/science fiction adventure series "The Champions". She has been cited as a sex symbol of the 1960s and 1970s. Bastedo was a vegetarian and animal welfare advocate.', 'hypothesis': 'Bastedo cared for all the animals that inhabit the earth.', 'label': 'neutral', 'reason': ''}
```
Here also, the dataset was generated successfuly even hough it had same keys without any warning.

The reason appears to stem from here:
https://github.com/huggingface/datasets/blob/56346791aed417306d054d89bd693d6b7eab17f7/src/datasets/builder.py#L988
Here, although it has access to every key, but it is not being checked and the example is written directly:
https://github.com/huggingface/datasets/blob/56346791aed417306d054d89bd693d6b7eab17f7/src/datasets/builder.py#L992

I would like to take this issue if you allow me. Thank You!