Fix backward compatibility in Dataset.load_from_disk
MEMBER
Hi @lhoestq, could you please check if this makes sense? Thanks.
2021-04-09T11:01:59Z
https://github.com/huggingface/datasets/pull/2199#issuecomment-816603373
https://api.github.com/repos/huggingface/datasets/issues/2199
MDEyOklzc3VlQ29tbWVudDgxNjYwMzM3Mw==
https://api.github.com/repos/huggingface/datasets/issues/comments/816603373/reactions
2021-04-09T11:01:59Z
https://api.github.com/repos/huggingface/datasets/issues/comments/816603373
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
MEMBER
What about using `_indices_data_files` field in save_to_disk instead of `_indices_files` ?
This way future datasets can also be reloaded from older versions of the lib

`_indices_files` was introduced in a recent PR and was not released
2021-04-09T11:13:58Z
https://github.com/huggingface/datasets/pull/2199#issuecomment-816609681
https://api.github.com/repos/huggingface/datasets/issues/2199
MDEyOklzc3VlQ29tbWVudDgxNjYwOTY4MQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/816609681/reactions
2021-04-09T11:14:30Z
https://api.github.com/repos/huggingface/datasets/issues/comments/816609681
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
Yes, I have seen it is not released yet...

You are right! It was your awesome PR on Tables which renamed this. If there is no particular reason for this renaming, yes, we could switch it back to the previous `_indices_data_files`. ;)
2021-04-09T11:23:06Z
https://github.com/huggingface/datasets/pull/2199#issuecomment-816614268
https://api.github.com/repos/huggingface/datasets/issues/2199
MDEyOklzc3VlQ29tbWVudDgxNjYxNDI2OA==
https://api.github.com/repos/huggingface/datasets/issues/comments/816614268/reactions
2021-04-09T11:23:06Z
https://api.github.com/repos/huggingface/datasets/issues/comments/816614268
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
Fix backward compatibility when loading from disk an old dataset saved to disk with indices using key "_indices_data_files".

Related to #2195.