adding keep in memory
NONE
_The documentation is not available anymore as the PR was closed or merged._
2022-10-06T12:19:41Z
https://github.com/huggingface/datasets/pull/5082#issuecomment-1269937672
https://api.github.com/repos/huggingface/datasets/issues/5082
IC_kwDODunzps5LsbYI
https://api.github.com/repos/huggingface/datasets/issues/comments/1269937672/reactions
2022-10-07T14:35:34Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1269937672
https://avatars.githubusercontent.com/u/99929124?v=4
https://api.github.com/users/HuggingFaceDocBuilderDev/events{/privacy}
https://api.github.com/users/HuggingFaceDocBuilderDev/followers
https://api.github.com/users/HuggingFaceDocBuilderDev/following{/other_user}
https://api.github.com/users/HuggingFaceDocBuilderDev/gists{/gist_id}
https://github.com/HuggingFaceDocBuilderDev
HuggingFaceDocBuilderDev
U_kgDOBfTMJA
https://api.github.com/users/HuggingFaceDocBuilderDev/orgs
https://api.github.com/users/HuggingFaceDocBuilderDev/received_events
https://api.github.com/users/HuggingFaceDocBuilderDev/repos
https://api.github.com/users/HuggingFaceDocBuilderDev/starred{/owner}{/repo}
https://api.github.com/users/HuggingFaceDocBuilderDev/subscriptions
User
https://api.github.com/users/HuggingFaceDocBuilderDev
public
CONTRIBUTOR
Hi @mariosasko , I have added a test for the `keep_in_memory` version. I have also removed the `Compatible with temp_seed` part in the scope of `dset_shuffled`, please verify if that makes sense.
2022-10-06T13:19:01Z
https://github.com/huggingface/datasets/pull/5082#issuecomment-1270032626
https://api.github.com/repos/huggingface/datasets/issues/5082
IC_kwDODunzps5Lsyjy
https://api.github.com/repos/huggingface/datasets/issues/comments/1270032626/reactions
2022-10-06T13:19:01Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1270032626
https://avatars.githubusercontent.com/u/66799406?v=4
https://api.github.com/users/Mustapha-AJEGHRIR/events{/privacy}
https://api.github.com/users/Mustapha-AJEGHRIR/followers
https://api.github.com/users/Mustapha-AJEGHRIR/following{/other_user}
https://api.github.com/users/Mustapha-AJEGHRIR/gists{/gist_id}
https://github.com/Mustapha-AJEGHRIR
Mustapha-AJEGHRIR
MDQ6VXNlcjY2Nzk5NDA2
https://api.github.com/users/Mustapha-AJEGHRIR/orgs
https://api.github.com/users/Mustapha-AJEGHRIR/received_events
https://api.github.com/users/Mustapha-AJEGHRIR/repos
https://api.github.com/users/Mustapha-AJEGHRIR/starred{/owner}{/repo}
https://api.github.com/users/Mustapha-AJEGHRIR/subscriptions
User
https://api.github.com/users/Mustapha-AJEGHRIR
public
Fixing #514 .

Hello @mariosasko 👋, I have implemented what you have recommanded to fix the keep in memory problem for shuffle on the issue #514 . 