Imppres
MEMBER
Feel free to ping me once you're ready for another review :) 
2020-12-14T13:55:11Z
https://github.com/huggingface/datasets/pull/1423#issuecomment-744455720
https://api.github.com/repos/huggingface/datasets/issues/1423
MDEyOklzc3VlQ29tbWVudDc0NDQ1NTcyMA==
https://api.github.com/repos/huggingface/datasets/issues/comments/744455720/reactions
2020-12-14T13:55:11Z
https://api.github.com/repos/huggingface/datasets/issues/comments/744455720
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
For sure! Gonna work on this now!
2020-12-14T17:47:01Z
https://github.com/huggingface/datasets/pull/1423#issuecomment-744602529
https://api.github.com/repos/huggingface/datasets/issues/1423
MDEyOklzc3VlQ29tbWVudDc0NDYwMjUyOQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/744602529/reactions
2020-12-14T17:47:01Z
https://api.github.com/repos/huggingface/datasets/issues/comments/744602529
https://avatars.githubusercontent.com/u/53267795?v=4
https://api.github.com/users/aclifton314/events{/privacy}
https://api.github.com/users/aclifton314/followers
https://api.github.com/users/aclifton314/following{/other_user}
https://api.github.com/users/aclifton314/gists{/gist_id}
https://github.com/aclifton314
aclifton314
MDQ6VXNlcjUzMjY3Nzk1
https://api.github.com/users/aclifton314/orgs
https://api.github.com/users/aclifton314/received_events
https://api.github.com/users/aclifton314/repos
https://api.github.com/users/aclifton314/starred{/owner}{/repo}
https://api.github.com/users/aclifton314/subscriptions
User
https://api.github.com/users/aclifton314
public
CONTRIBUTOR
I incorporated all the changes but when I go to rebase I get the following error:
```python
aclifton@pop-os:~/hf_datasets_sprint/datasets$ git rebase upstream/master
error: cannot rebase: You have unstaged changes.
error: Please commit or stash them.
aclifton@pop-os:~/hf_datasets_sprint/datasets$ git stash
Saved working directory and index state WIP on imppres: 51736236 Incorporated secondary sets as configurations instead of splits.
aclifton@pop-os:~/hf_datasets_sprint/datasets$ git rebase upstream/master
CONFLICT (add/add): Merge conflict in datasets/wiki_movies/wiki_movies.py
Auto-merging datasets/wiki_movies/wiki_movies.py
CONFLICT (add/add): Merge conflict in datasets/wiki_movies/dataset_infos.json
Auto-merging datasets/wiki_movies/dataset_infos.json
CONFLICT (add/add): Merge conflict in datasets/wiki_movies/README.md
Auto-merging datasets/wiki_movies/README.md
error: could not apply 04d08587... Created wiki_movies dataset.
Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 04d08587... Created wiki_movies dataset.
aclifton@pop-os:~/hf_datasets_sprint/datasets$ git branch
* (no branch, rebasing imppres)
  imppres
  logiqa_en
  master
  wiki_movies
  wiki_movies_htl
aclifton@pop-os:~/hf_datasets_sprint/datasets$ git checkout imppres 
datasets/wiki_movies/README.md: needs merge
datasets/wiki_movies/dataset_infos.json: needs merge
datasets/wiki_movies/wiki_movies.py: needs merge
error: you need to resolve your current index first
aclifton@pop-os:~/hf_datasets_sprint/datasets$ 
```
2020-12-14T18:35:54Z
https://github.com/huggingface/datasets/pull/1423#issuecomment-744630427
https://api.github.com/repos/huggingface/datasets/issues/1423
MDEyOklzc3VlQ29tbWVudDc0NDYzMDQyNw==
https://api.github.com/repos/huggingface/datasets/issues/comments/744630427/reactions
2020-12-14T18:35:54Z
https://api.github.com/repos/huggingface/datasets/issues/comments/744630427
https://avatars.githubusercontent.com/u/53267795?v=4
https://api.github.com/users/aclifton314/events{/privacy}
https://api.github.com/users/aclifton314/followers
https://api.github.com/users/aclifton314/following{/other_user}
https://api.github.com/users/aclifton314/gists{/gist_id}
https://github.com/aclifton314
aclifton314
MDQ6VXNlcjUzMjY3Nzk1
https://api.github.com/users/aclifton314/orgs
https://api.github.com/users/aclifton314/received_events
https://api.github.com/users/aclifton314/repos
https://api.github.com/users/aclifton314/starred{/owner}{/repo}
https://api.github.com/users/aclifton314/subscriptions
User
https://api.github.com/users/aclifton314
public
MEMBER
I think it's because the current branch includes changes about wiki_movies.

Can you create a new branch from `master` and create another PR please ?
2020-12-15T15:31:18Z
https://github.com/huggingface/datasets/pull/1423#issuecomment-745367933
https://api.github.com/repos/huggingface/datasets/issues/1423
MDEyOklzc3VlQ29tbWVudDc0NTM2NzkzMw==
https://api.github.com/repos/huggingface/datasets/issues/comments/745367933/reactions
2020-12-15T15:31:18Z
https://api.github.com/repos/huggingface/datasets/issues/comments/745367933
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
I get this response when I try to switch to master:
```
aclifton@pop-os:~/hf_datasets_sprint/datasets$ git checkout master
datasets/wiki_movies/README.md: needs merge
datasets/wiki_movies/dataset_infos.json: needs merge
datasets/wiki_movies/wiki_movies.py: needs merge
error: you need to resolve your current index first
```
2020-12-15T16:11:06Z
https://github.com/huggingface/datasets/pull/1423#issuecomment-745393568
https://api.github.com/repos/huggingface/datasets/issues/1423
MDEyOklzc3VlQ29tbWVudDc0NTM5MzU2OA==
https://api.github.com/repos/huggingface/datasets/issues/comments/745393568/reactions
2020-12-15T16:11:06Z
https://api.github.com/repos/huggingface/datasets/issues/comments/745393568
https://avatars.githubusercontent.com/u/53267795?v=4
https://api.github.com/users/aclifton314/events{/privacy}
https://api.github.com/users/aclifton314/followers
https://api.github.com/users/aclifton314/following{/other_user}
https://api.github.com/users/aclifton314/gists{/gist_id}
https://github.com/aclifton314
aclifton314
MDQ6VXNlcjUzMjY3Nzk1
https://api.github.com/users/aclifton314/orgs
https://api.github.com/users/aclifton314/received_events
https://api.github.com/users/aclifton314/repos
https://api.github.com/users/aclifton314/starred{/owner}{/repo}
https://api.github.com/users/aclifton314/subscriptions
User
https://api.github.com/users/aclifton314
public
MEMBER
Maybe you have to remove the changes in wiki_movies before checkout to master
```
git stash
```

should do the job
2020-12-16T09:41:53Z
https://github.com/huggingface/datasets/pull/1423#issuecomment-745996623
https://api.github.com/repos/huggingface/datasets/issues/1423
MDEyOklzc3VlQ29tbWVudDc0NTk5NjYyMw==
https://api.github.com/repos/huggingface/datasets/issues/comments/745996623/reactions
2020-12-16T09:41:53Z
https://api.github.com/repos/huggingface/datasets/issues/comments/745996623
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
Here is what I get:
```
aclifton@pop-os:~/hf_datasets_sprint/datasets$ git stash
datasets/wiki_movies/README.md: needs merge
datasets/wiki_movies/dataset_infos.json: needs merge
datasets/wiki_movies/wiki_movies.py: needs merge
```
2020-12-16T16:59:09Z
https://github.com/huggingface/datasets/pull/1423#issuecomment-746634290
https://api.github.com/repos/huggingface/datasets/issues/1423
MDEyOklzc3VlQ29tbWVudDc0NjYzNDI5MA==
https://api.github.com/repos/huggingface/datasets/issues/comments/746634290/reactions
2020-12-16T16:59:09Z
https://api.github.com/repos/huggingface/datasets/issues/comments/746634290
https://avatars.githubusercontent.com/u/53267795?v=4
https://api.github.com/users/aclifton314/events{/privacy}
https://api.github.com/users/aclifton314/followers
https://api.github.com/users/aclifton314/following{/other_user}
https://api.github.com/users/aclifton314/gists{/gist_id}
https://github.com/aclifton314
aclifton314
MDQ6VXNlcjUzMjY3Nzk1
https://api.github.com/users/aclifton314/orgs
https://api.github.com/users/aclifton314/received_events
https://api.github.com/users/aclifton314/repos
https://api.github.com/users/aclifton314/starred{/owner}{/repo}
https://api.github.com/users/aclifton314/subscriptions
User
https://api.github.com/users/aclifton314
public
MEMBER
Ok I see
Looks like you're in a `merge` process.
You can abort it with `git reset --merge`

Then `git checkout master` should work
2020-12-16T17:03:47Z
https://github.com/huggingface/datasets/pull/1423#issuecomment-746642205
https://api.github.com/repos/huggingface/datasets/issues/1423
MDEyOklzc3VlQ29tbWVudDc0NjY0MjIwNQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/746642205/reactions
2020-12-16T17:03:47Z
https://api.github.com/repos/huggingface/datasets/issues/comments/746642205
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
So close! I got the new branch made and went through all the tests. When I went to push, I got the following:
```
aclifton@pop-os:~/hf_datasets_sprint/datasets$ git push -u origin imppres
Username for 'https://github.com': aclifton314
Password for 'https://aclifton314@github.com': 
To https://github.com/aclifton314/datasets
 ! [rejected]          imppres -> imppres (non-fast-forward)
error: failed to push some refs to 'https://github.com/aclifton314/datasets'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
```
2020-12-16T20:32:46Z
https://github.com/huggingface/datasets/pull/1423#issuecomment-746968799
https://api.github.com/repos/huggingface/datasets/issues/1423
MDEyOklzc3VlQ29tbWVudDc0Njk2ODc5OQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/746968799/reactions
2020-12-16T20:32:46Z
https://api.github.com/repos/huggingface/datasets/issues/comments/746968799
https://avatars.githubusercontent.com/u/53267795?v=4
https://api.github.com/users/aclifton314/events{/privacy}
https://api.github.com/users/aclifton314/followers
https://api.github.com/users/aclifton314/following{/other_user}
https://api.github.com/users/aclifton314/gists{/gist_id}
https://github.com/aclifton314
aclifton314
MDQ6VXNlcjUzMjY3Nzk1
https://api.github.com/users/aclifton314/orgs
https://api.github.com/users/aclifton314/received_events
https://api.github.com/users/aclifton314/repos
https://api.github.com/users/aclifton314/starred{/owner}{/repo}
https://api.github.com/users/aclifton314/subscriptions
User
https://api.github.com/users/aclifton314
public
MEMBER
after a rebase you need to `git push --force`
2020-12-17T09:29:05Z
https://github.com/huggingface/datasets/pull/1423#issuecomment-747321576
https://api.github.com/repos/huggingface/datasets/issues/1423
MDEyOklzc3VlQ29tbWVudDc0NzMyMTU3Ng==
https://api.github.com/repos/huggingface/datasets/issues/comments/747321576/reactions
2020-12-17T09:29:05Z
https://api.github.com/repos/huggingface/datasets/issues/comments/747321576
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
Done!
2020-12-17T15:40:40Z
https://github.com/huggingface/datasets/pull/1423#issuecomment-747517564
https://api.github.com/repos/huggingface/datasets/issues/1423
MDEyOklzc3VlQ29tbWVudDc0NzUxNzU2NA==
https://api.github.com/repos/huggingface/datasets/issues/comments/747517564/reactions
2020-12-17T15:40:40Z
https://api.github.com/repos/huggingface/datasets/issues/comments/747517564
https://avatars.githubusercontent.com/u/53267795?v=4
https://api.github.com/users/aclifton314/events{/privacy}
https://api.github.com/users/aclifton314/followers
https://api.github.com/users/aclifton314/following{/other_user}
https://api.github.com/users/aclifton314/gists{/gist_id}
https://github.com/aclifton314
aclifton314
MDQ6VXNlcjUzMjY3Nzk1
https://api.github.com/users/aclifton314/orgs
https://api.github.com/users/aclifton314/received_events
https://api.github.com/users/aclifton314/repos
https://api.github.com/users/aclifton314/starred{/owner}{/repo}
https://api.github.com/users/aclifton314/subscriptions
User
https://api.github.com/users/aclifton314
public
2nd PR ever! Hopefully I'm starting to get the hang of this. This is for the IMPPRES dataset. Please let me know of any corrections or changes that need to be made.