Questions about XSUM 
MEMBER
We should try to regenerate the data using the official script.
But iirc that's what we used in the first place, so not sure why it didn't match in the first place.

I'll let you know when the dataset is updated
2020-09-28T08:12:01Z
https://github.com/huggingface/datasets/issues/672#issuecomment-699853177
https://api.github.com/repos/huggingface/datasets/issues/672
MDEyOklzc3VlQ29tbWVudDY5OTg1MzE3Nw==
https://api.github.com/repos/huggingface/datasets/issues/comments/699853177/reactions
2020-09-28T08:12:01Z
https://api.github.com/repos/huggingface/datasets/issues/comments/699853177
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
Thanks, looking forward to hearing your update on this thread. 

This is a blocking issue for us; would appreciate any progress on this front. We can also help with the fix, if you deem it appropriately. 
2020-09-28T20:24:30Z
https://github.com/huggingface/datasets/issues/672#issuecomment-700261838
https://api.github.com/repos/huggingface/datasets/issues/672
MDEyOklzc3VlQ29tbWVudDcwMDI2MTgzOA==
https://api.github.com/repos/huggingface/datasets/issues/comments/700261838/reactions
2020-09-28T20:24:30Z
https://api.github.com/repos/huggingface/datasets/issues/comments/700261838
https://avatars.githubusercontent.com/u/2441454?v=4
https://api.github.com/users/danyaljj/events{/privacy}
https://api.github.com/users/danyaljj/followers
https://api.github.com/users/danyaljj/following{/other_user}
https://api.github.com/users/danyaljj/gists{/gist_id}
https://github.com/danyaljj
danyaljj
MDQ6VXNlcjI0NDE0NTQ=
https://api.github.com/users/danyaljj/orgs
https://api.github.com/users/danyaljj/received_events
https://api.github.com/users/danyaljj/repos
https://api.github.com/users/danyaljj/starred{/owner}{/repo}
https://api.github.com/users/danyaljj/subscriptions
User
https://api.github.com/users/danyaljj
public
MEMBER
I just started the generation on my side, I'll let you know how it goes :) 
2020-09-29T09:03:50Z
https://github.com/huggingface/datasets/issues/672#issuecomment-700570070
https://api.github.com/repos/huggingface/datasets/issues/672
MDEyOklzc3VlQ29tbWVudDcwMDU3MDA3MA==
https://api.github.com/repos/huggingface/datasets/issues/comments/700570070/reactions
2020-09-29T09:03:50Z
https://api.github.com/repos/huggingface/datasets/issues/comments/700570070
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
Hmm after a first run I'm still missing 136668/226711 urls.
I'll relaunch it tomorrow to try to get the remaining ones.
2020-09-29T16:47:10Z
https://github.com/huggingface/datasets/issues/672#issuecomment-700840767
https://api.github.com/repos/huggingface/datasets/issues/672
MDEyOklzc3VlQ29tbWVudDcwMDg0MDc2Nw==
https://api.github.com/repos/huggingface/datasets/issues/comments/700840767/reactions
2020-09-29T16:47:10Z
https://api.github.com/repos/huggingface/datasets/issues/comments/700840767
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
Update: I'm missing 36/226711 urls but I haven't managed to download them yet
2020-10-01T16:58:43Z
https://github.com/huggingface/datasets/issues/672#issuecomment-702269065
https://api.github.com/repos/huggingface/datasets/issues/672
MDEyOklzc3VlQ29tbWVudDcwMjI2OTA2NQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/702269065/reactions
2020-10-01T16:58:43Z
https://api.github.com/repos/huggingface/datasets/issues/comments/702269065
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
Thanks! That sounds like a reasonable number! 
2020-10-01T17:01:35Z
https://github.com/huggingface/datasets/issues/672#issuecomment-702270572
https://api.github.com/repos/huggingface/datasets/issues/672
MDEyOklzc3VlQ29tbWVudDcwMjI3MDU3Mg==
https://api.github.com/repos/huggingface/datasets/issues/comments/702270572/reactions
2020-10-01T17:01:35Z
https://api.github.com/repos/huggingface/datasets/issues/comments/702270572
https://avatars.githubusercontent.com/u/2441454?v=4
https://api.github.com/users/danyaljj/events{/privacy}
https://api.github.com/users/danyaljj/followers
https://api.github.com/users/danyaljj/following{/other_user}
https://api.github.com/users/danyaljj/gists{/gist_id}
https://github.com/danyaljj
danyaljj
MDQ6VXNlcjI0NDE0NTQ=
https://api.github.com/users/danyaljj/orgs
https://api.github.com/users/danyaljj/received_events
https://api.github.com/users/danyaljj/repos
https://api.github.com/users/danyaljj/starred{/owner}{/repo}
https://api.github.com/users/danyaljj/subscriptions
User
https://api.github.com/users/danyaljj
public
MEMBER
So I managed to download them all but when parsing only 226,181/226,711 worked.
Not sure if it's worth digging and debugging parsing at this point :/ 
2020-10-01T21:32:22Z
https://github.com/huggingface/datasets/issues/672#issuecomment-702409648
https://api.github.com/repos/huggingface/datasets/issues/672
MDEyOklzc3VlQ29tbWVudDcwMjQwOTY0OA==
https://api.github.com/repos/huggingface/datasets/issues/comments/702409648/reactions
2020-10-01T23:52:36Z
https://api.github.com/repos/huggingface/datasets/issues/comments/702409648
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
Maybe @sshleifer can help, I think he's already played with xsum at one point
2020-10-01T21:33:38Z
https://github.com/huggingface/datasets/issues/672#issuecomment-702410148
https://api.github.com/repos/huggingface/datasets/issues/672
MDEyOklzc3VlQ29tbWVudDcwMjQxMDE0OA==
https://api.github.com/repos/huggingface/datasets/issues/comments/702410148/reactions
2020-10-01T21:33:38Z
https://api.github.com/repos/huggingface/datasets/issues/comments/702410148
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
Thanks @lhoestq
It would be great to improve coverage, but IDs are the really crucial part for us. We'd really appreciate an update to the dataset with IDs either way!
2020-10-01T21:41:37Z
https://github.com/huggingface/datasets/issues/672#issuecomment-702413333
https://api.github.com/repos/huggingface/datasets/issues/672
MDEyOklzc3VlQ29tbWVudDcwMjQxMzMzMw==
https://api.github.com/repos/huggingface/datasets/issues/comments/702413333/reactions
2020-10-01T21:41:37Z
https://api.github.com/repos/huggingface/datasets/issues/comments/702413333
https://avatars.githubusercontent.com/u/2238344?v=4
https://api.github.com/users/jbragg/events{/privacy}
https://api.github.com/users/jbragg/followers
https://api.github.com/users/jbragg/following{/other_user}
https://api.github.com/users/jbragg/gists{/gist_id}
https://github.com/jbragg
jbragg
MDQ6VXNlcjIyMzgzNDQ=
https://api.github.com/users/jbragg/orgs
https://api.github.com/users/jbragg/received_events
https://api.github.com/users/jbragg/repos
https://api.github.com/users/jbragg/starred{/owner}{/repo}
https://api.github.com/users/jbragg/subscriptions
User
https://api.github.com/users/jbragg
public
CONTRIBUTOR
I gave up at an even earlier point. The dataset I use has 204,017 train examples.
2020-10-01T23:45:51Z
https://github.com/huggingface/datasets/issues/672#issuecomment-702452917
https://api.github.com/repos/huggingface/datasets/issues/672
MDEyOklzc3VlQ29tbWVudDcwMjQ1MjkxNw==
https://api.github.com/repos/huggingface/datasets/issues/comments/702452917/reactions
2020-10-01T23:46:16Z
https://api.github.com/repos/huggingface/datasets/issues/comments/702452917
https://avatars.githubusercontent.com/u/6045025?v=4
https://api.github.com/users/sshleifer/events{/privacy}
https://api.github.com/users/sshleifer/followers
https://api.github.com/users/sshleifer/following{/other_user}
https://api.github.com/users/sshleifer/gists{/gist_id}
https://github.com/sshleifer
sshleifer
MDQ6VXNlcjYwNDUwMjU=
https://api.github.com/users/sshleifer/orgs
https://api.github.com/users/sshleifer/received_events
https://api.github.com/users/sshleifer/repos
https://api.github.com/users/sshleifer/starred{/owner}{/repo}
https://api.github.com/users/sshleifer/subscriptions
User
https://api.github.com/users/sshleifer
public
CONTRIBUTOR
@lhoestq @sshleifer like @jbragg said earlier, the main issue for us is that the current XSUM dataset (in your package) does not have IDs suggested by the original dataset ([here is the file](https://raw.githubusercontent.com/EdinburghNLP/XSum/master/XSum-Dataset/XSum-TRAINING-DEV-TEST-SPLIT-90-5-5.json).) Would appreciate if you update the XSUM dataset to include the instance IDs. 

The missing instances is also a problem, but likely not worth pursuing given its relatively small scale. 
2020-10-16T01:35:36Z
https://github.com/huggingface/datasets/issues/672#issuecomment-709677224
https://api.github.com/repos/huggingface/datasets/issues/672
MDEyOklzc3VlQ29tbWVudDcwOTY3NzIyNA==
https://api.github.com/repos/huggingface/datasets/issues/comments/709677224/reactions
2020-10-16T01:35:36Z
https://api.github.com/repos/huggingface/datasets/issues/comments/709677224
https://avatars.githubusercontent.com/u/2441454?v=4
https://api.github.com/users/danyaljj/events{/privacy}
https://api.github.com/users/danyaljj/followers
https://api.github.com/users/danyaljj/following{/other_user}
https://api.github.com/users/danyaljj/gists{/gist_id}
https://github.com/danyaljj
danyaljj
MDQ6VXNlcjI0NDE0NTQ=
https://api.github.com/users/danyaljj/orgs
https://api.github.com/users/danyaljj/received_events
https://api.github.com/users/danyaljj/repos
https://api.github.com/users/danyaljj/starred{/owner}{/repo}
https://api.github.com/users/danyaljj/subscriptions
User
https://api.github.com/users/danyaljj
public
CONTRIBUTOR
>So I managed to download them all but when parsing only 226,181/226,711 worked.

@lhoestq any chance we could update the HF-hosted dataset with the IDs in your new version? Happy to help if there's something I can do.
2020-10-20T05:31:37Z
https://github.com/huggingface/datasets/issues/672#issuecomment-712601378
https://api.github.com/repos/huggingface/datasets/issues/672
MDEyOklzc3VlQ29tbWVudDcxMjYwMTM3OA==
https://api.github.com/repos/huggingface/datasets/issues/comments/712601378/reactions
2020-10-20T05:31:48Z
https://api.github.com/repos/huggingface/datasets/issues/comments/712601378
https://avatars.githubusercontent.com/u/2238344?v=4
https://api.github.com/users/jbragg/events{/privacy}
https://api.github.com/users/jbragg/followers
https://api.github.com/users/jbragg/following{/other_user}
https://api.github.com/users/jbragg/gists{/gist_id}
https://github.com/jbragg
jbragg
MDQ6VXNlcjIyMzgzNDQ=
https://api.github.com/users/jbragg/orgs
https://api.github.com/users/jbragg/received_events
https://api.github.com/users/jbragg/repos
https://api.github.com/users/jbragg/starred{/owner}{/repo}
https://api.github.com/users/jbragg/subscriptions
User
https://api.github.com/users/jbragg
public
MEMBER
Well I couldn't parse what I downloaded.
Unfortunately I think I won't be able to take a look at it this week.
I can try to send you what I got if you want to give it a shot @jbragg 
Otherwise feel free to re-run the xsum download script, maybe you'll be luckier than me
2020-10-20T09:16:07Z
https://github.com/huggingface/datasets/issues/672#issuecomment-712713243
https://api.github.com/repos/huggingface/datasets/issues/672
MDEyOklzc3VlQ29tbWVudDcxMjcxMzI0Mw==
https://api.github.com/repos/huggingface/datasets/issues/comments/712713243/reactions
2020-10-20T09:16:07Z
https://api.github.com/repos/huggingface/datasets/issues/comments/712713243
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
COLLABORATOR
Resolved via #754
2022-10-04T17:30:17Z
https://github.com/huggingface/datasets/issues/672#issuecomment-1267330226
https://api.github.com/repos/huggingface/datasets/issues/672
IC_kwDODunzps5Lieyy
https://api.github.com/repos/huggingface/datasets/issues/comments/1267330226/reactions
2022-10-04T17:30:17Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1267330226
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
Hi there ✋ 

I'm looking into your `xsum` dataset and I have several questions on that. 
So here is how I loaded the data: 
```
>>> data = datasets.load_dataset('xsum', version='1.0.1')
>>> data['train']
Dataset(features: {'document': Value(dtype='string', id=None), 'summary': Value(dtype='string', id=None)}, num_rows: 204017)
>>> data['test']
Dataset(features: {'document': Value(dtype='string', id=None), 'summary': Value(dtype='string', id=None)}, num_rows: 11333)
```

The first issue is, the instance counts don’t match what I see on [the dataset's website](https://github.com/EdinburghNLP/XSum/tree/master/XSum-Dataset#what-builds-the-xsum-dataset) (11,333 vs 11,334 for test set; 204,017 vs 204,045 for training set)
```
 … training (90%, 204,045), validation (5%, 11,332), and test (5%, 11,334) set.
```
Any thoughts why? Perhaps @mariamabarham could help here, since she recently had a PR on this dataaset https://github.com/huggingface/datasets/pull/289  (reviewed by @patrickvonplaten) 

Another issue is that the instances don't seem to have IDs. The original datasets provides IDs for the instances: https://github.com/EdinburghNLP/XSum/blob/master/XSum-Dataset/XSum-TRAINING-DEV-TEST-SPLIT-90-5-5.json but to be able to use them, the dataset sizes need to match. 

CC @jbragg 

