Add Senti_Lex Dataset
CONTRIBUTOR
Better will be if you close this PR and make a fresh PR
2020-12-15T21:23:38Z
https://github.com/huggingface/datasets/pull/1502#issuecomment-745576341
https://api.github.com/repos/huggingface/datasets/issues/1502
MDEyOklzc3VlQ29tbWVudDc0NTU3NjM0MQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/745576341/reactions
2020-12-15T21:23:38Z
https://api.github.com/repos/huggingface/datasets/issues/comments/745576341
https://avatars.githubusercontent.com/u/33005287?v=4
https://api.github.com/users/tanmoyio/events{/privacy}
https://api.github.com/users/tanmoyio/followers
https://api.github.com/users/tanmoyio/following{/other_user}
https://api.github.com/users/tanmoyio/gists{/gist_id}
https://github.com/tanmoyio
tanmoyio
MDQ6VXNlcjMzMDA1Mjg3
https://api.github.com/users/tanmoyio/orgs
https://api.github.com/users/tanmoyio/received_events
https://api.github.com/users/tanmoyio/repos
https://api.github.com/users/tanmoyio/starred{/owner}{/repo}
https://api.github.com/users/tanmoyio/subscriptions
User
https://api.github.com/users/tanmoyio
public
MEMBER
Feel free to ping me if you also have questions about the dummy data
2020-12-17T15:28:11Z
https://github.com/huggingface/datasets/pull/1502#issuecomment-747509138
https://api.github.com/repos/huggingface/datasets/issues/1502
MDEyOklzc3VlQ29tbWVudDc0NzUwOTEzOA==
https://api.github.com/repos/huggingface/datasets/issues/comments/747509138/reactions
2020-12-17T15:28:11Z
https://api.github.com/repos/huggingface/datasets/issues/comments/747509138
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
also it looks like this PR includes changes about dummy_data.zip files in the ./datasets//un_pc folder. Can you remove them ?
2020-12-17T15:28:49Z
https://github.com/huggingface/datasets/pull/1502#issuecomment-747509578
https://api.github.com/repos/huggingface/datasets/issues/1502
MDEyOklzc3VlQ29tbWVudDc0NzUwOTU3OA==
https://api.github.com/repos/huggingface/datasets/issues/comments/747509578/reactions
2020-12-17T15:28:49Z
https://api.github.com/repos/huggingface/datasets/issues/comments/747509578
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
Thanks for all the advice @lhoestq. I've implemented the changes you kindly highlighted and have made sure the scripts pass all the test. I've also marked this as ready for review as I believe it's in a good place to be merged now.
2020-12-23T14:54:34Z
https://github.com/huggingface/datasets/pull/1502#issuecomment-750335558
https://api.github.com/repos/huggingface/datasets/issues/1502
MDEyOklzc3VlQ29tbWVudDc1MDMzNTU1OA==
https://api.github.com/repos/huggingface/datasets/issues/comments/750335558/reactions
2020-12-23T14:54:34Z
https://api.github.com/repos/huggingface/datasets/issues/comments/750335558
https://avatars.githubusercontent.com/u/35491698?v=4
https://api.github.com/users/KMFODA/events{/privacy}
https://api.github.com/users/KMFODA/followers
https://api.github.com/users/KMFODA/following{/other_user}
https://api.github.com/users/KMFODA/gists{/gist_id}
https://github.com/KMFODA
KMFODA
MDQ6VXNlcjM1NDkxNjk4
https://api.github.com/users/KMFODA/orgs
https://api.github.com/users/KMFODA/received_events
https://api.github.com/users/KMFODA/repos
https://api.github.com/users/KMFODA/starred{/owner}{/repo}
https://api.github.com/users/KMFODA/subscriptions
User
https://api.github.com/users/KMFODA
public
CONTRIBUTOR
Great suggestion I fixed the dummy data and the file paths.
2020-12-24T13:24:13Z
https://github.com/huggingface/datasets/pull/1502#issuecomment-750882394
https://api.github.com/repos/huggingface/datasets/issues/1502
MDEyOklzc3VlQ29tbWVudDc1MDg4MjM5NA==
https://api.github.com/repos/huggingface/datasets/issues/comments/750882394/reactions
2020-12-24T13:24:13Z
https://api.github.com/repos/huggingface/datasets/issues/comments/750882394
https://avatars.githubusercontent.com/u/35491698?v=4
https://api.github.com/users/KMFODA/events{/privacy}
https://api.github.com/users/KMFODA/followers
https://api.github.com/users/KMFODA/following{/other_user}
https://api.github.com/users/KMFODA/gists{/gist_id}
https://github.com/KMFODA
KMFODA
MDQ6VXNlcjM1NDkxNjk4
https://api.github.com/users/KMFODA/orgs
https://api.github.com/users/KMFODA/received_events
https://api.github.com/users/KMFODA/repos
https://api.github.com/users/KMFODA/starred{/owner}{/repo}
https://api.github.com/users/KMFODA/subscriptions
User
https://api.github.com/users/KMFODA
public
TODO:
Fix feature format issue
Create dataset_info.json file
Run pytests
Make Style