Bbaw egyptian
MEMBER
Hi @phiwi,

Thanks for contributing this nice dataset. If you have any blocking problem or question, do not hesitate to ask here. We are pleased to help you.

Could you please first synchronize with our master branch? From your branch `bbaw_egyptian`, type:
```
git fetch upstream master
git merge upstream/master
```
2021-05-03T08:05:31Z
https://github.com/huggingface/datasets/pull/2290#issuecomment-831096686
https://api.github.com/repos/huggingface/datasets/issues/2290
MDEyOklzc3VlQ29tbWVudDgzMTA5NjY4Ng==
https://api.github.com/repos/huggingface/datasets/issues/comments/831096686/reactions
2021-05-03T08:06:26Z
https://api.github.com/repos/huggingface/datasets/issues/comments/831096686
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
MEMBER
Thanks ! Can you check that you have `black==21.4b0` and run `make style` again ? This should fix the "check_code_quality" CI issue
2021-05-03T17:43:30Z
https://github.com/huggingface/datasets/pull/2290#issuecomment-831419599
https://api.github.com/repos/huggingface/datasets/issues/2290
MDEyOklzc3VlQ29tbWVudDgzMTQxOTU5OQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/831419599/reactions
2021-05-03T17:43:30Z
https://api.github.com/repos/huggingface/datasets/issues/comments/831419599
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
Reformatted with black.
2021-05-03T17:56:23Z
https://github.com/huggingface/datasets/pull/2290#issuecomment-831426899
https://api.github.com/repos/huggingface/datasets/issues/2290
MDEyOklzc3VlQ29tbWVudDgzMTQyNjg5OQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/831426899/reactions
2021-05-03T17:56:23Z
https://api.github.com/repos/huggingface/datasets/issues/comments/831426899
https://avatars.githubusercontent.com/u/54144149?v=4
https://api.github.com/users/phiwi/events{/privacy}
https://api.github.com/users/phiwi/followers
https://api.github.com/users/phiwi/following{/other_user}
https://api.github.com/users/phiwi/gists{/gist_id}
https://github.com/phiwi
phiwi
MDQ6VXNlcjU0MTQ0MTQ5
https://api.github.com/users/phiwi/orgs
https://api.github.com/users/phiwi/received_events
https://api.github.com/users/phiwi/repos
https://api.github.com/users/phiwi/starred{/owner}{/repo}
https://api.github.com/users/phiwi/subscriptions
User
https://api.github.com/users/phiwi
public
MEMBER
Hi @phiwi, there are still some minor problems in relation with the tags you used in the dataset card (README.md).

Here you can find the output of the metadata validator:
```
WARNING:root:❌ Failed to validate 'datasets/bbaw_egyptian/README.md':
Could not validate the metada, found the following errors:
* field 'size_categories':
	['100K<n<1000K'] are not registered tags for 'size_categories', reference at https://github.com/huggingface/datasets/tree/master/src/datasets/utils/resources/size_categories.json
* field 'task_ids':
	['machine translation'] are not registered tags for 'task_ids', reference at https://github.com/huggingface/datasets/tree/master/src/datasets/utils/resources/tasks.json
* field 'languages':
	['eg'] are not registered tags for 'languages', reference at https://github.com/huggingface/datasets/tree/master/src/datasets/utils/resources/languages.json

``` 
2021-05-05T07:18:58Z
https://github.com/huggingface/datasets/pull/2290#issuecomment-832470001
https://api.github.com/repos/huggingface/datasets/issues/2290
MDEyOklzc3VlQ29tbWVudDgzMjQ3MDAwMQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/832470001/reactions
2021-05-05T07:18:58Z
https://api.github.com/repos/huggingface/datasets/issues/comments/832470001
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
CONTRIBUTOR
@albertvillanova corrected :-)
2021-05-05T08:14:21Z
https://github.com/huggingface/datasets/pull/2290#issuecomment-832501956
https://api.github.com/repos/huggingface/datasets/issues/2290
MDEyOklzc3VlQ29tbWVudDgzMjUwMTk1Ng==
https://api.github.com/repos/huggingface/datasets/issues/comments/832501956/reactions
2021-05-05T08:14:21Z
https://api.github.com/repos/huggingface/datasets/issues/comments/832501956
https://avatars.githubusercontent.com/u/54144149?v=4
https://api.github.com/users/phiwi/events{/privacy}
https://api.github.com/users/phiwi/followers
https://api.github.com/users/phiwi/following{/other_user}
https://api.github.com/users/phiwi/gists{/gist_id}
https://github.com/phiwi
phiwi
MDQ6VXNlcjU0MTQ0MTQ5
https://api.github.com/users/phiwi/orgs
https://api.github.com/users/phiwi/received_events
https://api.github.com/users/phiwi/repos
https://api.github.com/users/phiwi/starred{/owner}{/repo}
https://api.github.com/users/phiwi/subscriptions
User
https://api.github.com/users/phiwi
public
MEMBER
Thanks, @phiwi. Now all tests should pass green.

However, I think there is still an issue with the language code:
- the code for the Ancient Egyptian is not `ar-EG`
- there is no ISO 639-1 code for the Ancient Egyptian
- there is an ISO 639-2 code: `egy`; but this code will not pass the validation test because it is not in the list of valid codes

I am not sure what to do in this case... Maybe @lhoestq has an idea? Maybe adding the code to the list? https://github.com/huggingface/datasets/blob/master/src/datasets/utils/resources/languages.json
2021-05-05T08:19:17Z
https://github.com/huggingface/datasets/pull/2290#issuecomment-832504857
https://api.github.com/repos/huggingface/datasets/issues/2290
MDEyOklzc3VlQ29tbWVudDgzMjUwNDg1Nw==
https://api.github.com/repos/huggingface/datasets/issues/comments/832504857/reactions
2021-05-05T08:21:18Z
https://api.github.com/repos/huggingface/datasets/issues/comments/832504857
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
MEMBER
I have just checked that in the [list of valid codes](https://github.com/huggingface/datasets/blob/master/src/datasets/utils/resources/languages.json) there are already ISO 639-2 codes. Therefore, I would suggest you to add it to the list:
```
"egy": "Egyptian (Ancient)",
```
and change it in the dataset card.
2021-05-05T08:25:59Z
https://github.com/huggingface/datasets/pull/2290#issuecomment-832508971
https://api.github.com/repos/huggingface/datasets/issues/2290
MDEyOklzc3VlQ29tbWVudDgzMjUwODk3MQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/832508971/reactions
2021-05-05T08:26:32Z
https://api.github.com/repos/huggingface/datasets/issues/comments/832508971
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
CONTRIBUTOR
Done.
2021-05-05T12:27:48Z
https://github.com/huggingface/datasets/pull/2290#issuecomment-832646910
https://api.github.com/repos/huggingface/datasets/issues/2290
MDEyOklzc3VlQ29tbWVudDgzMjY0NjkxMA==
https://api.github.com/repos/huggingface/datasets/issues/comments/832646910/reactions
2021-05-05T12:27:48Z
https://api.github.com/repos/huggingface/datasets/issues/comments/832646910
https://avatars.githubusercontent.com/u/54144149?v=4
https://api.github.com/users/phiwi/events{/privacy}
https://api.github.com/users/phiwi/followers
https://api.github.com/users/phiwi/following{/other_user}
https://api.github.com/users/phiwi/gists{/gist_id}
https://github.com/phiwi
phiwi
MDQ6VXNlcjU0MTQ0MTQ5
https://api.github.com/users/phiwi/orgs
https://api.github.com/users/phiwi/received_events
https://api.github.com/users/phiwi/repos
https://api.github.com/users/phiwi/starred{/owner}{/repo}
https://api.github.com/users/phiwi/subscriptions
User
https://api.github.com/users/phiwi
public
CONTRIBUTOR
Hope, everything is okay right now.
2021-05-06T09:33:01Z
https://github.com/huggingface/datasets/pull/2290#issuecomment-833383282
https://api.github.com/repos/huggingface/datasets/issues/2290
MDEyOklzc3VlQ29tbWVudDgzMzM4MzI4Mg==
https://api.github.com/repos/huggingface/datasets/issues/comments/833383282/reactions
2021-05-06T09:33:01Z
https://api.github.com/repos/huggingface/datasets/issues/comments/833383282
https://avatars.githubusercontent.com/u/54144149?v=4
https://api.github.com/users/phiwi/events{/privacy}
https://api.github.com/users/phiwi/followers
https://api.github.com/users/phiwi/following{/other_user}
https://api.github.com/users/phiwi/gists{/gist_id}
https://github.com/phiwi
phiwi
MDQ6VXNlcjU0MTQ0MTQ5
https://api.github.com/users/phiwi/orgs
https://api.github.com/users/phiwi/received_events
https://api.github.com/users/phiwi/repos
https://api.github.com/users/phiwi/starred{/owner}{/repo}
https://api.github.com/users/phiwi/subscriptions
User
https://api.github.com/users/phiwi
public
This is the "hieroglyph corpus" that I could unfortunately not contribute during the marathon. I re-extracted it again now, so that it is in the state as used in my paper (seee documentation). I hope it satiesfies your requirements and wish every scientist out their loads of fun deciphering a 5.000 years old language :-)