More faiss control
MEMBER
> Ok, so we're getting rid of the `FaissGpuOptions`?

We support `device=...` because it's simple, but faiss GPU options can be used in so many ways (you can set different gpu options for the different parts of your index for example) that it's probably better to let the user create and configure its index and then use `custom_index=...`
2020-07-08T17:09:09Z
https://github.com/huggingface/datasets/pull/354#issuecomment-655644679
https://api.github.com/repos/huggingface/datasets/issues/354
MDEyOklzc3VlQ29tbWVudDY1NTY0NDY3OQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/655644679/reactions
2020-07-08T17:09:09Z
https://api.github.com/repos/huggingface/datasets/issues/comments/655644679
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
Allow users to specify a faiss index they created themselves, as sometimes indexes can be composite for examples