Implement Dataset add_item
MEMBER
Thanks @lhoestq for your remarks. Yes, I agree there are still many issues to be tackled... This PR is just a starting point, so that we can discuss how Dataset should be generalized.
2021-02-15T08:58:56Z
https://github.com/huggingface/datasets/pull/1870#issuecomment-779068981
https://api.github.com/repos/huggingface/datasets/issues/1870
MDEyOklzc3VlQ29tbWVudDc3OTA2ODk4MQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/779068981/reactions
2021-02-15T08:58:56Z
https://api.github.com/repos/huggingface/datasets/issues/comments/779068981
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
MEMBER
Sure ! I opened an issue #1877 so we can discuss this specific aspect :)
2021-02-15T11:40:46Z
https://github.com/huggingface/datasets/pull/1870#issuecomment-779166453
https://api.github.com/repos/huggingface/datasets/issues/1870
MDEyOklzc3VlQ29tbWVudDc3OTE2NjQ1Mw==
https://api.github.com/repos/huggingface/datasets/issues/comments/779166453/reactions
2021-02-15T11:40:46Z
https://api.github.com/repos/huggingface/datasets/issues/comments/779166453
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
I am going to implement this consolidation step in #2151.
2021-04-01T13:58:12Z
https://github.com/huggingface/datasets/pull/1870#issuecomment-811927409
https://api.github.com/repos/huggingface/datasets/issues/1870
MDEyOklzc3VlQ29tbWVudDgxMTkyNzQwOQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/811927409/reactions
2021-04-01T13:58:12Z
https://api.github.com/repos/huggingface/datasets/issues/comments/811927409
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
MEMBER
Sounds good !
2021-04-01T13:59:26Z
https://github.com/huggingface/datasets/pull/1870#issuecomment-811928237
https://api.github.com/repos/huggingface/datasets/issues/1870
MDEyOklzc3VlQ29tbWVudDgxMTkyODIzNw==
https://api.github.com/repos/huggingface/datasets/issues/comments/811928237/reactions
2021-04-01T13:59:26Z
https://api.github.com/repos/huggingface/datasets/issues/comments/811928237
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
I retake this PR once the consolidation step is already implemented by #2151.
2021-04-20T09:36:09Z
https://github.com/huggingface/datasets/pull/1870#issuecomment-823133256
https://api.github.com/repos/huggingface/datasets/issues/1870
MDEyOklzc3VlQ29tbWVudDgyMzEzMzI1Ng==
https://api.github.com/repos/huggingface/datasets/issues/comments/823133256/reactions
2021-04-20T09:36:09Z
https://api.github.com/repos/huggingface/datasets/issues/comments/823133256
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
Implement `Dataset.add_item`.

Close #1854.