Refactor `string_to_dict` to return `None` if there is no match instead of raising `ValueError`
NONE
cc: @lhoestq 
2025-03-04T22:05:59Z
https://github.com/huggingface/datasets/pull/7435#issuecomment-2699051662
https://api.github.com/repos/huggingface/datasets/issues/7435
IC_kwDODunzps6g4EKO
https://api.github.com/repos/huggingface/datasets/issues/comments/2699051662/reactions
2025-03-04T22:05:59Z
https://api.github.com/repos/huggingface/datasets/issues/comments/2699051662
https://avatars.githubusercontent.com/u/27844407?v=4
https://api.github.com/users/ringohoffman/events{/privacy}
https://api.github.com/users/ringohoffman/followers
https://api.github.com/users/ringohoffman/following{/other_user}
https://api.github.com/users/ringohoffman/gists{/gist_id}
https://github.com/ringohoffman
ringohoffman
MDQ6VXNlcjI3ODQ0NDA3
https://api.github.com/users/ringohoffman/orgs
https://api.github.com/users/ringohoffman/received_events
https://api.github.com/users/ringohoffman/repos
https://api.github.com/users/ringohoffman/starred{/owner}{/repo}
https://api.github.com/users/ringohoffman/subscriptions
User
https://api.github.com/users/ringohoffman
public
NONE
I am going to rebase #7434 onto this branch. Then we can merge this one first if you approve, and then #7434.
2025-03-04T22:07:29Z
https://github.com/huggingface/datasets/pull/7435#issuecomment-2699054266
https://api.github.com/repos/huggingface/datasets/issues/7435
IC_kwDODunzps6g4Ey6
https://api.github.com/repos/huggingface/datasets/issues/comments/2699054266/reactions
2025-03-04T22:07:29Z
https://api.github.com/repos/huggingface/datasets/issues/comments/2699054266
https://avatars.githubusercontent.com/u/27844407?v=4
https://api.github.com/users/ringohoffman/events{/privacy}
https://api.github.com/users/ringohoffman/followers
https://api.github.com/users/ringohoffman/following{/other_user}
https://api.github.com/users/ringohoffman/gists{/gist_id}
https://github.com/ringohoffman
ringohoffman
MDQ6VXNlcjI3ODQ0NDA3
https://api.github.com/users/ringohoffman/orgs
https://api.github.com/users/ringohoffman/received_events
https://api.github.com/users/ringohoffman/repos
https://api.github.com/users/ringohoffman/starred{/owner}{/repo}
https://api.github.com/users/ringohoffman/subscriptions
User
https://api.github.com/users/ringohoffman
public
NONE
@lhoestq any thoughts here?
2025-03-06T09:40:20Z
https://github.com/huggingface/datasets/pull/7435#issuecomment-2703316391
https://api.github.com/repos/huggingface/datasets/issues/7435
IC_kwDODunzps6hIVWn
https://api.github.com/repos/huggingface/datasets/issues/comments/2703316391/reactions
2025-03-06T09:40:20Z
https://api.github.com/repos/huggingface/datasets/issues/comments/2703316391
https://avatars.githubusercontent.com/u/27844407?v=4
https://api.github.com/users/ringohoffman/events{/privacy}
https://api.github.com/users/ringohoffman/followers
https://api.github.com/users/ringohoffman/following{/other_user}
https://api.github.com/users/ringohoffman/gists{/gist_id}
https://github.com/ringohoffman
ringohoffman
MDQ6VXNlcjI3ODQ0NDA3
https://api.github.com/users/ringohoffman/orgs
https://api.github.com/users/ringohoffman/received_events
https://api.github.com/users/ringohoffman/repos
https://api.github.com/users/ringohoffman/starred{/owner}{/repo}
https://api.github.com/users/ringohoffman/subscriptions
User
https://api.github.com/users/ringohoffman
public
NONE
The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7435). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.
2025-03-07T14:14:22Z
https://github.com/huggingface/datasets/pull/7435#issuecomment-2706553202
https://api.github.com/repos/huggingface/datasets/issues/7435
IC_kwDODunzps6hUrly
https://api.github.com/repos/huggingface/datasets/issues/comments/2706553202/reactions
2025-03-07T14:14:22Z
https://api.github.com/repos/huggingface/datasets/issues/comments/2706553202
https://avatars.githubusercontent.com/u/99929124?v=4
https://api.github.com/users/HuggingFaceDocBuilderDev/events{/privacy}
https://api.github.com/users/HuggingFaceDocBuilderDev/followers
https://api.github.com/users/HuggingFaceDocBuilderDev/following{/other_user}
https://api.github.com/users/HuggingFaceDocBuilderDev/gists{/gist_id}
https://github.com/HuggingFaceDocBuilderDev
HuggingFaceDocBuilderDev
U_kgDOBfTMJA
https://api.github.com/users/HuggingFaceDocBuilderDev/orgs
https://api.github.com/users/HuggingFaceDocBuilderDev/received_events
https://api.github.com/users/HuggingFaceDocBuilderDev/repos
https://api.github.com/users/HuggingFaceDocBuilderDev/starred{/owner}{/repo}
https://api.github.com/users/HuggingFaceDocBuilderDev/subscriptions
User
https://api.github.com/users/HuggingFaceDocBuilderDev
public
NONE
It looks like I was unsafely asserting that `source_url_fields is not None` in `image.py`, `video.py` and `audio.py` (which did not correspond to the `except ValueError` like was there previously). I've changed it to handle `source_url_fields is None`.
2025-03-07T20:20:48Z
https://github.com/huggingface/datasets/pull/7435#issuecomment-2707346306
https://api.github.com/repos/huggingface/datasets/issues/7435
IC_kwDODunzps6hXtOC
https://api.github.com/repos/huggingface/datasets/issues/comments/2707346306/reactions
2025-03-07T20:20:59Z
https://api.github.com/repos/huggingface/datasets/issues/comments/2707346306
https://avatars.githubusercontent.com/u/27844407?v=4
https://api.github.com/users/ringohoffman/events{/privacy}
https://api.github.com/users/ringohoffman/followers
https://api.github.com/users/ringohoffman/following{/other_user}
https://api.github.com/users/ringohoffman/gists{/gist_id}
https://github.com/ringohoffman
ringohoffman
MDQ6VXNlcjI3ODQ0NDA3
https://api.github.com/users/ringohoffman/orgs
https://api.github.com/users/ringohoffman/received_events
https://api.github.com/users/ringohoffman/repos
https://api.github.com/users/ringohoffman/starred{/owner}{/repo}
https://api.github.com/users/ringohoffman/subscriptions
User
https://api.github.com/users/ringohoffman
public
NONE
Can we re-run CI on this one?
2025-03-10T08:57:01Z
https://github.com/huggingface/datasets/pull/7435#issuecomment-2709852063
https://api.github.com/repos/huggingface/datasets/issues/7435
IC_kwDODunzps6hhQ-f
https://api.github.com/repos/huggingface/datasets/issues/comments/2709852063/reactions
2025-03-10T08:57:01Z
https://api.github.com/repos/huggingface/datasets/issues/comments/2709852063
https://avatars.githubusercontent.com/u/27844407?v=4
https://api.github.com/users/ringohoffman/events{/privacy}
https://api.github.com/users/ringohoffman/followers
https://api.github.com/users/ringohoffman/following{/other_user}
https://api.github.com/users/ringohoffman/gists{/gist_id}
https://github.com/ringohoffman
ringohoffman
MDQ6VXNlcjI3ODQ0NDA3
https://api.github.com/users/ringohoffman/orgs
https://api.github.com/users/ringohoffman/received_events
https://api.github.com/users/ringohoffman/repos
https://api.github.com/users/ringohoffman/starred{/owner}{/repo}
https://api.github.com/users/ringohoffman/subscriptions
User
https://api.github.com/users/ringohoffman
public
NONE
Sweet! These failures are looking spurious due to connectivity issues. Can the failing run be retried?
2025-03-10T16:27:37Z
https://github.com/huggingface/datasets/pull/7435#issuecomment-2711160745
https://api.github.com/repos/huggingface/datasets/issues/7435
IC_kwDODunzps6hmQep
https://api.github.com/repos/huggingface/datasets/issues/comments/2711160745/reactions
2025-03-10T16:27:37Z
https://api.github.com/repos/huggingface/datasets/issues/comments/2711160745
https://avatars.githubusercontent.com/u/27844407?v=4
https://api.github.com/users/ringohoffman/events{/privacy}
https://api.github.com/users/ringohoffman/followers
https://api.github.com/users/ringohoffman/following{/other_user}
https://api.github.com/users/ringohoffman/gists{/gist_id}
https://github.com/ringohoffman
ringohoffman
MDQ6VXNlcjI3ODQ0NDA3
https://api.github.com/users/ringohoffman/orgs
https://api.github.com/users/ringohoffman/received_events
https://api.github.com/users/ringohoffman/repos
https://api.github.com/users/ringohoffman/starred{/owner}{/repo}
https://api.github.com/users/ringohoffman/subscriptions
User
https://api.github.com/users/ringohoffman
public
NONE
@lhoestq Sorry to double ping, but can this PR be reviewed? I think it is ready!

2025-03-11T12:37:04Z
https://github.com/huggingface/datasets/pull/7435#issuecomment-2714023858
https://api.github.com/repos/huggingface/datasets/issues/7435
IC_kwDODunzps6hxLey
https://api.github.com/repos/huggingface/datasets/issues/comments/2714023858/reactions
2025-03-11T12:37:04Z
https://api.github.com/repos/huggingface/datasets/issues/comments/2714023858
https://avatars.githubusercontent.com/u/27844407?v=4
https://api.github.com/users/ringohoffman/events{/privacy}
https://api.github.com/users/ringohoffman/followers
https://api.github.com/users/ringohoffman/following{/other_user}
https://api.github.com/users/ringohoffman/gists{/gist_id}
https://github.com/ringohoffman
ringohoffman
MDQ6VXNlcjI3ODQ0NDA3
https://api.github.com/users/ringohoffman/orgs
https://api.github.com/users/ringohoffman/received_events
https://api.github.com/users/ringohoffman/repos
https://api.github.com/users/ringohoffman/starred{/owner}{/repo}
https://api.github.com/users/ringohoffman/subscriptions
User
https://api.github.com/users/ringohoffman
public
Making this change, as encouraged here:

* https://github.com/huggingface/datasets/pull/7434#discussion_r1979933054

instead of having the pattern of using `try`-`except` to handle when there is no match, we can instead check if the return value is `None`; we can also assert that the return value should not be `None` if we know that should be true