Fake news english 4
CONTRIBUTOR
Thanks for the PR @MisbahKhan789 !

Few comments to help you along (I'm NOT a maintainer, just offering help to unblock the process) :-
 - Could you re-run `make style` and fix the errors related to code quality specific to your dataset in the `datasets/fake_news_english` folder?
(These seem to show errors that need manual fixes on running `flake8 datasets/fake_news_english`)
- Please run the local tests and check if they pass
`RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_real_dataset_<your-dataset-name>`
 `RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_<your-dataset-name>`
(If not, you may have to regenerate the dummy data and the `dataset_infos.json` files)


2020-12-12T18:11:21Z
https://github.com/huggingface/datasets/pull/1489#issuecomment-743794286
https://api.github.com/repos/huggingface/datasets/issues/1489
MDEyOklzc3VlQ29tbWVudDc0Mzc5NDI4Ng==
https://api.github.com/repos/huggingface/datasets/issues/comments/743794286/reactions
2020-12-12T18:11:21Z
https://api.github.com/repos/huggingface/datasets/issues/comments/743794286
https://avatars.githubusercontent.com/u/13381361?v=4
https://api.github.com/users/bharatr21/events{/privacy}
https://api.github.com/users/bharatr21/followers
https://api.github.com/users/bharatr21/following{/other_user}
https://api.github.com/users/bharatr21/gists{/gist_id}
https://github.com/bharatr21
bharatr21
MDQ6VXNlcjEzMzgxMzYx
https://api.github.com/users/bharatr21/orgs
https://api.github.com/users/bharatr21/received_events
https://api.github.com/users/bharatr21/repos
https://api.github.com/users/bharatr21/starred{/owner}{/repo}
https://api.github.com/users/bharatr21/subscriptions
User
https://api.github.com/users/bharatr21
public
NONE
Hii please follow me
2020-12-12T19:34:32Z
https://github.com/huggingface/datasets/pull/1489#issuecomment-743805055
https://api.github.com/repos/huggingface/datasets/issues/1489
MDEyOklzc3VlQ29tbWVudDc0MzgwNTA1NQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/743805055/reactions
2020-12-12T19:34:32Z
https://api.github.com/repos/huggingface/datasets/issues/comments/743805055
https://avatars.githubusercontent.com/u/67163272?v=4
https://api.github.com/users/ijaz314/events{/privacy}
https://api.github.com/users/ijaz314/followers
https://api.github.com/users/ijaz314/following{/other_user}
https://api.github.com/users/ijaz314/gists{/gist_id}
https://github.com/ijaz314
ijaz314
MDQ6VXNlcjY3MTYzMjcy
https://api.github.com/users/ijaz314/orgs
https://api.github.com/users/ijaz314/received_events
https://api.github.com/users/ijaz314/repos
https://api.github.com/users/ijaz314/starred{/owner}{/repo}
https://api.github.com/users/ijaz314/subscriptions
User
https://api.github.com/users/ijaz314
public
CONTRIBUTOR
> Thanks for the PR @MisbahKhan789 !
> 
> Few comments to help you along (I'm NOT a maintainer, just offering help to unblock the process) :-
> 
> * Could you re-run `make style` and fix the errors related to code quality specific to your dataset in the `datasets/fake_news_english` folder?
>   (These seem to show errors that need manual fixes on running `flake8 datasets/fake_news_english`)
> * Please run the local tests and check if they pass
>   `RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_real_dataset_<your-dataset-name>`
>   `RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_<your-dataset-name>`
>   (If not, you may have to regenerate the dummy data and the `dataset_infos.json` files)

Hey Bharat, thanks for the reply. I actually submitted a new PR with the changes that are required :)

2020-12-12T19:39:52Z
https://github.com/huggingface/datasets/pull/1489#issuecomment-743805687
https://api.github.com/repos/huggingface/datasets/issues/1489
MDEyOklzc3VlQ29tbWVudDc0MzgwNTY4Nw==
https://api.github.com/repos/huggingface/datasets/issues/comments/743805687/reactions
2020-12-12T19:39:52Z
https://api.github.com/repos/huggingface/datasets/issues/comments/743805687
https://avatars.githubusercontent.com/u/15351802?v=4
https://api.github.com/users/MisbahKhan789/events{/privacy}
https://api.github.com/users/MisbahKhan789/followers
https://api.github.com/users/MisbahKhan789/following{/other_user}
https://api.github.com/users/MisbahKhan789/gists{/gist_id}
https://github.com/MisbahKhan789
MisbahKhan789
MDQ6VXNlcjE1MzUxODAy
https://api.github.com/users/MisbahKhan789/orgs
https://api.github.com/users/MisbahKhan789/received_events
https://api.github.com/users/MisbahKhan789/repos
https://api.github.com/users/MisbahKhan789/starred{/owner}{/repo}
https://api.github.com/users/MisbahKhan789/subscriptions
User
https://api.github.com/users/MisbahKhan789
public