Docs are not generated after latest release
MEMBER
After a discussion with @mishig25:
- He said that this action should be triggered if we call our release branch according to the regex `v*-release`, as transformers does
- I said that our procedure is different: our release branch is *temporary* and it is deleted just after the release PR is merged to main
  - Indeed the release tag is not yet created when we make the release PR (not event when this is merged to main), but when we make the Release itself.

I was thinking that maybe we could change the triggering event: use `release` instead of `push`.

What do you think, @huggingface/datasets?
2022-11-16T15:28:02Z
https://github.com/huggingface/datasets/issues/5251#issuecomment-1317200279
https://api.github.com/repos/huggingface/datasets/issues/5251
IC_kwDODunzps5OguGX
https://api.github.com/repos/huggingface/datasets/issues/comments/1317200279/reactions
2022-11-16T15:29:26Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1317200279
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
MEMBER
Why is it an issue if our branch is temporary ?
2022-11-16T15:29:50Z
https://github.com/huggingface/datasets/issues/5251#issuecomment-1317203128
https://api.github.com/repos/huggingface/datasets/issues/5251
IC_kwDODunzps5Oguy4
https://api.github.com/repos/huggingface/datasets/issues/comments/1317203128/reactions
2022-11-16T15:29:50Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1317203128
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
He says not; but the branch has no tag yet; does the doc building require the tag? Or just the version number in `__init__.py` or setup.py?
2022-11-16T15:31:33Z
https://github.com/huggingface/datasets/issues/5251#issuecomment-1317205793
https://api.github.com/repos/huggingface/datasets/issues/5251
IC_kwDODunzps5Ogvch
https://api.github.com/repos/huggingface/datasets/issues/comments/1317205793/reactions
2022-11-16T15:31:53Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1317205793
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
MEMBER
It uses `module.__version__` (i.e. the one defined in `__init__.py`) - no need to have a tag

https://github.com/huggingface/doc-builder/blob/81575cf081964c30ea5fd39450f4820db963f18e/src/doc_builder/commands/build.py#L69
2022-11-16T16:02:05Z
https://github.com/huggingface/datasets/issues/5251#issuecomment-1317252480
https://api.github.com/repos/huggingface/datasets/issues/5251
IC_kwDODunzps5Og62A
https://api.github.com/repos/huggingface/datasets/issues/comments/1317252480/reactions
2022-11-16T16:02:39Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1317252480
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
Thanks, @lhoestq.

@mishig25 has manually forced the generation of the docs, that are live for 2.7.0 version: https://huggingface.co/docs/datasets/v2.7.0/en/index 
2022-11-16T16:08:35Z
https://github.com/huggingface/datasets/issues/5251#issuecomment-1317265262
https://api.github.com/repos/huggingface/datasets/issues/5251
IC_kwDODunzps5Og99u
https://api.github.com/repos/huggingface/datasets/issues/comments/1317265262/reactions
2022-11-16T16:08:35Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1317265262
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
MEMBER
Cool ! this can be closed then ?
2022-11-18T14:31:29Z
https://github.com/huggingface/datasets/issues/5251#issuecomment-1320072784
https://api.github.com/repos/huggingface/datasets/issues/5251
IC_kwDODunzps5OrrZQ
https://api.github.com/repos/huggingface/datasets/issues/comments/1320072784/reactions
2022-11-18T14:31:29Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1320072784
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
I was waiting for #5250 to be merged to close this.
2022-11-18T15:11:49Z
https://github.com/huggingface/datasets/issues/5251#issuecomment-1320156726
https://api.github.com/repos/huggingface/datasets/issues/5251
IC_kwDODunzps5Or_42
https://api.github.com/repos/huggingface/datasets/issues/comments/1320156726/reactions
2022-11-18T15:11:49Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1320156726
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
NONE
just to confirm, is there anything I need to do from my side ? Or is everything good here ?
2022-11-21T08:44:20Z
https://github.com/huggingface/datasets/issues/5251#issuecomment-1321702632
https://api.github.com/repos/huggingface/datasets/issues/5251
IC_kwDODunzps5Ox5To
https://api.github.com/repos/huggingface/datasets/issues/comments/1321702632/reactions
2022-11-21T08:44:20Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1321702632
https://avatars.githubusercontent.com/u/11827707?v=4
https://api.github.com/users/mishig25/events{/privacy}
https://api.github.com/users/mishig25/followers
https://api.github.com/users/mishig25/following{/other_user}
https://api.github.com/users/mishig25/gists{/gist_id}
https://github.com/mishig25
mishig25
MDQ6VXNlcjExODI3NzA3
https://api.github.com/users/mishig25/orgs
https://api.github.com/users/mishig25/received_events
https://api.github.com/users/mishig25/repos
https://api.github.com/users/mishig25/starred{/owner}{/repo}
https://api.github.com/users/mishig25/subscriptions
User
https://api.github.com/users/mishig25
public
After the latest `datasets` release version 0.7.0, the docs were not generated.

As we have changed the release procedure (so that now we do not push directly to main branch), maybe we should also change the corresponding GitHub action:

https://github.com/huggingface/datasets/blob/edf1902f954c5568daadebcd8754bdad44b02a85/.github/workflows/build_documentation.yml#L3-L8

Related to:
- #5250

CC: @mishig25 