SciFact dataset - minor changes
CONTRIBUTOR
Hi Dave,
You are more than welcome to open a PR to make these changes! 🤗
You will find the relevant information about opening a PR in the [contributing guide](https://github.com/huggingface/datasets/blob/master/CONTRIBUTING.md) and in the [dataset addition guide](https://github.com/huggingface/datasets/blob/master/ADD_NEW_DATASET.md).

Pinging also @lhoestq for the Google cloud matter.
2021-01-12T10:38:23Z
https://github.com/huggingface/datasets/issues/1717#issuecomment-758567009
https://api.github.com/repos/huggingface/datasets/issues/1717
MDEyOklzc3VlQ29tbWVudDc1ODU2NzAwOQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/758567009/reactions
2021-01-12T10:38:23Z
https://api.github.com/repos/huggingface/datasets/issues/comments/758567009
https://avatars.githubusercontent.com/u/33657802?v=4
https://api.github.com/users/SBrandeis/events{/privacy}
https://api.github.com/users/SBrandeis/followers
https://api.github.com/users/SBrandeis/following{/other_user}
https://api.github.com/users/SBrandeis/gists{/gist_id}
https://github.com/SBrandeis
SBrandeis
MDQ6VXNlcjMzNjU3ODAy
https://api.github.com/users/SBrandeis/orgs
https://api.github.com/users/SBrandeis/received_events
https://api.github.com/users/SBrandeis/repos
https://api.github.com/users/SBrandeis/starred{/owner}{/repo}
https://api.github.com/users/SBrandeis/subscriptions
User
https://api.github.com/users/SBrandeis
public
MEMBER
> I'd like to make a few minor changes, including the citation information and the `_URL` from which to download the dataset. Can I submit a PR for this?

Sure ! Also feel free to ping us for reviews or if we can help :)

> It also looks like the dataset is being downloaded directly from Huggingface's Google cloud account rather than via the `_URL` in [scifact.py](https://github.com/huggingface/datasets/blob/master/datasets/scifact/scifact.py). Can you help me update the version on gcloud?

What makes you think that ?
Afaik there's no scifact on our google storage

2021-01-13T11:05:03Z
https://github.com/huggingface/datasets/issues/1717#issuecomment-759376547
https://api.github.com/repos/huggingface/datasets/issues/1717
MDEyOklzc3VlQ29tbWVudDc1OTM3NjU0Nw==
https://api.github.com/repos/huggingface/datasets/issues/comments/759376547/reactions
2021-01-13T11:05:03Z
https://api.github.com/repos/huggingface/datasets/issues/comments/759376547
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR


> > I'd like to make a few minor changes, including the citation information and the `_URL` from which to download the dataset. Can I submit a PR for this?
> 
> Sure ! Also feel free to ping us for reviews or if we can help :)
> 
OK! We're organizing a [shared task](https://sdproc.org/2021/sharedtasks.html#sciver) based on the dataset, and I made some updates and changed the download URL - so the current code points to a dead URL. I'll update appropriately once the task is finalized and make a PR.

> > It also looks like the dataset is being downloaded directly from Huggingface's Google cloud account rather than via the `_URL` in [scifact.py](https://github.com/huggingface/datasets/blob/master/datasets/scifact/scifact.py). Can you help me update the version on gcloud?
> 
> What makes you think that ?
> Afaik there's no scifact on our google storage

You're right, I had the data cached on my machine somewhere. 


2021-01-14T01:41:44Z
https://github.com/huggingface/datasets/issues/1717#issuecomment-759868414
https://api.github.com/repos/huggingface/datasets/issues/1717
MDEyOklzc3VlQ29tbWVudDc1OTg2ODQxNA==
https://api.github.com/repos/huggingface/datasets/issues/comments/759868414/reactions
2021-01-14T01:42:10Z
https://api.github.com/repos/huggingface/datasets/issues/comments/759868414
https://avatars.githubusercontent.com/u/3091916?v=4
https://api.github.com/users/dwadden/events{/privacy}
https://api.github.com/users/dwadden/followers
https://api.github.com/users/dwadden/following{/other_user}
https://api.github.com/users/dwadden/gists{/gist_id}
https://github.com/dwadden
dwadden
MDQ6VXNlcjMwOTE5MTY=
https://api.github.com/users/dwadden/orgs
https://api.github.com/users/dwadden/received_events
https://api.github.com/users/dwadden/repos
https://api.github.com/users/dwadden/starred{/owner}{/repo}
https://api.github.com/users/dwadden/subscriptions
User
https://api.github.com/users/dwadden
public
CONTRIBUTOR
I opened a PR about this: https://github.com/huggingface/datasets/pull/1780. Closing this issue, will continue there.
2021-01-26T02:52:17Z
https://github.com/huggingface/datasets/issues/1717#issuecomment-767253541
https://api.github.com/repos/huggingface/datasets/issues/1717
MDEyOklzc3VlQ29tbWVudDc2NzI1MzU0MQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/767253541/reactions
2021-01-26T02:52:17Z
https://api.github.com/repos/huggingface/datasets/issues/comments/767253541
https://avatars.githubusercontent.com/u/3091916?v=4
https://api.github.com/users/dwadden/events{/privacy}
https://api.github.com/users/dwadden/followers
https://api.github.com/users/dwadden/following{/other_user}
https://api.github.com/users/dwadden/gists{/gist_id}
https://github.com/dwadden
dwadden
MDQ6VXNlcjMwOTE5MTY=
https://api.github.com/users/dwadden/orgs
https://api.github.com/users/dwadden/received_events
https://api.github.com/users/dwadden/repos
https://api.github.com/users/dwadden/starred{/owner}{/repo}
https://api.github.com/users/dwadden/subscriptions
User
https://api.github.com/users/dwadden
public
Hi,

SciFact dataset creator here. First of all, thanks for adding the dataset to Huggingface, much appreciated!

I'd like to make a few minor changes, including the citation information and the `_URL` from which to download the dataset. Can I submit a PR for this?

It also looks like the dataset is being downloaded directly from Huggingface's Google cloud account rather than via the `_URL` in [scifact.py](https://github.com/huggingface/datasets/blob/master/datasets/scifact/scifact.py). Can you help me update the version on gcloud?

Thanks,

Dave