Dataset BnL Historical Newspapers does not work in streaming mode
MEMBER
@albertvillanova let me know if there is anything I can do to help with this. I had a quick look at the code again and though I could try the following changes:
- use `download` instead of `download_and_extract`
https://github.com/huggingface/datasets/blob/d3d339fb86d378f4cb3c5d1de423315c07a466c6/datasets/bnl_newspapers/bnl_newspapers.py#L136
- swith to using `iter_archive` to loop through downloaded data to replace
https://github.com/huggingface/datasets/blob/d3d339fb86d378f4cb3c5d1de423315c07a466c6/datasets/bnl_newspapers/bnl_newspapers.py#L159

Let me know if it's useful for me to try and make those changes. 
2022-01-22T14:23:26Z
https://github.com/huggingface/datasets/issues/3615#issuecomment-1019279991
https://api.github.com/repos/huggingface/datasets/issues/3615
IC_kwDODunzps48wPp3
https://api.github.com/repos/huggingface/datasets/issues/comments/1019279991/reactions
2022-01-22T14:23:26Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1019279991
https://avatars.githubusercontent.com/u/8995957?v=4
https://api.github.com/users/davanstrien/events{/privacy}
https://api.github.com/users/davanstrien/followers
https://api.github.com/users/davanstrien/following{/other_user}
https://api.github.com/users/davanstrien/gists{/gist_id}
https://github.com/davanstrien
davanstrien
MDQ6VXNlcjg5OTU5NTc=
https://api.github.com/users/davanstrien/orgs
https://api.github.com/users/davanstrien/received_events
https://api.github.com/users/davanstrien/repos
https://api.github.com/users/davanstrien/starred{/owner}{/repo}
https://api.github.com/users/davanstrien/subscriptions
User
https://api.github.com/users/davanstrien
public
MEMBER
Thanks @davanstrien.

I have already been working on it so that it can be used in the BigScience workshop.

I agree that the `rglob()` is not efficient in this case.

I tried different solutions without success:
- `iter_archive` cannot be used in this case because it does not support ZIP files yet

Finally I have used `iter_files()`.
2022-01-22T14:51:29Z
https://github.com/huggingface/datasets/issues/3615#issuecomment-1019285228
https://api.github.com/repos/huggingface/datasets/issues/3615
IC_kwDODunzps48wQ7s
https://api.github.com/repos/huggingface/datasets/issues/comments/1019285228/reactions
2022-01-22T14:52:23Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1019285228
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
MEMBER
I see this is fixed now 🙂.  I also picked up a few other tips from your redactors so hopefully my next attempts will support streaming from the start. 
2022-01-22T16:47:46Z
https://github.com/huggingface/datasets/issues/3615#issuecomment-1019306944
https://api.github.com/repos/huggingface/datasets/issues/3615
IC_kwDODunzps48wWPA
https://api.github.com/repos/huggingface/datasets/issues/comments/1019306944/reactions
2022-01-22T16:47:46Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1019306944
https://avatars.githubusercontent.com/u/8995957?v=4
https://api.github.com/users/davanstrien/events{/privacy}
https://api.github.com/users/davanstrien/followers
https://api.github.com/users/davanstrien/following{/other_user}
https://api.github.com/users/davanstrien/gists{/gist_id}
https://github.com/davanstrien
davanstrien
MDQ6VXNlcjg5OTU5NTc=
https://api.github.com/users/davanstrien/orgs
https://api.github.com/users/davanstrien/received_events
https://api.github.com/users/davanstrien/repos
https://api.github.com/users/davanstrien/starred{/owner}{/repo}
https://api.github.com/users/davanstrien/subscriptions
User
https://api.github.com/users/davanstrien
public
## Describe the bug
When trying to load in streaming mode, it "hangs"...

## Steps to reproduce the bug
```python
ds = load_dataset("bnl_newspapers", split="train", streaming=True)
```

## Expected results
The code should be optimized, so that it works fast in streaming mode.

CC: @davanstrien 
