Fix `tqdm` zip bug
CONTRIBUTOR
@albertvillanova Thanks for your comment. What do you think about creating 2 `pbar` for each case? I see the `pbar_iterable` is initialized differently. Maybe `pbar` can also be initialized like that.
2022-10-17T20:59:53Z
https://github.com/huggingface/datasets/pull/5120#issuecomment-1281487887
https://api.github.com/repos/huggingface/datasets/issues/5120
IC_kwDODunzps5MYfQP
https://api.github.com/repos/huggingface/datasets/issues/comments/1281487887/reactions
2022-10-17T20:59:53Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1281487887
https://avatars.githubusercontent.com/u/9879252?v=4
https://api.github.com/users/david1542/events{/privacy}
https://api.github.com/users/david1542/followers
https://api.github.com/users/david1542/following{/other_user}
https://api.github.com/users/david1542/gists{/gist_id}
https://github.com/david1542
david1542
MDQ6VXNlcjk4NzkyNTI=
https://api.github.com/users/david1542/orgs
https://api.github.com/users/david1542/received_events
https://api.github.com/users/david1542/repos
https://api.github.com/users/david1542/starred{/owner}{/repo}
https://api.github.com/users/david1542/subscriptions
User
https://api.github.com/users/david1542
public
CONTRIBUTOR
@albertvillanova Another solution I implemented is to change `pbar_iterable` and add the `zip` to it. I updated the PR with this solution. Let me know what you think.
2022-10-17T21:05:18Z
https://github.com/huggingface/datasets/pull/5120#issuecomment-1281493399
https://api.github.com/repos/huggingface/datasets/issues/5120
IC_kwDODunzps5MYgmX
https://api.github.com/repos/huggingface/datasets/issues/comments/1281493399/reactions
2022-10-17T21:05:18Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1281493399
https://avatars.githubusercontent.com/u/9879252?v=4
https://api.github.com/users/david1542/events{/privacy}
https://api.github.com/users/david1542/followers
https://api.github.com/users/david1542/following{/other_user}
https://api.github.com/users/david1542/gists{/gist_id}
https://github.com/david1542
david1542
MDQ6VXNlcjk4NzkyNTI=
https://api.github.com/users/david1542/orgs
https://api.github.com/users/david1542/received_events
https://api.github.com/users/david1542/repos
https://api.github.com/users/david1542/starred{/owner}{/repo}
https://api.github.com/users/david1542/subscriptions
User
https://api.github.com/users/david1542
public
NONE
_The documentation is not available anymore as the PR was closed or merged._
2022-10-18T08:29:54Z
https://github.com/huggingface/datasets/pull/5120#issuecomment-1282008948
https://api.github.com/repos/huggingface/datasets/issues/5120
IC_kwDODunzps5Maed0
https://api.github.com/repos/huggingface/datasets/issues/comments/1282008948/reactions
2022-10-19T08:55:37Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1282008948
https://avatars.githubusercontent.com/u/99929124?v=4
https://api.github.com/users/HuggingFaceDocBuilderDev/events{/privacy}
https://api.github.com/users/HuggingFaceDocBuilderDev/followers
https://api.github.com/users/HuggingFaceDocBuilderDev/following{/other_user}
https://api.github.com/users/HuggingFaceDocBuilderDev/gists{/gist_id}
https://github.com/HuggingFaceDocBuilderDev
HuggingFaceDocBuilderDev
U_kgDOBfTMJA
https://api.github.com/users/HuggingFaceDocBuilderDev/orgs
https://api.github.com/users/HuggingFaceDocBuilderDev/received_events
https://api.github.com/users/HuggingFaceDocBuilderDev/repos
https://api.github.com/users/HuggingFaceDocBuilderDev/starred{/owner}{/repo}
https://api.github.com/users/HuggingFaceDocBuilderDev/subscriptions
User
https://api.github.com/users/HuggingFaceDocBuilderDev
public
NONE
@albertvillanova Done :) Let me know what you think.
2022-10-18T09:01:07Z
https://github.com/huggingface/datasets/pull/5120#issuecomment-1282050891
https://api.github.com/repos/huggingface/datasets/issues/5120
IC_kwDODunzps5MaotL
https://api.github.com/repos/huggingface/datasets/issues/comments/1282050891/reactions
2022-10-18T09:01:07Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1282050891
https://avatars.githubusercontent.com/u/74605177?v=4
https://api.github.com/users/dudulasry/events{/privacy}
https://api.github.com/users/dudulasry/followers
https://api.github.com/users/dudulasry/following{/other_user}
https://api.github.com/users/dudulasry/gists{/gist_id}
https://github.com/dudulasry
dudulasry
MDQ6VXNlcjc0NjA1MTc3
https://api.github.com/users/dudulasry/orgs
https://api.github.com/users/dudulasry/received_events
https://api.github.com/users/dudulasry/repos
https://api.github.com/users/dudulasry/starred{/owner}{/repo}
https://api.github.com/users/dudulasry/subscriptions
User
https://api.github.com/users/dudulasry
public
CONTRIBUTOR
@albertvillanova Thanks :) I also don't see an easy way to test this. This was just a problem in the way `tqdm` was used. I'm not sure we should cover it in tests.
2022-10-18T22:25:13Z
https://github.com/huggingface/datasets/pull/5120#issuecomment-1283077762
https://api.github.com/repos/huggingface/datasets/issues/5120
IC_kwDODunzps5MejaC
https://api.github.com/repos/huggingface/datasets/issues/comments/1283077762/reactions
2022-10-18T22:25:13Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1283077762
https://avatars.githubusercontent.com/u/9879252?v=4
https://api.github.com/users/david1542/events{/privacy}
https://api.github.com/users/david1542/followers
https://api.github.com/users/david1542/following{/other_user}
https://api.github.com/users/david1542/gists{/gist_id}
https://github.com/david1542
david1542
MDQ6VXNlcjk4NzkyNTI=
https://api.github.com/users/david1542/orgs
https://api.github.com/users/david1542/received_events
https://api.github.com/users/david1542/repos
https://api.github.com/users/david1542/starred{/owner}{/repo}
https://api.github.com/users/david1542/subscriptions
User
https://api.github.com/users/david1542
public
NONE
Hi, 

First of all, thanks for this PR. 
It's the first time I join a discussion on GitHUB on problem resolution in libraries such as transformers, so I hope I comply to the best practices for an efficient communication...

I am running `AutoTokenizer.from_pretrained` in a Google Colab notebook for using with BERT base. 
I am experiencing issue [5117](https://github.com/huggingface/datasets/issues/5117).

Each time I run my notebook, I do:

`! pip install transformers 
! pip install datasets 
! pip install huggingface_hub`

As I understand, the issue has been resolved and the solution merged to the released version of the code?
So I expect that the bug is resolved in my notebook, however this is not the case.

Do I get something wrong? 
Do I have to implement some change in the source code myself?

Thanks in advance for your help!
2022-10-22T22:04:01Z
https://github.com/huggingface/datasets/pull/5120#issuecomment-1287929662
https://api.github.com/repos/huggingface/datasets/issues/5120
IC_kwDODunzps5MxD8-
https://api.github.com/repos/huggingface/datasets/issues/comments/1287929662/reactions
2022-10-22T22:04:01Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1287929662
https://avatars.githubusercontent.com/u/97918270?v=4
https://api.github.com/users/Cochonaki/events{/privacy}
https://api.github.com/users/Cochonaki/followers
https://api.github.com/users/Cochonaki/following{/other_user}
https://api.github.com/users/Cochonaki/gists{/gist_id}
https://github.com/Cochonaki
Cochonaki
U_kgDOBdYdPg
https://api.github.com/users/Cochonaki/orgs
https://api.github.com/users/Cochonaki/received_events
https://api.github.com/users/Cochonaki/repos
https://api.github.com/users/Cochonaki/starred{/owner}{/repo}
https://api.github.com/users/Cochonaki/subscriptions
User
https://api.github.com/users/Cochonaki
public
CONTRIBUTOR
@Cochonaki Hi :) The problem was fixed but there wasn't a release since then. I believe a new release should come out in the upcoming weeks. Maybe someone from the core maintainers can answer that :)

cc: @albertvillanova 
2022-10-23T06:39:00Z
https://github.com/huggingface/datasets/pull/5120#issuecomment-1288024546
https://api.github.com/repos/huggingface/datasets/issues/5120
IC_kwDODunzps5MxbHi
https://api.github.com/repos/huggingface/datasets/issues/comments/1288024546/reactions
2022-10-23T06:39:00Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1288024546
https://avatars.githubusercontent.com/u/9879252?v=4
https://api.github.com/users/david1542/events{/privacy}
https://api.github.com/users/david1542/followers
https://api.github.com/users/david1542/following{/other_user}
https://api.github.com/users/david1542/gists{/gist_id}
https://github.com/david1542
david1542
MDQ6VXNlcjk4NzkyNTI=
https://api.github.com/users/david1542/orgs
https://api.github.com/users/david1542/received_events
https://api.github.com/users/david1542/repos
https://api.github.com/users/david1542/starred{/owner}{/repo}
https://api.github.com/users/david1542/subscriptions
User
https://api.github.com/users/david1542
public
NONE
Baby Haiti Coffee SE is born

NH watch

On Sun, Oct 23, 2022 at 02:39 Dudu Lasry ***@***.***> wrote:

> @Cochonaki <https://github.com/Cochonaki> Hi :) The problem was fixed but
> there wasn't a release since then. I believe a new release should come out
> in the upcoming weeks. Maybe someone from the core maintainers can answer
> that :)
>
> cc: @albertvillanova <https://github.com/albertvillanova>
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/huggingface/datasets/pull/5120#issuecomment-1288024546>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAB4E2NCT7QO7W3PTQGDIKDWETMQ7ANCNFSM6AAAAAARGRBY2M>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>

2022-10-23T06:39:56Z
https://github.com/huggingface/datasets/pull/5120#issuecomment-1288024801
https://api.github.com/repos/huggingface/datasets/issues/5120
IC_kwDODunzps5MxbLh
https://api.github.com/repos/huggingface/datasets/issues/comments/1288024801/reactions
2022-10-23T06:39:56Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1288024801
https://avatars.githubusercontent.com/u/246377?v=4
https://api.github.com/users/armw4/events{/privacy}
https://api.github.com/users/armw4/followers
https://api.github.com/users/armw4/following{/other_user}
https://api.github.com/users/armw4/gists{/gist_id}
https://github.com/armw4
armw4
MDQ6VXNlcjI0NjM3Nw==
https://api.github.com/users/armw4/orgs
https://api.github.com/users/armw4/received_events
https://api.github.com/users/armw4/repos
https://api.github.com/users/armw4/starred{/owner}{/repo}
https://api.github.com/users/armw4/subscriptions
User
https://api.github.com/users/armw4
public
MEMBER
Hi, @Cochonaki.

As @david1542 pointed out, we have not made a release since this bug was fixed. We will make one in the following weeks.

In the meantime, if you would like to incorporate the bug fix, you can install `datasets` from this repo main branch:
```shell
pip install git+https://github.com/huggingface/datasets#egg=datasets
```
2022-10-23T07:43:08Z
https://github.com/huggingface/datasets/pull/5120#issuecomment-1288041389
https://api.github.com/repos/huggingface/datasets/issues/5120
IC_kwDODunzps5MxfOt
https://api.github.com/repos/huggingface/datasets/issues/comments/1288041389/reactions
2022-10-23T07:43:08Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1288041389
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
NONE
Thanks a lot @albertvillanova and @david1542, it works now!
I am really thankful for your help, that encourages me to participate more in this community.
See you around!
2022-10-23T10:22:37Z
https://github.com/huggingface/datasets/pull/5120#issuecomment-1288080041
https://api.github.com/repos/huggingface/datasets/issues/5120
IC_kwDODunzps5Mxoqp
https://api.github.com/repos/huggingface/datasets/issues/comments/1288080041/reactions
2022-10-23T10:22:37Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1288080041
https://avatars.githubusercontent.com/u/97918270?v=4
https://api.github.com/users/Cochonaki/events{/privacy}
https://api.github.com/users/Cochonaki/followers
https://api.github.com/users/Cochonaki/following{/other_user}
https://api.github.com/users/Cochonaki/gists{/gist_id}
https://github.com/Cochonaki
Cochonaki
U_kgDOBdYdPg
https://api.github.com/users/Cochonaki/orgs
https://api.github.com/users/Cochonaki/received_events
https://api.github.com/users/Cochonaki/repos
https://api.github.com/users/Cochonaki/starred{/owner}{/repo}
https://api.github.com/users/Cochonaki/subscriptions
User
https://api.github.com/users/Cochonaki
public
MEMBER
Welcome!!! 🤗
2022-10-23T10:27:52Z
https://github.com/huggingface/datasets/pull/5120#issuecomment-1288080962
https://api.github.com/repos/huggingface/datasets/issues/5120
IC_kwDODunzps5Mxo5C
https://api.github.com/repos/huggingface/datasets/issues/comments/1288080962/reactions
2022-10-23T10:27:52Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1288080962
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
This PR solves #5117, by wrapping the entire `zip` clause in tqdm.

For more information, please checkout this Stack Overflow thread:
https://stackoverflow.com/questions/41171191/tqdm-progressbar-and-zip-built-in-do-not-work-together