Add a method to shuffle a dataset
NONE
+1 for the naming convention

About the `shuffle` method, from my understanding it should be done in `Dataloader` (better separation between dataset processing - usage)
2020-05-20T00:15:06Z
https://github.com/huggingface/datasets/issues/166#issuecomment-631158575
https://api.github.com/repos/huggingface/datasets/issues/166
MDEyOklzc3VlQ29tbWVudDYzMTE1ODU3NQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/631158575/reactions
2020-05-20T00:15:06Z
https://api.github.com/repos/huggingface/datasets/issues/comments/631158575
https://avatars.githubusercontent.com/u/43774355?v=4
https://api.github.com/users/astariul/events{/privacy}
https://api.github.com/users/astariul/followers
https://api.github.com/users/astariul/following{/other_user}
https://api.github.com/users/astariul/gists{/gist_id}
https://github.com/astariul
astariul
MDQ6VXNlcjQzNzc0MzU1
https://api.github.com/users/astariul/orgs
https://api.github.com/users/astariul/received_events
https://api.github.com/users/astariul/repos
https://api.github.com/users/astariul/starred{/owner}{/repo}
https://api.github.com/users/astariul/subscriptions
User
https://api.github.com/users/astariul
public
CONTRIBUTOR
+1 for shuffle in `Dataloader`. 
Some `Dataloader` just store idxs of dataset and just shuffle those idxs, which might(?) be faster than do shuffle in dataset, especially when doing shuffle every epoch.

Also +1 for the naming convention.
2020-05-23T10:01:34Z
https://github.com/huggingface/datasets/issues/166#issuecomment-633018440
https://api.github.com/repos/huggingface/datasets/issues/166
MDEyOklzc3VlQ29tbWVudDYzMzAxODQ0MA==
https://api.github.com/repos/huggingface/datasets/issues/comments/633018440/reactions
2020-05-23T10:01:34Z
https://api.github.com/repos/huggingface/datasets/issues/comments/633018440
https://avatars.githubusercontent.com/u/17963619?v=4
https://api.github.com/users/richarddwang/events{/privacy}
https://api.github.com/users/richarddwang/followers
https://api.github.com/users/richarddwang/following{/other_user}
https://api.github.com/users/richarddwang/gists{/gist_id}
https://github.com/richarddwang
richarddwang
MDQ6VXNlcjE3OTYzNjE5
https://api.github.com/users/richarddwang/orgs
https://api.github.com/users/richarddwang/received_events
https://api.github.com/users/richarddwang/repos
https://api.github.com/users/richarddwang/starred{/owner}{/repo}
https://api.github.com/users/richarddwang/subscriptions
User
https://api.github.com/users/richarddwang
public
CONTRIBUTOR
As you might already know the issue of dataset shuffling came up in the nlp code [walkthrough](https://youtu.be/G3pOvrKkFuk?t=3204) by Yannic Kilcher

2020-05-26T11:53:10Z
https://github.com/huggingface/datasets/issues/166#issuecomment-633977763
https://api.github.com/repos/huggingface/datasets/issues/166
MDEyOklzc3VlQ29tbWVudDYzMzk3Nzc2Mw==
https://api.github.com/repos/huggingface/datasets/issues/comments/633977763/reactions
2020-05-26T11:53:10Z
https://api.github.com/repos/huggingface/datasets/issues/comments/633977763
https://avatars.githubusercontent.com/u/458335?v=4
https://api.github.com/users/vblagoje/events{/privacy}
https://api.github.com/users/vblagoje/followers
https://api.github.com/users/vblagoje/following{/other_user}
https://api.github.com/users/vblagoje/gists{/gist_id}
https://github.com/vblagoje
vblagoje
MDQ6VXNlcjQ1ODMzNQ==
https://api.github.com/users/vblagoje/orgs
https://api.github.com/users/vblagoje/received_events
https://api.github.com/users/vblagoje/repos
https://api.github.com/users/vblagoje/starred{/owner}{/repo}
https://api.github.com/users/vblagoje/subscriptions
User
https://api.github.com/users/vblagoje
public
MEMBER
We added the `.shuffle` method :)

Closing this one.
2020-06-23T15:07:32Z
https://github.com/huggingface/datasets/issues/166#issuecomment-648224781
https://api.github.com/repos/huggingface/datasets/issues/166
MDEyOklzc3VlQ29tbWVudDY0ODIyNDc4MQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/648224781/reactions
2020-06-23T15:07:32Z
https://api.github.com/repos/huggingface/datasets/issues/comments/648224781
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
Could maybe be a `dataset.shuffle(generator=None, seed=None)` signature method.

Also, we could maybe have a clear indication of which method modify in-place and which methods return/cache a modified dataset. I kinda like torch conversion of having an underscore suffix for all the methods which modify a dataset in-place. What do you think?