break statement not required
NONE
I guess,test failing due to connection error?
2020-06-22T01:51:10Z
https://github.com/huggingface/datasets/pull/291#issuecomment-647222037
https://api.github.com/repos/huggingface/datasets/issues/291
MDEyOklzc3VlQ29tbWVudDY0NzIyMjAzNw==
https://api.github.com/repos/huggingface/datasets/issues/comments/647222037/reactions
2020-06-22T01:51:10Z
https://api.github.com/repos/huggingface/datasets/issues/comments/647222037
https://avatars.githubusercontent.com/u/12967587?v=4
https://api.github.com/users/mayurnewase/events{/privacy}
https://api.github.com/users/mayurnewase/followers
https://api.github.com/users/mayurnewase/following{/other_user}
https://api.github.com/users/mayurnewase/gists{/gist_id}
https://github.com/mayurnewase
mayurnewase
MDQ6VXNlcjEyOTY3NTg3
https://api.github.com/users/mayurnewase/orgs
https://api.github.com/users/mayurnewase/received_events
https://api.github.com/users/mayurnewase/repos
https://api.github.com/users/mayurnewase/starred{/owner}{/repo}
https://api.github.com/users/mayurnewase/subscriptions
User
https://api.github.com/users/mayurnewase
public
MEMBER
We just fixed the other dataset on master. Could you rebase from master and push to rerun the CI ?
2020-06-22T12:22:54Z
https://github.com/huggingface/datasets/pull/291#issuecomment-647482968
https://api.github.com/repos/huggingface/datasets/issues/291
MDEyOklzc3VlQ29tbWVudDY0NzQ4Mjk2OA==
https://api.github.com/repos/huggingface/datasets/issues/comments/647482968/reactions
2020-06-22T12:22:54Z
https://api.github.com/repos/huggingface/datasets/issues/comments/647482968
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
If I'm not wrong this function returns None if no main class was found.
I think it makes things less clear not to have a return at the end of the function.
I guess we can have one return in the for loop instead of the break statement, AND one return at the end to explicitly return None.
What do you think ?
2020-06-23T08:01:53Z
https://github.com/huggingface/datasets/pull/291#issuecomment-647979356
https://api.github.com/repos/huggingface/datasets/issues/291
MDEyOklzc3VlQ29tbWVudDY0Nzk3OTM1Ng==
https://api.github.com/repos/huggingface/datasets/issues/comments/647979356/reactions
2020-06-23T08:01:53Z
https://api.github.com/repos/huggingface/datasets/issues/comments/647979356
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public