Drop Python 3.6 support
NONE
_The documentation is not available anymore as the PR was closed or merged._
2022-06-08T12:15:36Z
https://github.com/huggingface/datasets/pull/4460#issuecomment-1149837761
https://api.github.com/repos/huggingface/datasets/issues/4460
IC_kwDODunzps5EiSHB
https://api.github.com/repos/huggingface/datasets/issues/comments/1149837761/reactions
2022-07-26T19:16:39Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1149837761
https://avatars.githubusercontent.com/u/99929124?v=4
https://api.github.com/users/HuggingFaceDocBuilderDev/events{/privacy}
https://api.github.com/users/HuggingFaceDocBuilderDev/followers
https://api.github.com/users/HuggingFaceDocBuilderDev/following{/other_user}
https://api.github.com/users/HuggingFaceDocBuilderDev/gists{/gist_id}
https://github.com/HuggingFaceDocBuilderDev
HuggingFaceDocBuilderDev
U_kgDOBfTMJA
https://api.github.com/users/HuggingFaceDocBuilderDev/orgs
https://api.github.com/users/HuggingFaceDocBuilderDev/received_events
https://api.github.com/users/HuggingFaceDocBuilderDev/repos
https://api.github.com/users/HuggingFaceDocBuilderDev/starred{/owner}{/repo}
https://api.github.com/users/HuggingFaceDocBuilderDev/subscriptions
User
https://api.github.com/users/HuggingFaceDocBuilderDev
public
COLLABORATOR
I've disabled the `test_dummy_dataset_serialize_s3` tests in the Linux CI to avoid the failures (these tests only fail on Windows in 3.6). These failures are unrelated to this PR's changes, and I would like to address this in a new PR.
2022-06-16T17:17:37Z
https://github.com/huggingface/datasets/pull/4460#issuecomment-1157935276
https://api.github.com/repos/huggingface/datasets/issues/4460
IC_kwDODunzps5FBLCs
https://api.github.com/repos/huggingface/datasets/issues/comments/1157935276/reactions
2022-06-16T17:17:37Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1157935276
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
COLLABORATOR
[This comment](https://github.com/pytorch/audio/issues/2363#issuecomment-1179089175) explains the issue with MP3 decoding in `torchaudio` in the latest release (supports Python 3.7+). I fixed CI by pinning `torchaudio` to `<0.12.0`. Another way to fix this issue is by installing `ffmpeg` with conda or using the unofficial GH action. But I don't think it's worth making CI more complex, considering we can wait for the soundfile release, which should bring MP3 decoding, and drop the `torchaudio` dependency then.
2022-07-26T11:44:21Z
https://github.com/huggingface/datasets/pull/4460#issuecomment-1195375746
https://api.github.com/repos/huggingface/datasets/issues/4460
IC_kwDODunzps5HP_yC
https://api.github.com/repos/huggingface/datasets/issues/comments/1195375746/reactions
2022-07-26T11:44:21Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1195375746
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
MEMBER
Yay for dropping Python 3.6!
2022-07-26T11:59:51Z
https://github.com/huggingface/datasets/pull/4460#issuecomment-1195390644
https://api.github.com/repos/huggingface/datasets/issues/4460
IC_kwDODunzps5HQDa0
https://api.github.com/repos/huggingface/datasets/issues/comments/1195390644/reactions
2022-07-26T11:59:51Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1195390644
https://avatars.githubusercontent.com/u/326577?v=4
https://api.github.com/users/julien-c/events{/privacy}
https://api.github.com/users/julien-c/followers
https://api.github.com/users/julien-c/following{/other_user}
https://api.github.com/users/julien-c/gists{/gist_id}
https://github.com/julien-c
julien-c
MDQ6VXNlcjMyNjU3Nw==
https://api.github.com/users/julien-c/orgs
https://api.github.com/users/julien-c/received_events
https://api.github.com/users/julien-c/repos
https://api.github.com/users/julien-c/starred{/owner}{/repo}
https://api.github.com/users/julien-c/subscriptions
User
https://api.github.com/users/julien-c
public
COLLABORATOR
I think we can merge in this state. Also, if an env has Python version < 3.7 installed, we raise a warning, so I don't think we even need to create (and pin) an issue to notify the contributors of this change.
2022-07-26T14:13:34Z
https://github.com/huggingface/datasets/pull/4460#issuecomment-1195540137
https://api.github.com/repos/huggingface/datasets/issues/4460
IC_kwDODunzps5HQn6p
https://api.github.com/repos/huggingface/datasets/issues/comments/1195540137/reactions
2022-07-26T14:13:34Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1195540137
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
Remove the fallback imports/checks in the code needed for Python 3.6 and update the requirements/CI files. Also, use Python types for the NumPy dtype wherever possible to avoid deprecation warnings in newer NumPy versions.
