Support huggingface_hub 0.5
MEMBER
Looks like GH actions is not able to resolve `huggingface_hub` 0.5.0, I'm investivating
2022-04-06T10:19:08Z
https://github.com/huggingface/datasets/pull/4106#issuecomment-1090101376
https://api.github.com/repos/huggingface/datasets/issues/4106
IC_kwDODunzps5A-aCA
https://api.github.com/repos/huggingface/datasets/issues/comments/1090101376/reactions
2022-04-06T10:19:08Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1090101376
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
NONE
_The documentation is not available anymore as the PR was closed or merged._
2022-04-06T10:25:05Z
https://github.com/huggingface/datasets/pull/4106#issuecomment-1090106425
https://api.github.com/repos/huggingface/datasets/issues/4106
IC_kwDODunzps5A-bQ5
https://api.github.com/repos/huggingface/datasets/issues/comments/1090106425/reactions
2022-04-08T10:28:43Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1090106425
https://avatars.githubusercontent.com/u/99929124?v=4
https://api.github.com/users/HuggingFaceDocBuilderDev/events{/privacy}
https://api.github.com/users/HuggingFaceDocBuilderDev/followers
https://api.github.com/users/HuggingFaceDocBuilderDev/following{/other_user}
https://api.github.com/users/HuggingFaceDocBuilderDev/gists{/gist_id}
https://github.com/HuggingFaceDocBuilderDev
HuggingFaceDocBuilderDev
U_kgDOBfTMJA
https://api.github.com/users/HuggingFaceDocBuilderDev/orgs
https://api.github.com/users/HuggingFaceDocBuilderDev/received_events
https://api.github.com/users/HuggingFaceDocBuilderDev/repos
https://api.github.com/users/HuggingFaceDocBuilderDev/starred{/owner}{/repo}
https://api.github.com/users/HuggingFaceDocBuilderDev/subscriptions
User
https://api.github.com/users/HuggingFaceDocBuilderDev
public
NONE
I'm glad to see changes in `huggingface_hub` are simplifying code here.
2022-04-06T10:51:26Z
https://github.com/huggingface/datasets/pull/4106#issuecomment-1090129959
https://api.github.com/repos/huggingface/datasets/issues/4106
IC_kwDODunzps5A-hAn
https://api.github.com/repos/huggingface/datasets/issues/comments/1090129959/reactions
2022-04-06T10:51:26Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1090129959
https://avatars.githubusercontent.com/u/1663864?v=4
https://api.github.com/users/adrinjalali/events{/privacy}
https://api.github.com/users/adrinjalali/followers
https://api.github.com/users/adrinjalali/following{/other_user}
https://api.github.com/users/adrinjalali/gists{/gist_id}
https://github.com/adrinjalali
adrinjalali
MDQ6VXNlcjE2NjM4NjQ=
https://api.github.com/users/adrinjalali/orgs
https://api.github.com/users/adrinjalali/received_events
https://api.github.com/users/adrinjalali/repos
https://api.github.com/users/adrinjalali/starred{/owner}{/repo}
https://api.github.com/users/adrinjalali/subscriptions
User
https://api.github.com/users/adrinjalali
public
MEMBER
seems to supersede #4102, feel free to close mine :)
2022-04-06T12:14:17Z
https://github.com/huggingface/datasets/pull/4106#issuecomment-1090198508
https://api.github.com/repos/huggingface/datasets/issues/4106
IC_kwDODunzps5A-xvs
https://api.github.com/repos/huggingface/datasets/issues/comments/1090198508/reactions
2022-04-06T12:14:17Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1090198508
https://avatars.githubusercontent.com/u/326577?v=4
https://api.github.com/users/julien-c/events{/privacy}
https://api.github.com/users/julien-c/followers
https://api.github.com/users/julien-c/following{/other_user}
https://api.github.com/users/julien-c/gists{/gist_id}
https://github.com/julien-c
julien-c
MDQ6VXNlcjMyNjU3Nw==
https://api.github.com/users/julien-c/orgs
https://api.github.com/users/julien-c/received_events
https://api.github.com/users/julien-c/repos
https://api.github.com/users/julien-c/starred{/owner}{/repo}
https://api.github.com/users/julien-c/subscriptions
User
https://api.github.com/users/julien-c
public
MEMBER
maybe just cherry-pick the docstring fix
2022-04-06T12:15:13Z
https://github.com/huggingface/datasets/pull/4106#issuecomment-1090199321
https://api.github.com/repos/huggingface/datasets/issues/4106
IC_kwDODunzps5A-x8Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1090199321/reactions
2022-04-06T12:15:13Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1090199321
https://avatars.githubusercontent.com/u/326577?v=4
https://api.github.com/users/julien-c/events{/privacy}
https://api.github.com/users/julien-c/followers
https://api.github.com/users/julien-c/following{/other_user}
https://api.github.com/users/julien-c/gists{/gist_id}
https://github.com/julien-c
julien-c
MDQ6VXNlcjMyNjU3Nw==
https://api.github.com/users/julien-c/orgs
https://api.github.com/users/julien-c/received_events
https://api.github.com/users/julien-c/repos
https://api.github.com/users/julien-c/starred{/owner}{/repo}
https://api.github.com/users/julien-c/subscriptions
User
https://api.github.com/users/julien-c
public
MEMBER
I think I've found the issue:
- https://github.com/huggingface/huggingface_hub/pull/790
2022-04-06T12:34:08Z
https://github.com/huggingface/datasets/pull/4106#issuecomment-1090215660
https://api.github.com/repos/huggingface/datasets/issues/4106
IC_kwDODunzps5A-17s
https://api.github.com/repos/huggingface/datasets/issues/comments/1090215660/reactions
2022-04-06T12:34:30Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1090215660
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
MEMBER
Good catch, `huggingface_hub` doesn't support python 3.6 anymore indeed, therefore we should keep support for 0.4.0. I'm reverting the requirement version bump for now.

We can update the requirement once we drop support for python 3.6 in `datasets`
2022-04-06T12:40:50Z
https://github.com/huggingface/datasets/pull/4106#issuecomment-1090222058
https://api.github.com/repos/huggingface/datasets/issues/4106
IC_kwDODunzps5A-3fq
https://api.github.com/repos/huggingface/datasets/issues/comments/1090222058/reactions
2022-04-06T12:40:50Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1090222058
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
@lhoestq, I've opened this PR on `huggingface_hub`: 
- https://github.com/huggingface/huggingface_hub/pull/823

Is there any strong reason why `huggingface_hub` no longer supports Python 3.6? 
2022-04-06T12:42:11Z
https://github.com/huggingface/datasets/pull/4106#issuecomment-1090223678
https://api.github.com/repos/huggingface/datasets/issues/4106
IC_kwDODunzps5A-34-
https://api.github.com/repos/huggingface/datasets/issues/comments/1090223678/reactions
2022-04-06T12:42:32Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1090223678
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
MEMBER
I think `datasets` can drop support for 3.6 soon. But for now maybe let's keep support for 0.4.0, python 3.6 users are not affected by https://github.com/huggingface/datasets/issues/4105 anyway.

`huggingface_hub` doesn't not have to support 3.6 again just for the CI IMO
2022-04-06T12:50:33Z
https://github.com/huggingface/datasets/pull/4106#issuecomment-1090231721
https://api.github.com/repos/huggingface/datasets/issues/4106
IC_kwDODunzps5A-52p
https://api.github.com/repos/huggingface/datasets/issues/comments/1090231721/reactions
2022-04-06T12:50:33Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1090231721
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
@lhoestq I commented on the PR, that IMO it is not a good practice to drop support for Python 3.6 without a previous deprecation cycle.
2022-04-06T12:52:51Z
https://github.com/huggingface/datasets/pull/4106#issuecomment-1090233824
https://api.github.com/repos/huggingface/datasets/issues/4106
IC_kwDODunzps5A-6Xg
https://api.github.com/repos/huggingface/datasets/issues/comments/1090233824/reactions
2022-04-06T12:52:51Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1090233824
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
MEMBER
Re-added support for older versions. I ended up checking `huggingface_hub` version to use the old, deprecated API for <0.5.0
2022-04-06T13:35:16Z
https://github.com/huggingface/datasets/pull/4106#issuecomment-1090280905
https://api.github.com/repos/huggingface/datasets/issues/4106
IC_kwDODunzps5A_F3J
https://api.github.com/repos/huggingface/datasets/issues/comments/1090280905/reactions
2022-04-06T13:35:16Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1090280905
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
NONE
I find it good practice to have all dependency version related code in a single file so that when you decide to remove support for an old version of a dependency it's easy to find and remove them, hence suggesting `utils/_fixes.py` in https://github.com/huggingface/datasets/issues/4105#issuecomment-1090041204
2022-04-06T13:37:13Z
https://github.com/huggingface/datasets/pull/4106#issuecomment-1090283193
https://api.github.com/repos/huggingface/datasets/issues/4106
IC_kwDODunzps5A_Ga5
https://api.github.com/repos/huggingface/datasets/issues/comments/1090283193/reactions
2022-04-06T13:37:13Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1090283193
https://avatars.githubusercontent.com/u/1663864?v=4
https://api.github.com/users/adrinjalali/events{/privacy}
https://api.github.com/users/adrinjalali/followers
https://api.github.com/users/adrinjalali/following{/other_user}
https://api.github.com/users/adrinjalali/gists{/gist_id}
https://github.com/adrinjalali
adrinjalali
MDQ6VXNlcjE2NjM4NjQ=
https://api.github.com/users/adrinjalali/orgs
https://api.github.com/users/adrinjalali/received_events
https://api.github.com/users/adrinjalali/repos
https://api.github.com/users/adrinjalali/starred{/owner}{/repo}
https://api.github.com/users/adrinjalali/subscriptions
User
https://api.github.com/users/adrinjalali
public
MEMBER
good idea, thanks !
2022-04-06T13:39:11Z
https://github.com/huggingface/datasets/pull/4106#issuecomment-1090285239
https://api.github.com/repos/huggingface/datasets/issues/4106
IC_kwDODunzps5A_G63
https://api.github.com/repos/huggingface/datasets/issues/comments/1090285239/reactions
2022-04-06T13:39:11Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1090285239
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
I used your suggestion @adrinjalali , I just replace the try/except with a check on the version of `huggingface_hub`
2022-04-06T14:08:28Z
https://github.com/huggingface/datasets/pull/4106#issuecomment-1090316849
https://api.github.com/repos/huggingface/datasets/issues/4106
IC_kwDODunzps5A_Oox
https://api.github.com/repos/huggingface/datasets/issues/comments/1090316849/reactions
2022-04-06T14:08:28Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1090316849
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
Following https://github.com/huggingface/datasets/issues/4105

`huggingface_hub` deprecated some parameters in `HfApi` in 0.5. This PR updates all the calls to HfApi to remove all the deprecations, <s>and I set the `hugginface_hub` requirement to `>=0.5.0`</s>

cc @adrinjalali @LysandreJik 