Fixed label parsing in the ProductReviews dataset
CONTRIBUTOR
@lhoestq, can you please review this PR?
What exactly is the problem in the test case? Should it matter?
2021-06-22T09:22:13Z
https://github.com/huggingface/datasets/pull/2530#issuecomment-865805319
https://api.github.com/repos/huggingface/datasets/issues/2530
MDEyOklzc3VlQ29tbWVudDg2NTgwNTMxOQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/865805319/reactions
2021-06-22T09:22:13Z
https://api.github.com/repos/huggingface/datasets/issues/comments/865805319
https://avatars.githubusercontent.com/u/5150963?v=4
https://api.github.com/users/yavuzKomecoglu/events{/privacy}
https://api.github.com/users/yavuzKomecoglu/followers
https://api.github.com/users/yavuzKomecoglu/following{/other_user}
https://api.github.com/users/yavuzKomecoglu/gists{/gist_id}
https://github.com/yavuzKomecoglu
yavuzKomecoglu
MDQ6VXNlcjUxNTA5NjM=
https://api.github.com/users/yavuzKomecoglu/orgs
https://api.github.com/users/yavuzKomecoglu/received_events
https://api.github.com/users/yavuzKomecoglu/repos
https://api.github.com/users/yavuzKomecoglu/starred{/owner}{/repo}
https://api.github.com/users/yavuzKomecoglu/subscriptions
User
https://api.github.com/users/yavuzKomecoglu
public
MEMBER
Hi ! Thanks for fixing this :)

The CI fails for two reasons:
- the `pretty_name` tag is missing in yaml tags in ./datasets/turkish_product_reviews/README.md. You can fix that by adding this in the yaml tags:
```yaml
pretty_name: Turkish Product Reviews
```
- The test that runs the turkish_product_reviews.py file on the dummy_data.zip data returned 0 examples. Indeed it looks like you changed dummy_data.zip file and now it is an empty zip file. I think you can fix that by reverting your change to the dummy_data.zip file
2021-06-22T10:24:13Z
https://github.com/huggingface/datasets/pull/2530#issuecomment-865861937
https://api.github.com/repos/huggingface/datasets/issues/2530
MDEyOklzc3VlQ29tbWVudDg2NTg2MTkzNw==
https://api.github.com/repos/huggingface/datasets/issues/comments/865861937/reactions
2021-06-22T10:24:13Z
https://api.github.com/repos/huggingface/datasets/issues/comments/865861937
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
> Hi ! Thanks for fixing this :)
> 
> The CI fails for two reasons:
> 
>     * the `pretty_name` tag is missing in yaml tags in ./datasets/turkish_product_reviews/README.md. You can fix that by adding this in the yaml tags:
> 
> 
> ```yaml
> pretty_name: Turkish Product Reviews
> ```
> 
>     * The test that runs the turkish_product_reviews.py file on the dummy_data.zip data returned 0 examples. Indeed it looks like you changed dummy_data.zip file and now it is an empty zip file. I think you can fix that by reverting your change to the dummy_data.zip file

Many thanks for the quick feedback.
I made the relevant fixes but still got the error :(
2021-06-22T11:03:08Z
https://github.com/huggingface/datasets/pull/2530#issuecomment-865886341
https://api.github.com/repos/huggingface/datasets/issues/2530
MDEyOklzc3VlQ29tbWVudDg2NTg4NjM0MQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/865886341/reactions
2021-06-22T11:03:08Z
https://api.github.com/repos/huggingface/datasets/issues/comments/865886341
https://avatars.githubusercontent.com/u/5150963?v=4
https://api.github.com/users/yavuzKomecoglu/events{/privacy}
https://api.github.com/users/yavuzKomecoglu/followers
https://api.github.com/users/yavuzKomecoglu/following{/other_user}
https://api.github.com/users/yavuzKomecoglu/gists{/gist_id}
https://github.com/yavuzKomecoglu
yavuzKomecoglu
MDQ6VXNlcjUxNTA5NjM=
https://api.github.com/users/yavuzKomecoglu/orgs
https://api.github.com/users/yavuzKomecoglu/received_events
https://api.github.com/users/yavuzKomecoglu/repos
https://api.github.com/users/yavuzKomecoglu/starred{/owner}{/repo}
https://api.github.com/users/yavuzKomecoglu/subscriptions
User
https://api.github.com/users/yavuzKomecoglu
public
CONTRIBUTOR
> Thanks !
> The CI was failing because of the dataset card that was missing some sections. I fixed that.
> 
> It's all good now

Super.  Thanks for the support.
2021-06-22T12:55:20Z
https://github.com/huggingface/datasets/pull/2530#issuecomment-865958030
https://api.github.com/repos/huggingface/datasets/issues/2530
MDEyOklzc3VlQ29tbWVudDg2NTk1ODAzMA==
https://api.github.com/repos/huggingface/datasets/issues/comments/865958030/reactions
2021-06-22T12:55:20Z
https://api.github.com/repos/huggingface/datasets/issues/comments/865958030
https://avatars.githubusercontent.com/u/5150963?v=4
https://api.github.com/users/yavuzKomecoglu/events{/privacy}
https://api.github.com/users/yavuzKomecoglu/followers
https://api.github.com/users/yavuzKomecoglu/following{/other_user}
https://api.github.com/users/yavuzKomecoglu/gists{/gist_id}
https://github.com/yavuzKomecoglu
yavuzKomecoglu
MDQ6VXNlcjUxNTA5NjM=
https://api.github.com/users/yavuzKomecoglu/orgs
https://api.github.com/users/yavuzKomecoglu/received_events
https://api.github.com/users/yavuzKomecoglu/repos
https://api.github.com/users/yavuzKomecoglu/starred{/owner}{/repo}
https://api.github.com/users/yavuzKomecoglu/subscriptions
User
https://api.github.com/users/yavuzKomecoglu
public
Fixed issue with parsing dataset labels. 