Common voice validated partition
CONTRIBUTOR
Hi @patrickvonplaten - could you please advise whether this would be a welcomed change, and if so, who I consult regarding the unit-tests?
2022-02-03T12:24:42Z
https://github.com/huggingface/datasets/pull/3669#issuecomment-1028937996
https://api.github.com/repos/huggingface/datasets/issues/3669
IC_kwDODunzps49VFkM
https://api.github.com/repos/huggingface/datasets/issues/comments/1028937996/reactions
2022-02-03T12:24:42Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1028937996
https://avatars.githubusercontent.com/u/98762373?v=4
https://api.github.com/users/shalymin-amzn/events{/privacy}
https://api.github.com/users/shalymin-amzn/followers
https://api.github.com/users/shalymin-amzn/following{/other_user}
https://api.github.com/users/shalymin-amzn/gists{/gist_id}
https://github.com/shalymin-amzn
shalymin-amzn
U_kgDOBeL-hQ
https://api.github.com/users/shalymin-amzn/orgs
https://api.github.com/users/shalymin-amzn/received_events
https://api.github.com/users/shalymin-amzn/repos
https://api.github.com/users/shalymin-amzn/starred{/owner}{/repo}
https://api.github.com/users/shalymin-amzn/subscriptions
User
https://api.github.com/users/shalymin-amzn
public
CONTRIBUTOR
I'd be happy with adding this change. @anton-l @lhoestq - what do you think?
2022-02-07T16:00:51Z
https://github.com/huggingface/datasets/pull/3669#issuecomment-1031631311
https://api.github.com/repos/huggingface/datasets/issues/3669
IC_kwDODunzps49fXHP
https://api.github.com/repos/huggingface/datasets/issues/comments/1031631311/reactions
2022-02-07T16:00:51Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1031631311
https://avatars.githubusercontent.com/u/23423619?v=4
https://api.github.com/users/patrickvonplaten/events{/privacy}
https://api.github.com/users/patrickvonplaten/followers
https://api.github.com/users/patrickvonplaten/following{/other_user}
https://api.github.com/users/patrickvonplaten/gists{/gist_id}
https://github.com/patrickvonplaten
patrickvonplaten
MDQ6VXNlcjIzNDIzNjE5
https://api.github.com/users/patrickvonplaten/orgs
https://api.github.com/users/patrickvonplaten/received_events
https://api.github.com/users/patrickvonplaten/repos
https://api.github.com/users/patrickvonplaten/starred{/owner}{/repo}
https://api.github.com/users/patrickvonplaten/subscriptions
User
https://api.github.com/users/patrickvonplaten
public
MEMBER
Cool ! I just fixed the tests by adding a dummy `validated.tsv` file in the dummy data archive of common_voice

I wonder if you should separate the train/valid/test configuration from the validated/invalidated configuration of the splits ? 
In particular having `validated` along with the train/valid/test splits could be a bit weird since it comprises them. We can do that if you think it makes more sense. Otherwise it's also good as it is right now :)

2022-02-07T17:08:02Z
https://github.com/huggingface/datasets/pull/3669#issuecomment-1031705411
https://api.github.com/repos/huggingface/datasets/issues/3669
IC_kwDODunzps49fpND
https://api.github.com/repos/huggingface/datasets/issues/comments/1031705411/reactions
2022-02-07T17:08:02Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1031705411
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
Thanks! I think that there are 2 cases for using the validated partition: 1) trainset = {validated - dev - test}, dev and test as they come; 2) train, dev, and test sampled from validated manually with the desired ratios.
In either case, I think that it's quite a big change on the HF interface part, so could as well be taken care of in the client code. Or is it not? (In which case, what's the most compact way to implement this?)
2022-02-07T17:18:32Z
https://github.com/huggingface/datasets/pull/3669#issuecomment-1031716493
https://api.github.com/repos/huggingface/datasets/issues/3669
IC_kwDODunzps49fr6N
https://api.github.com/repos/huggingface/datasets/issues/comments/1031716493/reactions
2022-02-07T17:18:32Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1031716493
https://avatars.githubusercontent.com/u/98762373?v=4
https://api.github.com/users/shalymin-amzn/events{/privacy}
https://api.github.com/users/shalymin-amzn/followers
https://api.github.com/users/shalymin-amzn/following{/other_user}
https://api.github.com/users/shalymin-amzn/gists{/gist_id}
https://github.com/shalymin-amzn
shalymin-amzn
U_kgDOBeL-hQ
https://api.github.com/users/shalymin-amzn/orgs
https://api.github.com/users/shalymin-amzn/received_events
https://api.github.com/users/shalymin-amzn/repos
https://api.github.com/users/shalymin-amzn/starred{/owner}{/repo}
https://api.github.com/users/shalymin-amzn/subscriptions
User
https://api.github.com/users/shalymin-amzn
public
MEMBER
What's important IMO is to let the users as much flexibility as they need - so we try to not do too much regarding splits to not constrain users. So I guess the way it is right now is ok. Can you confirm that it's ok @patrickvonplaten and that it won't break some speech training script out there ?
2022-02-07T20:33:51Z
https://github.com/huggingface/datasets/pull/3669#issuecomment-1031894245
https://api.github.com/repos/huggingface/datasets/issues/3669
IC_kwDODunzps49gXTl
https://api.github.com/repos/huggingface/datasets/issues/comments/1031894245/reactions
2022-02-07T20:33:51Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1031894245
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
@lhoestq all split names are explicit in our example scripts, so this shouldn't break anything, feel free to merge :)
I'll go ahead and add this to the official `mozilla-foundation` datasets as well 
2022-02-07T22:55:35Z
https://github.com/huggingface/datasets/pull/3669#issuecomment-1032017532
https://api.github.com/repos/huggingface/datasets/issues/3669
IC_kwDODunzps49g1Z8
https://api.github.com/repos/huggingface/datasets/issues/comments/1032017532/reactions
2022-02-07T22:55:35Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1032017532
https://avatars.githubusercontent.com/u/26864830?v=4
https://api.github.com/users/anton-l/events{/privacy}
https://api.github.com/users/anton-l/followers
https://api.github.com/users/anton-l/following{/other_user}
https://api.github.com/users/anton-l/gists{/gist_id}
https://github.com/anton-l
anton-l
MDQ6VXNlcjI2ODY0ODMw
https://api.github.com/users/anton-l/orgs
https://api.github.com/users/anton-l/received_events
https://api.github.com/users/anton-l/repos
https://api.github.com/users/anton-l/starred{/owner}{/repo}
https://api.github.com/users/anton-l/subscriptions
User
https://api.github.com/users/anton-l
public
CONTRIBUTOR
Good for me! This has no real down-sides IMO and surely won't break any training scripts.
2022-02-08T15:46:28Z
https://github.com/huggingface/datasets/pull/3669#issuecomment-1032754502
https://api.github.com/repos/huggingface/datasets/issues/3669
IC_kwDODunzps49jpVG
https://api.github.com/repos/huggingface/datasets/issues/comments/1032754502/reactions
2022-02-08T15:46:46Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1032754502
https://avatars.githubusercontent.com/u/23423619?v=4
https://api.github.com/users/patrickvonplaten/events{/privacy}
https://api.github.com/users/patrickvonplaten/followers
https://api.github.com/users/patrickvonplaten/following{/other_user}
https://api.github.com/users/patrickvonplaten/gists{/gist_id}
https://github.com/patrickvonplaten
patrickvonplaten
MDQ6VXNlcjIzNDIzNjE5
https://api.github.com/users/patrickvonplaten/orgs
https://api.github.com/users/patrickvonplaten/received_events
https://api.github.com/users/patrickvonplaten/repos
https://api.github.com/users/patrickvonplaten/starred{/owner}{/repo}
https://api.github.com/users/patrickvonplaten/subscriptions
User
https://api.github.com/users/patrickvonplaten
public
This patch adds access to the 'validated' partitions of CommonVoice datasets (provided by the dataset creators but not available in the HuggingFace interface yet).
As 'validated' contains significantly more data than 'train' (although it contains both test and validation, so one needs to be careful there), it can be useful to train better models where no strict comparison with the previous work is intended.