Add "ipykernel" to list of `co_filename`s to remove
CONTRIBUTOR
I don't know how I could add some tests for this, although jupyter is not among the dependencies so at least that would need to be added. If someone can tell a recommended way I will try to do it!
2022-10-27T06:46:13Z
https://github.com/huggingface/datasets/pull/5169#issuecomment-1293068444
https://api.github.com/repos/huggingface/datasets/issues/5169
IC_kwDODunzps5NEqic
https://api.github.com/repos/huggingface/datasets/issues/comments/1293068444/reactions
2022-10-27T06:46:13Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1293068444
https://avatars.githubusercontent.com/u/32967787?v=4
https://api.github.com/users/gpucce/events{/privacy}
https://api.github.com/users/gpucce/followers
https://api.github.com/users/gpucce/following{/other_user}
https://api.github.com/users/gpucce/gists{/gist_id}
https://github.com/gpucce
gpucce
MDQ6VXNlcjMyOTY3Nzg3
https://api.github.com/users/gpucce/orgs
https://api.github.com/users/gpucce/received_events
https://api.github.com/users/gpucce/repos
https://api.github.com/users/gpucce/starred{/owner}{/repo}
https://api.github.com/users/gpucce/subscriptions
User
https://api.github.com/users/gpucce
public
CONTRIBUTOR
So testing by myself and looking around the jupyter codebase it looks like the `co_filename` of objects created within jupyter is of the form `f"{tempfile.tempdir}/ipykernel_{id1}/{id2}.py"` however I can't find the exact command setting it so I [asked in discourse](https://discourse.jupyter.org/t/co-filename-within-notebooks/16538). For now adapted the `co_filename` filter and added tests according to this I hope to get an answer and possibly fix based on that.
2022-10-27T14:46:46Z
https://github.com/huggingface/datasets/pull/5169#issuecomment-1293637728
https://api.github.com/repos/huggingface/datasets/issues/5169
IC_kwDODunzps5NG1hg
https://api.github.com/repos/huggingface/datasets/issues/comments/1293637728/reactions
2022-10-27T14:46:46Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1293637728
https://avatars.githubusercontent.com/u/32967787?v=4
https://api.github.com/users/gpucce/events{/privacy}
https://api.github.com/users/gpucce/followers
https://api.github.com/users/gpucce/following{/other_user}
https://api.github.com/users/gpucce/gists{/gist_id}
https://github.com/gpucce
gpucce
MDQ6VXNlcjMyOTY3Nzg3
https://api.github.com/users/gpucce/orgs
https://api.github.com/users/gpucce/received_events
https://api.github.com/users/gpucce/repos
https://api.github.com/users/gpucce/starred{/owner}{/repo}
https://api.github.com/users/gpucce/subscriptions
User
https://api.github.com/users/gpucce
public
MEMBER
Ok ! I think it's fine to just check if the parent folder is named like `ipykernel_*` then

see the source code of how it's created:

https://github.com/ipython/ipykernel/blob/7f73ff705510b35d1e2faad7f5a676c620ce08d4/ipykernel/compiler.py#L72-L75
2022-10-27T14:55:24Z
https://github.com/huggingface/datasets/pull/5169#issuecomment-1293649411
https://api.github.com/repos/huggingface/datasets/issues/5169
IC_kwDODunzps5NG4YD
https://api.github.com/repos/huggingface/datasets/issues/comments/1293649411/reactions
2022-10-27T14:55:24Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1293649411
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
Should look better now didn't notice the duplicated tests
2022-10-27T15:20:32Z
https://github.com/huggingface/datasets/pull/5169#issuecomment-1293696264
https://api.github.com/repos/huggingface/datasets/issues/5169
IC_kwDODunzps5NHD0I
https://api.github.com/repos/huggingface/datasets/issues/comments/1293696264/reactions
2022-10-27T15:20:32Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1293696264
https://avatars.githubusercontent.com/u/32967787?v=4
https://api.github.com/users/gpucce/events{/privacy}
https://api.github.com/users/gpucce/followers
https://api.github.com/users/gpucce/following{/other_user}
https://api.github.com/users/gpucce/gists{/gist_id}
https://github.com/gpucce
gpucce
MDQ6VXNlcjMyOTY3Nzg3
https://api.github.com/users/gpucce/orgs
https://api.github.com/users/gpucce/received_events
https://api.github.com/users/gpucce/repos
https://api.github.com/users/gpucce/starred{/owner}{/repo}
https://api.github.com/users/gpucce/subscriptions
User
https://api.github.com/users/gpucce
public
NONE
_The documentation is not available anymore as the PR was closed or merged._
2022-10-27T15:25:49Z
https://github.com/huggingface/datasets/pull/5169#issuecomment-1293703331
https://api.github.com/repos/huggingface/datasets/issues/5169
IC_kwDODunzps5NHFij
https://api.github.com/repos/huggingface/datasets/issues/comments/1293703331/reactions
2022-11-02T15:46:00Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1293703331
https://avatars.githubusercontent.com/u/99929124?v=4
https://api.github.com/users/HuggingFaceDocBuilderDev/events{/privacy}
https://api.github.com/users/HuggingFaceDocBuilderDev/followers
https://api.github.com/users/HuggingFaceDocBuilderDev/following{/other_user}
https://api.github.com/users/HuggingFaceDocBuilderDev/gists{/gist_id}
https://github.com/HuggingFaceDocBuilderDev
HuggingFaceDocBuilderDev
U_kgDOBfTMJA
https://api.github.com/users/HuggingFaceDocBuilderDev/orgs
https://api.github.com/users/HuggingFaceDocBuilderDev/received_events
https://api.github.com/users/HuggingFaceDocBuilderDev/repos
https://api.github.com/users/HuggingFaceDocBuilderDev/starred{/owner}{/repo}
https://api.github.com/users/HuggingFaceDocBuilderDev/subscriptions
User
https://api.github.com/users/HuggingFaceDocBuilderDev
public
CONTRIBUTOR
Should work now on windows too
2022-10-27T16:05:51Z
https://github.com/huggingface/datasets/pull/5169#issuecomment-1293755489
https://api.github.com/repos/huggingface/datasets/issues/5169
IC_kwDODunzps5NHSRh
https://api.github.com/repos/huggingface/datasets/issues/comments/1293755489/reactions
2022-10-27T16:05:51Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1293755489
https://avatars.githubusercontent.com/u/32967787?v=4
https://api.github.com/users/gpucce/events{/privacy}
https://api.github.com/users/gpucce/followers
https://api.github.com/users/gpucce/following{/other_user}
https://api.github.com/users/gpucce/gists{/gist_id}
https://github.com/gpucce
gpucce
MDQ6VXNlcjMyOTY3Nzg3
https://api.github.com/users/gpucce/orgs
https://api.github.com/users/gpucce/received_events
https://api.github.com/users/gpucce/repos
https://api.github.com/users/gpucce/starred{/owner}{/repo}
https://api.github.com/users/gpucce/subscriptions
User
https://api.github.com/users/gpucce
public
CONTRIBUTOR
I did the changes you suggested and tried to rebase, the first part went fine, the second less so :( 

If you have time to spare, can you tell me what should I do now to fix this? thanks
2022-10-28T03:43:46Z
https://github.com/huggingface/datasets/pull/5169#issuecomment-1294412793
https://api.github.com/repos/huggingface/datasets/issues/5169
IC_kwDODunzps5NJyv5
https://api.github.com/repos/huggingface/datasets/issues/comments/1294412793/reactions
2022-10-28T03:43:46Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1294412793
https://avatars.githubusercontent.com/u/32967787?v=4
https://api.github.com/users/gpucce/events{/privacy}
https://api.github.com/users/gpucce/followers
https://api.github.com/users/gpucce/following{/other_user}
https://api.github.com/users/gpucce/gists{/gist_id}
https://github.com/gpucce
gpucce
MDQ6VXNlcjMyOTY3Nzg3
https://api.github.com/users/gpucce/orgs
https://api.github.com/users/gpucce/received_events
https://api.github.com/users/gpucce/repos
https://api.github.com/users/gpucce/starred{/owner}{/repo}
https://api.github.com/users/gpucce/subscriptions
User
https://api.github.com/users/gpucce
public
MEMBER
Instead of rebasing you can just merge `main` into your branch, otherwise the GitHub preview of your PR shows changes of from `main`.

Feel free to close this PR and create a new one. Or alternatively your can force push to this PR with a new clean git history.
2022-10-28T13:23:23Z
https://github.com/huggingface/datasets/pull/5169#issuecomment-1294996160
https://api.github.com/repos/huggingface/datasets/issues/5169
IC_kwDODunzps5NMBLA
https://api.github.com/repos/huggingface/datasets/issues/comments/1294996160/reactions
2022-10-28T13:23:23Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1294996160
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
I have force-pushed and merged main, only shows the right changes, if you can run CI one more time it should be ok now
2022-10-28T14:25:14Z
https://github.com/huggingface/datasets/pull/5169#issuecomment-1295067193
https://api.github.com/repos/huggingface/datasets/issues/5169
IC_kwDODunzps5NMSg5
https://api.github.com/repos/huggingface/datasets/issues/comments/1295067193/reactions
2022-10-28T14:25:14Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1295067193
https://avatars.githubusercontent.com/u/32967787?v=4
https://api.github.com/users/gpucce/events{/privacy}
https://api.github.com/users/gpucce/followers
https://api.github.com/users/gpucce/following{/other_user}
https://api.github.com/users/gpucce/gists{/gist_id}
https://github.com/gpucce
gpucce
MDQ6VXNlcjMyOTY3Nzg3
https://api.github.com/users/gpucce/orgs
https://api.github.com/users/gpucce/received_events
https://api.github.com/users/gpucce/repos
https://api.github.com/users/gpucce/starred{/owner}{/repo}
https://api.github.com/users/gpucce/subscriptions
User
https://api.github.com/users/gpucce
public
CONTRIBUTOR
Hi, sorry I have been busy, the thing is I can't really understand why the test fail, besides the ugly thing I had done in the last commit to check if within CI smth stange happened with `os`, locally tests pass
2022-11-02T14:29:13Z
https://github.com/huggingface/datasets/pull/5169#issuecomment-1300532080
https://api.github.com/repos/huggingface/datasets/issues/5169
IC_kwDODunzps5NhItw
https://api.github.com/repos/huggingface/datasets/issues/comments/1300532080/reactions
2022-11-02T14:29:13Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1300532080
https://avatars.githubusercontent.com/u/32967787?v=4
https://api.github.com/users/gpucce/events{/privacy}
https://api.github.com/users/gpucce/followers
https://api.github.com/users/gpucce/following{/other_user}
https://api.github.com/users/gpucce/gists{/gist_id}
https://github.com/gpucce
gpucce
MDQ6VXNlcjMyOTY3Nzg3
https://api.github.com/users/gpucce/orgs
https://api.github.com/users/gpucce/received_events
https://api.github.com/users/gpucce/repos
https://api.github.com/users/gpucce/starred{/owner}{/repo}
https://api.github.com/users/gpucce/subscriptions
User
https://api.github.com/users/gpucce
public
MEMBER
The CI wasn't passing when using the latest version `dill==0.3.6`. We have a separate function to dump CodeType objects for 0.3.6

I applied the same changes you did to this other function as well - it should be all good now
2022-11-02T15:21:06Z
https://github.com/huggingface/datasets/pull/5169#issuecomment-1300662014
https://api.github.com/repos/huggingface/datasets/issues/5169
IC_kwDODunzps5Nhob-
https://api.github.com/repos/huggingface/datasets/issues/comments/1300662014/reactions
2022-11-02T15:21:06Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1300662014
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
> The CI wasn't passing when using the latest version `dill==0.3.6`. We have a separate function to dump CodeType objects for 0.3.6
> 
> I applied the same changes you did to this other function as well - it should be all good now

Thanks, it would have taken a long time to figure out :)
2022-11-02T15:23:28Z
https://github.com/huggingface/datasets/pull/5169#issuecomment-1300668131
https://api.github.com/repos/huggingface/datasets/issues/5169
IC_kwDODunzps5Nhp7j
https://api.github.com/repos/huggingface/datasets/issues/comments/1300668131/reactions
2022-11-02T15:23:28Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1300668131
https://avatars.githubusercontent.com/u/32967787?v=4
https://api.github.com/users/gpucce/events{/privacy}
https://api.github.com/users/gpucce/followers
https://api.github.com/users/gpucce/following{/other_user}
https://api.github.com/users/gpucce/gists{/gist_id}
https://github.com/gpucce
gpucce
MDQ6VXNlcjMyOTY3Nzg3
https://api.github.com/users/gpucce/orgs
https://api.github.com/users/gpucce/received_events
https://api.github.com/users/gpucce/repos
https://api.github.com/users/gpucce/starred{/owner}{/repo}
https://api.github.com/users/gpucce/subscriptions
User
https://api.github.com/users/gpucce
public
Should resolve #5157 