Fix manual download instructions
CONTRIBUTOR
Verified that this works, thanks!
2020-06-18T17:01:08Z
https://github.com/huggingface/datasets/pull/284#issuecomment-646175431
https://api.github.com/repos/huggingface/datasets/issues/284
MDEyOklzc3VlQ29tbWVudDY0NjE3NTQzMQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/646175431/reactions
2020-06-18T17:01:08Z
https://api.github.com/repos/huggingface/datasets/issues/comments/646175431
https://avatars.githubusercontent.com/u/6045025?v=4
https://api.github.com/users/sshleifer/events{/privacy}
https://api.github.com/users/sshleifer/followers
https://api.github.com/users/sshleifer/following{/other_user}
https://api.github.com/users/sshleifer/gists{/gist_id}
https://github.com/sshleifer
sshleifer
MDQ6VXNlcjYwNDUwMjU=
https://api.github.com/users/sshleifer/orgs
https://api.github.com/users/sshleifer/received_events
https://api.github.com/users/sshleifer/repos
https://api.github.com/users/sshleifer/starred{/owner}{/repo}
https://api.github.com/users/sshleifer/subscriptions
User
https://api.github.com/users/sshleifer
public
CONTRIBUTOR
But I get
```python
ConnectionError: Couldn't reach https://s3.amazonaws.com/datasets.huggingface.co/nlp/datasets/./datasets/wmt16/wmt16.py
```
When I try from jupyter on brutasse or my mac. (the jupyter server is run from transformers).


Both machines can run
```bash
aws s3 ls s3://datasets.huggingface.co/nlp/datasets/wmt16/
```
but it seems one must be in the nlp directory to run the command?

(I ran `pip install -e . ` on this branch in both situations.)



2020-06-18T17:14:44Z
https://github.com/huggingface/datasets/pull/284#issuecomment-646187004
https://api.github.com/repos/huggingface/datasets/issues/284
MDEyOklzc3VlQ29tbWVudDY0NjE4NzAwNA==
https://api.github.com/repos/huggingface/datasets/issues/comments/646187004/reactions
2020-06-18T17:15:17Z
https://api.github.com/repos/huggingface/datasets/issues/comments/646187004
https://avatars.githubusercontent.com/u/6045025?v=4
https://api.github.com/users/sshleifer/events{/privacy}
https://api.github.com/users/sshleifer/followers
https://api.github.com/users/sshleifer/following{/other_user}
https://api.github.com/users/sshleifer/gists{/gist_id}
https://github.com/sshleifer
sshleifer
MDQ6VXNlcjYwNDUwMjU=
https://api.github.com/users/sshleifer/orgs
https://api.github.com/users/sshleifer/received_events
https://api.github.com/users/sshleifer/repos
https://api.github.com/users/sshleifer/starred{/owner}{/repo}
https://api.github.com/users/sshleifer/subscriptions
User
https://api.github.com/users/sshleifer
public
MEMBER
`https://s3.amazonaws.com/datasets.huggingface.co/nlp/datasets/./datasets/wmt16/wmt16.py` looks very weird.

(Also, S3 is not a file-system, it's a flat key-value store)
2020-06-18T18:07:03Z
https://github.com/huggingface/datasets/pull/284#issuecomment-646223223
https://api.github.com/repos/huggingface/datasets/issues/284
MDEyOklzc3VlQ29tbWVudDY0NjIyMzIyMw==
https://api.github.com/repos/huggingface/datasets/issues/comments/646223223/reactions
2020-06-18T18:07:03Z
https://api.github.com/repos/huggingface/datasets/issues/comments/646223223
https://avatars.githubusercontent.com/u/326577?v=4
https://api.github.com/users/julien-c/events{/privacy}
https://api.github.com/users/julien-c/followers
https://api.github.com/users/julien-c/following{/other_user}
https://api.github.com/users/julien-c/gists{/gist_id}
https://github.com/julien-c
julien-c
MDQ6VXNlcjMyNjU3Nw==
https://api.github.com/users/julien-c/orgs
https://api.github.com/users/julien-c/received_events
https://api.github.com/users/julien-c/repos
https://api.github.com/users/julien-c/starred{/owner}{/repo}
https://api.github.com/users/julien-c/subscriptions
User
https://api.github.com/users/julien-c
public
CONTRIBUTOR
Good to merge I think @lhoestq 
2020-06-18T21:26:57Z
https://github.com/huggingface/datasets/pull/284#issuecomment-646314424
https://api.github.com/repos/huggingface/datasets/issues/284
MDEyOklzc3VlQ29tbWVudDY0NjMxNDQyNA==
https://api.github.com/repos/huggingface/datasets/issues/comments/646314424/reactions
2020-06-18T21:26:57Z
https://api.github.com/repos/huggingface/datasets/issues/comments/646314424
https://avatars.githubusercontent.com/u/23423619?v=4
https://api.github.com/users/patrickvonplaten/events{/privacy}
https://api.github.com/users/patrickvonplaten/followers
https://api.github.com/users/patrickvonplaten/following{/other_user}
https://api.github.com/users/patrickvonplaten/gists{/gist_id}
https://github.com/patrickvonplaten
patrickvonplaten
MDQ6VXNlcjIzNDIzNjE5
https://api.github.com/users/patrickvonplaten/orgs
https://api.github.com/users/patrickvonplaten/received_events
https://api.github.com/users/patrickvonplaten/repos
https://api.github.com/users/patrickvonplaten/starred{/owner}{/repo}
https://api.github.com/users/patrickvonplaten/subscriptions
User
https://api.github.com/users/patrickvonplaten
public
MEMBER
> But I get
> 
> ```python
> ConnectionError: Couldn't reach https://s3.amazonaws.com/datasets.huggingface.co/nlp/datasets/./datasets/wmt16/wmt16.py
> ```
> 
> When I try from jupyter on brutasse or my mac. (the jupyter server is run from transformers).
> 
> Both machines can run
> 
> ```shell
> aws s3 ls s3://datasets.huggingface.co/nlp/datasets/wmt16/
> ```
> 
> but it seems one must be in the nlp directory to run the command?
> 
> (I ran `pip install -e . ` on this branch in both situations.)

As soon as it is on master, the dataset script wmt16.py will be synced on S3 and you'll be able to do `load_dataset("wmt16")`
2020-06-19T07:40:05Z
https://github.com/huggingface/datasets/pull/284#issuecomment-646489706
https://api.github.com/repos/huggingface/datasets/issues/284
MDEyOklzc3VlQ29tbWVudDY0NjQ4OTcwNg==
https://api.github.com/repos/huggingface/datasets/issues/comments/646489706/reactions
2020-06-19T07:40:05Z
https://api.github.com/repos/huggingface/datasets/issues/comments/646489706
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
This PR replaces the static `DatasetBulider` variable `MANUAL_DOWNLOAD_INSTRUCTIONS` by a property function `manual_download_instructions()`. 

Some datasets like XTREME and all WMT need the manual data dir only for a small fraction of the possible configs.

After some brainstorming with @mariamabarham and @lhoestq, we came to the conclusion that having a property function `manual_download_instructions()` gives us more flexibility to decide on a per config basis in the dataset builder if manual download instructions are needed.

Also this PR should unblock solves a bug with `wmt16 - ro-en` 
@sshleifer from this branch you should be able to succesfully run

```python 
import nlp 
ds = nlp.load_dataset('./datasets/wmt16', 'ro-en')
```

and once this PR is merged S3 should be synched so that 

```python
import nlp
ds = nlp.load_dataset("wmt16", "ro-en")
```

works as well.

**Important**: Since `MANUAL_DOWNLOAD_INSTRUCTIONS` was not really exposed to the user, this PR should not be a problem regarding backward compatibility.