Dataset Viewer issue for openclimatefix/nimrod-uk-1km
COLLABORATOR
If I understand correctly, this is due to the key `split` missing in the line https://huggingface.co/datasets/openclimatefix/nimrod-uk-1km/blob/main/nimrod-uk-1km.py#L41 of the script.
Maybe @albertvillanova could confirm.
2022-06-03T12:31:25Z
https://github.com/huggingface/datasets/issues/4443#issuecomment-1145915569
https://api.github.com/repos/huggingface/datasets/issues/4443
IC_kwDODunzps5ETUix
https://api.github.com/repos/huggingface/datasets/issues/comments/1145915569/reactions
2022-06-03T12:31:25Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1145915569
https://avatars.githubusercontent.com/u/1676121?v=4
https://api.github.com/users/severo/events{/privacy}
https://api.github.com/users/severo/followers
https://api.github.com/users/severo/following{/other_user}
https://api.github.com/users/severo/gists{/gist_id}
https://github.com/severo
severo
MDQ6VXNlcjE2NzYxMjE=
https://api.github.com/users/severo/orgs
https://api.github.com/users/severo/received_events
https://api.github.com/users/severo/repos
https://api.github.com/users/severo/starred{/owner}{/repo}
https://api.github.com/users/severo/subscriptions
User
https://api.github.com/users/severo
public
MEMBER
I'm having a look.
2022-06-03T13:26:01Z
https://github.com/huggingface/datasets/issues/4443#issuecomment-1145963656
https://api.github.com/repos/huggingface/datasets/issues/4443
IC_kwDODunzps5ETgSI
https://api.github.com/repos/huggingface/datasets/issues/comments/1145963656/reactions
2022-06-03T13:26:01Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1145963656
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
MEMBER
Indeed there are several issues in this dataset loading script.

The one pointed out by @severo: for the default configuration "crops": https://huggingface.co/datasets/openclimatefix/nimrod-uk-1km/blob/main/nimrod-uk-1km.py#L244
- The download manager downloads `_URL`
- But `_URL` is not defined:  https://huggingface.co/datasets/openclimatefix/nimrod-uk-1km/blob/main/nimrod-uk-1km.py#L41
  ```python
  _URL = {'train': []}
  ```
- Afterwards, for each split, a different key in `_ULR` is used, but it only contains one key: "train"
  - "valid" key: https://huggingface.co/datasets/openclimatefix/nimrod-uk-1km/blob/main/nimrod-uk-1km.py#L260
  - "test key: https://huggingface.co/datasets/openclimatefix/nimrod-uk-1km/blob/main/nimrod-uk-1km.py#L269
  
These keys do not exist inside `_URL`, thus the error message reported in the viewer: 
```
Exception:     KeyError
Message:       'valid'
```
2022-06-03T13:38:57Z
https://github.com/huggingface/datasets/issues/4443#issuecomment-1145976159
https://api.github.com/repos/huggingface/datasets/issues/4443
IC_kwDODunzps5ETjVf
https://api.github.com/repos/huggingface/datasets/issues/comments/1145976159/reactions
2022-06-03T13:38:57Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1145976159
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
MEMBER
Would anyone want to submit a Hub PR (or open a Discussion for the authors to be aware) to this dataset? https://huggingface.co/datasets/openclimatefix/nimrod-uk-1km
2022-06-06T07:20:33Z
https://github.com/huggingface/datasets/issues/4443#issuecomment-1147131238
https://api.github.com/repos/huggingface/datasets/issues/4443
IC_kwDODunzps5EX9Vm
https://api.github.com/repos/huggingface/datasets/issues/comments/1147131238/reactions
2022-06-06T07:20:33Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1147131238
https://avatars.githubusercontent.com/u/326577?v=4
https://api.github.com/users/julien-c/events{/privacy}
https://api.github.com/users/julien-c/followers
https://api.github.com/users/julien-c/following{/other_user}
https://api.github.com/users/julien-c/gists{/gist_id}
https://github.com/julien-c
julien-c
MDQ6VXNlcjMyNjU3Nw==
https://api.github.com/users/julien-c/orgs
https://api.github.com/users/julien-c/received_events
https://api.github.com/users/julien-c/repos
https://api.github.com/users/julien-c/starred{/owner}{/repo}
https://api.github.com/users/julien-c/subscriptions
User
https://api.github.com/users/julien-c
public
NONE
Hi, I'm the main author for that dataset, so I'll work on updating it! I was working on debugging some stuff awhile ago, which is what broke it. 
2022-06-06T19:49:23Z
https://github.com/huggingface/datasets/issues/4443#issuecomment-1147844588
https://api.github.com/repos/huggingface/datasets/issues/4443
IC_kwDODunzps5Earfs
https://api.github.com/repos/huggingface/datasets/issues/comments/1147844588/reactions
2022-06-06T19:49:23Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1147844588
https://avatars.githubusercontent.com/u/7170359?v=4
https://api.github.com/users/jacobbieker/events{/privacy}
https://api.github.com/users/jacobbieker/followers
https://api.github.com/users/jacobbieker/following{/other_user}
https://api.github.com/users/jacobbieker/gists{/gist_id}
https://github.com/jacobbieker
jacobbieker
MDQ6VXNlcjcxNzAzNTk=
https://api.github.com/users/jacobbieker/orgs
https://api.github.com/users/jacobbieker/received_events
https://api.github.com/users/jacobbieker/repos
https://api.github.com/users/jacobbieker/starred{/owner}{/repo}
https://api.github.com/users/jacobbieker/subscriptions
User
https://api.github.com/users/jacobbieker
public
MEMBER
I've opened a Discussion page, so that we can ask/answer and propose fixes until the script works properly: https://huggingface.co/datasets/openclimatefix/nimrod-uk-1km/discussions/1

CC: @julien-c @jacobbieker 
2022-06-07T08:23:52Z
https://github.com/huggingface/datasets/issues/4443#issuecomment-1148355829
https://api.github.com/repos/huggingface/datasets/issues/4443
IC_kwDODunzps5EcoT1
https://api.github.com/repos/huggingface/datasets/issues/comments/1148355829/reactions
2022-06-07T08:23:52Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1148355829
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
COLLABORATOR
can we close this issue and followup in the discussion?
2023-09-25T12:15:08Z
https://github.com/huggingface/datasets/issues/4443#issuecomment-1733582449
https://api.github.com/repos/huggingface/datasets/issues/4443
IC_kwDODunzps5nVF5x
https://api.github.com/repos/huggingface/datasets/issues/comments/1733582449/reactions
2023-09-25T12:15:08Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1733582449
https://avatars.githubusercontent.com/u/1676121?v=4
https://api.github.com/users/severo/events{/privacy}
https://api.github.com/users/severo/followers
https://api.github.com/users/severo/following{/other_user}
https://api.github.com/users/severo/gists{/gist_id}
https://github.com/severo
severo
MDQ6VXNlcjE2NzYxMjE=
https://api.github.com/users/severo/orgs
https://api.github.com/users/severo/received_events
https://api.github.com/users/severo/repos
https://api.github.com/users/severo/starred{/owner}{/repo}
https://api.github.com/users/severo/subscriptions
User
https://api.github.com/users/severo
public
### Link

_No response_

### Description

_No response_

### Owner

_No response_