Raise FileNotFoundError in WindowsFileLock
MEMBER
Hi ! Could you clarify what it fixes exactly and give more details please ? Especially why this is related to the windows hanging error ?
2021-06-21T08:56:08Z
https://github.com/huggingface/datasets/pull/2524#issuecomment-864858738
https://api.github.com/repos/huggingface/datasets/issues/2524
MDEyOklzc3VlQ29tbWVudDg2NDg1ODczOA==
https://api.github.com/repos/huggingface/datasets/issues/comments/864858738/reactions
2021-06-28T08:47:34Z
https://api.github.com/repos/huggingface/datasets/issues/comments/864858738
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
COLLABORATOR
This has already been merged, but I'll clarify the idea of this PR. Before this merge, FileLock was the only component affected by the max path limit on Windows (that came to my notice) because of its infinite loop that would suppress errors. So instead of suppressing the `FileNotFoundError` that is thrown by `os.open` if the file name is longer than the max allowed path length, this PR reraises it to notify the user.
2021-06-28T09:56:17Z
https://github.com/huggingface/datasets/pull/2524#issuecomment-869546745
https://api.github.com/repos/huggingface/datasets/issues/2524
MDEyOklzc3VlQ29tbWVudDg2OTU0Njc0NQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/869546745/reactions
2021-06-28T09:56:17Z
https://api.github.com/repos/huggingface/datasets/issues/comments/869546745
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
Closes #2443 