Move checks from _map_single to map
COLLABORATOR
@lhoestq This one has been open for a while. Could you please take a look?
2021-08-18T00:38:07Z
https://github.com/huggingface/datasets/pull/2660#issuecomment-900725348
https://api.github.com/repos/huggingface/datasets/issues/2660
IC_kwDODunzps41r_pk
https://api.github.com/repos/huggingface/datasets/issues/comments/900725348/reactions
2021-08-18T00:38:07Z
https://api.github.com/repos/huggingface/datasets/issues/comments/900725348
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
COLLABORATOR
@lhoestq Ready for the final review!
2021-09-03T11:06:02Z
https://github.com/huggingface/datasets/pull/2660#issuecomment-912455270
https://api.github.com/repos/huggingface/datasets/issues/2660
IC_kwDODunzps42YvZm
https://api.github.com/repos/huggingface/datasets/issues/comments/912455270/reactions
2021-09-03T11:06:02Z
https://api.github.com/repos/huggingface/datasets/issues/comments/912455270
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
COLLABORATOR
I forgot to update the signature of `DatasetDict.map`, so did that now.
2021-09-05T19:25:42Z
https://github.com/huggingface/datasets/pull/2660#issuecomment-913213612
https://api.github.com/repos/huggingface/datasets/issues/2660
IC_kwDODunzps42bois
https://api.github.com/repos/huggingface/datasets/issues/comments/913213612/reactions
2021-09-05T19:25:59Z
https://api.github.com/repos/huggingface/datasets/issues/comments/913213612
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
The goal of this PR is to remove duplicated checks in the `map` logic to execute them only once whenever possible (`fn_kwargs`, `input_columns`, ...). Additionally, this PR improves the consistency (to align it with `input_columns`) of the `remove_columns` check by adding support for a single string value, which is then wrapped into a list. 