Multi Domain Sentiment Analysis Dataset (MDSA)
MEMBER
can you also run `make style` to format the code ?
2020-12-08T13:54:41Z
https://github.com/huggingface/datasets/pull/1240#issuecomment-740633075
https://api.github.com/repos/huggingface/datasets/issues/1240
MDEyOklzc3VlQ29tbWVudDc0MDYzMzA3NQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/740633075/reactions
2020-12-08T13:54:41Z
https://api.github.com/repos/huggingface/datasets/issues/comments/740633075
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
I'll come back to this one in sometime :) @lhoestq 
2020-12-08T13:56:25Z
https://github.com/huggingface/datasets/pull/1240#issuecomment-740634044
https://api.github.com/repos/huggingface/datasets/issues/1240
MDEyOklzc3VlQ29tbWVudDc0MDYzNDA0NA==
https://api.github.com/repos/huggingface/datasets/issues/comments/740634044/reactions
2020-12-08T13:56:33Z
https://api.github.com/repos/huggingface/datasets/issues/comments/740634044
https://avatars.githubusercontent.com/u/1183441?v=4
https://api.github.com/users/abhishekkrthakur/events{/privacy}
https://api.github.com/users/abhishekkrthakur/followers
https://api.github.com/users/abhishekkrthakur/following{/other_user}
https://api.github.com/users/abhishekkrthakur/gists{/gist_id}
https://github.com/abhishekkrthakur
abhishekkrthakur
MDQ6VXNlcjExODM0NDE=
https://api.github.com/users/abhishekkrthakur/orgs
https://api.github.com/users/abhishekkrthakur/received_events
https://api.github.com/users/abhishekkrthakur/repos
https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}
https://api.github.com/users/abhishekkrthakur/subscriptions
User
https://api.github.com/users/abhishekkrthakur
public
MEMBER
Also if you would use `xml.etree.ElementTree` to parse the XML it would be awesome, because right now you're using an external dependency `xmltodict `
2020-12-08T13:56:50Z
https://github.com/huggingface/datasets/pull/1240#issuecomment-740634313
https://api.github.com/repos/huggingface/datasets/issues/1240
MDEyOklzc3VlQ29tbWVudDc0MDYzNDMxMw==
https://api.github.com/repos/huggingface/datasets/issues/comments/740634313/reactions
2020-12-08T13:56:50Z
https://api.github.com/repos/huggingface/datasets/issues/comments/740634313
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
CONTRIBUTOR
> Also if you would use xml.etree.ElementTree to parse the XML it would be awesome, because right now you're using an external dependency xmltodict

Its pseudo xml so elementtree fails. xmltodict seems to be working quite good for this. do we have examples of pseudo xml datasets?
2020-12-08T13:58:58Z
https://github.com/huggingface/datasets/pull/1240#issuecomment-740635453
https://api.github.com/repos/huggingface/datasets/issues/1240
MDEyOklzc3VlQ29tbWVudDc0MDYzNTQ1Mw==
https://api.github.com/repos/huggingface/datasets/issues/comments/740635453/reactions
2020-12-08T13:58:58Z
https://api.github.com/repos/huggingface/datasets/issues/comments/740635453
https://avatars.githubusercontent.com/u/1183441?v=4
https://api.github.com/users/abhishekkrthakur/events{/privacy}
https://api.github.com/users/abhishekkrthakur/followers
https://api.github.com/users/abhishekkrthakur/following{/other_user}
https://api.github.com/users/abhishekkrthakur/gists{/gist_id}
https://github.com/abhishekkrthakur
abhishekkrthakur
MDQ6VXNlcjExODM0NDE=
https://api.github.com/users/abhishekkrthakur/orgs
https://api.github.com/users/abhishekkrthakur/received_events
https://api.github.com/users/abhishekkrthakur/repos
https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}
https://api.github.com/users/abhishekkrthakur/subscriptions
User
https://api.github.com/users/abhishekkrthakur
public
MEMBER
for the other pseudo xml the text is parsed manually
2020-12-09T14:36:30Z
https://github.com/huggingface/datasets/pull/1240#issuecomment-741812381
https://api.github.com/repos/huggingface/datasets/issues/1240
MDEyOklzc3VlQ29tbWVudDc0MTgxMjM4MQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/741812381/reactions
2020-12-09T14:36:30Z
https://api.github.com/repos/huggingface/datasets/issues/comments/741812381
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
Can you add `xmltodict` to the test dependencies in setup.py please to fix the CI please ?
2020-12-11T18:06:29Z
https://github.com/huggingface/datasets/pull/1240#issuecomment-743343509
https://api.github.com/repos/huggingface/datasets/issues/1240
MDEyOklzc3VlQ29tbWVudDc0MzM0MzUwOQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/743343509/reactions
2020-12-11T18:06:29Z
https://api.github.com/repos/huggingface/datasets/issues/comments/743343509
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
Also can you add the dataset card with the tags and run `make style` ?
2020-12-11T18:07:26Z
https://github.com/huggingface/datasets/pull/1240#issuecomment-743343943
https://api.github.com/repos/huggingface/datasets/issues/1240
MDEyOklzc3VlQ29tbWVudDc0MzM0Mzk0Mw==
https://api.github.com/repos/huggingface/datasets/issues/comments/743343943/reactions
2020-12-11T18:07:26Z
https://api.github.com/repos/huggingface/datasets/issues/comments/743343943
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
Hi :) have you had a chance to fix the test dependency and apply `make style` ?

Feel fee to ping me when it's ready for a review
2020-12-16T16:26:23Z
https://github.com/huggingface/datasets/pull/1240#issuecomment-746580049
https://api.github.com/repos/huggingface/datasets/issues/1240
MDEyOklzc3VlQ29tbWVudDc0NjU4MDA0OQ==
https://api.github.com/repos/huggingface/datasets/issues/comments/746580049/reactions
2020-12-16T16:26:23Z
https://api.github.com/repos/huggingface/datasets/issues/comments/746580049
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
Thanks for your contribution, @abhishekkrthakur. Are you still interested in adding this dataset?

We are removing the dataset scripts from this GitHub repo and moving them to the Hugging Face Hub: https://huggingface.co/datasets

We would suggest you create this dataset there. Please, feel free to tell us if you need some help.
2022-09-30T14:46:55Z
https://github.com/huggingface/datasets/pull/1240#issuecomment-1263671649
https://api.github.com/repos/huggingface/datasets/issues/1240
IC_kwDODunzps5LUhlh
https://api.github.com/repos/huggingface/datasets/issues/comments/1263671649/reactions
2022-09-30T14:46:55Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1263671649
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public