Is `fs=` deprecated in `load_from_disk()` as well?
COLLABORATOR
Hi! Yes, we should deprecate the `fs` param here. Would you be interested in submitting a PR? 
2022-12-23T12:42:01Z
https://github.com/huggingface/datasets/issues/5385#issuecomment-1363922527
https://api.github.com/repos/huggingface/datasets/issues/5385
IC_kwDODunzps5RS85f
https://api.github.com/repos/huggingface/datasets/issues/comments/1363922527/reactions
2022-12-23T12:42:01Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1363922527
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
CONTRIBUTOR
> Hi! Yes, we should deprecate the `fs` param here. Would you be interested in submitting a PR?

Yeah I can do that sometime next week. Should the storage_options be a new arg here?  I’ll look around for anywhere else where fs is an arg.
2022-12-23T20:44:14Z
https://github.com/huggingface/datasets/issues/5385#issuecomment-1364324079
https://api.github.com/repos/huggingface/datasets/issues/5385
IC_kwDODunzps5RUe7v
https://api.github.com/repos/huggingface/datasets/issues/comments/1364324079/reactions
2022-12-23T20:44:14Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1364324079
https://avatars.githubusercontent.com/u/15098095?v=4
https://api.github.com/users/dconathan/events{/privacy}
https://api.github.com/users/dconathan/followers
https://api.github.com/users/dconathan/following{/other_user}
https://api.github.com/users/dconathan/gists{/gist_id}
https://github.com/dconathan
dconathan
MDQ6VXNlcjE1MDk4MDk1
https://api.github.com/users/dconathan/orgs
https://api.github.com/users/dconathan/received_events
https://api.github.com/users/dconathan/repos
https://api.github.com/users/dconathan/starred{/owner}{/repo}
https://api.github.com/users/dconathan/subscriptions
User
https://api.github.com/users/dconathan
public
MEMBER
Closed by #5393.
2023-01-23T10:50:04Z
https://github.com/huggingface/datasets/issues/5385#issuecomment-1400146415
https://api.github.com/repos/huggingface/datasets/issues/5385
IC_kwDODunzps5TdInv
https://api.github.com/repos/huggingface/datasets/issues/comments/1400146415/reactions
2023-01-23T10:50:04Z
https://api.github.com/repos/huggingface/datasets/issues/comments/1400146415
https://avatars.githubusercontent.com/u/8515462?v=4
https://api.github.com/users/albertvillanova/events{/privacy}
https://api.github.com/users/albertvillanova/followers
https://api.github.com/users/albertvillanova/following{/other_user}
https://api.github.com/users/albertvillanova/gists{/gist_id}
https://github.com/albertvillanova
albertvillanova
MDQ6VXNlcjg1MTU0NjI=
https://api.github.com/users/albertvillanova/orgs
https://api.github.com/users/albertvillanova/received_events
https://api.github.com/users/albertvillanova/repos
https://api.github.com/users/albertvillanova/starred{/owner}{/repo}
https://api.github.com/users/albertvillanova/subscriptions
User
https://api.github.com/users/albertvillanova
public
### Describe the bug

The `fs=` argument was deprecated from `Dataset.save_to_disk` and `Dataset.load_from_disk` in favor of automagically figuring it out via fsspec:
https://github.com/huggingface/datasets/blob/9a7272cd4222383a5b932b0083a4cc173fda44e8/src/datasets/arrow_dataset.py#L1339-L1340

Is there a reason the same thing shouldn't also apply to `datasets.load.load_from_disk()` as well ?

https://github.com/huggingface/datasets/blob/9a7272cd4222383a5b932b0083a4cc173fda44e8/src/datasets/load.py#L1779



### Steps to reproduce the bug

n/a

### Expected behavior

n/a

### Environment info

n/a