Ambiguous documentation
CONTRIBUTOR
Hi @theo-m !

A few lines above this line, you'll find that the `_split_generators` method returns a list of `SplitGenerator`s objects:

```python
datasets.SplitGenerator(
    name=datasets.Split.VALIDATION,
    # These kwargs will be passed to _generate_examples
    gen_kwargs={
        "filepath": os.path.join(data_dir, "dev.jsonl"),
        "split": "dev",
    },
),
```

Notice the `gen_kwargs` argument passed to the constructor of `SplitGenerator`: this dict will be unpacked as keyword arguments to pass to the `_generat_examples` method (in this case the `filepath` and `split` arguments).

Let me know if that helps!
2021-03-09T08:56:18Z
https://github.com/huggingface/datasets/issues/2009#issuecomment-793575100
https://api.github.com/repos/huggingface/datasets/issues/2009
MDEyOklzc3VlQ29tbWVudDc5MzU3NTEwMA==
https://api.github.com/repos/huggingface/datasets/issues/comments/793575100/reactions
2021-03-09T08:57:46Z
https://api.github.com/repos/huggingface/datasets/issues/comments/793575100
https://avatars.githubusercontent.com/u/33657802?v=4
https://api.github.com/users/SBrandeis/events{/privacy}
https://api.github.com/users/SBrandeis/followers
https://api.github.com/users/SBrandeis/following{/other_user}
https://api.github.com/users/SBrandeis/gists{/gist_id}
https://github.com/SBrandeis
SBrandeis
MDQ6VXNlcjMzNjU3ODAy
https://api.github.com/users/SBrandeis/orgs
https://api.github.com/users/SBrandeis/received_events
https://api.github.com/users/SBrandeis/repos
https://api.github.com/users/SBrandeis/starred{/owner}{/repo}
https://api.github.com/users/SBrandeis/subscriptions
User
https://api.github.com/users/SBrandeis
public
CONTRIBUTOR
Oh ok I hadn't made the connection between those two, will offer a tweak to the comment and the template then - thanks!
2021-03-09T09:03:29Z
https://github.com/huggingface/datasets/issues/2009#issuecomment-793583708
https://api.github.com/repos/huggingface/datasets/issues/2009
MDEyOklzc3VlQ29tbWVudDc5MzU4MzcwOA==
https://api.github.com/repos/huggingface/datasets/issues/comments/793583708/reactions
2021-03-09T09:03:38Z
https://api.github.com/repos/huggingface/datasets/issues/comments/793583708
https://avatars.githubusercontent.com/u/17948980?v=4
https://api.github.com/users/theo-m/events{/privacy}
https://api.github.com/users/theo-m/followers
https://api.github.com/users/theo-m/following{/other_user}
https://api.github.com/users/theo-m/gists{/gist_id}
https://github.com/theo-m
theo-m
MDQ6VXNlcjE3OTQ4OTgw
https://api.github.com/users/theo-m/orgs
https://api.github.com/users/theo-m/received_events
https://api.github.com/users/theo-m/repos
https://api.github.com/users/theo-m/starred{/owner}{/repo}
https://api.github.com/users/theo-m/subscriptions
User
https://api.github.com/users/theo-m
public
https://github.com/huggingface/datasets/blob/2ac9a0d24a091989f869af55f9f6411b37ff5188/templates/new_dataset_script.py#L156-L158

Looking at the template, I find this documentation line to be confusing, the method parameters don't include the `gen_kwargs` so I'm unclear where they're coming from.

Happy to push a PR with a clearer statement when I understand the meaning.