Remove a reference to the open Arrow file when deleting a TF dataset created with to_tf_dataset
COLLABORATOR
@lhoestq The test passes even without the try/except block!
2021-10-04T10:38:29Z
https://github.com/huggingface/datasets/pull/3002#issuecomment-933358365
https://api.github.com/repos/huggingface/datasets/issues/3002
IC_kwDODunzps43oesd
https://api.github.com/repos/huggingface/datasets/issues/comments/933358365/reactions
2021-10-04T10:38:29Z
https://api.github.com/repos/huggingface/datasets/issues/comments/933358365
https://avatars.githubusercontent.com/u/47462742?v=4
https://api.github.com/users/mariosasko/events{/privacy}
https://api.github.com/users/mariosasko/followers
https://api.github.com/users/mariosasko/following{/other_user}
https://api.github.com/users/mariosasko/gists{/gist_id}
https://github.com/mariosasko
mariosasko
MDQ6VXNlcjQ3NDYyNzQy
https://api.github.com/users/mariosasko/orgs
https://api.github.com/users/mariosasko/received_events
https://api.github.com/users/mariosasko/repos
https://api.github.com/users/mariosasko/starred{/owner}{/repo}
https://api.github.com/users/mariosasko/subscriptions
User
https://api.github.com/users/mariosasko
public
MEMBER
Hey, I'm a little late because I was caught up in the course work, but I double-checked this and it looks great. Thanks for fixing!
2021-10-13T11:48:00Z
https://github.com/huggingface/datasets/pull/3002#issuecomment-942218860
https://api.github.com/repos/huggingface/datasets/issues/3002
IC_kwDODunzps44KR5s
https://api.github.com/repos/huggingface/datasets/issues/comments/942218860/reactions
2021-10-13T11:48:00Z
https://api.github.com/repos/huggingface/datasets/issues/comments/942218860
https://avatars.githubusercontent.com/u/12866554?v=4
https://api.github.com/users/Rocketknight1/events{/privacy}
https://api.github.com/users/Rocketknight1/followers
https://api.github.com/users/Rocketknight1/following{/other_user}
https://api.github.com/users/Rocketknight1/gists{/gist_id}
https://github.com/Rocketknight1
Rocketknight1
MDQ6VXNlcjEyODY2NTU0
https://api.github.com/users/Rocketknight1/orgs
https://api.github.com/users/Rocketknight1/received_events
https://api.github.com/users/Rocketknight1/repos
https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}
https://api.github.com/users/Rocketknight1/subscriptions
User
https://api.github.com/users/Rocketknight1
public
This [comment](https://github.com/huggingface/datasets/issues/2934#issuecomment-922970919) explains the issue. This PR fixes that with a `weakref` callback, and additionally:
* renames `TensorflowDatasetMixIn` to `TensorflowDatasetMixin` for consistency
* correctly indents `TensorflowDatasetMixin`'s docstring
* replaces `tf.data.AUTOTUNE` with `tf.data.experimental.AUTOTUNE` (we support TF>=2.2 according to the [setup.py](https://github.com/huggingface/datasets/blob/fc46bba66ba4f432cc10501c16a677112e13984c/setup.py#L188) and `AUTOTUNE` has been moved to the experimental part of `tf.data` in 1.X if I'm not mistaken)

Fixes #2934