Add not-in-place implementations for several dataset transforms
CONTRIBUTOR
@lhoestq I am not sure how to test `dictionary_encode_column` (in-place version was not tested before)
2021-02-18T15:04:20Z
https://github.com/huggingface/datasets/pull/1883#issuecomment-781406546
https://api.github.com/repos/huggingface/datasets/issues/1883
MDEyOklzc3VlQ29tbWVudDc4MTQwNjU0Ng==
https://api.github.com/repos/huggingface/datasets/issues/comments/781406546/reactions
2021-02-18T15:04:20Z
https://api.github.com/repos/huggingface/datasets/issues/comments/781406546
https://avatars.githubusercontent.com/u/33657802?v=4
https://api.github.com/users/SBrandeis/events{/privacy}
https://api.github.com/users/SBrandeis/followers
https://api.github.com/users/SBrandeis/following{/other_user}
https://api.github.com/users/SBrandeis/gists{/gist_id}
https://github.com/SBrandeis
SBrandeis
MDQ6VXNlcjMzNjU3ODAy
https://api.github.com/users/SBrandeis/orgs
https://api.github.com/users/SBrandeis/received_events
https://api.github.com/users/SBrandeis/repos
https://api.github.com/users/SBrandeis/starred{/owner}{/repo}
https://api.github.com/users/SBrandeis/subscriptions
User
https://api.github.com/users/SBrandeis
public
MEMBER
I can take a look at dictionary_encode_column tomorrow.
Although it's likely that it doesn't work then. It was added at the beginning of the lib and never tested nor used afaik.
2021-02-18T18:59:19Z
https://github.com/huggingface/datasets/pull/1883#issuecomment-781565808
https://api.github.com/repos/huggingface/datasets/issues/1883
MDEyOklzc3VlQ29tbWVudDc4MTU2NTgwOA==
https://api.github.com/repos/huggingface/datasets/issues/comments/781565808/reactions
2021-02-18T18:59:19Z
https://api.github.com/repos/huggingface/datasets/issues/comments/781565808
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
MEMBER
Now let's update the documentation to use the new methods x)
2021-02-24T14:54:49Z
https://github.com/huggingface/datasets/pull/1883#issuecomment-785132076
https://api.github.com/repos/huggingface/datasets/issues/1883
MDEyOklzc3VlQ29tbWVudDc4NTEzMjA3Ng==
https://api.github.com/repos/huggingface/datasets/issues/comments/785132076/reactions
2021-02-24T14:54:49Z
https://api.github.com/repos/huggingface/datasets/issues/comments/785132076
https://avatars.githubusercontent.com/u/42851186?v=4
https://api.github.com/users/lhoestq/events{/privacy}
https://api.github.com/users/lhoestq/followers
https://api.github.com/users/lhoestq/following{/other_user}
https://api.github.com/users/lhoestq/gists{/gist_id}
https://github.com/lhoestq
lhoestq
MDQ6VXNlcjQyODUxMTg2
https://api.github.com/users/lhoestq/orgs
https://api.github.com/users/lhoestq/received_events
https://api.github.com/users/lhoestq/repos
https://api.github.com/users/lhoestq/starred{/owner}{/repo}
https://api.github.com/users/lhoestq/subscriptions
User
https://api.github.com/users/lhoestq
public
Should we deprecate in-place versions of such methods?