Dataset Viewer
cve
large_string | desc
large_string | owner
large_string | repo
large_string | commit_id
large_string | commit_message
large_string | diff
large_string | label
int64 | rank
uint32 |
|---|---|---|---|---|---|---|---|---|
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
f03ecb52e9b69716349b281e8c27cb04e530885c
|
Updated info about rdesktop-gmp.patch.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@162 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit f03ecb52e9b69716349b281e8c27cb04e530885c
Author: Peter Åstrand <[email protected]>
Date: Mon Sep 16 07:10:42 2002 +0000
Updated info about rdesktop-gmp.patch.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@162 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/patches.txt b/doc/patches.txt
index eae2d04..2db565b 100644
--- a/doc/patches.txt
+++ b/doc/patches.txt
@@ -204,9 +204,9 @@ Not needed anymore, with the new keyboard mapping implementation.
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/rdesktop-gmp.patch
Description:
-Seems to make the crypto stuff link with GNU MP.
+Use GMP for RSA crypto.
Status:
-Not applied.
+Not needed since rdesktop now use OpenSSL for all of the crypto.
URL:
| 0 | 80 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
9231b642e8d4d4a69b10fd71d727fcc6a35aca2b
|
Detection of unclean disconnect turned out not to work on W2K3 Server. Doh!
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@425 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 9231b642e8d4d4a69b10fd71d727fcc6a35aca2b
Author: Erik Forsberg <[email protected]>
Date: Thu Jun 19 11:46:30 2003 +0000
Detection of unclean disconnect turned out not to work on W2K3 Server. Doh!
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@425 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/rdp.c b/rdp.c
index 314f781..5a83c3e 100644
--- a/rdp.c
+++ b/rdp.c
@@ -865,7 +865,12 @@ rdp_main_loop(void)
case RDP_PDU_DEACTIVATE:
DEBUG(("RDP_PDU_DEACTIVATE\n"));
- return True;
+ /* We thought we could detect a clean
+ shutdown of the session by this
+ packet, but it seems Windows 2003
+ is sending us one of these when we
+ reconnect to a disconnected session
+ return True; */
break;
case RDP_PDU_DATA:
@@ -879,7 +884,10 @@ rdp_main_loop(void)
unimpl("PDU %d\n", type);
}
}
- return False;
+ return True;
+ /* We want to detect if we got a clean shutdown, but we
+ can't. Se above.
+ return False; */
}
/* Establish a connection up to the RDP layer */
| 0 | 90 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
79cd4ee093370c25c81c34e2d592c0b4b53cd84f
|
Updated with info about rdesktop-1.0.0-pl19-7-2-mmihalik-1.diff and rdesktop-gmp.patch.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@145 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 79cd4ee093370c25c81c34e2d592c0b4b53cd84f
Author: Peter Åstrand <[email protected]>
Date: Sat Sep 14 17:55:27 2002 +0000
Updated with info about rdesktop-1.0.0-pl19-7-2-mmihalik-1.diff and rdesktop-gmp.patch.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@145 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/patches.txt b/doc/patches.txt
index 9dc3e47..a288235 100644
--- a/doc/patches.txt
+++ b/doc/patches.txt
@@ -196,17 +196,17 @@ As far as I understand, this patch is applied.
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/rdesktop-1.0.0-pl19-7-2-mmihalik-1.diff
Description:
-TDB
+Some kind of new alternative keyboard mapping implementation.
Status:
-Not yet examined.
+Not needed anymore, with the new keyboard mapping implementation.
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/rdesktop-gmp.patch
Description:
-TDB
+Seems to make the crypto stuff link with GNU MP.
Status:
-Not yet examined.
+Not applied.
URL:
| 0 | 71 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
51a944f431b0e44c439bb5098203990d6054a2ab
|
Updated with info about vincent_19-7-2.secure.patch.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@174 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 51a944f431b0e44c439bb5098203990d6054a2ab
Author: Peter Åstrand <[email protected]>
Date: Tue Sep 17 09:42:42 2002 +0000
Updated with info about vincent_19-7-2.secure.patch.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@174 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/patches.txt b/doc/patches.txt
index e0b1d32..ca0daa5 100644
--- a/doc/patches.txt
+++ b/doc/patches.txt
@@ -310,9 +310,10 @@ Not yet examined.
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/vincent_19-7-2.secure.patch
Description:
-TDB
+Fixes a problem during the connection to a French NT4 TSE (a French
+NT4 TSE doesn't use encryptation).
Status:
-Not yet examined.
+Applied.
URL:
| 0 | 47 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
de59a100ead9eadc5a2a925124cfb82707ed0360
|
Mark rd_protocol_error() as "noreturn"
This allows the compiler to optimize things better and give better
warnings as it knows it will never return from this function.
|
commit de59a100ead9eadc5a2a925124cfb82707ed0360
Author: Pierre Ossman <[email protected]>
Date: Thu Apr 4 15:00:35 2019 +0200
Mark rd_protocol_error() as "noreturn"
This allows the compiler to optimize things better and give better
warnings as it knows it will never return from this function.
diff --git a/proto.h b/proto.h
index 5571996..f7f0c6c 100644
--- a/proto.h
+++ b/proto.h
@@ -25,6 +25,11 @@ extern "C" {
#endif
/* *INDENT-ON* */
#define UNUSED(param) ((void)param)
+#ifdef __GNUC__
+# define NORETURN __attribute__((noreturn))
+#else
+# define NORETURN
+#endif // __GNUC__
/* bitmap.c */
RD_BOOL bitmap_decompress(uint8 * output, int width, int height, uint8 * input, int size, int Bpp);
/* cache.c */
@@ -167,7 +172,7 @@ void rdp_reset_state(void);
void rdp_disconnect(void);
#define rdp_protocol_error(m, s) _rdp_protocol_error(__FILE__, __LINE__, __func__, m, s)
void _rdp_protocol_error(const char *file, int line, const char *func,
- const char *message, STREAM s);
+ const char *message, STREAM s) NORETURN;
/* rdpdr.c */
int get_device_index(RD_NTHANDLE handle);
void convert_to_unix_filename(char *filename);
| 0 | 16 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
ac166d9439ed824928f65feba85803d0154a68aa
|
Updated with reality; many RDP5 features already implemented.
Added many other things that needs to be done.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@671 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit ac166d9439ed824928f65feba85803d0154a68aa
Author: Peter Åstrand <[email protected]>
Date: Sun Apr 18 19:59:22 2004 +0000
Updated with reality; many RDP5 features already implemented.
Added many other things that needs to be done.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@671 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/TODO b/doc/TODO
index ee55606..d91c2cf 100644
--- a/doc/TODO
+++ b/doc/TODO
@@ -1,14 +1,47 @@
-* Implement support for more RDP 5.X features:
- * Serial port redirection
+* Clipboard:
- * Drive redirection
+ * Support other data types than plain text.
+
+ * Conversion between different character sets.
-* Keymapping: Support non-dead versions of some dead keys, like
- "acute". It seems like RDP4 only supports the dead versions, but the
- non-dead ones can be simulated by sending a space after the dead
- key.
+* Drive Redirection:
+ * Real support for file locking
-* Keymapping: Autodetect which keymap to use.
\ No newline at end of file
+ * Handle reconnections correctly.
+
+ * Various deficiencies; see FIXMEs in source code.
+
+
+* Serial Port Redirection:
+
+ * More testing needed.
+
+
+* Printer Redirection:
+
+ * More testing needed.
+
+
+* Keymapping:
+
+ * Support non-dead versions of some dead keys, like
+ "acute". It seems like RDP4 only supports the dead versions, but
+ the non-dead ones can be simulated by sending a space after the
+ dead key.
+
+ * Autodetect which keymap to use.
+
+
+* Miscellaneous
+
+ * Clean up header files. The current "proto.h" and "xproto.h" is far
+ from optimal.
+
+ * Go through the many trackers (bugs/patches/RFEs) at SourceForge.
+
+ * More fancy homepage.
+
+ * Enhance documentation. Write a FAQ.
| 0 | 98 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
2101ef3081d4ed02cad93ac7b599b642b109fafb
|
Update seamless protocol spec with the new HIDE/UNHIDE commands.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/branches/seamlessrdp-branch/rdesktop@1193 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 2101ef3081d4ed02cad93ac7b599b642b109fafb
Author: Pierre Ossman <[email protected]>
Date: Wed Mar 22 16:28:13 2006 +0000
Update seamless protocol spec with the new HIDE/UNHIDE commands.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/branches/seamlessrdp-branch/rdesktop@1193 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/seamlessrdp-channel.txt b/doc/seamlessrdp-channel.txt
index dd909a6..8a8ab11 100644
--- a/doc/seamlessrdp-channel.txt
+++ b/doc/seamlessrdp-channel.txt
@@ -173,8 +173,11 @@ Syntax:
HELLO,<SERIAL>,<FLAGS>
The server starts each connection by sending this message. Normally the client
-will react by sending a SYNC back to the server. The low bit in FLAGS is set if
-this is a new connection to an existing session.
+will react by sending a SYNC back to the server.
+
+Flags:
+ 0x0001 : This is a reconnect to an existing session.
+ 0x0002 : The desktop is currently hidden (see HIDE).
ACK
---
@@ -189,6 +192,33 @@ the server, the server will send an ACK back to the client. The purpose of this
is to inform the client of when the operation was actually performed, allowing
high latencies in the channel.
+HIDE
+----
+
+The desktop has become hidden on the server.
+
+Syntax:
+ HIDE,<SERIAL>,<FLAGS>
+
+This message is sent when the desktop on the server is obscured by something
+that cannot be tracked. The client should remove all windows and display the
+entire desktop, allowing the user to handle whatever is blocking the view.
+
+Note that updates to windows will still be sent as the windows still exist on
+the server, they are merely not visible.
+
+UNHIDE
+------
+
+The desktop has been restored on the server.
+
+Syntax:
+ UNHIDE,<SERIAL>,<FLAGS>
+
+This message is sent some time after a HIDE, indicating that the windowed view
+has been restored. If the client has dropped all information about windows then
+it can send a SYNC to re-enumerate them.
+
Client to Server Operations
===========================
| 0 | 95 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
3808350adb0c641d1c7ae6e74f59392e32be0afb
|
Fix from Paul Whitaker: It is not safe to assume that free space
available at the top of the tree is indicative of free space anywhere in
the tree, because you may wish to redirect a mount point hierarchy.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1434 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 3808350adb0c641d1c7ae6e74f59392e32be0afb
Author: Matt Chapman <[email protected]>
Date: Sat Feb 16 00:15:43 2008 +0000
Fix from Paul Whitaker: It is not safe to assume that free space
available at the top of the tree is indicative of free space anywhere in
the tree, because you may wish to redirect a mount point hierarchy.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1434 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/disk.c b/disk.c
index ef3d9dc..cf4a155 100644
--- a/disk.c
+++ b/disk.c
@@ -853,7 +853,7 @@ disk_set_information(RD_NTHANDLE handle, uint32 info_class, STREAM in, STREAM ou
in_uint32_le(in, length); /* file size */
/* prevents start of writing if not enough space left on device */
- if (STATFS_FN(g_rdpdr_device[pfinfo->device_id].local_path, &stat_fs) == 0)
+ if (STATFS_FN(pfinfo->path, &stat_fs) == 0)
if (stat_fs.f_bfree * stat_fs.f_bsize < length)
return RD_STATUS_DISK_FULL;
| 0 | 45 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
b924730d4f716777263cab856e555868b4358ab6
|
Add suggestions for improving the event model of rdesktop.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1347 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit b924730d4f716777263cab856e555868b4358ab6
Author: Pierre Ossman <[email protected]>
Date: Mon Dec 11 14:50:01 2006 +0000
Add suggestions for improving the event model of rdesktop.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1347 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/TODO b/doc/TODO
index 1aa830a..b45a73b 100644
--- a/doc/TODO
+++ b/doc/TODO
@@ -1,3 +1,11 @@
+* General
+
+ * Rework main loop to a generic event handler (i.e. move select() to
+ the top of the stack, not the end). Also means rewriting the connect
+ procedure as a state machine.
+
+ * Stop using static objects for packets and make it more clear when it
+ is in use (explicit allocation and free).
* Clipboard:
| 0 | 82 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
d017f799eafc55dc1395b10d9319b01996101158
|
Added copyright header and links to IRP resources.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@656 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit d017f799eafc55dc1395b10d9319b01996101158
Author: Peter Åstrand <[email protected]>
Date: Fri Apr 16 11:28:34 2004 +0000
Added copyright header and links to IRP resources.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@656 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/rdpdr.c b/rdpdr.c
index b5c9464..6fb7f96 100644
--- a/rdpdr.c
+++ b/rdpdr.c
@@ -1,3 +1,38 @@
+/* -*- c-basic-offset: 8 -*-
+ rdesktop: A Remote Desktop Protocol client.
+ Copyright (C) Matthew Chapman 1999-2004
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+*/
+
+/*
+ Here are some resources, for your IRP hacking pleasure:
+
+ http://cvs.sourceforge.net/viewcvs.py/mingw/w32api/include/ddk/winddk.h?view=markup
+
+ http://win32.mvps.org/ntfs/streams.cpp
+
+ http://www.acc.umu.se/~bosse/ntifs.h
+
+ http://undocumented.ntinternals.net/UserMode/Undocumented%20Functions/NT%20Objects/File/
+
+ http://us1.samba.org/samba/ftp/specs/smb-nt01.txt
+
+ http://www.osronline.com/
+*/
+
#include <unistd.h>
#include <sys/types.h>
#include <sys/time.h>
| 0 | 85 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
e7cda3dbf8074c78ff9ad852a59811b10a78dcb8
|
add -M for local mouse cursor
|
commit e7cda3dbf8074c78ff9ad852a59811b10a78dcb8
Author: Joshua Hudson <[email protected]>
Date: Wed Oct 25 19:22:35 2017 -0700
add -M for local mouse cursor
diff --git a/doc/rdesktop.1 b/doc/rdesktop.1
index 3708105..64abf11 100644
--- a/doc/rdesktop.1
+++ b/doc/rdesktop.1
@@ -128,6 +128,11 @@ but everything after this is unencrypted (including interactive logins).
Do not send mouse motion events. This saves bandwidth, although some Windows
applications may rely on receiving mouse motion.
.TP
+.BR "-M"
+Use local X cursor inherited from window manager instead of server cursor. This
+is mostly useful with -m, but is also useful if the server is sending bogus
+mouse cursors.
+.TP
.BR "-C"
Use private colourmap. This will improve colour accuracy on an 8-bit display,
but rdesktop will appear in false colour when not focused.
diff --git a/rdesktop.c b/rdesktop.c
index 26411f7..6d5bf4f 100644
--- a/rdesktop.c
+++ b/rdesktop.c
@@ -96,6 +96,7 @@ RD_BOOL g_desktop_save = True; /* desktop save order */
RD_BOOL g_polygon_ellipse_orders = True; /* polygon / ellipse orders */
RD_BOOL g_fullscreen = False;
RD_BOOL g_grab_keyboard = True;
+RD_BOOL g_local_cursor = False;
RD_BOOL g_hide_decorations = False;
RDP_VERSION g_rdp_version = RDP_V5; /* Default to version 5 */
RD_BOOL g_rdpclip = True;
@@ -182,6 +183,7 @@ usage(char *program)
fprintf(stderr, " -e: disable encryption (French TS)\n");
fprintf(stderr, " -E: disable encryption from client to server\n");
fprintf(stderr, " -m: do not send motion events\n");
+ fprintf(stderr, " -M: use local mouse cursor\n");
fprintf(stderr, " -C: use private colour map\n");
fprintf(stderr, " -D: hide window manager decorations\n");
fprintf(stderr, " -K: keep window manager key bindings\n");
@@ -638,7 +640,7 @@ main(int argc, char *argv[])
g_num_devices = 0;
while ((c = getopt(argc, argv,
- "A:u:L:d:s:c:p:n:k:g:o:fbBeEitmzCDKS:T:NX:a:x:Pr:045vh?")) != -1)
+ "A:u:L:d:s:c:p:n:k:g:o:fbBeEitmMzCDKS:T:NX:a:x:Pr:045vh?")) != -1)
{
switch (c)
{
@@ -787,6 +789,9 @@ main(int argc, char *argv[])
case 'm':
g_sendmotion = False;
break;
+ case 'M':
+ g_local_cursor = True;
+ break;
case 'C':
g_owncolmap = True;
@@ -1040,6 +1045,12 @@ main(int argc, char *argv[])
usage(argv[0]);
return EX_USAGE;
}
+ if (g_local_cursor)
+ {
+ /* there is no point wasting bandwidth on cursor shadows
+ * that we're just going to throw out anyway */
+ g_rdp5_performanceflags |= PERF_DISABLE_CURSOR_SHADOW;
+ }
STRNCPY(server, argv[optind], sizeof(server));
parse_server_and_port(server);
diff --git a/rdp.c b/rdp.c
index cf1091c..03c868e 100644
--- a/rdp.c
+++ b/rdp.c
@@ -1171,6 +1171,7 @@ process_demand_active(STREAM s)
static void
process_colour_pointer_common(STREAM s, int bpp)
{
+ extern RD_BOOL g_local_cursor;
uint16 width, height, cache_idx, masklen, datalen;
uint16 x, y;
uint8 *mask;
@@ -1194,6 +1195,7 @@ process_colour_pointer_common(STREAM s, int bpp)
/* keep hotspot within cursor bounding box */
x = MIN(x, width - 1);
y = MIN(y, height - 1);
+ if (g_local_cursor) return ; /* don't bother creating a cursor we won't use */
cursor = ui_create_cursor(x, y, width, height, mask, data, bpp);
ui_set_cursor(cursor);
cache_put_cursor(cache_idx, cursor);
diff --git a/xwin.c b/xwin.c
index 6282e98..071c722 100644
--- a/xwin.c
+++ b/xwin.c
@@ -3088,6 +3088,8 @@ ui_create_cursor(unsigned int xhot, unsigned int yhot, uint32 width,
void
ui_set_cursor(RD_HCURSOR cursor)
{
+ extern RD_BOOL g_local_cursor;
+ if (g_local_cursor) return ;
logger(GUI, Debug, "ui_set_cursor(): g_current_cursor = %p, new = %p",
g_current_cursor, cursor);
| 0 | 31 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
fc1d563ef5f5f95ac77c298527b0fcbe770eb4ff
|
Closing unnecessary fds before askpass execution
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@96 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit fc1d563ef5f5f95ac77c298527b0fcbe770eb4ff
Author: Peter Åstrand <[email protected]>
Date: Fri Aug 9 11:55:39 2002 +0000
Closing unnecessary fds before askpass execution
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@96 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/readpass.c b/readpass.c
index cef9cca..44f74fc 100644
--- a/readpass.c
+++ b/readpass.c
@@ -26,6 +26,8 @@
#include <assert.h>
#include <unistd.h>
#include <sys/wait.h>
+#include <sys/stat.h>
+#include <fcntl.h>
/* Execute specified askpass program and fetch password from standard
output. Return NULL on failure, otherwise a pointer to the data
@@ -39,6 +41,7 @@ askpass(char *askpass, const char *msg)
char *pass;
int p[2], status, ret;
char buf[1024];
+ int devnull;
if (fflush(stdout) != 0)
error("askpass: fflush: %s", strerror(errno));
@@ -62,11 +65,28 @@ askpass(char *askpass, const char *msg)
setuid(getuid());
/* Close read end */
close(p[0]);
+
+ /* Setup stdin */
+ devnull = open("/dev/null", 0, O_RDONLY);
+ if (dup2(devnull, STDIN_FILENO) < 0)
+ {
+ error("askpass: dup2: %s", strerror(errno));
+ exit(1);
+ }
+ close(devnull);
+
+ /* Setup stdout */
if (dup2(p[1], STDOUT_FILENO) < 0)
{
error("askpass: dup2: %s", strerror(errno));
exit(1);
}
+ close(p[1]);
+
+ /* By now, the following fds are open:
+ 0 -> /dev/null
+ 1 -> pipe write end
+ 2 -> users terminal */
execlp(askpass, askpass, msg, (char *) 0);
error("askpass: exec(%s): %s", askpass, strerror(errno));
exit(1);
| 0 | 19 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
ea2bdbc96b1d83cf06c31a805ee6325c5238f857
|
This patch is a re-work of patch r1538. One one hand, the plain old
behaviour of setting the session size in ui_init is not going to work,
due to xrandr, as pointed out in r1538. However, the approach
implemented in this revision doesn't work either: When the window is
created before the connection, this means that as soon as X11 events
are recieved, this is going to trigger RDP transmissions. For example,
a call to reset_modifiers_keys. But if the RDP connection is not
ready, the WTS is not prepared to handle such data. We must wait with,
for example, keyboard input until the connection is READY. OTOH, we
can't just ignore those X11 events; that might lead to that we are not
sending information that we need to send.
So, it is actually better to wait with creating the window until we
have been connected. An additional advantage of this is that for the
load balancing / session directory case, there's no risk of confusion
of which RDP connection we are actually sending data to.
The previous behaviour of creating the window after we have been
connected has been restored.
Since we still need to set connection data (currently screen size) on
a per connection basis, we need to create a new UI function for this.
Non-X11 backends need to implement this new function.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1545 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit ea2bdbc96b1d83cf06c31a805ee6325c5238f857
Author: Peter Åstrand <[email protected]>
Date: Wed Jan 13 13:51:06 2010 +0000
This patch is a re-work of patch r1538. One one hand, the plain old
behaviour of setting the session size in ui_init is not going to work,
due to xrandr, as pointed out in r1538. However, the approach
implemented in this revision doesn't work either: When the window is
created before the connection, this means that as soon as X11 events
are recieved, this is going to trigger RDP transmissions. For example,
a call to reset_modifiers_keys. But if the RDP connection is not
ready, the WTS is not prepared to handle such data. We must wait with,
for example, keyboard input until the connection is READY. OTOH, we
can't just ignore those X11 events; that might lead to that we are not
sending information that we need to send.
So, it is actually better to wait with creating the window until we
have been connected. An additional advantage of this is that for the
load balancing / session directory case, there's no risk of confusion
of which RDP connection we are actually sending data to.
The previous behaviour of creating the window after we have been
connected has been restored.
Since we still need to set connection data (currently screen size) on
a per connection basis, we need to create a new UI function for this.
Non-X11 backends need to implement this new function.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1545 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/proto.h b/proto.h
index 75287ad..3486abc 100644
--- a/proto.h
+++ b/proto.h
@@ -231,6 +231,7 @@ void rdp_send_scancode(uint32 time, uint16 flags, uint8 scancode);
/* xwin.c */
RD_BOOL get_key_state(unsigned int state, uint32 keysym);
RD_BOOL ui_init(void);
+void ui_init_connection(void);
void ui_deinit(void);
RD_BOOL ui_create_window(void);
void ui_resize_window(void);
diff --git a/rdesktop.c b/rdesktop.c
index b7ffd52..24a80c8 100644
--- a/rdesktop.c
+++ b/rdesktop.c
@@ -965,9 +965,7 @@ main(int argc, char *argv[])
while (run_count < 2 && continue_connect) /* add support for Session Directory; only reconnect once */
{
- if (run_count == 0)
- if (!ui_create_window())
- return EX_OSERR;
+ ui_init_connection();
if (run_count == 0)
{
@@ -986,6 +984,10 @@ main(int argc, char *argv[])
DEBUG(("Connection successful.\n"));
memset(password, 0, sizeof(password));
+ if (run_count == 0)
+ if (!ui_create_window())
+ return EX_OSERR;
+
if (continue_connect)
rdp_main_loop(&deactivated, &ext_disc_reason);
diff --git a/xwin.c b/xwin.c
index 369bf60..f4715fc 100644
--- a/xwin.c
+++ b/xwin.c
@@ -1818,6 +1818,7 @@ error_handler(Display * dpy, XErrorEvent * eev)
return g_old_error_handler(dpy, eev);
}
+/* Initialize the UI. This is done once per process. */
RD_BOOL
ui_init(void)
{
@@ -1894,6 +1895,53 @@ ui_init(void)
return True;
}
+
+/*
+ Initialize connection specific data, such as session size.
+ */
+void
+ui_init_connection(void)
+{
+ /*
+ * Determine desktop size
+ */
+ if (g_fullscreen)
+ {
+ g_width = WidthOfScreen(g_screen);
+ g_height = HeightOfScreen(g_screen);
+ g_using_full_workarea = True;
+ }
+ else if (g_width < 0)
+ {
+ /* Percent of screen */
+ if (-g_width >= 100)
+ g_using_full_workarea = True;
+ g_height = HeightOfScreen(g_screen) * (-g_width) / 100;
+ g_width = WidthOfScreen(g_screen) * (-g_width) / 100;
+ }
+ else if (g_width == 0)
+ {
+ /* Fetch geometry from _NET_WORKAREA */
+ uint32 x, y, cx, cy;
+ if (get_current_workarea(&x, &y, &cx, &cy) == 0)
+ {
+ g_width = cx;
+ g_height = cy;
+ g_using_full_workarea = True;
+ }
+ else
+ {
+ warning("Failed to get workarea: probably your window manager does not support extended hints\n");
+ g_width = WidthOfScreen(g_screen);
+ g_height = HeightOfScreen(g_screen);
+ }
+ }
+
+ /* make sure width is a multiple of 4 */
+ g_width = (g_width + 3) & ~3;
+}
+
+
void
ui_deinit(void)
{
@@ -1961,44 +2009,6 @@ ui_create_window(void)
long input_mask, ic_input_mask;
XEvent xevent;
- /*
- * Determine desktop size
- */
- if (g_fullscreen)
- {
- g_width = WidthOfScreen(g_screen);
- g_height = HeightOfScreen(g_screen);
- g_using_full_workarea = True;
- }
- else if (g_width < 0)
- {
- /* Percent of screen */
- if (-g_width >= 100)
- g_using_full_workarea = True;
- g_height = HeightOfScreen(g_screen) * (-g_width) / 100;
- g_width = WidthOfScreen(g_screen) * (-g_width) / 100;
- }
- else if (g_width == 0)
- {
- /* Fetch geometry from _NET_WORKAREA */
- uint32 x, y, cx, cy;
- if (get_current_workarea(&x, &y, &cx, &cy) == 0)
- {
- g_width = cx;
- g_height = cy;
- g_using_full_workarea = True;
- }
- else
- {
- warning("Failed to get workarea: probably your window manager does not support extended hints\n");
- g_width = WidthOfScreen(g_screen);
- g_height = HeightOfScreen(g_screen);
- }
- }
-
- /* make sure width is a multiple of 4 */
- g_width = (g_width + 3) & ~3;
-
wndwidth = g_fullscreen ? WidthOfScreen(g_screen) : g_width;
wndheight = g_fullscreen ? HeightOfScreen(g_screen) : g_height;
| 0 | 54 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
869be1e63208dcc27d837023e3a4fd3867e317bd
|
Removed README; now in doc/keymapping.txt
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@104 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 869be1e63208dcc27d837023e3a4fd3867e317bd
Author: Peter Åstrand <[email protected]>
Date: Sun Sep 1 10:22:51 2002 +0000
Removed README; now in doc/keymapping.txt
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@104 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/keymaps/README b/keymaps/README
deleted file mode 100644
index 418397f..0000000
--- a/keymaps/README
+++ /dev/null
@@ -1,79 +0,0 @@
-Keymap-files
-============
-The keymaps are line based. There are three different types of lines:
-
-1) include-lines
-Syntax:
-include <another-map-file>
-
-
-2) map-lines
-Syntax:
-map <hex-number>
-
-Map-lines specifies how the remote RDP server should interpret the
-sent scancodes.
-
-
-3) Translation-lines
-Syntax:
-<keysym-name> <scancode> [flags..]
-
-The scancode can be found in scancodes.h. Note: The scancode value for
-extended keys can be calculated by OR:ing with 0x80. Example: The
-Delete key have the scancode sequence 0xe0, 0x52. You can get the
-scancode value to put into the map file by running:
-
-python -c "print hex(0x80 | 0x52)"
-
-If flags are "altgr", "shift", "numlock", the scancode sent for this
-keysym will be prefix with AltGr, Shift or Numlock.
-
-If flags include "addupper", an translation for this keysyms uppercase
-name will as well, in addition to the non-uppercase name. Example:
-
-x 2d addupper
-
-...will add an translation for "X" automatically, just like if you
-would specify:
-
-X 2d shift
-
-If flags include "localstate", the modifier to send will be determined
-by the local modifier state.
-
-
-4) enable_compose
-
-If any line starts with the keyword "enable_compose", rdesktop will
-enable local Compose/Multi_key handling. Enabling this will often make
-it impossible to compose characters with dead keys (on the remote
-side). This is because when local compose support is enabled, dead
-keys will not be sent to the remote side.
-
-
-Suggested X11 keysym mapping on PCs
-===================================
-Unfortunately, there is no standard for which keysyms a given key
-should generate. If you have a PC-keyboard with Windows keys, I suggest this mapping:
-
-Keyboard keys:
-CtrlLeft WinLeft AltLeft Space AltGr WinRight Menu CtrlRight
-
-...should generate keysyms:
-Control_L Hyper_L Alt_L space Mode_switch Hyper_R Menu Control_R
-
-Additionally:
-Shift-Alt should produce Meta_L
-Shift-AltGr should produce Multi_Key.
-
-Use a modifier-map like this:
-
-shift Shift_L (0x32), Shift_R (0x3e)
-lock Caps_Lock (0x25)
-control Control_L (0x42), Control_R (0x6d)
-mod1 Alt_L (0x40)
-mod2 Num_Lock (0x4d)
-mod3 Mode_switch (0x71)
-mod4 Hyper_L (0x73), Hyper_R (0x74)
-mod5 Scroll_Lock (0x4e)
| 0 | 96 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
d2e07bca4ad5e9f2790a5ece27f3fbe61ed67cc4
|
Updated with info about hostname-patch.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@137 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit d2e07bca4ad5e9f2790a5ece27f3fbe61ed67cc4
Author: Peter Åstrand <[email protected]>
Date: Sat Sep 14 16:22:46 2002 +0000
Updated with info about hostname-patch.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@137 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/patches.txt b/doc/patches.txt
index c8a1b0d..12691eb 100644
--- a/doc/patches.txt
+++ b/doc/patches.txt
@@ -110,9 +110,16 @@ From what I can tell, this patch is no longer necessary.
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/hostname-patch
Description:
-TDB
+(From http://mail.rdesktop.org/archive/2001/msg00163.html):
+
+rdesktop uses gethostname to figure out the hostname, but gethostname
+under linux returns an error when the hostname is longer than the
+buffer. This hack gives gethostname a 64 char buffer and then strips
+the first 16 chars or upto the first '.' and puts the result in
+hostname[16].
+
Status:
-Not yet examined.
+Applied in version 1.10 of rdesktop.c.
URL:
| 0 | 41 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
db9b485501de47f94086b302d611fa8842ac605f
|
Updated with info about norbert_percent.txt.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@141 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit db9b485501de47f94086b302d611fa8842ac605f
Author: Peter Åstrand <[email protected]>
Date: Sat Sep 14 16:39:43 2002 +0000
Updated with info about norbert_percent.txt.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@141 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/patches.txt b/doc/patches.txt
index 9ea8513..83028e6 100644
--- a/doc/patches.txt
+++ b/doc/patches.txt
@@ -150,9 +150,10 @@ Applied.
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/norbert_percent.txt
Description:
-TDB
+Makes is possible to specify RDP geometry based a percent value of the
+current desktop size.
Status:
-Not yet examined.
+Not applied. I don't think many people will need this.
URL:
| 0 | 62 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
4e95dbd8cd9e2692a0ebe43dcc23d2140fcf5aeb
|
Added missing parameters to man-page
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@504 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 4e95dbd8cd9e2692a0ebe43dcc23d2140fcf5aeb
Author: Michael Gernoth <[email protected]>
Date: Sun Oct 19 12:05:23 2003 +0000
Added missing parameters to man-page
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@504 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/rdesktop.1 b/doc/rdesktop.1
index ccee1f5..3c01ea9 100644
--- a/doc/rdesktop.1
+++ b/doc/rdesktop.1
@@ -70,6 +70,10 @@ higher-level drawing operations.
Disable encryption. This option is only needed (and will only work) if you
have a French version of NT TSE.
.TP
+.BR "-E"
+Disable encryption from client to server. This sends an encrypted login-packet,
+but everything after this is unencrypted. This also includes interactive logins.
+.TP
.BR "-m"
Do not send mouse motion events. This saves bandwidth, although some Windows
applications may rely on receiving mouse motion.
@@ -87,6 +91,24 @@ Window title.
.TP
.BR "-D"
Hide window manager decorations, by using MWM hints.
+.TP
+.BR "-a <bpp>"
+Use bpp as colourdepth for the connection. Supported are 8, 15, 16 and 24.
+More than 8 bpp are only supported when connecting to Windows XP or
+Windows Server 2003.
+.TP
+.BR "-0"
+Attach to the console of the Server.
+.TP
+.BR "-4"
+Use RDP version 4.
+.TP
+.BR "-5"
+Use RDP version 5 (default).
+.TP
+.BR "-r redirection"
+Enable/disable specific resource-redirections. Please have a look at
+redirection.txt for more informations.
.PP
.SH LINKS
| 0 | 99 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
4580492c1224f9c5d72f8863e8027563d58494ec
|
Prefer online resize over reconnect resizes
We had a case on Windows 2012R2 where any early resizes would be
handled by a reconnect rather than an online resize, which led to a
bunch of follow-up problems with the session startup.
To solve this, we gave the RDPEDISP channel more time to become
established.
Co-authored-by: Henrik Andersson <[email protected]>
Co-authored-by: Karl Mikaelsson <[email protected]>
|
commit 4580492c1224f9c5d72f8863e8027563d58494ec
Author: Cendio <[email protected]>
Date: Wed Mar 7 10:49:25 2018 +0100
Prefer online resize over reconnect resizes
We had a case on Windows 2012R2 where any early resizes would be
handled by a reconnect rather than an online resize, which led to a
bunch of follow-up problems with the session startup.
To solve this, we gave the RDPEDISP channel more time to become
established.
Co-authored-by: Henrik Andersson <[email protected]>
Co-authored-by: Karl Mikaelsson <[email protected]>
diff --git a/rdpedisp.c b/rdpedisp.c
index 43903ae..d1f27b8 100644
--- a/rdpedisp.c
+++ b/rdpedisp.c
@@ -28,6 +28,7 @@
extern int g_dpi;
extern RD_BOOL g_pending_resize_defer;
+extern struct timeval g_pending_resize_defer_timer;
static void rdpedisp_send(STREAM s);
static void rdpedisp_init_packet(STREAM s, uint32 type, uint32 length);
@@ -45,8 +46,15 @@ rdpedisp_process_caps_pdu(STREAM s)
"rdpedisp_process_caps_pdu(), Max supported monitor area (square pixels) is %d",
tmp[0] * tmp[1] * tmp[2]);
- /* Start allowing session resizes */
+ /* When the RDPEDISP channel is established, we allow dynamic
+ session resize straight away by clearing the defer flag and
+ the defer timer. This lets process_pending_resize() start
+ processing pending resizes immediately. We expect that
+ process_pending_resize will prefer RDPEDISP resizes over
+ disconnect/reconnect resizes. */
g_pending_resize_defer = False;
+ g_pending_resize_defer_timer.tv_sec = 0;
+ g_pending_resize_defer_timer.tv_usec = 0;
}
static void
diff --git a/xwin.c b/xwin.c
index 6fa4343..5fcd99d 100644
--- a/xwin.c
+++ b/xwin.c
@@ -3065,9 +3065,22 @@ process_pending_resize ()
/* There is a race problem when using disconnect / reconnect
sequence were one sometimes would be presented with
unexpected login window. Waiting a little bit extra after
- getting the reconnect cookie solves this problem. */
+ getting the reconnect cookie solves this problem.
+
+ In addition to that delay, we also want to wait for
+ RDPEDISP to become available. In scenarios where we can use
+ both online and reconnect-based resizes, we prefer
+ online. Our brief investigation shows that RDPEDISP support
+ is established about 100-300 ms after the login info packet
+ was received. Thus, we want to wait a bit so we can avoid
+ resizes using reconnect. Once RDPEDISP is established, the
+ defer timer is cleared, so there will be no delay before
+ the first resize for servers that support RDPEDISP. Other
+ servers will get the initial resize delayed with 2 seconds.
+ */
+
if (timeval_is_set(&g_pending_resize_defer_timer) &&
- time_difference_in_ms(g_pending_resize_defer_timer, now) >= 100)
+ time_difference_in_ms(g_pending_resize_defer_timer, now) >= 2000)
{
g_pending_resize_defer_timer.tv_sec = g_pending_resize_defer_timer.tv_usec = 0;
g_pending_resize_defer = False;
| 0 | 9 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
5100adfecaee55fa62fc24622e61deaee2c5e590
|
Added a few more TODOs for SeamlessRDP.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1203 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 5100adfecaee55fa62fc24622e61deaee2c5e590
Author: Peter Åstrand <[email protected]>
Date: Mon Mar 27 08:40:58 2006 +0000
Added a few more TODOs for SeamlessRDP.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1203 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/TODO b/doc/TODO
index f80d39d..bb31d0b 100644
--- a/doc/TODO
+++ b/doc/TODO
@@ -84,3 +84,10 @@
* Implement something similiar to explhook.dll - support for running
explorer.exe in non-shell mode.
+
+ * Better compatibility with Task Manager.
+
+ * XINERAMA support.
+
+ * When enumerating windows, make sure to send info about windows
+ that are transient for other windows after the referred window.
| 0 | 73 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
f6520423f4bb19a652090265d225289390f5d3ab
|
If WITH_DEBUG, print the number of the packet just received, which makes
it easier to follow the packet on the network.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@339 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit f6520423f4bb19a652090265d225289390f5d3ab
Author: Erik Forsberg <[email protected]>
Date: Thu Mar 6 14:11:17 2003 +0000
If WITH_DEBUG, print the number of the packet just received, which makes
it easier to follow the packet on the network.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@339 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/rdp.c b/rdp.c
index 730afe8..10daf82 100644
--- a/rdp.c
+++ b/rdp.c
@@ -30,6 +30,10 @@ extern BOOL desktop_save;
uint8 *next_packet;
uint32 rdp_shareid;
+#if WITH_DEBUG
+static uint32 packetno;
+#endif
+
/* Initialise an RDP packet */
static STREAM
rdp_init(int maxlen)
@@ -91,7 +95,7 @@ rdp_recv(uint8 * type)
*type = pdu_type & 0xf;
#if WITH_DEBUG
- DEBUG(("RDP packet (type %x):\n", *type));
+ DEBUG(("RDP packet #%d, (type %x):\n", ++packetno, *type));
hexdump(next_packet, length);
#endif /* */
| 0 | 25 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
09024cf458927aaf7bb996b8450c26cc47183058
|
Revert to old behaviour of connecting before creating the UI.
This is to stop the UI generating input before the connection is complete
(which causes connection failures). The one difficulty is that ui_select
is now called before ui_create_window, which may cause problems for other
UIs - we may still need to change this in the future.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@52 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 09024cf458927aaf7bb996b8450c26cc47183058
Author: Matt Chapman <[email protected]>
Date: Tue May 28 11:48:55 2002 +0000
Revert to old behaviour of connecting before creating the UI.
This is to stop the UI generating input before the connection is complete
(which causes connection failures). The one difficulty is that ui_select
is now called before ui_create_window, which may cause problems for other
UIs - we may still need to change this in the future.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@52 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/rdesktop.c b/rdesktop.c
index e89008b..5f7ade6 100644
--- a/rdesktop.c
+++ b/rdesktop.c
@@ -214,19 +214,19 @@ main(int argc, char *argv[])
strcpy(title, "rdesktop - ");
strncat(title, server, sizeof(title) - sizeof("rdesktop - "));
+ if (!rdp_connect(server, flags, domain, password, shell, directory))
+ return 1;
+
+ printf("Connection successful.\n");
+
if (ui_create_window(title))
{
- if (!rdp_connect(server, flags, domain, password, shell,
- directory))
- return 1;
-
- printf("Connection successful.\n");
rdp_main_loop();
- printf("Disconnecting...\n");
ui_destroy_window();
- rdp_disconnect();
}
+ printf("Disconnecting...\n");
+ rdp_disconnect();
return 0;
}
diff --git a/xwin.c b/xwin.c
index 6ca8303..f26d9c4 100644
--- a/xwin.c
+++ b/xwin.c
@@ -397,9 +397,6 @@ xwin_process_events()
uint32 ev_time;
uint32 tmpmods;
- if (display == NULL)
- return;
-
while (XCheckMaskEvent(display, ~0, &xkbevent.core))
{
ev_time = time(NULL);
@@ -594,15 +591,17 @@ ui_select(int rdp_socket)
int n = (rdp_socket > x_socket) ? rdp_socket+1 : x_socket+1;
fd_set rfds;
- XFlush(display);
-
FD_ZERO(&rfds);
while (True)
{
FD_ZERO(&rfds);
FD_SET(rdp_socket, &rfds);
- FD_SET(x_socket, &rfds);
+ if (display != NULL)
+ {
+ FD_SET(x_socket, &rfds);
+ XFlush(display);
+ }
switch (select(n, &rfds, NULL, NULL, NULL))
{
| 0 | 60 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
8a91f9e27905293fc521bb64043d459f31a700c2
|
Updated comments with reality.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@456 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 8a91f9e27905293fc521bb64043d459f31a700c2
Author: Peter Åstrand <[email protected]>
Date: Sun Aug 31 20:04:05 2003 +0000
Updated comments with reality.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@456 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/keymaps/modifiers b/keymaps/modifiers
index 6ef0ac6..06c4344 100644
--- a/keymaps/modifiers
+++ b/keymaps/modifiers
@@ -8,17 +8,8 @@ Alt_L 0x38
Control_R 0x9d
Control_L 0x1d
-# Translate Meta, Super and Hyper to Windows key. It seems the RDP
-# protocol does not support these keys directly. Therefore, rdesktop
-# currently translates the keysyms listed below into Ctrl-Esc. This is
-# hard-coded, since multiple scancodes cannot be specified in keymap
-# files.
-#Meta_L 0xdb
-#Super_L 0xdb
-#Hyper_L 0xdb
-#Meta_R 0xdc
-#Super_R 0xdc
-#Hyper_R 0xdc
+# Translate Meta, Super and Hyper to Windows keys.
+# This is hardcoded. See documentation for details.
# Translate Menu to the Windows Application key.
# This one does not work either.
| 0 | 53 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
2671e6902708b7c94e9c9e477027019ad4384db8
|
Support for non-dead keys and autodetection of keymap has been
implemented.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@971 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 2671e6902708b7c94e9c9e477027019ad4384db8
Author: Peter Åstrand <[email protected]>
Date: Thu Aug 4 12:11:10 2005 +0000
Support for non-dead keys and autodetection of keymap has been
implemented.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@971 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/TODO b/doc/TODO
index 56d1e77..7513c3e 100644
--- a/doc/TODO
+++ b/doc/TODO
@@ -27,13 +27,6 @@
* Keymapping:
- * Support non-dead versions of some dead keys, like
- "acute". It seems like RDP4 only supports the dead versions, but
- the non-dead ones can be simulated by sending a space after the
- dead key.
-
- * Autodetect which keymap to use.
-
* Sound redirection
| 0 | 64 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
6036a9a2492b87a5355cd10eab3aa19d918f5510
|
Added note about dead keys.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@269 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 6036a9a2492b87a5355cd10eab3aa19d918f5510
Author: Peter Åstrand <[email protected]>
Date: Tue Nov 19 13:47:46 2002 +0000
Added note about dead keys.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@269 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/TODO b/doc/TODO
index 9bbbcec..475fcd9 100644
--- a/doc/TODO
+++ b/doc/TODO
@@ -1,2 +1,7 @@
* Implement support for RDP 5.X features, like cut-n-paste, sound and
serial port redirection.
+
+* Keymapping: Support non-dead versions of some dead keys, like
+ "acute". It seems like RDP4 only supports the dead versions, but the
+ non-dead ones can be simulated by sending a space after the dead
+ key.
| 0 | 65 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
470741631421a0cfa3b6454d2720f04098e64e84
|
Make sure we close the connection before redirect.
Complementary fix for commit r1825.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1827 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 470741631421a0cfa3b6454d2720f04098e64e84
Author: Henrik Andersson <[email protected]>
Date: Tue Sep 2 10:24:40 2014 +0000
Make sure we close the connection before redirect.
Complementary fix for commit r1825.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1827 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/rdesktop.c b/rdesktop.c
index cbc7263..4e887b4 100644
--- a/rdesktop.c
+++ b/rdesktop.c
@@ -1159,7 +1159,10 @@ main(int argc, char *argv[])
}
if (g_redirect)
+ {
+ rdp_disconnect();
continue;
+ }
/* By setting encryption to False here, we have an encrypted login
packet but unencrypted transfer of other packets */
| 0 | 22 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
290fd9b54dd2682ee6587d070f0b8d895982f06d
|
How to make a new release.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1624 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 290fd9b54dd2682ee6587d070f0b8d895982f06d
Author: Peter Åstrand <[email protected]>
Date: Mon Apr 18 07:53:52 2011 +0000
How to make a new release.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1624 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/makerelease.txt b/doc/makerelease.txt
new file mode 100644
index 0000000..c509399
--- /dev/null
+++ b/doc/makerelease.txt
@@ -0,0 +1,20 @@
+
+* Update doc/ChangeLog
+
+* Update version in configure.ac and rdesktop.spec
+
+* Create a tarball: "make dist". Verify that it contains only relevant files
+
+* Test build the tarball on a few systems. Test "rpmbuild -ta" as well
+
+* Tag:
+ svn copy https://rdesktop.svn.sourceforge.net/svnroot/rdesktop/rdesktop/trunk \
+ https://rdesktop.svn.sourceforge.net/svnroot/rdesktop/rdesktop/tags/rdesktop-x.y.z
+
+* Do a new SF file release
+
+* Send announcement to the mailing list
+
+* Update Freshmeat entry
+
+* Append "post" to VERSION
| 0 | 77 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
dcfcf59f60388a7a6e874077416b5b2063fa067b
|
Fix segfault when using a relative folder name with disk redirection
Until this commit using "-r disk:floppy=my_floppy" causes a segfault.
You had to use "-r disk:floppy=./my_floppy" to use a folder in the current path.
|
commit dcfcf59f60388a7a6e874077416b5b2063fa067b
Author: HenryJacques <[email protected]>
Date: Tue May 3 16:13:27 2016 +0200
Fix segfault when using a relative folder name with disk redirection
Until this commit using "-r disk:floppy=my_floppy" causes a segfault.
You had to use "-r disk:floppy=./my_floppy" to use a folder in the current path.
diff --git a/disk.c b/disk.c
index 31d07c0..223d64b 100644
--- a/disk.c
+++ b/disk.c
@@ -654,7 +654,10 @@ disk_query_information(RD_NTHANDLE handle, uint32 info_class, STREAM out)
if (S_ISDIR(filestat.st_mode))
file_attributes |= FILE_ATTRIBUTE_DIRECTORY;
- filename = 1 + strrchr(path, '/');
+ filename = strrchr(path, '/');
+ if (filename)
+ filename += 1;
+
if (filename && filename[0] == '.')
file_attributes |= FILE_ATTRIBUTE_HIDDEN;
| 0 | 8 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
05d0cc957e8d92899a865249bff498a4ffe6ee00
|
adding some info about -r args.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@580 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 05d0cc957e8d92899a865249bff498a4ffe6ee00
Author: Peter Kallden <[email protected]>
Date: Fri Jan 23 14:34:47 2004 +0000
adding some info about -r args.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@580 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/rdesktop.1 b/doc/rdesktop.1
index 30042f8..852c4fe 100644
--- a/doc/rdesktop.1
+++ b/doc/rdesktop.1
@@ -1,4 +1,4 @@
-.TH rdesktop 1 "October 2002"
+.TH rdesktop 1 "January 2004"
.SH NAME
.I rdesktop
\- Remote Desktop Protocol client
@@ -105,9 +105,34 @@ limited by the server configuration.
.TP
.BR "-r <device>"
Enable redirection of the specified device on the client, such
-that it appears on the server. The only device currently supported
-is "sound" (requires Windows XP or newer). Note that the allowed
+that it appears on the server. Note that the allowed
redirections may be restricted by the server configuration.
+
+Following devices are currently supported:
+.TP
+.BR "-r comport:<comport>=<device>,..."
+Redirects serial devices on your client to the
+server. Note that if you need to change any settings on the serial device(s),
+do so with an appropriate tool before starting rdesktop. In most
+OSes you would use stty.
+.TP
+.BR "-r disk:<driveletter>=<path>,..."
+Redirects a path to the drive letter of your choice on the server.
+(requires Windows XP or newer).
+.TP
+.BR "-r lptport:<lptport>=<device>,..."
+Redirects parallel devices on your client to the server.
+.TP
+.BR "-r printer:<printername>[=<driver>],..."
+Redirects a printer queue on the client to the server. The <printername>
+is the name of the queue in your local system. <driver> defaults to a
+simple PS-driver unless you specify one. Keep in mind that you need a
+100% match in the server environment, or the driver will fail. The first
+printer on the command line will be set as your default printer.
+.TP
+.BR "-r sound"
+Redirects sound generated on the server to the client ( Requires
+Windows XP or newer).
.TP
.BR "-0"
Attach to the console of the server (requires Windows Server 2003
@@ -118,7 +143,6 @@ Use RDP version 4.
.TP
.BR "-5"
Use RDP version 5 (default).
-
.PP
.SH LINKS
Main website of rdesktop
| 0 | 94 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
b9b6c830c45cc9b4d725979db27d864f54a003ef
|
Added ipv6.txt
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@440 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit b9b6c830c45cc9b4d725979db27d864f54a003ef
Author: Peter Åstrand <[email protected]>
Date: Mon Aug 11 11:12:32 2003 +0000
Added ipv6.txt
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@440 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/ipv6.txt b/doc/ipv6.txt
new file mode 100644
index 0000000..a0ccc11
--- /dev/null
+++ b/doc/ipv6.txt
@@ -0,0 +1,21 @@
+
+IPv6 support in rdesktop
+========================
+The IPv6 support was developed by Mike Dawson <[email protected]>:
+
+ Attached is a patch to tcp.c to enable IPv6 support. Build with
+ 'IPv6' defined to enable it. It's so far only been tested on
+ Linux 2.4.21 connecting to Windows XP SP1.
+
+ Since terminal services doesn't seem to bind to the ipv6 interface
+ on XP I had to run 'netsh interface portproxy add v6tov4
+ listenport=3389 connectport=33 89' from the windows command prompt
+ to get it to work.
+
+ One problem is that numeric ipv6 addresses on the command line
+ don't work as they conflict with the host:port format for
+ specifying host names. Fixes for this I can think of include:
+
+ * have a -6 switch for enabling ipv6 support
+ * change the host:port format to 'host -P port' or something
+ * more complicated parsing of the given host/address
| 0 | 76 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
2b39b63722772b47dc111bec85afa42624a299a7
|
Added some test cases.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1219 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 2b39b63722772b47dc111bec85afa42624a299a7
Author: Peter Åstrand <[email protected]>
Date: Fri Apr 7 22:36:12 2006 +0000
Added some test cases.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1219 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/keymapping.txt b/doc/keymapping.txt
index 2d440e0..6d10eae 100644
--- a/doc/keymapping.txt
+++ b/doc/keymapping.txt
@@ -208,3 +208,36 @@ Special keys
Links
=====
http://www.win.tue.nl/~aeb/linux/kbd/scancodes.html
+
+
+Test cases
+==========
+When changing the keyboard code, make sure all these tests in Notepad
+works:
+
+1. Ctrl+f should bring up Find dialog, with CapsLock both on and off.
+
+2. Ctrl+Shift+arrows should mark text, with CapsLock both on and off.
+
+3. Test a sequence, like egrave.
+
+4. Test a char generated with AltGr, such as @ on a swedish keyboard.
+
+5. Test Ctrl-Alt-Delete.
+
+6. Ctrl-Alt-Enter should toggle fullscreen.
+
+7. Test NumLock synchronization using the -N option. Excel is able to
+ indicate the current NumLock state. Verify that the status is
+ updated correctly on reconnects.
+
+8. Test the Windows keys, standalone as well as in combination with,
+ say, E.
+
+9. Make sure the system menu (via Alt-space) cannot be accessed in
+ single app mode.
+
+10. Make sure keymaps can be loaded from ~/.rdesktop/keymaps,
+ KEYMAP_PATH, $CWD/keymaps, and from an absolute path.
+
+
| 0 | 87 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
91f3b6151f8edf7ffa8f95f8cc03d4ea6c3ed38e
|
Changed style of copyright header to match the other files
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1533 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 91f3b6151f8edf7ffa8f95f8cc03d4ea6c3ed38e
Author: Peter Åstrand <[email protected]>
Date: Tue Jan 12 08:06:15 2010 +0000
Changed style of copyright header to match the other files
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1533 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/printercache.c b/printercache.c
index 2db9509..5204bdd 100644
--- a/printercache.c
+++ b/printercache.c
@@ -1,23 +1,23 @@
/* -*- c-basic-offset: 8 -*-
- * rdesktop: A Remote Desktop Protocol client.
- * Entrypoint and utility functions
- * Copyright (C) Matthew Chapman 1999-2008
- * Copyright (C) Jeroen Meijer 2003-2008
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
- */
+ rdesktop: A Remote Desktop Protocol client.
+ Entrypoint and utility functions
+ Copyright (C) Matthew Chapman 1999-2008
+ Copyright (C) Jeroen Meijer 2003-2008
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+*/
/* According to the W2K RDP Printer Redirection WhitePaper, a data
* blob is sent to the client after the configuration of the printer
| 0 | 83 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
faa696f9fa667fae55c6e3c9dfa59864c359decd
|
Added README
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@108 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit faa696f9fa667fae55c6e3c9dfa59864c359decd
Author: Peter Åstrand <[email protected]>
Date: Sun Sep 1 11:37:28 2002 +0000
Added README
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@108 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/README b/README
new file mode 100644
index 0000000..8d02851
--- /dev/null
+++ b/README
@@ -0,0 +1,17 @@
+rdesktop is an open source client for Windows NT Terminal Server and
+Windows 2000 Terminal Services, capable of natively speaking Remote
+Desktop Protocol (RDP) in order to present the user's NT
+desktop. Unlike Citrix ICA, no server extensions are required.
+
+rdesktop currently runs on most UNIX based platforms with the X Window
+System, and other ports should be fairly straightforward.
+
+rdesktop was written by Matt Chapman ([email protected]) based
+on various scarce documentation, wire sniffs, and trial-and-error. It
+is released under the GNU Public Licence (GPL). Please send feedback,
+bug reports and patches to the appropriate mailing list
+(http://sourceforge.net/mail/?group_id=24366)
+
+rdesktop is a Sourceforge project. See the Sourceforge rdesktop
+project info (http://sourceforge.net/projects/rdesktop/) for more
+information.
| 0 | 93 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
41d42b12a696ad10f749aeda66d8e93f4b7e9c35
|
Added some info about fasttext2+nobackpixmap.patch.
Using double blank lines between each patch entry.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@132 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 41d42b12a696ad10f749aeda66d8e93f4b7e9c35
Author: Peter Åstrand <[email protected]>
Date: Sat Sep 14 15:52:26 2002 +0000
Added some info about fasttext2+nobackpixmap.patch.
Using double blank lines between each patch entry.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@132 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/patches.txt b/doc/patches.txt
index 7ea7a76..064ba82 100644
--- a/doc/patches.txt
+++ b/doc/patches.txt
@@ -2,6 +2,7 @@ This file documents some of all patches for rdesktop, floating around
the net, and how they are related to the current (CVS) version of
rdesktop.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/Makefile.diff
Description:
@@ -10,6 +11,7 @@ and OSF1.
Status:
Applied (slightly modified)
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/assar_19-7-2.hostlen.patch
Description:
@@ -17,6 +19,7 @@ Fix for hostnames longer than 30 chars.
Status:
Applied (revision 1.11 of secure.c)
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/backingstore+privatecolormap-for-19-3-9.patch
Description:
@@ -28,6 +31,7 @@ map in 8 bpp mode. 2) is, as far as I understand, also not
need. rdesktop automatically uses a software backing store if the
Xserver does not provide one.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/ben_xwin.c.diff
Description:
@@ -35,6 +39,7 @@ Fixes for CapsLock and NumLock.
Status:
Not needed anymore, with the new keyboard mapping implementation.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/ctrl1nohang.diff
Description:
@@ -42,6 +47,7 @@ Fixes problem with ctrl1 hangs.
Status:
Not needed anymore, with the new keyboard mapping implementation.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/downkeypatch.diff
Description:
@@ -49,13 +55,31 @@ Seems to keep track of the remote modifier status.
Status:
Not needed anymore, with the new keyboard mapping implementation.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/fasttext2+nobackpixmap.patch
Description:
-TDB
+(From http://mail.rdesktop.org/archive/2001/msg00218.html):
+
+* Added --no-backpixmap option to disable the ugly double drawing in
+xwin.c (I have a very robust backing storage in my X, so I don't need
+it ;)
+
+* More optimizations to text draw (previous fast-text patch was
+included in 192-3-6-2). In text drawing with solid background the
+glyphs are drawn with stippled fill instead of XCopyPlane (runs faster
+on my S3Trio64 with XFree 3.3.6, please test it on other
+configurations to validate this). The WinTach not show any improvement
+with this change, it seems to use all transparent background text
+draws, but with a old PC Magazine Winbench (3.1) doing the scroll text
+test the speed gain is significative.
+
+* My Previous patch to disable backing storage in fullscreen
+
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/francisco_fix_patblt.html
Description:
@@ -63,6 +87,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/frank_1linerfix.html
Description:
@@ -70,6 +95,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/frank_fasttext.patch.txt
Description:
@@ -77,6 +103,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/hostname-patch
Description:
@@ -84,6 +111,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/hove-19-7-2endian.diff
Description:
@@ -91,6 +119,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/mmihalik_19-7-3-keyfix-4.patch
Description:
@@ -98,6 +127,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/norbert_fullscreen.patch
Description:
@@ -105,6 +135,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/norbert_percent.txt
Description:
@@ -112,6 +143,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/norbert_rdp_tcp_port.diff
Description:
@@ -119,6 +151,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/patch19-7-2.xyPos.emptyPassword.patch
Description:
@@ -126,6 +159,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/rdesktop-1.0.0-19-7-1-mmihalik-3.diff
Description:
@@ -133,6 +167,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/rdesktop-1.0.0-mmihalik-1.diff
Description:
@@ -140,6 +175,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/rdesktop-1.0.0-pl19-7-2-mmihalik-1.diff
Description:
@@ -147,6 +183,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/rdesktop-gmp.patch
Description:
@@ -154,6 +191,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/rdesktop-new_kb.patch
Description:
@@ -161,6 +199,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/rdesktop-openssl.patch
Description:
@@ -168,6 +207,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/rdesktop.vncviewer_patch
Description:
@@ -175,6 +215,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/rdesktop_keymap.patch
Description:
@@ -182,6 +223,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/rdp-srvr-19-6-6.diff
Description:
@@ -189,6 +231,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/scroll-to-death-patch.txt
Description:
@@ -196,6 +239,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/spark-manpage-patch-19.4
Description:
@@ -203,6 +247,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/spark-manpage-patch-19.4-1
Description:
@@ -210,6 +255,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/spark_xinerama-patch2
Description:
@@ -217,6 +263,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/svenni_dis_wmkeybnds.patch
Description:
@@ -224,6 +271,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/svenni_disable_bs_in_x-tiny-patch
Description:
@@ -231,6 +279,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/vincent_19-7-2.license.patch
Description:
@@ -238,6 +287,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/vincent_19-7-2.secure.patch
Description:
@@ -245,6 +295,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/vincent_19-7-3_excel.patch
Description:
@@ -252,6 +303,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/vincent_8bpp.patch
Description:
@@ -259,6 +311,7 @@ TDB
Status:
Not yet examined.
+
URL:
http://bibl4.oru.se/projects/rdesktop/patch19/patches/vpypatch.txt
Description:
| 0 | 75 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
567b1f74326c8ccacbeedc39f4833f543ace23c7
|
Clear password is smart card pin upon redirect
Upon a redirection, we have received a cookie that is used
for authentication and we should not flag this as a pin
code for the smartcard. This solves a problem with incorrect
pin code when using smart card authentication and if
redirected to a server were a session exists.
|
commit 567b1f74326c8ccacbeedc39f4833f543ace23c7
Author: Henrik Andersson <[email protected]>
Date: Tue Apr 17 16:57:05 2018 +0200
Clear password is smart card pin upon redirect
Upon a redirection, we have received a cookie that is used
for authentication and we should not flag this as a pin
code for the smartcard. This solves a problem with incorrect
pin code when using smart card authentication and if
redirected to a server were a session exists.
diff --git a/rdp.c b/rdp.c
index 2edc14b..dfe79cc 100644
--- a/rdp.c
+++ b/rdp.c
@@ -390,6 +390,7 @@ rdp_send_client_info_pdu(uint32 flags, char *domain, char *user,
if (g_redirect == True && g_redirect_cookie_len > 0)
{
+ flags &= ~RDP_INFO_PASSWORD_IS_SC_PIN;
flags |= RDP_INFO_AUTOLOGON;
len_password = g_redirect_cookie_len;
len_password -= 2; /* subtract 2 bytes which is added below */
| 0 | 24 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
24ee89b5ad2881376a2872f61d3c33c8518db82a
|
Clarified usage message for -E flag.
Fixed flag-collission (-E was used twice, the other -E is now -Q).
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@470 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 24ee89b5ad2881376a2872f61d3c33c8518db82a
Author: Erik Forsberg <[email protected]>
Date: Mon Sep 22 12:33:21 2003 +0000
Clarified usage message for -E flag.
Fixed flag-collission (-E was used twice, the other -E is now -Q).
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@470 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/rdesktop.c b/rdesktop.c
index 69213b8..1ce0117 100644
--- a/rdesktop.c
+++ b/rdesktop.c
@@ -81,7 +81,7 @@ usage(char *program)
fprintf(stderr, "Usage: %s [options] server[:port]\n", program);
#ifdef RDP2VNC
fprintf(stderr, " -V: vnc port\n");
- fprintf(stderr, " -E: defer time (ms)\n");
+ fprintf(stderr, " -Q: defer time (ms)\n");
#endif
fprintf(stderr, " -u: user name\n");
fprintf(stderr, " -d: domain\n");
@@ -95,7 +95,7 @@ usage(char *program)
fprintf(stderr, " -f: full-screen mode\n");
fprintf(stderr, " -b: force bitmap updates\n");
fprintf(stderr, " -e: disable encryption (French TS)\n");
- fprintf(stderr, " -E: disable encryption of everything but the logon packet\n");
+ fprintf(stderr, " -E: disable encryption from client to server\n");
fprintf(stderr, " -m: do not send motion events\n");
fprintf(stderr, " -C: use private colour map\n");
fprintf(stderr, " -K: keep window manager key bindings\n");
@@ -213,7 +213,7 @@ main(int argc, char *argv[])
strcpy(keymapname, "en-us");
#ifdef RDP2VNC
-#define VNCOPT "V:E:"
+#define VNCOPT "V:Q:"
#else
#define VNCOPT
#endif
@@ -229,7 +229,7 @@ main(int argc, char *argv[])
rfb_port += 5900;
break;
- case 'E':
+ case 'Q':
defer_time = strtol(optarg, NULL, 10);
if (defer_time < 0)
defer_time = 0;
| 0 | 52 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
86091fb5f569d9adbca06176a14c48911dbfe908
|
Clarified what the numlock flag means.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1215 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 86091fb5f569d9adbca06176a14c48911dbfe908
Author: Peter Åstrand <[email protected]>
Date: Fri Apr 7 14:19:46 2006 +0000
Clarified what the numlock flag means.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1215 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/keymapping.txt b/doc/keymapping.txt
index d5972a8..2d440e0 100644
--- a/doc/keymapping.txt
+++ b/doc/keymapping.txt
@@ -93,6 +93,10 @@ by the local modifier state.
If flags is "inhibit", nothing will be sent to the server.
+If flags is "numlock", rdesktop will make sure that the remote NumLock
+state is on before generating the key event. Otherwise, it will make
+sure NumLock is off.
+
4) enable_compose
| 0 | 59 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
1e75df64c20f37b5034492da1777e2761a6b3253
|
change to -r sound:local instead of -r sound:on
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@629 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 1e75df64c20f37b5034492da1777e2761a6b3253
Author: Peter Kallden <[email protected]>
Date: Fri Mar 5 06:39:00 2004 +0000
change to -r sound:local instead of -r sound:on
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@629 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/rdesktop.c b/rdesktop.c
index 97df4d8..63554af 100644
--- a/rdesktop.c
+++ b/rdesktop.c
@@ -132,7 +132,7 @@ usage(char *program)
fprintf(stderr, " '-r printer:mydeskjet': enable printer redirection\n");
fprintf(stderr,
" or mydeskjet=\"HP LaserJet IIIP\" to enter server driver as well\n");
- fprintf(stderr, " '-r sound:[on|off|remote]': enable sound redirection\n");
+ fprintf(stderr, " '-r sound:[local|off|remote]': enable sound redirection\n");
fprintf(stderr, " remote would leave sound on server\n");
fprintf(stderr, " -0: attach to console\n");
fprintf(stderr, " -4: use RDP version 4\n");
@@ -425,7 +425,7 @@ main(int argc, char *argv[])
if (strncmp("remote", optarg, 6) == 0)
flags |= RDP_LOGON_LEAVE_AUDIO;
- if (strncmp("on", optarg, 2) == 0)
+ if (strncmp("local", optarg, 5) == 0)
#ifdef WITH_RDPSND
g_rdpsnd = True;
#else
| 0 | 40 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
ee8366405da491f2ab5025566fef923d055e6bfe
|
Make sure we handle redirection PDU packet received
within rdp_connect() loop.
Fixes silent exits of rdesktop when receiving a redirection
PDU before license handling which is a corner case appeared
while using CredSSP+Kerberos.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1825 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit ee8366405da491f2ab5025566fef923d055e6bfe
Author: Henrik Andersson <[email protected]>
Date: Wed Aug 27 12:19:59 2014 +0000
Make sure we handle redirection PDU packet received
within rdp_connect() loop.
Fixes silent exits of rdesktop when receiving a redirection
PDU before license handling which is a corner case appeared
while using CredSSP+Kerberos.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1825 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/rdesktop.c b/rdesktop.c
index 42f07a1..cbc7263 100644
--- a/rdesktop.c
+++ b/rdesktop.c
@@ -1133,6 +1133,7 @@ main(int argc, char *argv[])
and therefor we just clear this error before we connect to redirected server.
*/
g_network_error = False;
+ g_redirect = False;
}
ui_init_connection();
@@ -1157,6 +1158,8 @@ main(int argc, char *argv[])
continue;
}
+ if (g_redirect)
+ continue;
/* By setting encryption to False here, we have an encrypted login
packet but unencrypted transfer of other packets */
@@ -1169,7 +1172,6 @@ main(int argc, char *argv[])
tcp_run_ui(True);
deactivated = False;
- g_redirect = False;
g_reconnect_loop = False;
rdp_main_loop(&deactivated, &ext_disc_reason);
diff --git a/rdp.c b/rdp.c
index 890bc09..44d8bdb 100644
--- a/rdp.c
+++ b/rdp.c
@@ -1752,6 +1752,9 @@ rdp_connect(char *server, uint32 flags, char *domain, char *password,
if (!rdp_loop(&deactivated, &ext_disc_reason))
return False;
+
+ if (g_redirect)
+ return True;
}
return True;
}
| 0 | 14 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
a9deb66c1b567f37a01275bd15b6e0a060eb75ef
|
Merge pull request #40 from HenryJacques/disk_fix
Fix segfault when using a relative folder name with disk redirection
|
commit a9deb66c1b567f37a01275bd15b6e0a060eb75ef
Merge: 2140da0 dcfcf59
Author: Henrik Andersson <[email protected]>
Date: Thu Jun 16 08:40:01 2016 +0200
Merge pull request #40 from HenryJacques/disk_fix
Fix segfault when using a relative folder name with disk redirection
| 0 | 2 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
b19e3d035ddf371c617794ec57d0ad0b9c7674a4
|
-A -> -r sound
Update option listing and documentation for this and some other options.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@519 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit b19e3d035ddf371c617794ec57d0ad0b9c7674a4
Author: Matt Chapman <[email protected]>
Date: Tue Oct 28 05:07:00 2003 +0000
-A -> -r sound
Update option listing and documentation for this and some other options.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@519 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/rdesktop.1 b/doc/rdesktop.1
index b1c15e7..c48fc0c 100644
--- a/doc/rdesktop.1
+++ b/doc/rdesktop.1
@@ -7,14 +7,14 @@
.br
.SH DESCRIPTION
.I rdesktop
-is a client for Microsoft Windows NT Terminal Server, Windows 2000 Terminal
-Services, Windows XP Remote Desktop, and possibly other Terminal Services
-products. rdesktop currently implements the RDP version 4 protocol.
+is a client for Remote Desktop Protocol (RDP), used in a number of Microsoft
+products including Windows NT Terminal Server, Windows 2000 Server, Windows XP
+and Windows 2003 Server.
.SH OPTIONS
.TP
.BR "-u <username>"
-Username for authentication on the terminal server.
+Username for authentication on the server.
.TP
.BR "-d <domain>"
Domain for authentication.
@@ -22,14 +22,6 @@ Domain for authentication.
.BR "-s <shell>"
Startup shell for the user - starts a specific application instead of Explorer.
.TP
-.BR "-S <button size>"
-Enable single application mode. This option can be used when running a
-single, maximized application (via -s). When the minimize button of
-the windows application is pressed, the rdesktop window is minimized
-instead of the remote application. The maximize/restore button is
-disabled. For this to work, you must specify the correct button
-size, in pixels. The special word "standard" means 18 pixels.
-.TP
.BR "-c <directory>"
The initial working directory for the user. Often used in combination with -s
to set up a fixed login environment.
@@ -54,8 +46,8 @@ en-us, en-gb, de, fr, sv, etc. The default is en-us (a US keyboard).
.BR "-g <geometry>"
Desktop geometry (WxH). If geometry is the special word "workarea", the geometry
will be fetched from the extended window manager hints property _NET_WORKAREA, from
-the root window. The geometry can also be specified in terms of percent of the whole
-screen, like "-g 80%".
+the root window. The geometry can also be specified as a percentage of the whole
+screen, e.g. "-g 80%".
.TP
.BR "-f"
Enable fullscreen mode. This overrides the window manager and causes the
@@ -71,8 +63,8 @@ Disable encryption. This option is only needed (and will only work) if you
have a French version of NT TSE.
.TP
.BR "-E"
-Disable encryption from client to server. This sends an encrypted login-packet,
-but everything after this is unencrypted. This also includes interactive logins.
+Disable encryption from client to server. This sends an encrypted login packet,
+but everything after this is unencrypted (including interactive logins).
.TP
.BR "-m"
Do not send mouse motion events. This saves bandwidth, although some Windows
@@ -82,23 +74,39 @@ applications may rely on receiving mouse motion.
Use private colourmap. This will improve colour accuracy on an 8-bit display,
but rdesktop will appear in false colour when not focused.
.TP
+.BR "-D"
+Hide window manager decorations, by using MWM hints.
+.TP
.BR "-K"
Do not override window manager key bindings. By default rdesktop attempts
to grab all keyboard input when it is in focus.
.TP
-.BR "-T <title>"
-Window title.
+.BR "-S <button size>"
+Enable single application mode. This option can be used when running a
+single, maximized application (via -s). When the minimize button of
+the windows application is pressed, the rdesktop window is minimized
+instead of the remote application. The maximize/restore button is
+disabled. For this to work, you must specify the correct button
+size, in pixels. The special word "standard" means 18 pixels.
.TP
-.BR "-D"
-Hide window manager decorations, by using MWM hints.
+.BR "-T <title>"
+Sets the window title.
.TP
.BR "-a <bpp>"
-Use bpp as colourdepth for the connection. Supported are 8, 15, 16 and 24.
-More than 8 bpp are only supported when connecting to Windows XP or
-Windows Server 2003.
+Sets the colour depth for the connection (8, 15, 16 or 24).
+More than 8 bpp are only supported when connecting to Windows XP
+(up to 16 bpp) or newer. Note that the colour depth may also be
+limited by the server configuration.
+.TP
+.BR "-r <device>"
+Enable redirection of the specified device on the client, such
+that it appears on the server. The only device currently supported
+is "sound" (requires Windows XP or newer). Note that the allowed
+redirections may be restricted by the server configuration.
.TP
.BR "-0"
-Attach to the console of the Server.
+Attach to the console of the server (requires Windows Server 2003
+or newer).
.TP
.BR "-4"
Use RDP version 4.
diff --git a/rdesktop.c b/rdesktop.c
index f45710a..abab1b1 100644
--- a/rdesktop.c
+++ b/rdesktop.c
@@ -69,7 +69,7 @@ BOOL g_console_session = False;
extern BOOL g_owncolmap;
#ifdef WITH_RDPSND
-BOOL g_rdpsnd = True;
+BOOL g_rdpsnd = False;
#endif
#ifdef RDP2VNC
@@ -95,11 +95,10 @@ usage(char *program)
fprintf(stderr, " -u: user name\n");
fprintf(stderr, " -d: domain\n");
fprintf(stderr, " -s: shell\n");
- fprintf(stderr, " -S: caption button size (single application mode)\n");
fprintf(stderr, " -c: working directory\n");
fprintf(stderr, " -p: password (- to prompt)\n");
fprintf(stderr, " -n: client hostname\n");
- fprintf(stderr, " -k: keyboard layout on terminal server (us,sv,gr,etc.)\n");
+ fprintf(stderr, " -k: keyboard layout on server (en-us, de, sv, etc.)\n");
fprintf(stderr, " -g: desktop geometry (WxH)\n");
fprintf(stderr, " -f: full-screen mode\n");
fprintf(stderr, " -b: force bitmap updates\n");
@@ -107,13 +106,12 @@ usage(char *program)
fprintf(stderr, " -E: disable encryption from client to server\n");
fprintf(stderr, " -m: do not send motion events\n");
fprintf(stderr, " -C: use private colour map\n");
+ fprintf(stderr, " -D: hide window manager decorations\n");
fprintf(stderr, " -K: keep window manager key bindings\n");
+ fprintf(stderr, " -S: caption button size (single application mode)\n");
fprintf(stderr, " -T: window title\n");
- fprintf(stderr, " -D: hide window manager decorations\n");
-#ifdef WITH_RDPSND
- fprintf(stderr, " -A: disable audio-redirection\n");
-#endif
- fprintf(stderr, " -a: server bpp\n");
+ fprintf(stderr, " -a: connection colour depth\n");
+ fprintf(stderr, " -r: enable specified device redirection (currently: sound)\n");
fprintf(stderr, " -0: attach to console\n");
fprintf(stderr, " -4: use RDP version 4\n");
fprintf(stderr, " -5: use RDP version 5 (default)\n");
@@ -231,7 +229,7 @@ main(int argc, char *argv[])
#define VNCOPT
#endif
- while ((c = getopt(argc, argv, VNCOPT "u:d:s:S:c:p:n:k:g:a:fbeEmCKT:AD045h?")) != -1)
+ while ((c = getopt(argc, argv, VNCOPT "u:d:s:c:p:n:k:g:fbeEmCDKS:T:a:r:045h?")) != -1)
{
switch (c)
{
@@ -262,23 +260,6 @@ main(int argc, char *argv[])
STRNCPY(shell, optarg, sizeof(shell));
break;
- case 'S':
- if (!strcmp(optarg, "standard"))
- {
- g_win_button_size = 18;
- break;
- }
-
- g_win_button_size = strtol(optarg, &p, 10);
-
- if (*p)
- {
- error("invalid button size\n");
- return 1;
- }
-
- break;
-
case 'c':
STRNCPY(directory, optarg, sizeof(directory));
break;
@@ -357,16 +338,33 @@ main(int argc, char *argv[])
g_owncolmap = True;
break;
+ case 'D':
+ g_hide_decorations = True;
+ break;
+
case 'K':
g_grab_keyboard = False;
break;
- case 'T':
- STRNCPY(g_title, optarg, sizeof(g_title));
+ case 'S':
+ if (!strcmp(optarg, "standard"))
+ {
+ g_win_button_size = 18;
+ break;
+ }
+
+ g_win_button_size = strtol(optarg, &p, 10);
+
+ if (*p)
+ {
+ error("invalid button size\n");
+ return 1;
+ }
+
break;
- case 'D':
- g_hide_decorations = True;
+ case 'T':
+ STRNCPY(g_title, optarg, sizeof(g_title));
break;
case 'a':
@@ -379,11 +377,15 @@ main(int argc, char *argv[])
}
break;
+ case 'r':
+ if (!strcmp(optarg, "sound"))
#ifdef WITH_RDPSND
- case 'A':
- g_rdpsnd = False;
- break;
+ g_rdpsnd = True;
+#else
+ warning("Not compiled with sound support");
#endif
+ break;
+
case '0':
g_console_session = True;
break;
@@ -459,9 +461,7 @@ main(int argc, char *argv[])
#ifdef WITH_RDPSND
if (g_rdpsnd)
- {
rdpsnd_init();
- }
#endif
/* rdpdr_init(); */
| 0 | 91 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
545a7094629d203e5e11e27a3e9c77607a5c5895
|
Removing old autom4te.cache before autoreconf. Seems to
be necessary on FC2.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@761 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 545a7094629d203e5e11e27a3e9c77607a5c5895
Author: Peter Åstrand <[email protected]>
Date: Tue Sep 7 11:33:46 2004 +0000
Removing old autom4te.cache before autoreconf. Seems to
be necessary on FC2.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@761 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/bootstrap b/bootstrap
index 68f4a17..7397914 100755
--- a/bootstrap
+++ b/bootstrap
@@ -1,2 +1,3 @@
#!/bin/sh
+rm -rf autom4te.cache
autoreconf -i
| 0 | 51 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
058ee33be3fbc52cbf04883c4a98acb71c947640
|
Clean up and document the return values. Trying to solve a number of issues:
* The current return values have been selected pretty much without any
thought. Basically, the value 1 is used for all different kinds of
errors, except for a corner case where the server doesn't send a
RDP_PDU_DEACTIVATE in combination with a few special "reasons", where
the value 2 is used instead.
* rdesktop will currently also return with 2 if the user is closing
the rdesktop window, the same error as many other fatal errors, which
is somewhat strange.
* The main principle of my patch is to utilize more of the available
256 return codes. We are currently only using 3 values out of
256. This is bad; rdesktop should expose more information to the
caller about error conditions if it can.
Besides using the standardized exit codes for generic errors such as
EX_USAGE for command line usage errors, I've also exposed the
"extended disconnect reasons" from RDP. This allows for, for example,
to be able to distinguish between a logoff and a disconnect.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1510 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 058ee33be3fbc52cbf04883c4a98acb71c947640
Author: Peter Åstrand <[email protected]>
Date: Wed Sep 2 13:03:43 2009 +0000
Clean up and document the return values. Trying to solve a number of issues:
* The current return values have been selected pretty much without any
thought. Basically, the value 1 is used for all different kinds of
errors, except for a corner case where the server doesn't send a
RDP_PDU_DEACTIVATE in combination with a few special "reasons", where
the value 2 is used instead.
* rdesktop will currently also return with 2 if the user is closing
the rdesktop window, the same error as many other fatal errors, which
is somewhat strange.
* The main principle of my patch is to utilize more of the available
256 return codes. We are currently only using 3 values out of
256. This is bad; rdesktop should expose more information to the
caller about error conditions if it can.
Besides using the standardized exit codes for generic errors such as
EX_USAGE for command line usage errors, I've also exposed the
"extended disconnect reasons" from RDP. This allows for, for example,
to be able to distinguish between a logoff and a disconnect.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1510 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/cache.c b/cache.c
index 45ed891..e3c9d8f 100644
--- a/cache.c
+++ b/cache.c
@@ -95,7 +95,7 @@ cache_rebuild_bmpcache_linked_list(uint8 id, sint16 * idx, int count)
{
error("Oops. %d in bitmap cache linked list, %d in ui cache...\n", c,
g_bmpcache_count[id]);
- exit(1);
+ exit(EX_SOFTWARE);
}
}
diff --git a/configure.ac b/configure.ac
index 006f1b1..d59bef1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -36,6 +36,7 @@ AC_CHECK_HEADER(sys/filio.h, AC_DEFINE(HAVE_SYS_FILIO_H))
AC_CHECK_HEADER(sys/strtio.h, AC_DEFINE(HAVE_SYS_STRTIO_H))
AC_CHECK_HEADER(locale.h, AC_DEFINE(HAVE_LOCALE_H))
AC_CHECK_HEADER(langinfo.h, AC_DEFINE(HAVE_LANGINFO_H))
+AC_CHECK_HEADER(sysexits.h, AC_DEFINE(HAVE_SYSEXITS_H))
AC_CHECK_TOOL(STRIP, strip, :)
diff --git a/constants.h b/constants.h
index 902c4a5..0185504 100644
--- a/constants.h
+++ b/constants.h
@@ -408,6 +408,7 @@ enum RDP_INPUT_DEVICE
#define exDiscReasonOutOfMemory 0x0006
#define exDiscReasonServerDeniedConnection 0x0007
#define exDiscReasonServerDeniedConnectionFips 0x0008
+#define exDiscReasonWindows7Disconnect 0x000b /* unofficial */
#define exDiscReasonLicenseInternal 0x0100
#define exDiscReasonLicenseNoLicenseServer 0x0101
#define exDiscReasonLicenseNoLicense 0x0102
diff --git a/disk.c b/disk.c
index bf299fa..96b135f 100644
--- a/disk.c
+++ b/disk.c
@@ -480,7 +480,7 @@ disk_create(uint32 device_id, uint32 accessmask, uint32 sharemode, uint32 create
{
error("Maximum number of open files (%s) reached. Increase MAX_OPEN_FILES!\n",
handle);
- exit(1);
+ exit(EX_SOFTWARE);
}
if (dirp)
diff --git a/doc/rdesktop.1 b/doc/rdesktop.1
index 68f2139..9850b2e 100644
--- a/doc/rdesktop.1
+++ b/doc/rdesktop.1
@@ -220,6 +220,64 @@ Use RDP version 4.
.BR "-5"
Use RDP version 5 (default).
.PP
+.SH "EXIT VALUES"
+.PP
+.IP "\fB0\fP"
+RDP session terminated normally
+.IP "\fB1\fP"
+Server initiated disconnect
+.IP "\fB2\fP"
+Server initiated logoff
+.IP "\fB3\fP"
+Server idle timeout reached
+.IP "\fB4\fP"
+Server logon timeout reached
+.IP "\fB5\fP"
+The session was replaced
+.IP "\fB6\fP"
+The server is out of memory
+.IP "\fB7\fP"
+The server denied the connection
+.IP "\fB8\fP"
+The server denied the connection for security reason
+.IP "\fB16\fP"
+Internal licensing error
+.IP "\fB17\fP"
+No license server available
+.IP "\fB18\fP"
+No valid license available
+.IP "\fB19\fP"
+Invalid licensing message
+.IP "\fB20\fP"
+Hardware id doesn't match software license
+.IP "\fB21\fP"
+Client license error
+.IP "\fB22\fP"
+Network error during licensing protocol
+.IP "\fB23\fP"
+Licensing protocol was not completed
+.IP "\fB24\fP"
+Incorrect client license enryption
+.IP "\fB25\fP"
+Can't upgrade license
+.IP "\fB26\fP"
+The server is not licensed to accept remote connections
+.IP "\fB62\fP"
+The local client window was closed
+.IP "\fB63\fP"
+Some other, unknown error occured
+.IP "\fB64\fP"
+Command line usage error
+.IP "\fB69\fP"
+A service or resource (such as memory) is unavailable
+.IP "\fB70\fP"
+An internal software error has been detected
+.IP "\fB71\fP"
+Operating system error
+.IP "\fB76\fP"
+Protocol error or unable to connect to remote host.
+
+.PP
.SH LINKS
Main website of rdesktop
.br
diff --git a/rdesktop.c b/rdesktop.c
index e8c632c..f1652ce 100644
--- a/rdesktop.c
+++ b/rdesktop.c
@@ -91,6 +91,7 @@ RD_BOOL g_lspci_enabled = False;
RD_BOOL g_owncolmap = False;
RD_BOOL g_ownbackstore = True; /* We can't rely on external BackingStore */
RD_BOOL g_seamless_rdp = False;
+RD_BOOL g_user_quit = False;
uint32 g_embed_wnd;
uint32 g_rdp5_performanceflags =
RDP5_NO_WALLPAPER | RDP5_NO_FULLWINDOWDRAG | RDP5_NO_MENUANIMATIONS;
@@ -213,91 +214,116 @@ usage(char *program)
fprintf(stderr, " -5: use RDP version 5 (default)\n");
}
-static void
-print_disconnect_reason(uint16 reason)
+static int
+handle_disconnect_reason(RD_BOOL deactivated, uint16 reason)
{
char *text;
+ int retval;
switch (reason)
{
case exDiscReasonNoInfo:
text = "No information available";
+ if (deactivated)
+ retval = EX_OK;
+ else
+ retval = EXRD_UNKNOWN;
break;
case exDiscReasonAPIInitiatedDisconnect:
+ case exDiscReasonWindows7Disconnect:
text = "Server initiated disconnect";
+ retval = EXRD_API_DISCONNECT;
break;
case exDiscReasonAPIInitiatedLogoff:
text = "Server initiated logoff";
+ retval = EXRD_API_LOGOFF;
break;
case exDiscReasonServerIdleTimeout:
text = "Server idle timeout reached";
+ retval = EXRD_IDLE_TIMEOUT;
break;
case exDiscReasonServerLogonTimeout:
text = "Server logon timeout reached";
+ retval = EXRD_LOGON_TIMEOUT;
break;
case exDiscReasonReplacedByOtherConnection:
text = "The session was replaced";
+ retval = EXRD_REPLACED;
break;
case exDiscReasonOutOfMemory:
text = "The server is out of memory";
+ retval = EXRD_OUT_OF_MEM;
break;
case exDiscReasonServerDeniedConnection:
text = "The server denied the connection";
+ retval = EXRD_DENIED;
break;
case exDiscReasonServerDeniedConnectionFips:
text = "The server denied the connection for security reason";
+ retval = EXRD_DENIED_FIPS;
break;
case exDiscReasonLicenseInternal:
text = "Internal licensing error";
+ retval = EXRD_LIC_INTERNAL;
break;
case exDiscReasonLicenseNoLicenseServer:
text = "No license server available";
+ retval = EXRD_LIC_NOSERVER;
break;
case exDiscReasonLicenseNoLicense:
text = "No valid license available";
+ retval = EXRD_LIC_NOLICENSE;
break;
case exDiscReasonLicenseErrClientMsg:
text = "Invalid licensing message";
+ retval = EXRD_LIC_MSG;
break;
case exDiscReasonLicenseHwidDoesntMatchLicense:
text = "Hardware id doesn't match software license";
+ retval = EXRD_LIC_HWID;
break;
case exDiscReasonLicenseErrClientLicense:
text = "Client license error";
+ retval = EXRD_LIC_CLIENT;
break;
case exDiscReasonLicenseCantFinishProtocol:
text = "Network error during licensing protocol";
+ retval = EXRD_LIC_NET;
break;
case exDiscReasonLicenseClientEndedProtocol:
text = "Licensing protocol was not completed";
+ retval = EXRD_LIC_PROTO;
break;
case exDiscReasonLicenseErrClientEncryption:
text = "Incorrect client license enryption";
+ retval = EXRD_LIC_ENC;
break;
case exDiscReasonLicenseCantUpgradeLicense:
text = "Can't upgrade license";
+ retval = EXRD_LIC_UPGRADE;
break;
case exDiscReasonLicenseNoRemoteConnections:
text = "The server is not licensed to accept remote connections";
+ retval = EXRD_LIC_NOREMOTE;
break;
default:
@@ -309,8 +335,12 @@ print_disconnect_reason(uint16 reason)
{
text = "Unknown reason";
}
+ retval = EXRD_UNKNOWN;
}
- fprintf(stderr, "disconnect: %s.\n", text);
+ if (reason != exDiscReasonNoInfo)
+ fprintf(stderr, "disconnect: %s.\n", text);
+
+ return retval;
}
static void
@@ -535,7 +565,7 @@ main(int argc, char *argv[])
if (g_width <= 0)
{
error("invalid geometry\n");
- return 1;
+ return EX_USAGE;
}
if (*p == 'x')
@@ -544,7 +574,7 @@ main(int argc, char *argv[])
if (g_height <= 0)
{
error("invalid geometry\n");
- return 1;
+ return EX_USAGE;
}
if (*p == '%')
@@ -613,7 +643,7 @@ main(int argc, char *argv[])
if (*p)
{
error("invalid button size\n");
- return 1;
+ return EX_USAGE;
}
break;
@@ -638,7 +668,7 @@ main(int argc, char *argv[])
&& g_server_depth != 32)
{
error("Invalid server colour depth.\n");
- return 1;
+ return EX_USAGE;
}
break;
@@ -789,14 +819,14 @@ main(int argc, char *argv[])
case '?':
default:
usage(argv[0]);
- return 1;
+ return EX_USAGE;
}
}
if (argc - optind != 1)
{
usage(argv[0]);
- return 1;
+ return EX_USAGE;
}
STRNCPY(server, argv[optind], sizeof(server));
@@ -807,33 +837,33 @@ main(int argc, char *argv[])
if (g_win_button_size)
{
error("You cannot use -S and -A at the same time\n");
- return 1;
+ return EX_USAGE;
}
g_rdp5_performanceflags &= ~RDP5_NO_FULLWINDOWDRAG;
if (geometry_option)
{
error("You cannot use -g and -A at the same time\n");
- return 1;
+ return EX_USAGE;
}
if (g_fullscreen)
{
error("You cannot use -f and -A at the same time\n");
- return 1;
+ return EX_USAGE;
}
if (g_hide_decorations)
{
error("You cannot use -D and -A at the same time\n");
- return 1;
+ return EX_USAGE;
}
if (g_embed_wnd)
{
error("You cannot use -X and -A at the same time\n");
- return 1;
+ return EX_USAGE;
}
if (!g_use_rdp5)
{
error("You cannot use -4 and -A at the same time\n");
- return 1;
+ return EX_USAGE;
}
g_width = -100;
g_grab_keyboard = False;
@@ -845,7 +875,7 @@ main(int argc, char *argv[])
if ((pw == NULL) || (pw->pw_name == NULL))
{
error("could not determine username, use -u\n");
- return 1;
+ return EX_OSERR;
}
/* +1 for trailing \0 */
int pwlen = strlen(pw->pw_name) + 1;
@@ -872,7 +902,7 @@ main(int argc, char *argv[])
if (gethostname(fullhostname, sizeof(fullhostname)) == -1)
{
error("could not determine local hostname, use -n\n");
- return 1;
+ return EX_OSERR;
}
p = strchr(fullhostname, '.');
@@ -908,11 +938,11 @@ main(int argc, char *argv[])
#ifdef RDP2VNC
rdp2vnc_connect(server, flags, domain, password, shell, directory);
- return 0;
+ return EX_OK;
#else
if (!ui_init())
- return 1;
+ return EX_OSERR;
#ifdef WITH_RDPSND
if (g_rdpsnd)
@@ -934,11 +964,11 @@ main(int argc, char *argv[])
if (run_count == 0)
{
if (!rdp_connect(server, flags, domain, password, shell, directory))
- return 1;
+ return EX_PROTOCOL;
}
else if (!rdp_reconnect
(server, flags, domain, password, shell, directory, g_redirect_cookie))
- return 1;
+ return EX_PROTOCOL;
/* By setting encryption to False here, we have an encrypted login
packet but unencrypted transfer of other packets */
@@ -987,28 +1017,10 @@ main(int argc, char *argv[])
cache_save_state();
ui_deinit();
- if (ext_disc_reason >= 2)
- print_disconnect_reason(ext_disc_reason);
+ if (g_user_quit)
+ return EXRD_WINDOW_CLOSED;
- if (deactivated)
- {
- /* clean disconnect */
- return 0;
- }
- else
- {
- if (ext_disc_reason == exDiscReasonAPIInitiatedDisconnect
- || ext_disc_reason == exDiscReasonAPIInitiatedLogoff)
- {
- /* not so clean disconnect, but nothing to worry about */
- return 0;
- }
- else
- {
- /* return error */
- return 2;
- }
- }
+ return handle_disconnect_reason(deactivated, ext_disc_reason);
#endif
if (g_redirect_username)
@@ -1108,7 +1120,7 @@ xmalloc(int size)
if (mem == NULL)
{
error("xmalloc %d\n", size);
- exit(1);
+ exit(EX_UNAVAILABLE);
}
return mem;
}
@@ -1120,7 +1132,7 @@ exit_if_null(void *ptr)
if (ptr == NULL)
{
error("unexpected null pointer. Out of memory?\n");
- exit(1);
+ exit(EX_UNAVAILABLE);
}
}
@@ -1132,7 +1144,7 @@ xstrdup(const char *s)
if (mem == NULL)
{
perror("strdup");
- exit(1);
+ exit(EX_UNAVAILABLE);
}
return mem;
}
@@ -1149,7 +1161,7 @@ xrealloc(void *oldmem, size_t size)
if (mem == NULL)
{
error("xrealloc %ld\n", size);
- exit(1);
+ exit(EX_UNAVAILABLE);
}
return mem;
}
diff --git a/rdesktop.h b/rdesktop.h
index 31ed64e..4a86d02 100644
--- a/rdesktop.h
+++ b/rdesktop.h
@@ -38,9 +38,87 @@
#endif
#endif
#include <limits.h> /* PATH_MAX */
+#ifdef HAVE_SYSEXITS_H
+#include <sysexits.h>
+#endif
#define VERSION "1.6.0"
+/* standard exit codes */
+#ifndef EX_OK
+#define EX_OK 0
+#endif
+#ifndef EX_USAGE
+#define EX_USAGE 64
+#endif
+#ifndef EX_DATAERR
+#define EX_DATAERR 65
+#endif
+#ifndef EX_NOINPUT
+#define EX_NOINPUT 66
+#endif
+#ifndef EX_NOUSER
+#define EX_NOUSER 67
+#endif
+#ifndef EX_NOHOST
+#define EX_NOHOST 68
+#endif
+#ifndef EX_UNAVAILABLE
+#define EX_UNAVAILABLE 69
+#endif
+#ifndef EX_SOFTWARE
+#define EX_SOFTWARE 70
+#endif
+#ifndef EX_OSERR
+#define EX_OSERR 71
+#endif
+#ifndef EX_OSFILE
+#define EX_OSFILE 72
+#endif
+#ifndef EX_CANTCREAT
+#define EX_CANTCREAT 73
+#endif
+#ifndef EX_IOERR
+#define EX_IOERR 74
+#endif
+#ifndef EX_TEMPFAIL
+#define EX_TEMPFAIL 75
+#endif
+#ifndef EX_PROTOCOL
+#define EX_PROTOCOL 76
+#endif
+#ifndef EX_NOPERM
+#define EX_NOPERM 77
+#endif
+#ifndef EX_CONFIG
+#define EX_CONFIG 78
+#endif
+
+/* rdesktop specific exit codes, lined up with disconnect PDU reasons */
+#define EXRD_API_DISCONNECT 1
+#define EXRD_API_LOGOFF 2
+#define EXRD_IDLE_TIMEOUT 3
+#define EXRD_LOGON_TIMEOUT 4
+#define EXRD_REPLACED 5
+#define EXRD_OUT_OF_MEM 6
+#define EXRD_DENIED 7
+#define EXRD_DENIED_FIPS 8
+#define EXRD_LIC_INTERNAL 16
+#define EXRD_LIC_NOSERVER 17
+#define EXRD_LIC_NOLICENSE 18
+#define EXRD_LIC_MSG 19
+#define EXRD_LIC_HWID 20
+#define EXRD_LIC_CLIENT 21
+#define EXRD_LIC_NET 22
+#define EXRD_LIC_PROTO 23
+#define EXRD_LIC_ENC 24
+#define EXRD_LIC_UPGRADE 25
+#define EXRD_LIC_NOREMOTE 26
+
+/* other exit codes */
+#define EXRD_WINDOW_CLOSED 62
+#define EXRD_UNKNOWN 63
+
#ifdef WITH_DEBUG
#define DEBUG(args) printf args;
#else
diff --git a/tcp.c b/tcp.c
index 1971ad7..5e1adab 100644
--- a/tcp.c
+++ b/tcp.c
@@ -56,6 +56,7 @@ static int g_sock;
static struct stream g_in;
static struct stream g_out[STREAM_COUNT];
int g_tcp_port_rdp = TCP_PORT_RDP;
+extern RD_BOOL g_user_quit;
/* wait till socket is ready to write or timeout */
static RD_BOOL
@@ -173,8 +174,11 @@ tcp_recv(STREAM s, uint32 length)
while (length > 0)
{
if (!ui_select(g_sock))
+ {
/* User quit */
+ g_user_quit = True;
return NULL;
+ }
rcvd = recv(g_sock, s->end, length, 0);
if (rcvd < 0)
| 0 | 61 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
00aadf65217499a75f124970e56d777764a576b5
|
Added note explaining that protocol stack should be
system-independent.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@323 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 00aadf65217499a75f124970e56d777764a576b5
Author: Peter Åstrand <[email protected]>
Date: Tue Feb 11 10:40:03 2003 +0000
Added note explaining that protocol stack should be
system-independent.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@323 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/HACKING b/doc/HACKING
index f769846..1b2412b 100644
--- a/doc/HACKING
+++ b/doc/HACKING
@@ -9,3 +9,12 @@ Variable argument macros
Variable argument macros are non-portable in general, and should be
avoided. Either use a second set of parentheses like DEBUG, or create
a variable argument function like error.
+
+Structure
+---------
+The core protocol stack should be system-independent (i.e. ANSI C
+only) so that it is easy to port. This currently applies to the
+following files:
+
+bitmap.c licence.c orders.c rdp.c cache.c iso.c mcs.c rdesktop.c
+secure.c
| 0 | 66 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
da9f50db6526a2eb147fcfe0e3d4e29b5f2090b9
|
Fix Session Directory Support entry in ChangeLog
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@981 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit da9f50db6526a2eb147fcfe0e3d4e29b5f2090b9
Author: Michael Gernoth <[email protected]>
Date: Mon Aug 15 12:13:41 2005 +0000
Fix Session Directory Support entry in ChangeLog
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@981 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/ChangeLog b/doc/ChangeLog
index 4f7e5c5..9a42c6b 100644
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -4,11 +4,10 @@ rdesktop (1.?.?)
* Keyboard handling improvements and fixes
* Sound-driver for SGI/Irix
* Support for clipboard INCR protocol
- * Session Directory support
+ * Session Directory support (patch from Brian Chapeau <[email protected]>)
* Support for long filenames on redirected drives
rdesktop (1.4.1)
- * Session Directory support (patch from Brian Chapeau <[email protected]>)
* persistent bitmap cache optimisations
* support for more RDP-orders (ellipse, polygon)
* libao sound-driver (for Mac OSX and others)
| 0 | 50 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
456e775f9038481d9b7813e6efdd449486f16cc1
|
Clarify the behaviour when windows are initially created.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/branches/seamlessrdp-branch/rdesktop@1125 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 456e775f9038481d9b7813e6efdd449486f16cc1
Author: Pierre Ossman <[email protected]>
Date: Wed Mar 15 11:43:57 2006 +0000
Clarify the behaviour when windows are initially created.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/branches/seamlessrdp-branch/rdesktop@1125 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/seamlessrdp-channel.txt b/doc/seamlessrdp-channel.txt
index 34005c9..4d5778f 100644
--- a/doc/seamlessrdp-channel.txt
+++ b/doc/seamlessrdp-channel.txt
@@ -88,7 +88,8 @@ Syntax:
The text is guaranteed to be stripped of control characters (< 0x20).
Note that this has the same requirement as POSITION, that the title needs to
-be stored for newly created windows until a STATE is sent.
+be stored for newly created windows until a STATE is sent. It is however not
+guaranteed that a TITLE will be sent before the first STATE.
ZCHANGE
@@ -115,6 +116,8 @@ State can have one of three values:
1 : Minimized.
2 : Maximized.
+The initial STATE for a window will always be preceeded by one CREATE and one
+POSITION. Optionally, a TITLE may also be sent before the first STATE.
DEBUG
-----
@@ -160,8 +163,9 @@ Request a synchronisation of window information.
Syntax:
SYNC,<FLAGS>
-For each window, the server will send CREATE, POSITION, TITLE and
-STATE just as if the window was created.
+For each window, the server will send CREATE, POSITION and STATE, in that
+order, just as if the window was created. Note that a TITLE may also,
+optionally, be sent before the STATE.
POSITION
--------
| 0 | 56 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
7c41cdc1d0f7d8b65937db7cb857f4b315af686d
|
Fixes (?) for font problems with Microsoft Office
Added URL to website http://www.rdesktop.org/
Releasing 0.9.0-alpha2
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@16 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 7c41cdc1d0f7d8b65937db7cb857f4b315af686d
Author: Matt Chapman <[email protected]>
Date: Thu Sep 28 15:54:11 2000 +0000
Fixes (?) for font problems with Microsoft Office
Added URL to website http://www.rdesktop.org/
Releasing 0.9.0-alpha2
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@16 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/ANNOUNCE b/ANNOUNCE
deleted file mode 100644
index 012348a..0000000
--- a/ANNOUNCE
+++ /dev/null
@@ -1,33 +0,0 @@
-===============================
-ANNOUNCING rdesktop 0.9.0alpha1
-===============================
-
-rdesktop is an open source client for Windows NT Terminal Server,
-capable of natively speaking its Remote Desktop Protocol. No server
-extensions are required.
-
-0.9.0alpha1 is a milestone release including experimental support for
-much of the protocol. It is NOT a stable, production-quality release.
-Users should be prepared to submit bug reports and, ideally, patches.
-
-The current X-Windows driver is rather limited - an Xlib guru's
-assistance would be appreciated. In particular, this version requires
-the X display to support windows of 8-bit depth, which in most cases
-means running X in 8-bit mode. Keyboard mapping may also be problematic.
-
-The -l option will disable licence negotiation, which is probably
-what you want during testing.
-
-Tested platforms include Linux, Solaris and OSF1, but it is should be
-fairly straight-forward to port to other platforms and even windowing
-systems.
-
-rdesktop is released under the GNU Public License.
-
-See http://www.cse.unsw.edu.au/~matthewc/rdesktop/ for more information
-and download instructions. Please send feedback to me.
-
-Cheers,
-
-Matt Chapman <[email protected]>
-rdesktop Author
diff --git a/orders.c b/orders.c
index b5c0b10..22bd385 100644
--- a/orders.c
+++ b/orders.c
@@ -618,8 +618,11 @@ static void process_text2(STREAM s, TEXT2_ORDER *os, uint32 present, BOOL delta)
cache_put_text(os->text[os->length+1], os->text, os->length);
}
- ui_draw_text(os->font, os->flags, os->mixmode,
- os->x, os->y, os->boxleft, os->boxtop,
+ ui_draw_text(os->font, os->flags, os->mixmode, os->x, os->y,
+ os->clipleft, os->cliptop,
+ os->clipright - os->clipleft,
+ os->clipbottom - os->cliptop,
+ os->boxleft, os->boxtop,
os->boxright - os->boxleft,
os->boxbottom - os->boxtop,
os->bgcolour, os->fgcolour, os->text, os->length);
diff --git a/proto.h b/proto.h
index 1d39056..4fea04c 100644
--- a/proto.h
+++ b/proto.h
@@ -90,6 +90,6 @@ void ui_triblt(uint8 opcode, int x, int y, int cx, int cy, HBITMAP src, int srcx
void ui_line(uint8 opcode, int startx, int starty, int endx, int endy, PEN *pen);
void ui_rect(int x, int y, int cx, int cy, int colour);
void ui_draw_glyph(int mixmode, int x, int y, int cx, int cy, HGLYPH glyph, int srcx, int srcy, int bgcolour, int fgcolour);
-void ui_draw_text(uint8 font, uint8 flags, int mixmode, int x, int y, int boxx, int boxy, int boxcx, int boxcy, int bgcolour, int fgcolour, uint8 *text, uint8 length);
+void ui_draw_text(uint8 font, uint8 flags, int mixmode, int x, int y, int clipx, int clipy, int clipcx, int clipcy, int boxx, int boxy, int boxcx, int boxcy, int bgcolour, int fgcolour, uint8 *text, uint8 length);
void ui_desktop_save(uint32 offset, int x, int y, int cx, int cy);
void ui_desktop_restore(uint32 offset, int x, int y, int cx, int cy);
diff --git a/rdesktop.c b/rdesktop.c
index 6edf484..1dd0e3f 100644
--- a/rdesktop.c
+++ b/rdesktop.c
@@ -59,7 +59,8 @@ int main(int argc, char *argv[])
int c;
STATUS("rdesktop: A Remote Desktop Protocol client.\n");
- STATUS("Version "VERSION". Copyright (C) 1999-2000 Matt Chapman.\n\n");
+ STATUS("Version "VERSION". Copyright (C) 1999-2000 Matt Chapman.\n");
+ STATUS("See http://www.rdesktop.org/ for more information.\n\n");
while ((c = getopt(argc, argv, "u:n:w:h:k:mbl?")) != -1)
{
diff --git a/rdesktop.h b/rdesktop.h
index c7254fd..1eaa156 100644
--- a/rdesktop.h
+++ b/rdesktop.h
@@ -21,7 +21,7 @@
#include <stdio.h>
#include <string.h>
-#define VERSION "0.9.0-alpha1"
+#define VERSION "0.9.0-alpha2"
#define STATUS(args...) fprintf(stderr, args);
#define ERROR(args...) fprintf(stderr, "ERROR: "args);
diff --git a/xwin.c b/xwin.c
index 5814bdb..9a209af 100644
--- a/xwin.c
+++ b/xwin.c
@@ -491,8 +491,9 @@ void ui_draw_glyph(int mixmode,
}
}
-void ui_draw_text(uint8 font, uint8 flags, int mixmode, int x,
- int y, int boxx, int boxy, int boxcx, int boxcy,
+void ui_draw_text(uint8 font, uint8 flags, int mixmode, int x, int y,
+ int clipx, int clipy, int clipcx, int clipcy,
+ int boxx, int boxy, int boxcx, int boxcy,
int bgcolour, int fgcolour, uint8 *text, uint8 length)
{
FONTGLYPH *glyph;
@@ -502,12 +503,19 @@ void ui_draw_text(uint8 font, uint8 flags, int mixmode, int x,
{
ui_rect(boxx, boxy, boxcx, boxcy, bgcolour);
}
+ else if (mixmode == MIX_OPAQUE)
+ {
+ ui_rect(clipx, clipy, clipcx, clipcy, bgcolour);
+ }
/* Paint text, character by character */
for (i = 0; i < length; i++)
{
glyph = cache_get_font(font, text[i]);
+ if (!(flags & TEXT2_IMPLICIT_X))
+ x += text[++i];
+
if (glyph != NULL)
{
ui_draw_glyph(mixmode, x,
@@ -518,8 +526,6 @@ void ui_draw_text(uint8 font, uint8 flags, int mixmode, int x,
if (flags & TEXT2_IMPLICIT_X)
x += glyph->width;
- else
- x += text[++i];
}
}
}
| 0 | 63 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
0cc7e8346d2b53813d9043ab8f7cdde087f435a0
|
Make sure iorq->fd is a valid FD before adding it to the FD_SET.
Prevents endless loops with "select: Bad file descriptor" error
messages.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@661 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 0cc7e8346d2b53813d9043ab8f7cdde087f435a0
Author: Peter Åstrand <[email protected]>
Date: Fri Apr 16 14:04:02 2004 +0000
Make sure iorq->fd is a valid FD before adding it to the FD_SET.
Prevents endless loops with "select: Bad file descriptor" error
messages.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@661 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/rdpdr.c b/rdpdr.c
index 0fc2ba3..99ccd37 100644
--- a/rdpdr.c
+++ b/rdpdr.c
@@ -809,11 +809,13 @@ rdpdr_add_fds(int *n, fd_set * rfds, fd_set * wfds, struct timeval *tv, BOOL * t
{
uint32 select_timeout = 0; // Timeout value to be used for select() (in millisecons).
struct async_iorequest *iorq;
+ char c;
iorq = g_iorequest;
while (iorq != NULL)
{
- if (iorq->fd != 0)
+ /* We need to test that the fd is still valid */
+ if ((iorq->fd != 0) && (read(iorq->fd, &c, 0) == 0))
{
switch (iorq->major)
{
| 0 | 32 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
ee2699d8880672e29523353f3bcb1571e42c2505
|
Added keymapping doc
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@103 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit ee2699d8880672e29523353f3bcb1571e42c2505
Author: Peter Åstrand <[email protected]>
Date: Sun Sep 1 10:22:14 2002 +0000
Added keymapping doc
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@103 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/keymapping.txt b/doc/keymapping.txt
new file mode 100644
index 0000000..be45a84
--- /dev/null
+++ b/doc/keymapping.txt
@@ -0,0 +1,114 @@
+Keyboard mapping
+================
+This release of rdesktop uses a new, portable keyboard mapping
+implementation. It should hopefully work on all X11 systems. This new
+implementation only looks at X11 keysyms: Not on (nonportable)
+keycodes or modifier status. This means that rdesktop will obey your
+local keyboard configuration. For example, if you have swapped
+CapsLock and Control, rdesktop will use this mapping.
+
+XKB is currently not used. It seems like a good idea to me, but since
+some X servers (like Xvnc) does not support XKB, we still need to use
+the plain old interface as well, at least.
+
+There are still some small problems.
+
+* NumLock handling: NumLock is switched off when typing a non-numlock
+ key. rdesktop does not know which keys are NumLock-dependent and
+ not. When you type a numlock-dependent key again, NumLock is
+ switched on on the server again. The only problem really is that the
+ NumLock indicator in Wordpad etc switches on and off when you type.
+
+* CapsLock: CapsLock changes are never sent to the RDP server. This is
+ a problem of the same type as NumLock: rdesktop does not know which
+ keys that are modified by CapsLock and which are not. So, the
+ CapsLock indicator in Wordpad etc will always be off.
+
+Composing/Multi_key is supported. For more information, see:
+
+ MIT: $SRC/xc/nls/X11/locale/Compose/iso8859-1
+ XFree86: /usr/X11R6/lib/X11/locale/*/Compose
+ Solaris' Openwin: /usr/openwin/include/X11/Suncompose.h
+ /usr/openwin/lib/locale/*/Compose
+ Irix6: compose(5)
+
+
+Keymap-files
+============
+The keymaps are line based. There are three different types of lines:
+
+1) include-lines
+Syntax:
+include <another-map-file>
+
+
+2) map-lines
+Syntax:
+map <hex-number>
+
+Map-lines specifies how the remote RDP server should interpret the
+sent scancodes.
+
+
+3) Translation-lines
+Syntax:
+<keysym-name> <scancode> [flags..]
+
+The scancode can be found in scancodes.h. Note: The scancode value for
+extended keys can be calculated by OR:ing with 0x80. Example: The
+Delete key have the scancode sequence 0xe0, 0x52. You can get the
+scancode value to put into the map file by running:
+
+python -c "print hex(0x80 | 0x52)"
+
+If flags are "altgr", "shift", "numlock", the scancode sent for this
+keysym will be prefix with AltGr, Shift or Numlock.
+
+If flags include "addupper", an translation for this keysyms uppercase
+name will as well, in addition to the non-uppercase name. Example:
+
+x 2d addupper
+
+...will add an translation for "X" automatically, just like if you
+would specify:
+
+X 2d shift
+
+If flags include "localstate", the modifier to send will be determined
+by the local modifier state.
+
+
+4) enable_compose
+
+If any line starts with the keyword "enable_compose", rdesktop will
+enable local Compose/Multi_key handling. Enabling this will often make
+it impossible to compose characters with dead keys (on the remote
+side). This is because when local compose support is enabled, dead
+keys will not be sent to the remote side.
+
+
+Suggested X11 keysym mapping on PCs
+===================================
+Unfortunately, there is no standard for which keysyms a given key
+should generate. If you have a PC-keyboard with Windows keys, I suggest this mapping:
+
+Keyboard keys:
+CtrlLeft WinLeft AltLeft Space AltGr WinRight Menu CtrlRight
+
+...should generate keysyms:
+Control_L Hyper_L Alt_L space Mode_switch Hyper_R Menu Control_R
+
+Additionally:
+Shift-Alt should produce Meta_L
+Shift-AltGr should produce Multi_Key.
+
+Use a modifier-map like this:
+
+shift Shift_L (0x32), Shift_R (0x3e)
+lock Caps_Lock (0x25)
+control Control_L (0x42), Control_R (0x6d)
+mod1 Alt_L (0x40)
+mod2 Num_Lock (0x4d)
+mod3 Mode_switch (0x71)
+mod4 Hyper_L (0x73), Hyper_R (0x74)
+mod5 Scroll_Lock (0x4e)
| 0 | 100 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
0fa8eb2b0d96b2466eeba75db1a32d734f5a99d4
|
update the -r sound documentation
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@634 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 0fa8eb2b0d96b2466eeba75db1a32d734f5a99d4
Author: Peter Kallden <[email protected]>
Date: Wed Mar 10 07:39:49 2004 +0000
update the -r sound documentation
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@634 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/rdesktop.1 b/doc/rdesktop.1
index e042a37..7f201a8 100644
--- a/doc/rdesktop.1
+++ b/doc/rdesktop.1
@@ -135,8 +135,9 @@ simple PS-driver unless you specify one. Keep in mind that you need a
100% match in the server environment, or the driver will fail. The first
printer on the command line will be set as your default printer.
.TP
-.BR "-r sound:[on|off|remote]"
-Redirects sound generated on the server to the client ( Requires
+.BR "-r sound:[local|off|remote]"
+Redirects sound generated on the server to the client. "remote" only has
+any effect when you connect to the console with the -0 option. (Requires
Windows XP or newer).
.TP
.BR "-0"
| 0 | 84 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
1ac2cd144ee56227590933f885c39b595f47cf35
|
Control codes to SCardControl() are platform dependent so we need to do
some translation before passing them on.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1595 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 1ac2cd144ee56227590933f885c39b595f47cf35
Author: Pierre Ossman <[email protected]>
Date: Mon Jun 14 07:35:55 2010 +0000
Control codes to SCardControl() are platform dependent so we need to do
some translation before passing them on.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1595 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/scard.c b/scard.c
index 34054fb..1179ac6 100644
--- a/scard.c
+++ b/scard.c
@@ -2037,6 +2037,14 @@ TS_SCardControl(STREAM in, STREAM out)
in_uint8a(in, pInBuffer, nInBufferSize);
}
+ /* Is this a proper Windows smart card ioctl? */
+ if ((dwControlCode & 0xffff0000) != (49 << 16))
+ return SCARD_E_INVALID_PARAMETER;
+
+ /* Translate to local encoding */
+ dwControlCode = (dwControlCode & 0x3ffc) >> 2;
+ dwControlCode = SCARD_CTL_CODE(dwControlCode);
+
#if 0
if (nOutBufferSize > 0)
{
| 0 | 15 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
6028c999ba7852d560b7831853502e675c65709a
|
Allow TLS to continue without system database
It will mean manual confirmation for users, but that is probably
better than outright refusal.
|
commit 6028c999ba7852d560b7831853502e675c65709a
Author: Pierre Ossman <[email protected]>
Date: Tue Jun 4 16:53:13 2019 +0200
Allow TLS to continue without system database
It will mean manual confirmation for users, but that is probably
better than outright refusal.
diff --git a/tcp.c b/tcp.c
index 1b16886..71fc2f7 100644
--- a/tcp.c
+++ b/tcp.c
@@ -373,7 +373,8 @@ tcp_tls_connect(void)
}
err = gnutls_certificate_set_x509_system_trust(xcred);
if (err < 0) {
- gnutls_fatal("Could not load system trust database", err);
+ logger(Core, Error, "%s(), Could not load system trust database: %s",
+ __func__, gnutls_strerror(err));
}
gnutls_certificate_set_verify_function(xcred, cert_verify_callback);
gnutls_transport_set_int(g_tls_session, g_sock);
| 0 | 30 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
9b5f8966622d08b95e22435ff85105ac33526a2a
|
We need to include sys/types.h before including sys/socket.h
This broke builds on AIX.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@880 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 9b5f8966622d08b95e22435ff85105ac33526a2a
Author: Michael Gernoth <[email protected]>
Date: Mon Apr 4 16:37:19 2005 +0000
We need to include sys/types.h before including sys/socket.h
This broke builds on AIX.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@880 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/rdesktop.c b/rdesktop.c
index 25b6ed0..3770324 100644
--- a/rdesktop.c
+++ b/rdesktop.c
@@ -40,6 +40,7 @@
#endif
#ifdef EGD_SOCKET
+#include <sys/types.h>
#include <sys/socket.h> /* socket connect */
#include <sys/un.h> /* sockaddr_un */
#endif
| 0 | 23 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
a4bdfcfe76b4d39c2d6fd7c8c5be4af90dd4b82d
|
Don't check certificate purpose on older GnuTLS
The feature was added in 3.6.0, so avoid compilation errors if
building with an older GnuTLS.
|
commit a4bdfcfe76b4d39c2d6fd7c8c5be4af90dd4b82d
Author: Pierre Ossman <[email protected]>
Date: Fri Mar 1 11:17:40 2019 +0100
Don't check certificate purpose on older GnuTLS
The feature was added in 3.6.0, so avoid compilation errors if
building with an older GnuTLS.
diff --git a/utils.c b/utils.c
index bbfb8e6..b8d9b8e 100644
--- a/utils.c
+++ b/utils.c
@@ -847,6 +847,7 @@ _utils_cert_get_status_report(gnutls_x509_crt_t cert, unsigned int status,
size -= strlen(buf);
}
+#if GNUTLS_VERSION_NUMBER >= 0x030600
if (status & GNUTLS_CERT_PURPOSE_MISMATCH) {
snprintf(buf, sizeof(buf),
" %d. The certificate or an intermediate does not match the\n"
@@ -854,6 +855,7 @@ _utils_cert_get_status_report(gnutls_x509_crt_t cert, unsigned int status,
strncat(out, buf, size);
size -= strlen(buf);
}
+#endif
}
static int
| 0 | 27 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
0538dcc5494eb9e6eb735862ceb43b1813fc1b7a
|
Icons are supported, but there's still a problem with topmost windows
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1444 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 0538dcc5494eb9e6eb735862ceb43b1813fc1b7a
Author: Peter Åstrand <[email protected]>
Date: Thu Mar 6 15:49:29 2008 +0000
Icons are supported, but there's still a problem with topmost windows
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1444 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/TODO b/doc/TODO
index b45a73b..1321d2b 100644
--- a/doc/TODO
+++ b/doc/TODO
@@ -76,8 +76,6 @@
* Systray support.
- * Support for transferring the application taskbar icon.
-
* Better support for non-EWMH window managers.
* Support for non-rectangular windows.
@@ -95,3 +93,7 @@
* When enumerating windows, make sure to send info about windows
that are transient for other windows after the referred window.
+
+ * We support topmost windows at creating time, but we do not detect
+ when this property is added or removed. This can be verified with
+ task manager, which has an "Always on top" option.
| 0 | 43 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
e20b0e26767a7dc7ae896906ddac5d70aae644f0
|
Update documentation for -k.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@240 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit e20b0e26767a7dc7ae896906ddac5d70aae644f0
Author: Matt Chapman <[email protected]>
Date: Thu Oct 24 08:35:28 2002 +0000
Update documentation for -k.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@240 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/rdesktop.1 b/doc/rdesktop.1
index c1fc2f6..6f49d4a 100644
--- a/doc/rdesktop.1
+++ b/doc/rdesktop.1
@@ -38,9 +38,11 @@ Client hostname. Normally rdesktop automatically obtains the hostname of the
client.
.TP
.BR "-k <layout>"
-Keyboard layout on terminal server (us,sv,gr,etc.). This requires a
-corresponding keymap file to be installed (normally the keymaps are found in
-/usr/share/rdesktop/keymaps/ or /usr/local/share/rdesktop/keymaps/).
+Keyboard layout to emulate. This requires a corresponding keymap file to be
+installed. The standard keymaps provided with rdesktop follow the RFC1766
+naming scheme: a language code followed by a country code if necessary - e.g.
+en-us, en-gb, de, fr, sv, etc. The default is en-us (a US keyboard).
+
.TP
.BR "-g <geometry>"
Desktop geometry (WxH).
| 0 | 81 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
8376afac54a53c29cd77693a3f85fe0e14256ae0
|
Fix to compile with GCC 7.3.0 and possibly fix a security issue
Did a google search and found this.
https://stackoverflow.com/questions/4419293/warning-format-not-a-string-literal-and-no-format-arguments/4419319#4419319
With this little fix, rdesktop compiled again using gcc 7.3.0.
|
commit 8376afac54a53c29cd77693a3f85fe0e14256ae0
Author: kekePower <[email protected]>
Date: Mon Jan 29 20:35:44 2018 +0100
Fix to compile with GCC 7.3.0 and possibly fix a security issue
Did a google search and found this.
https://stackoverflow.com/questions/4419293/warning-format-not-a-string-literal-and-no-format-arguments/4419319#4419319
With this little fix, rdesktop compiled again using gcc 7.3.0.
diff --git a/rdesktop.c b/rdesktop.c
index 298b2b6..085f9b5 100644
--- a/rdesktop.c
+++ b/rdesktop.c
@@ -517,7 +517,7 @@ read_password(char *password, int size)
if (tcgetattr(STDIN_FILENO, &tios) == 0)
{
- fprintf(stderr, prompt);
+ fputs(prompt, stderr);
tios.c_lflag &= ~ECHO;
tcsetattr(STDIN_FILENO, TCSANOW, &tios);
istty = 1;
| 0 | 13 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
7457cd9bdd8fe6872713252d9ef01a018e65d0b6
|
Adds 1 to data length for including the terminating null
character when sending clipboard data to rdp server.
This fixes issue were last character is missing in a
local copy then paste into server session.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1653 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 7457cd9bdd8fe6872713252d9ef01a018e65d0b6
Author: Henrik Andersson <[email protected]>
Date: Wed Dec 21 15:19:56 2011 +0000
Adds 1 to data length for including the terminating null
character when sending clipboard data to rdp server.
This fixes issue were last character is missing in a
local copy then paste into server session.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1653 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/xclip.c b/xclip.c
index 8f19576..1ce375a 100644
--- a/xclip.c
+++ b/xclip.c
@@ -389,7 +389,7 @@ xclip_send_data_with_convert(uint8 * source, size_t source_size, Atom target)
translated_data = lf2crlf(source, &length);
if (translated_data != NULL)
{
- helper_cliprdr_send_response(translated_data, length);
+ helper_cliprdr_send_response(translated_data, length+1);
xfree(translated_data); /* Not the same thing as XFree! */
}
| 0 | 17 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
bba4cd2cf0269ec933cb2ccf92743bbcebf3c2da
|
Merge pull request #125 from uglym8/fix_118
Workaround for key caching in OpenSSL > 1.1.0 ( fixes #118)
|
commit bba4cd2cf0269ec933cb2ccf92743bbcebf3c2da
Merge: ba804fa a3dfcee
Author: Henrik Andersson <[email protected]>
Date: Wed Jul 5 14:15:01 2017 +0200
Merge pull request #125 from uglym8/fix_118
Workaround for key caching in OpenSSL > 1.1.0 ( fixes #118)
| 0 | 3 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
5ce283806c8385bca9bfc23e2e577d16f9aa28eb
|
Restore leniance in certificate key usage violations
It was removed in 256d8e2 because the purpose was unclear. It turns
out that the automatically generated self signed certificates will
have Key Encipherment and Data Encipherment set as key usage, but
the required ones are Digital Signature and Key Encipherment. A
proper certificate generally doesn't have this issue, but connecting
to stand alone machines without a proper certificate is common.
Unfortunately the %COMPAT flag is the only thing that makes GnuTLS
tolerate this bug, but that flag also allows a lot of other protocol
violations.
|
commit 5ce283806c8385bca9bfc23e2e577d16f9aa28eb
Author: Pierre Ossman <[email protected]>
Date: Fri Sep 20 09:00:04 2019 +0200
Restore leniance in certificate key usage violations
It was removed in 256d8e2 because the purpose was unclear. It turns
out that the automatically generated self signed certificates will
have Key Encipherment and Data Encipherment set as key usage, but
the required ones are Digital Signature and Key Encipherment. A
proper certificate generally doesn't have this issue, but connecting
to stand alone machines without a proper certificate is common.
Unfortunately the %COMPAT flag is the only thing that makes GnuTLS
tolerate this bug, but that flag also allows a lot of other protocol
violations.
diff --git a/tcp.c b/tcp.c
index e85eb96..948d44b 100644
--- a/tcp.c
+++ b/tcp.c
@@ -55,7 +55,10 @@
#define INADDR_NONE ((unsigned long) -1)
#endif
-#define GNUTLS_PRIORITY "NORMAL"
+/* Windows' self signed certificates omit the required Digital
+ Signature key usage flag, and only %COMPAT makes GnuTLS ignore
+ that violation. */
+#define GNUTLS_PRIORITY "NORMAL:%COMPAT"
#ifdef IPv6
static struct addrinfo *g_server_address = NULL;
| 0 | 20 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
a90ea17abb3f37a50ca190fd4f2320b745dae02e
|
Test if SSL_OP_NO_COMPRESSION is defined before use.
OpenSSL < 0.9.9 does not support this option, see upstream
commit 566dda07ba16f9d3b9774fd5c8d526d7cc93f179 for reference.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1734 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit a90ea17abb3f37a50ca190fd4f2320b745dae02e
Author: Henrik Andersson <[email protected]>
Date: Thu Aug 29 14:27:25 2013 +0000
Test if SSL_OP_NO_COMPRESSION is defined before use.
OpenSSL < 0.9.9 does not support this option, see upstream
commit 566dda07ba16f9d3b9774fd5c8d526d7cc93f179 for reference.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1734 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/tcp.c b/tcp.c
index aca789a..e8c8f2d 100644
--- a/tcp.c
+++ b/tcp.c
@@ -318,7 +318,9 @@ tcp_tls_connect(void)
}
options = 0;
+#ifdef SSL_OP_NO_COMPRESSION
options |= SSL_OP_NO_COMPRESSION;
+#endif // __SSL_OP_NO_COMPRESSION
options |= SSL_OP_DONT_INSERT_EMPTY_FRAGMENTS;
SSL_CTX_set_options(g_ssl_ctx, options);
}
| 0 | 36 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
d5e339e5d979155da1c1374463c543e5084b09b5
|
Add an check for mech set availability before using it,
this fixes a segfault if gssglue cant initialize when
/etc/gssapi_mech.conf is missing on system.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1685 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit d5e339e5d979155da1c1374463c543e5084b09b5
Author: Henrik Andersson <[email protected]>
Date: Thu Nov 29 11:38:29 2012 +0000
Add an check for mech set availability before using it,
this fixes a segfault if gssglue cant initialize when
/etc/gssapi_mech.conf is missing on system.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1685 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/cssp.c b/cssp.c
index 1bd30af..2f540c5 100644
--- a/cssp.c
+++ b/cssp.c
@@ -90,6 +90,8 @@ cssp_gss_mech_available(gss_OID mech)
return True;
major_status = gss_indicate_mechs(&minor_status, &mech_set);
+ if (!mech_set)
+ return False;
if (GSS_ERROR(major_status))
{
| 0 | 28 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
231c3f1285c97ef4e8d93f60ba3415850e0afa30
|
Fix bug #1886199 (tracked down by [email protected]).
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1463 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 231c3f1285c97ef4e8d93f60ba3415850e0afa30
Author: Matt Chapman <[email protected]>
Date: Sat Apr 5 05:56:26 2008 +0000
Fix bug #1886199 (tracked down by [email protected]).
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1463 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/xwin.c b/xwin.c
index a91ed04..a6a6d9b 100644
--- a/xwin.c
+++ b/xwin.c
@@ -1,7 +1,7 @@
/* -*- c-basic-offset: 8 -*-
rdesktop: A Remote Desktop Protocol client.
User interface services - X Window System
- Copyright (C) Matthew Chapman 1999-2007
+ Copyright (C) Matthew Chapman 1999-2008
Copyright 2007 Pierre Ossman <[email protected]> for Cendio AB
This program is free software; you can redistribute it and/or modify
@@ -110,7 +110,7 @@ static XIC g_IC;
static XModifierKeymap *g_mod_map;
/* Maps logical (xmodmap -pp) pointing device buttons (0-based) back
to physical (1-based) indices. */
-static unsigned char g_pointer_log_to_phys_map[16];
+static unsigned char g_pointer_log_to_phys_map[32];
static Cursor g_current_cursor;
static RD_HCURSOR g_null_cursor = NULL;
static Atom g_protocol_atom, g_kill_atom;
@@ -1525,11 +1525,17 @@ xwin_refresh_pointer_map(void)
int i, pointer_buttons;
pointer_buttons = XGetPointerMapping(g_display, phys_to_log_map, sizeof(phys_to_log_map));
- for (i = 0; i < pointer_buttons; ++i)
+ if (pointer_buttons > sizeof(phys_to_log_map))
+ pointer_buttons = sizeof(phys_to_log_map);
+
+ /* if multiple physical buttons map to the same logical button, then
+ * use the lower numbered physical one */
+ for (i = pointer_buttons-1; i >= 0; i--)
{
- /* This might produce multiple logical buttons mapping
- to a single physical one, but hey, that's
- life... */
+ /* a user could specify arbitrary values for the logical button
+ * number, ignore any that are abnormally large */
+ if (phys_to_log_map[i] > sizeof(g_pointer_log_to_phys_map))
+ continue;
g_pointer_log_to_phys_map[phys_to_log_map[i] - 1] = i + 1;
}
}
| 0 | 10 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
bc727e7ef188a6f103f1a5cc201090f831cd9b03
|
One should be able to provide empty password via -p
|
commit bc727e7ef188a6f103f1a5cc201090f831cd9b03
Author: Henrik Andersson <[email protected]>
Date: Tue Jan 29 10:28:14 2019 +0100
One should be able to provide empty password via -p
diff --git a/rdesktop.c b/rdesktop.c
index 5c62b1b..010ddb6 100644
--- a/rdesktop.c
+++ b/rdesktop.c
@@ -159,6 +159,8 @@ extern RDPDR_DEVICE g_rdpdr_device[];
extern uint32 g_num_devices;
extern char *g_rdpdr_clientname;
+RD_BOOL password_provided = False;
+
/* Display usage information */
static void
usage(char *program)
@@ -857,6 +859,7 @@ main(int argc, char *argv[])
case 'p':
if (!((optarg[0] == '-') && (optarg[1] == 0)))
{
+ password_provided = True;
STRNCPY(g_password, optarg, sizeof(g_password));
flags |= RDP_INFO_AUTOLOGON;
@@ -1282,7 +1285,7 @@ main(int argc, char *argv[])
xfree(locale);
/* If no password provided at this point, prompt for password / pin */
- if (!g_password[0])
+ if (!g_password[0] && password_provided == False)
{
if (read_password(g_password, sizeof(g_password)))
{
| 0 | 7 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
8346fea6cc42e405aaad94d22c305949c201a288
|
Merge pull request #249 from derfian/reconnect-related-fixes
* When connecting to a Windows 2008 Server, pressing Cancel or hitting Escape while entering credentials (on the server) would lead to a reconnect if there was a resize pending.
* When connecting to a RDS farm name (round robin DNS entry as per MS recommendations), reconnecting could connect you to a different server, leading to a login screen rather than your session.
* rdesktop never had any logging that told you which address you were connecting to.
|
commit 8346fea6cc42e405aaad94d22c305949c201a288
Merge: 4580492 d6c99bf
Author: Karl Mikaelsson <[email protected]>
Date: Fri Mar 23 09:38:17 2018 +0100
Merge pull request #249 from derfian/reconnect-related-fixes
* When connecting to a Windows 2008 Server, pressing Cancel or hitting Escape while entering credentials (on the server) would lead to a reconnect if there was a resize pending.
* When connecting to a RDS farm name (round robin DNS entry as per MS recommendations), reconnecting could connect you to a different server, leading to a login screen rather than your session.
* rdesktop never had any logging that told you which address you were connecting to.
| 0 | 4 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
b793a87e6d87af0aba384cd07e123151b72031ab
|
Updated CHangeLog and bumped version to 1.8.3
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1837 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit b793a87e6d87af0aba384cd07e123151b72031ab
Author: Henrik Andersson <[email protected]>
Date: Fri Oct 31 11:39:04 2014 +0000
Updated CHangeLog and bumped version to 1.8.3
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1837 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/configure.ac b/configure.ac
index dd187b3..586dd5c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,4 +1,4 @@
-AC_INIT(rdesktop, 1.8.2post)
+AC_INIT(rdesktop, 1.8.3)
AC_CONFIG_SRCDIR([rdesktop.c])
diff --git a/doc/ChangeLog b/doc/ChangeLog
index ab52452..351442a 100644
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -1,3 +1,24 @@
+rdesktop (1.8.3)
+ * Added a persistent mode used with SeamlessRDP
+ * Added US international keyboard layout with dead keys
+ * Code cleanup to match specifications, use constants defined
+ instead of magic numbers, remove of dead code
+ * Fix regression with failed connection and a invalid licensing
+ message, introduced in 1.8.2
+ * Fix issue with Non ASCII user / password when using CredSSP
+ * Fix issues using smartcard redirection with Windows 2012 R2
+ * Fix issue with windows key functionality
+ * Fix memory corruption when using rdp_out_unistr()
+ * Fix workaround for the lack of support for alpha cursors
+ * Fix silent exit when redirected when using CredSSP
+ * Fix crash when starting rdesktop without domain specified
+ while using CredSSP
+ * Fix issue in SeamlessRDP protocol parser upon reconnect
+ * Fix issue were a new SeamlessRDP application is respawned
+ upon a reconnection
+
+ -- Henrik Andersson <[email protected]> 2014-10-31
+
rdesktop (1.8.2)
* Support enhanced server redirection (Session broker 2012)
* Support License Error Alert PDU
diff --git a/rdesktop.spec b/rdesktop.spec
index 53a5b97..f9b2f54 100644
--- a/rdesktop.spec
+++ b/rdesktop.spec
@@ -1,6 +1,6 @@
Summary: Remote Desktop Protocol client
Name: rdesktop
-Version: 1.8.2post
+Version: 1.8.3
Release: 1
License: GPL; see COPYING
Group: Applications/Communications
| 0 | 42 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
0bc9d7632c00b0323fd53972817513dd302990be
|
Merge pull request #200 from alexandrevicenzi/ignore_obj
Ignore object files.
|
commit 0bc9d7632c00b0323fd53972817513dd302990be
Merge: 93a2ecd 4c03af1
Author: Henrik Andersson <[email protected]>
Date: Fri Nov 24 07:53:23 2017 +0100
Merge pull request #200 from alexandrevicenzi/ignore_obj
Ignore object files.
| 0 | 5 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
655478be53ce49f6e2714d582ac23bb5281358e7
|
Added Michael.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@529 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 655478be53ce49f6e2714d582ac23bb5281358e7
Author: Peter Åstrand <[email protected]>
Date: Wed Oct 29 13:41:20 2003 +0000
Added Michael.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@529 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/AUTHORS b/doc/AUTHORS
index cb2b888..c5016ac 100644
--- a/doc/AUTHORS
+++ b/doc/AUTHORS
@@ -10,4 +10,4 @@ Peter
Michal Mihalik <[email protected]>
Norbert Federa <[email protected]>
Erik Forsberg <[email protected]>
-
+Michael Gernoth <[email protected]>
| 0 | 35 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
77a061a1218128fafa0a86a80b0e034d31f3141b
|
added svgareadme.txt
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@733 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 77a061a1218128fafa0a86a80b0e034d31f3141b
Author: Jay Sorg <[email protected]>
Date: Fri Jul 9 17:27:28 2004 +0000
added svgareadme.txt
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@733 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/uiports/svgareadme.txt b/uiports/svgareadme.txt
new file mode 100644
index 0000000..bc9f6f3
--- /dev/null
+++ b/uiports/svgareadme.txt
@@ -0,0 +1,35 @@
+This is the svga ui port
+svgalib should be installed
+tested with versions 1.4.3, 1.9.x
+
+svgardesktopbuild.sh can be edited to change file localtions or endianness
+run ./svgardesktopbuild.sh in this directory to compile it
+
+svgareadme.txt - notes, this file
+svgardesktopbuild.sh - script to build
+svgawin.c - ui lib
+
+svgalib has some support for acceleration but most drivers
+do not support it. I hope they fix this.
+The ones that do are Cirus Logic and ATI Mach 32 cards.
+If running on really slow hardware(486), use one of these cards,
+it improves performance alot.
+
+run ./svgardesktop with no parameters to see a list of
+commnad line options
+
+You will need to modify the libvga.config file most likely.
+Its in /etc/vga.
+Here is what mine looks like.
+BOF
+ mouse imps2
+ mouse_fake_kbd_event 112 113
+ mouse_accel_mult 1.5
+ mouse_accel_type normal
+ HorizSync 31.5 56.0
+ VertRefresh 50 90
+ nosigint
+EOF
+The mouse_fake_kbd_event line makes the wheel mouse work.
+
+Jay
| 0 | 86 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
6f09d54010087d7d8233d718698be247d304c492
|
added qtreadme.txt
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@721 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 6f09d54010087d7d8233d718698be247d304c492
Author: Jay Sorg <[email protected]>
Date: Thu Jun 24 22:06:01 2004 +0000
added qtreadme.txt
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@721 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/uiports/qtreadme.txt b/uiports/qtreadme.txt
new file mode 100755
index 0000000..435738c
--- /dev/null
+++ b/uiports/qtreadme.txt
@@ -0,0 +1,12 @@
+This is the Qt/X11 ui port
+qt should be installed in /usr/local/qt
+you may need to have LD_LIBRARY_PATH defined to run qtrdesktop
+tested with versions 2.3.2, 3.12
+
+qtrdesktopbuild.sh can be edited to change file localtions or endianness
+run ./qtrdesktopbuild.sh in this directory to compile it
+
+qtreadme.txt - notes, this file
+qtrdesktopbuild.sh - script to build
+qtwin.cpp - ui lib
+qtwin.h - header
| 0 | 78 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
d384c1b5391afaf4946e99dc3f4ab85a6dc15603
|
Documentation for -S.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@329 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit d384c1b5391afaf4946e99dc3f4ab85a6dc15603
Author: Peter Åstrand <[email protected]>
Date: Tue Feb 18 13:16:53 2003 +0000
Documentation for -S.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@329 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/rdesktop.1 b/doc/rdesktop.1
index ecf6887..9365fbf 100644
--- a/doc/rdesktop.1
+++ b/doc/rdesktop.1
@@ -22,6 +22,14 @@ Domain for authentication.
.BR "-s <shell>"
Startup shell for the user - starts a specific application instead of Explorer.
.TP
+.BR "-S <button size>"
+Enable single application mode. This option can be used when running a
+single, maximized application (via -s). When the minimize button of
+the windows application is pressed, the rdesktop window is minimized
+instead of the remote application. The maximize/restore button is
+disabled. For this to work, you must specify the correct button
+size, in pixels. The special word "standard" means 18 pixels.
+.TP
.BR "-c <directory>"
The initial working directory for the user. Often used in combination with -s
to set up a fixed login environment.
| 0 | 70 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
8adc0f9a2144ad2ea651b433a812a9aa367a37de
|
Update and rename README to README,md
Change the current README file into a markdown formatted README
|
commit 8adc0f9a2144ad2ea651b433a812a9aa367a37de
Author: Henrik Andersson <[email protected]>
Date: Mon Feb 27 11:01:40 2017 +0100
Update and rename README to README,md
Change the current README file into a markdown formatted README
diff --git a/README b/README,md
similarity index 68%
rename from README
rename to README,md
index 26b0627..1f1ae63 100644
--- a/README
+++ b/README,md
@@ -1,14 +1,13 @@
-==========================================
-rdesktop: A Remote Desktop Protocol client
-==========================================
+# rdesktop - A Remote Desktop Protocol client
rdesktop is an open source client for Microsoft's RDP protocol. It is
known to work with Windows versions ranging from NT 4 Terminal Server
to Windows 2012r2 RDS. rdesktop currently implements the RDP version 4
and 5 protocols.
-Installation
-------------
+
+## Installation
+
rdesktop uses a GNU-style build procedure. Typically all that is necessary
to install rdesktop is the following::
@@ -19,15 +18,21 @@ to install rdesktop is the following::
The default is to install under /usr/local. This can be changed by adding
--prefix=directory to the configure line.
-Note for users building from source
------------------------------------
+The smart-card support module uses PCSC-lite. You should use PCSC-lite 1.2.9 or
+later. To enable smart-card support in the rdesktop just run `./configure` with the
+`--enable-smartcard` option.
+
+
+## Note for users building from source
+
If you have retreived a snapshot of rdesktop source, you will first
-need to run ./bootstrap in order to generate the build infrastructure.
+need to run `./bootstrap` in order to generate the build infrastructure.
This is not necessary for release versions of rdesktop.
-Invocation
-----------
-Simply run::
+
+## Usage
+
+Conenct to a RDP server like:
% rdesktop server
@@ -37,12 +42,3 @@ Terminal Services enabled, or there is a firewall blocking access.)
You can also specify a number of options on the command line. These are listed
in the rdesktop manual page (run "man rdesktop").
-
-Smart-card support notes
-------------------------
-The smart-card support module uses PCSC-lite. You should use PCSC-lite 1.2.9 or
-later.
-
-To enable smart-card support in the rdesktop just run "./configure" with the
-"--enable-smartcard" option.
-
| 0 | 89 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
54f33977096ca2e05976f37d88a44989df5fd84c
|
Updated the list of Windows versions we know that rdesktop is known to
work with. Replaced CVS with Subversion.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1611 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 54f33977096ca2e05976f37d88a44989df5fd84c
Author: Peter Åstrand <[email protected]>
Date: Wed Apr 13 08:46:04 2011 +0000
Updated the list of Windows versions we know that rdesktop is known to
work with. Replaced CVS with Subversion.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1611 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/README b/README
index cb76fb6..13dd635 100644
--- a/README
+++ b/README
@@ -2,10 +2,10 @@
rdesktop: A Remote Desktop Protocol client
==========================================
-rdesktop is a client for Microsoft Windows NT Terminal Server, Windows 2000
-Terminal Services, Windows 2003 Terminal Services/Remote Desktop, Windows XP
-Remote Desktop, and possibly other Terminal Services products.
-rdesktop currently implements the RDP version 4 and 5 protocols.
+rdesktop is an open source client for Microsoft's RDP protocol. It is
+known to work with Windows versions such as NT 4 Terminal Server,
+2000, XP, 2003, 2003 R2, Vista, 2008, 7, and 2008 R2. rdesktop
+currently implements the RDP version 4 and 5 protocols.
Installation
------------
@@ -19,11 +19,12 @@ to install rdesktop is the following::
The default is to install under /usr/local. This can be changed by adding
--prefix=directory to the configure line.
-Note for CVS users
-------------------
-If you have downloaded a snapshot of rdesktop using CVS, you will first need to
-run ./bootstrap in order to generate the build infrastructure. This is not
-necessary for release versions of rdesktop.
+Note for Subversion users
+-------------------------
+If you have downloaded a snapshot of rdesktop using Subversion, you
+will first need to run ./bootstrap in order to generate the build
+infrastructure. This is not necessary for release versions of
+rdesktop.
Invocation
----------
| 0 | 97 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
8acf574b28b5bde6f74ff81aa3c180c21cd24a38
|
Fix compression regression introduced in commit 0c7b411
When adding support for multi fragments, we started to read and
use length from fast path packet. However a packet can be
compressed and uncompressed length should be used instead.
Fix issue #185
|
commit 8acf574b28b5bde6f74ff81aa3c180c21cd24a38
Author: Henrik Andersson <[email protected]>
Date: Fri Nov 3 12:33:00 2017 +0100
Fix compression regression introduced in commit 0c7b411
When adding support for multi fragments, we started to read and
use length from fast path packet. However a packet can be
compressed and uncompressed length should be used instead.
Fix issue #185
diff --git a/rdp5.c b/rdp5.c
index 3912e38..32a4a36 100644
--- a/rdp5.c
+++ b/rdp5.c
@@ -119,6 +119,7 @@ process_ts_fp_updates(STREAM s)
ns->p = ns->data;
ns->rdp_hdr = ns->p;
+ length = rlen;
ts = ns;
}
else
| 0 | 11 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
3961df1f790e63b5324df351b6e01e419db2fc0e
|
Replace README with build and invocation instructions.
Update man page.
Still need to update AUTHORS.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@216 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 3961df1f790e63b5324df351b6e01e419db2fc0e
Author: Matt Chapman <[email protected]>
Date: Wed Oct 9 14:13:46 2002 +0000
Replace README with build and invocation instructions.
Update man page.
Still need to update AUTHORS.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@216 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/README b/README
index 8d02851..7a748ae 100644
--- a/README
+++ b/README
@@ -1,17 +1,31 @@
-rdesktop is an open source client for Windows NT Terminal Server and
-Windows 2000 Terminal Services, capable of natively speaking Remote
-Desktop Protocol (RDP) in order to present the user's NT
-desktop. Unlike Citrix ICA, no server extensions are required.
-
-rdesktop currently runs on most UNIX based platforms with the X Window
-System, and other ports should be fairly straightforward.
-
-rdesktop was written by Matt Chapman ([email protected]) based
-on various scarce documentation, wire sniffs, and trial-and-error. It
-is released under the GNU Public Licence (GPL). Please send feedback,
-bug reports and patches to the appropriate mailing list
-(http://sourceforge.net/mail/?group_id=24366)
-
-rdesktop is a Sourceforge project. See the Sourceforge rdesktop
-project info (http://sourceforge.net/projects/rdesktop/) for more
-information.
+===========================================
+rdesktop: A Remote Desktop Protocol client.
+===========================================
+
+rdesktop is a client for Microsoft Windows NT Terminal Server, Windows 2000
+Terminal Services, Windows XP Remote Desktop, and possibly other Terminal
+Services products. rdesktop currently implements the RDP version 4 protocol.
+
+Installation
+------------
+rdesktop uses a typical GNU-style build procedure:
+
+ % ./configure [options]
+ % make
+ % make install
+
+where documentation for [options] can be found by running "./configure --help".
+Usually no options are necessary. The default is to install under /usr/local,
+this can be changed with --prefix=directory.
+
+Invocation
+----------
+
+ % rdesktop [options] server
+
+where server is the name of the Terminal Services machine. Note: if you
+receive "Connection refused", this probably means that the server does not have
+Terminal Services enabled, or there is a firewall blocking access.
+
+The rdesktop manual page lists the possible options ("man rdesktop").
+
diff --git a/doc/rdesktop.1 b/doc/rdesktop.1
index ef6af2b..eb0dd11 100644
--- a/doc/rdesktop.1
+++ b/doc/rdesktop.1
@@ -1,8 +1,4 @@
-.TH RDESKTOP 1 "September 2002" "Manual page for rdesktop"
-.\"
-.\" Man page author:
-.\" Hugo Trippaers <[email protected]>
-.\" Peter ?strand <[email protected]>
+.TH rdesktop 1 "October 2002"
.SH NAME
.I rdesktop
\- Remote Desktop Protocol client
@@ -11,96 +7,75 @@
.br
.SH DESCRIPTION
.I rdesktop
-is a client for Windows NT4 Terminal Server and Windows 2000 Terminal
-Services. rdesktop implements the RDP version 4 protocol, which used
-by Windows NT4 Terminal Server, and parts of RDP version 5, which is
-used by Windows 2000 Terminal Services.
+is a client for Microsoft Windows NT Terminal Server, Windows 2000 Terminal
+Services, Windows XP Remote Desktop, and possibly other Terminal Services
+products. rdesktop currently implements the RDP version 4 protocol.
.SH OPTIONS
.TP
.BR "-u <username>"
-The username for authentication on the terminal server, together with -p
-this can be used for autologon.
+Username for authentication on the terminal server.
.TP
.BR "-d <domain>"
-The domain to to which the user belongs.
+Domain for authentication.
.TP
.BR "-s <shell>"
-The startup shell for the user. Use this to start a specific application,
-instead of a regular desktop.
+Startup shell for the user - starts a specific application instead of Explorer.
.TP
.BR "-c <directory>"
-The current working directory for the user. Often used in combination with -s
-to setup a fixed environment for the user after logon.
+The initial working directory for the user. Often used in combination with -s
+to set up a fixed login environment.
.TP
.BR "-p <password>"
-The password to authenticate with. Use -p - to make rdesktop request a
-password at startup (from standard input).
-WARNING: if you specify a password on the command line it may be visible
-to other users when they use tools like ps.
+The password to authenticate with. Note that this may have no effect if
+"Always prompt for password" is enabled on the server. WARNING: if you specify
+a password on the command line it may be visible to other users when they use
+tools like ps. Use -p - to make rdesktop request a password at startup (from
+standard input).
.TP
-.BR "-n <name>"
-Client name. The default is the hostname.
+.BR "-n <hostname>"
+Client hostname. Normally rdesktop automatically obtains the hostname of the
+client.
.TP
.BR "-k <layout>"
-keyboard layout on terminal server (us,sv,gr etc.)
+Keyboard layout on terminal server (us,sv,gr,etc.). This requires a
+corresponding keymap file to be installed (normally the keymaps are found in
+/usr/share/rdesktop/keymaps/ or /usr/local/share/rdesktop/keymaps/).
.TP
.BR "-g <geometry>"
Desktop geometry (WxH).
.TP
.BR "-f"
-Enable fullscreen mode. The -g option will be ignored when using -f,
-rdesktop will get the current height and width from the current
-desktop.
+Enable fullscreen mode. This overrides the window manager and causes the
+rdesktop window to fully cover the current screen. Fullscreen mode can be
+toggled at any time using Ctrl-Alt-Break.
.TP
.BR "-b"
-Force bitmap updates.
-.TP
-.BR "-e"
-Do not use encryption, this is only for people who are not allowed to
-use encryption in Windows products. If you live in France you
-probably need this switch.
+Force the server to send screen updates as bitmaps rather than using
+higher-level drawing operations.
.TP
.BR "-m"
-Do not send motion events.
+Do not send mouse motion events. This saves bandwidth, although some Windows
+applications may rely on receiving mouse motion.
.TP
-.BR "-l"
-Do not request licence.
+.BR "-e"
+Disable encryption. This option is only needed (and will only work) if you
+have a French version of NT TSE.
.TP
.BR "-t <port>"
-Connect to this TCP port. The default is 3389.
+Connect to the specified TCP port instead of 3389.
.TP
.BR "-K"
-Keep window manager key bindings.
+Do not override window manager key bindings. By default rdesktop attempts
+to grab all keyboard input when it is in focus.
.TP
.BR "-w <title>"
-Set window title to <title>.
+Window title.
.PP
-.SH "RETURN VALUES"
-None are defined (yet).
.SH LINKS
Main website of rdesktop
.br
-\fIhttp://www.rdesktop.org
-.LP
-.SH BUGS
-We suggest you visit the website at http://www.rdesktop.org and follow
-the links to the Bug Tracker.
-.SH VERSION
-This manual page documents version 1.2.
-.SH AUTHOR
-rdesktop is written by Matt Chapman <[email protected]>
+\fIhttp://www.rdesktop.org/
.LP
-The following persons have contributed to the project:
-.LP
-Peter Bystrom <[email protected]>
-.br
-Hugo Trippaers <[email protected]>
-.br
-Jay Sorg
-.br
-Peter ?strand
-.SH THANKS
-Thanks to all the mailinglist members for their contributions to rdesktop.
.PP
| 0 | 79 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
0ac32bd06cb2165cd1f8542c877de55871bccdad
|
Bump version to 1.8.2 and updated ChangeLog
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1806 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 0ac32bd06cb2165cd1f8542c877de55871bccdad
Author: Henrik Andersson <[email protected]>
Date: Tue May 20 14:37:02 2014 +0000
Bump version to 1.8.2 and updated ChangeLog
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1806 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/configure.ac b/configure.ac
index 5746daa..c72220f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,4 +1,4 @@
-AC_INIT(rdesktop, 1.8.1post)
+AC_INIT(rdesktop, 1.8.2)
AC_CONFIG_SRCDIR([rdesktop.c])
diff --git a/doc/ChangeLog b/doc/ChangeLog
index 5f3529d..ab52452 100644
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -1,3 +1,19 @@
+rdesktop (1.8.2)
+ * Support enhanced server redirection (Session broker 2012)
+ * Support License Error Alert PDU
+ * Changed default driver for printer redirection
+ * Fix CredSSP login using non-ASCII username/password
+ * Fix double login prompt bug with Win2008 server redirection
+ * Fix keysym collisions
+ * Fix mouse cursor with 2012 R2
+ * Fix local drive redirection with Win8 / Win2012
+ * Fix issue with mouse cursor hotspot
+ * Fix issue with mouse / keyboard against VirtualBox RDP
+ * Fix uncomplete czech keymap
+ * Fix error in dutch keymap
+
+ -- Henrik Andersson <[email protected]> 2014-05-20
+
rdesktop (1.8.1)
* Fix a typo in configure.ac
* Fix a bug which made rdesktop steal CPU cycles.
diff --git a/rdesktop.spec b/rdesktop.spec
index b4f771b..dc68d3a 100644
--- a/rdesktop.spec
+++ b/rdesktop.spec
@@ -1,6 +1,6 @@
Summary: Remote Desktop Protocol client
Name: rdesktop
-Version: 1.8.1post
+Version: 1.8.2
Release: 1
License: GPL; see COPYING
Group: Applications/Communications
| 0 | 57 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
72610f5b01b69eb724d7e6d14a4664910571341c
|
Bump up version to 1.7.1, updated ChangeLog
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1654 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 72610f5b01b69eb724d7e6d14a4664910571341c
Author: Henrik Andersson <[email protected]>
Date: Mon Jan 9 12:29:39 2012 +0000
Bump up version to 1.7.1, updated ChangeLog
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1654 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/configure.ac b/configure.ac
index a0ddcb1..b06cd9e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,4 +1,4 @@
-AC_INIT(rdesktop, 1.7.0post)
+AC_INIT(rdesktop, 1.7.1)
AC_CONFIG_SRCDIR([rdesktop.c])
diff --git a/doc/ChangeLog b/doc/ChangeLog
index 2531440..297f995 100644
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -1,3 +1,13 @@
+rdesktop (1.7.1)
+ * Fix clipboard issue when not building with unicode support
+ * Fix compilation against newer PCSC lite versions
+ * Fix for per-device license mode on Windows 2008 R2 terminal server
+ * Fix building 64bit version with static openssl linkage
+ * Rewrite of smartcard handling for 64bit support, fixes several bugs
+ * Improved license handling using XDG directories
+
+ -- Henrik Andersson <[email protected]> 2012-01-09
+
rdesktop (1.7.0)
* Security: Directory traversal vulnerability with disk redirection (disallow /.. requests)
* New maintainer: Peter Åstrand <[email protected]>
diff --git a/rdesktop.spec b/rdesktop.spec
index a613dcc..dd8fc27 100644
--- a/rdesktop.spec
+++ b/rdesktop.spec
@@ -1,6 +1,6 @@
Summary: Remote Desktop Protocol client
Name: rdesktop
-Version: 1.7.0post
+Version: 1.7.1
Release: 1
License: GPL; see COPYING
Group: Applications/Communications
| 0 | 46 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
3b403f934685652a032bae58666d07da7385a30b
|
Better handling of guessed key translations: Uses local shift state.
Fixes problem with LeftShift not working without keymaps.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@164 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 3b403f934685652a032bae58666d07da7385a30b
Author: Peter Åstrand <[email protected]>
Date: Mon Sep 16 13:21:44 2002 +0000
Better handling of guessed key translations: Uses local shift state.
Fixes problem with LeftShift not working without keymaps.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@164 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/xkeymap.c b/xkeymap.c
index c0ff2c4..4c50d08 100644
--- a/xkeymap.c
+++ b/xkeymap.c
@@ -289,6 +289,15 @@ xkeymap_translate_key(KeySym keysym, unsigned int keycode, unsigned int state)
if ((keycode >= min_keycode) && (keycode <= 0x60))
{
tr.scancode = keycode - min_keycode;
+
+ /* The modifiers to send for this key should be
+ obtained from the local state. Currently, only
+ shift is implemented. */
+ if (state & ShiftMask)
+ {
+ tr.modifiers = MapLeftShiftMask;
+ }
+
fprintf(stderr, "Sending guessed scancode 0x%x\n", tr.scancode);
}
else
@@ -367,6 +376,7 @@ ensure_remote_modifiers(uint32 ev_time, key_translation tr)
{
/* Should not use this modifier. Send up. */
rdp_send_scancode(ev_time, RDP_KEYRELEASE, SCANCODE_CHAR_LSHIFT);
+ rdp_send_scancode(ev_time, RDP_KEYRELEASE, SCANCODE_CHAR_RSHIFT);
}
}
| 0 | 67 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
e1f84d5ef181c2f2cb4200ac46ad0a27fc0a771a
|
Notes on FileDispositionInformation. Closing before unlinking
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@658 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit e1f84d5ef181c2f2cb4200ac46ad0a27fc0a771a
Author: Peter Åstrand <[email protected]>
Date: Fri Apr 16 11:37:24 2004 +0000
Notes on FileDispositionInformation. Closing before unlinking
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@658 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/disk.c b/disk.c
index 5c23f12..d375f1c 100644
--- a/disk.c
+++ b/disk.c
@@ -608,11 +608,25 @@ disk_set_information(HANDLE handle, uint32 info_class, STREAM in, STREAM out)
break;
case FileDispositionInformation:
-
- //unimpl("IRP Set File Information class: FileDispositionInformation\n");
+ /* As far as I understand it, the correct
+ thing to do here is to *schedule* a delete,
+ so it will be deleted when the file is
+ closed. Subsequent
+ FileDispositionInformation requests with
+ DeleteFile set to FALSE should unschedule
+ the delete. See
+ http://www.osronline.com/article.cfm?article=245. Currently,
+ we are deleting the file immediately. I
+ guess this is a FIXME. */
//in_uint32_le(in, delete_on_close);
- // disk_close(handle);
+
+ /* Make sure we close the file before
+ unlinking it. Not doing so would trigger
+ silly-delete if using NFS, which might fail
+ on FAT floppies, for example. */
+ disk_close(handle);
+
if ((pfinfo->flags_and_attributes & FILE_DIRECTORY_FILE)) // remove a directory
{
if (rmdir(pfinfo->path) < 0)
| 0 | 55 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
4c03af14786f3ff3f926347fc73d077ea1a2cf71
|
Ignore object files.
|
commit 4c03af14786f3ff3f926347fc73d077ea1a2cf71
Author: Alexandre Vicenzi <[email protected]>
Date: Thu Nov 23 16:19:13 2017 -0200
Ignore object files.
diff --git a/.gitignore b/.gitignore
index 17bfe87..3f57c02 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,3 +6,4 @@ config.status
configure
rdesktop*.tar.gz
aclocal.m4
+*.o
| 0 | 1 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
46f5d6f7fcb48a199dc2c2bb52268a91ca8576ff
|
Explicitly list the files to cproto, instead of using *.c. This avoids
troubles if you have some old files in the working directory
(foo.c). Also, the order will be more permanent, which avoids
unncessary changes to proto.h. The sound API is defined by
rdpsnd_oss.c; no need to include the others.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@945 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit 46f5d6f7fcb48a199dc2c2bb52268a91ca8576ff
Author: Peter Åstrand <[email protected]>
Date: Tue Aug 2 09:42:26 2005 +0000
Explicitly list the files to cproto, instead of using *.c. This avoids
troubles if you have some old files in the working directory
(foo.c). Also, the order will be more permanent, which avoids
unncessary changes to proto.h. The sound API is defined by
rdpsnd_oss.c; no need to include the others.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@945 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/Makefile.in b/Makefile.in
index 6279786..a44d197 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -76,7 +76,11 @@ installkeymaps:
.PHONY: proto
proto:
- cproto -DMAKE_PROTO -DWITH_OPENSSL -o proto.h *.c
+ cproto -DMAKE_PROTO -DWITH_OPENSSL -o proto.h \
+ bitmap.c cache.c channels.c cliprdr.c disk.c mppc.c ewmhints.c \
+ iso.c licence.c mcs.c orders.c parallel.c printer.c printercache.c \
+ pstcache.c rdesktop.c rdp5.c rdp.c rdpdr.c rdpsnd.c rdpsnd_oss.c \
+ secure.c serial.c tcp.c xclip.c xkeymap.c xwin.c
.PHONY: clean
clean:
| 0 | 39 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
8ea3fab052a5e6b8b86f3dc39bbd44a303406719
|
Set master version to 1.8.99 to be greater than 1.8.x versions
Currently, the version number of releases made from the branch 1.8.x are
greater than the version in the master branch (1.8.3post).
That makes life a little harder for packages wanting to package the code
from the master branch.
So, set the version to 1.8.99, ensuring with a high probability, that
the version will be greater than all 1.8.x releases.
Fixes: https://github.com/rdesktop/rdesktop/issues/325
|
commit 8ea3fab052a5e6b8b86f3dc39bbd44a303406719
Author: Paul Menzel <[email protected]>
Date: Fri Apr 12 16:52:48 2019 +0200
Set master version to 1.8.99 to be greater than 1.8.x versions
Currently, the version number of releases made from the branch 1.8.x are
greater than the version in the master branch (1.8.3post).
That makes life a little harder for packages wanting to package the code
from the master branch.
So, set the version to 1.8.99, ensuring with a high probability, that
the version will be greater than all 1.8.x releases.
Fixes: https://github.com/rdesktop/rdesktop/issues/325
diff --git a/configure.ac b/configure.ac
index faf7281..f3c58dc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,4 +1,4 @@
-AC_INIT(rdesktop, 1.8.3post)
+AC_INIT(rdesktop, 1.8.99)
AC_CONFIG_SRCDIR([rdesktop.c])
diff --git a/rdesktop.spec b/rdesktop.spec
index 07246e8..88c4c40 100644
--- a/rdesktop.spec
+++ b/rdesktop.spec
@@ -1,6 +1,6 @@
Summary: Remote Desktop Protocol client
Name: rdesktop
-Version: 1.8.3post
+Version: 1.8.99
Release: 1
License: GPL; see COPYING
Group: Applications/Communications
| 0 | 74 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
b9a8f97955451a4f077c0c2703abe5a4d8db0f68
|
Fix the ctrl sockets storage path to be XDG complient.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1694 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit b9a8f97955451a4f077c0c2703abe5a4d8db0f68
Author: Henrik Andersson <[email protected]>
Date: Tue Feb 5 07:48:55 2013 +0000
Fix the ctrl sockets storage path to be XDG complient.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1694 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/ctrl.c b/ctrl.c
index 5719a6a..bf64486 100644
--- a/ctrl.c
+++ b/ctrl.c
@@ -30,7 +30,7 @@
#define CTRL_LINEBUF_SIZE 1024
#define CTRL_RESULT_SIZE 32
-#define RDESKTOP_CTRLSOCK_STORE "/.local/var/run/rdesktop"
+#define RDESKTOP_CTRLSOCK_STORE "/.local/share/rdesktop/ctrl"
#define CTRL_HASH_FLAG_SEAMLESS 1
| 0 | 21 |
CVE-2000-0948
|
GnoRPM before 0.95 allows local users to modify arbitrary files via a symlink attack.
|
rdesktop
|
rdesktop
|
eb45995b16480b33398b8ec37d5e723b8114772f
|
We use RFC1766 now; update doc.
Added note about writing keymap files.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@271 423420c4-83ab-492f-b58f-81f9feb106b5
|
commit eb45995b16480b33398b8ec37d5e723b8114772f
Author: Peter Åstrand <[email protected]>
Date: Tue Nov 19 13:59:56 2002 +0000
We use RFC1766 now; update doc.
Added note about writing keymap files.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@271 423420c4-83ab-492f-b58f-81f9feb106b5
diff --git a/doc/keymapping.txt b/doc/keymapping.txt
index 8b04a6a..41309bc 100644
--- a/doc/keymapping.txt
+++ b/doc/keymapping.txt
@@ -34,10 +34,8 @@ Composing/Multi_key is supported. For more information, see:
Keymap files
-=============
-The keymap-files have two-letter names. These follows ISO 639
-(2-letter codes). ISO639 can be found at
-http://www.w3.org/WAI/ER/IG/ert/iso639.htm
+============
+The names of the keymaps follows RFC1766.
(You can find a translation from Windows keyboard layout numbers to
keymap names by looking at
@@ -126,3 +124,23 @@ mod2 Num_Lock (0x4d)
mod3 Mode_switch (0x71)
mod4 Hyper_L (0x73), Hyper_R (0x74)
mod5 Scroll_Lock (0x4e)
+
+
+Updating / writing keymap files
+===============================
+When writing new or updating keymap files, please use comments and
+blanks, to increase readability. The "sv" keymap is a good template.
+
+When you need to add a translation to a keymap file, do:
+
+ 1. Get the "key number" for this key, by looking at keynums.png.
+
+ 2. Take a look at scancodes.h, and look for
+ SCANCODE_KEY_<my-key-number>. The scancode value is at the end of
+ the line. If the line contains (SCANCODE_EXTENDED | 0xsomething),
+ then you should OR 0x80 to this value. For example, you can do:
+
+ python -c "print hex(0x80 | 0xsomething)"
+
+ 3. Put the scancode (from step 2) and keysym name (found in the
+ error message) into the keymap file.
| 0 | 92 |
End of preview. Expand
in Data Studio
README.md exists but content is empty.
- Downloads last month
- 86