ibm-granite

/

rag-intrinsics-lib

like 5

Follow

IBM Granite 3.14k

Thanks for putting this together! Review comments follow.

• Please remove the old Granite-Experiments stuff in the first two paragraphs; this intrinsic is no longer part of the Granite-Experiments collection
• "This is a a family" => "This is a family"
• Hugging Face's Tranformers library is spelled with a capital "T".
• The correct install command for granite-common is pip install granite-common.
• The lines

  intrinsic_kwargs = {}
  rewritten_request = rewriter.transform(request_json, **intrinsic_kwargs)
  

  in the code examples can be replaced with just rewritten_request = rewriter.transform(request_json)

Thanks @frreiss , I just updated the PR to address the review comments.
Please let me know if any other changes are needed.

LGTM, thanks @yannisk2