msvc-fix
#5
by
pamparamm
- opened
This PR adds some changes that allow SageAttention3 to be compiled on Windows with MSVC
- Explicitly add
/Zc:__cplusplusand/bigobjflags from cutlass CMakeLists to both cxx_flags and nvcc_flags on "nt" platform (assuming "nt" always uses MSVC for compiling CUDA extensions) - Inline
SfAtomandLayoutSF(for some reason not doing that leads to compilation errors, but I'm not really sure, why)
Thanks for the fixes, I've tested and confirmed that this resolves the issue with MSVC:
\SageAttention3\sageattn\blackwell\kernel_traits.h(154): warning C4346: 'LayoutSF': dependent name is not a type
\SageAttention3\sageattn\blackwell\kernel_traits.h(154): error C2061: syntax error: identifier 'LayoutSF'
\SageAttention3\sageattn\blackwell\kernel_traits.h(155): warning C4346: 'SfAtom': dependent name is not a type
\SageAttention3\sageattn\blackwell\kernel_traits.h(155): error C2061: syntax error: identifier 'SfAtom'
pamparamm
changed pull request status to
open
So im not that good with Python and i really struggle rn compiling SageAttn3 on my 5090 rig. Sage Attention 2 worked fine but something always spits out errors at me. Is there like a precompiled wheel for cp310?